Merge pull request #1465 from CyberL1/fix/name-must-not-be-empty

2 files changed, 20 insertions, 2 deletions

diff --git a/src/api/routes/applications/#application_id/bot/index.ts b/src/api/routes/applications/#application_id/bot/index.ts

index 901f386f5..7f5369aee 100644
--- a/src/api/routes/applications/#application_id/bot/index.ts
+++ b/src/api/routes/applications/#application_id/bot/index.ts
@@ -17,7 +17,7 @@
 */
 
 import { route } from "@spacebar/api";
-import { Application, DiscordApiErrors, User, createAppBotUser, generateToken, handleFile } from "@spacebar/util";
+import { Application, DiscordApiErrors, FieldErrors, User, createAppBotUser, generateToken, handleFile } from "@spacebar/util";
 import { Request, Response, Router } from "express";
 import { HTTPError } from "lambert-server";
 import { verifyToken } from "node-2fa";
@@ -100,6 +100,15 @@ router.patch(
         const body = req.body as BotModifySchema;
         if (!body.avatar?.trim()) delete body.avatar;
 
+        if (body.username?.trim() == "") {
+            throw FieldErrors({
+                username: {
+                    code: "BASE_TYPE_REQUIRED",
+                    message: req.t("common:field.BASE_TYPE_REQUIRED"),
+                },
+            });
+        }
+
         const app = await Application.findOneOrFail({
             where: { id: req.params.application_id },
             relations: { bot: true, owner: true },
diff --git a/src/api/routes/applications/#application_id/index.ts b/src/api/routes/applications/#application_id/index.ts

index 1576df88e..58c01568e 100644
--- a/src/api/routes/applications/#application_id/index.ts
+++ b/src/api/routes/applications/#application_id/index.ts
@@ -17,7 +17,7 @@
 */
 
 import { route } from "@spacebar/api";
-import { Application, DiscordApiErrors, Guild, handleFile, User } from "@spacebar/util";
+import { Application, DiscordApiErrors, FieldErrors, Guild, handleFile, User } from "@spacebar/util";
 import { Request, Response, Router } from "express";
 import { HTTPError } from "lambert-server";
 import { verifyToken } from "node-2fa";
@@ -73,6 +73,15 @@ router.patch(
 
         if (app.owner.totp_secret && (!req.body.code || verifyToken(app.owner.totp_secret, req.body.code))) throw new HTTPError(req.t("auth:login.INVALID_TOTP_CODE"), 60008);
 
+        if (body.name?.trim() == "") {
+            throw FieldErrors({
+                name: {
+                    code: "BASE_TYPE_REQUIRED",
+                    message: req.t("common:field.BASE_TYPE_REQUIRED"),
+                },
+            });
+        }
+
         if (body.icon) {
             body.icon = await handleFile(`/app-icons/${app.id}`, body.icon as string);
         }