summary refs log tree commit diff
path: root/tests
diff options
context:
space:
mode:
authorRichard van der Hoff <richard@matrix.org>2020-03-31 17:31:32 +0100
committerRichard van der Hoff <richard@matrix.org>2020-03-31 17:43:58 +0100
commitb4c22342320d7de86c02dfb36415a38c62bec88d (patch)
tree3ba67bc86f0d45365816167698fa4a86c367d893 /tests
parentSet a logging context while running the bg updates (diff)
downloadsynapse-b4c22342320d7de86c02dfb36415a38c62bec88d.tar.xz
Make do_next_background_update return a bool
returning a None or an int that we don't use is confusing.
Diffstat (limited to 'tests')
-rw-r--r--tests/storage/test_background_update.py6
1 files changed, 3 insertions, 3 deletions
diff --git a/tests/storage/test_background_update.py b/tests/storage/test_background_update.py
index e578de8acf..940b166129 100644
--- a/tests/storage/test_background_update.py
+++ b/tests/storage/test_background_update.py
@@ -56,7 +56,7 @@ class BackgroundUpdateTestCase(unittest.HomeserverTestCase):
             ),
             by=0.1,
         )
-        self.assertIsNotNone(res)
+        self.assertFalse(res)
 
         # on the first call, we should get run with the default background update size
         self.update_handler.assert_called_once_with(
@@ -79,7 +79,7 @@ class BackgroundUpdateTestCase(unittest.HomeserverTestCase):
         result = self.get_success(
             self.updates.do_next_background_update(target_background_update_duration_ms)
         )
-        self.assertIsNotNone(result)
+        self.assertFalse(result)
         self.update_handler.assert_called_once()
 
         # third step: we don't expect to be called any more
@@ -87,5 +87,5 @@ class BackgroundUpdateTestCase(unittest.HomeserverTestCase):
         result = self.get_success(
             self.updates.do_next_background_update(target_background_update_duration_ms)
         )
-        self.assertIsNone(result)
+        self.assertTrue(result)
         self.assertFalse(self.update_handler.called)