Revert emergency registration patches

Revert "Merge remote-tracking branch 'origin/clokep/no-validate-ui-auth-sess' into matrix-org-hotfixes"

This reverts commit 5adad58d959ed0b249d43a9df81f034edc8876e7, reversing
changes made to 617541c4c6f9dea1ac1ed0a8f1ab848507457e23.

1 files changed, 1 insertions, 3 deletions

diff --git a/synapse/handlers/auth.py b/synapse/handlers/auth.py

index 1d779d2978..a167498add 100644
--- a/synapse/handlers/auth.py
+++ b/synapse/handlers/auth.py
@@ -317,7 +317,7 @@ class AuthHandler(BaseHandler):
             except StoreError:
                 raise SynapseError(400, "Unknown session ID: %s" % (sid,))
 
-            if clientdict:
+            if not clientdict:
                 # This was designed to allow the client to omit the parameters
                 # and just supply the session in subsequent calls so it split
                 # auth between devices by just sharing the session, (eg. so you
@@ -327,8 +327,6 @@ class AuthHandler(BaseHandler):
                 # on a homeserver.
                 # Revisit: Assuming the REST APIs do sensible validation, the data
                 # isn't arbitrary.
-                await self.store.set_ui_auth_clientdict(sid, clientdict)
-            else:
                 clientdict = session.clientdict
 
         if not authdict: