From 6610343332bd16cfebe94fb93fe7b55c7362e28a Mon Sep 17 00:00:00 2001 From: Richard van der Hoff Date: Mon, 11 May 2020 13:08:14 +0100 Subject: Revert emergency registration patches Revert "Merge remote-tracking branch 'origin/clokep/no-validate-ui-auth-sess' into matrix-org-hotfixes" This reverts commit 5adad58d959ed0b249d43a9df81f034edc8876e7, reversing changes made to 617541c4c6f9dea1ac1ed0a8f1ab848507457e23. --- synapse/handlers/auth.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'synapse/handlers/auth.py') diff --git a/synapse/handlers/auth.py b/synapse/handlers/auth.py index 1d779d2978..a167498add 100644 --- a/synapse/handlers/auth.py +++ b/synapse/handlers/auth.py @@ -317,7 +317,7 @@ class AuthHandler(BaseHandler): except StoreError: raise SynapseError(400, "Unknown session ID: %s" % (sid,)) - if clientdict: + if not clientdict: # This was designed to allow the client to omit the parameters # and just supply the session in subsequent calls so it split # auth between devices by just sharing the session, (eg. so you @@ -327,8 +327,6 @@ class AuthHandler(BaseHandler): # on a homeserver. # Revisit: Assuming the REST APIs do sensible validation, the data # isn't arbitrary. - await self.store.set_ui_auth_clientdict(sid, clientdict) - else: clientdict = session.clientdict if not authdict: -- cgit 1.5.1