summary refs log tree commit diff
path: root/scripts-dev/complement.sh
diff options
context:
space:
mode:
authorDavid Robertson <davidr@element.io>2021-12-07 12:33:13 +0000
committerDavid Robertson <davidr@element.io>2021-12-07 18:21:59 +0000
commitbca64f949e42bd5a45056da9bf8ece46dceae99b (patch)
treebf06772750f69e9743ef24aa9614fe7de996f07b /scripts-dev/complement.sh
parentPull out `_classify_rooms_by_membership_changes` (diff)
downloadsynapse-bca64f949e42bd5a45056da9bf8ece46dceae99b.tar.xz
Remove unused branch
I claim that it is impossible to hit the `continue` which is removed in
this commit. Setup:

- `events` is a list of all membership events in the range
  `since < time <= now`.
- `non_joins` is the list of `e in events` with `e.membership` not equal
  to`"join"`.
- `events` is a nonempty list by construction of
  `mem_change_events_by_room_id`.

Rationale:

- We hit the deleted code only if `non_joins` is empty.
- If so, `events` consists only of `join` membership events.
- `events` is non_empty, so there was at least one join during the
  sync period.
- Therefore the room_id will belong to
  `sync_result_builder.joined_room_ids`. But this means we will have
 `continue`d in the branch above.
  - I'm assuming here that `joined_room_ids` and `events` are both using
   the same `now_token.room_key`.
Diffstat (limited to 'scripts-dev/complement.sh')
0 files changed, 0 insertions, 0 deletions