summary refs log tree commit diff
diff options
context:
space:
mode:
authorDavid Robertson <davidr@element.io>2022-04-06 17:06:09 +0100
committerDavid Robertson <davidr@element.io>2022-04-06 17:06:09 +0100
commit50290790abbc2b1092bd14f06aff3e3d3fec485b (patch)
treec2eb907770a644991227d9ed1d3966b5e3a5bf18
parentFix `synapse_event_persisted_position` metric (#12390) (diff)
downloadsynapse-50290790abbc2b1092bd14f06aff3e3d3fec485b.tar.xz
Narrow the `importlib_metadata` dependency
`pyproject.toml` already has the version guard. I struggled to work out
how to reproduce this guard under setuptools in #12384. But I really
should have persisted there; without this, poetry and setuptools
generate different sets of requirements. That means a poetry-installed
Synapse on a 3.8+ interpreter will fail the runtime dependency checks.
-rw-r--r--synapse/python_dependencies.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/synapse/python_dependencies.py b/synapse/python_dependencies.py
index cd68aa362e..8bd91d5f72 100644
--- a/synapse/python_dependencies.py
+++ b/synapse/python_dependencies.py
@@ -91,7 +91,7 @@ REQUIREMENTS = [
     "packaging>=16.1",
     # At the time of writing, we only use functions from the version `importlib.metadata`
     # which shipped in Python 3.8. This corresponds to version 1.4 of the backport.
-    "importlib_metadata>=1.4",
+    "importlib_metadata>=1.4 ; python_version < '3.8'",
 ]
 
 CONDITIONAL_REQUIREMENTS = {