diff options
| author | Eric Eastwood <eric.eastwood@beta.gouv.fr> | 2024-08-08 18:23:50 -0500 |
|---|---|---|
| committer | Eric Eastwood <eric.eastwood@beta.gouv.fr> | 2024-08-08 18:23:50 -0500 |
| commit | 3367422fd3b7ac352b65b9c5da4601ec055cb13e (patch) | |
| tree | 5ab229f534bb5ed926ad28d54256d09ba02c1279 | |
| parent | Fill in `stream_ordering`/`bump_stamp` for any event being persisted (diff) | |
| download | synapse-madlittlemods/sliding-sync-pre-populate-room-meta-data.tar.xz | |
Need to fix upsert github/madlittlemods/sliding-sync-pre-populate-room-meta-data madlittlemods/sliding-sync-pre-populate-room-meta-data
| -rw-r--r-- | synapse/storage/databases/main/events.py | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/synapse/storage/databases/main/events.py b/synapse/storage/databases/main/events.py index 2b91f1f67c..276188e21b 100644 --- a/synapse/storage/databases/main/events.py +++ b/synapse/storage/databases/main/events.py @@ -2008,6 +2008,9 @@ class PersistEventsStore: # `_store_event_txn` is run before `_update_current_state_txn` which handles # deleting the rows if we are no longer in the room so we don't need to worry # about inserting something that will be orphaned. + # + # FIXME: We need to handle cases where we are persisting events out of order and + # the stream_ordering didn't increase. self.db_pool.simple_upsert_many_txn( txn, table="sliding_sync_joined_rooms", |