From 3367422fd3b7ac352b65b9c5da4601ec055cb13e Mon Sep 17 00:00:00 2001 From: Eric Eastwood Date: Thu, 8 Aug 2024 18:23:50 -0500 Subject: Need to fix upsert --- synapse/storage/databases/main/events.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/synapse/storage/databases/main/events.py b/synapse/storage/databases/main/events.py index 2b91f1f67c..276188e21b 100644 --- a/synapse/storage/databases/main/events.py +++ b/synapse/storage/databases/main/events.py @@ -2008,6 +2008,9 @@ class PersistEventsStore: # `_store_event_txn` is run before `_update_current_state_txn` which handles # deleting the rows if we are no longer in the room so we don't need to worry # about inserting something that will be orphaned. + # + # FIXME: We need to handle cases where we are persisting events out of order and + # the stream_ordering didn't increase. self.db_pool.simple_upsert_many_txn( txn, table="sliding_sync_joined_rooms", -- cgit 1.4.1