Need to fix upsert github/madlittlemods/sliding-sync-pre-populate-room-meta-data madlittlemods/sliding-sync-pre-populate-room-meta-data

1 files changed, 3 insertions, 0 deletions

diff --git a/synapse/storage/databases/main/events.py b/synapse/storage/databases/main/events.py

index 2b91f1f67c..276188e21b 100644
--- a/synapse/storage/databases/main/events.py
+++ b/synapse/storage/databases/main/events.py
@@ -2008,6 +2008,9 @@ class PersistEventsStore:
         # `_store_event_txn` is run before `_update_current_state_txn` which handles
         # deleting the rows if we are no longer in the room so we don't need to worry
         # about inserting something that will be orphaned.
+        #
+        # FIXME: We need to handle cases where we are persisting events out of order and
+        # the stream_ordering didn't increase.
         self.db_pool.simple_upsert_many_txn(
             txn,
             table="sliding_sync_joined_rooms",