diff --git a/src/timeline/InputBar.cpp b/src/timeline/InputBar.cpp
index 6854fce3..a9afb01c 100644
--- a/src/timeline/InputBar.cpp
+++ b/src/timeline/InputBar.cpp
@@ -803,8 +803,8 @@ InputBar::command(const QString &command, QString args)
}
MediaUpload::MediaUpload(std::unique_ptr<QIODevice> source_,
- QString mimetype,
- QString originalFilename,
+ const QString &mimetype,
+ const QString &originalFilename,
bool encrypt,
QObject *parent)
: QObject(parent)
@@ -911,7 +911,7 @@ MediaUpload::MediaUpload(std::unique_ptr<QIODevice> source_,
connect(mediaPlayer,
qOverload<const QString &, const QVariant &>(&QMediaPlayer::metaDataChanged),
this,
- [this, mediaPlayer](QString t, QVariant) {
+ [this, mediaPlayer](const QString &t, const QVariant &) {
nhlog::ui()->debug("Got metadata {}", t.toStdString());
if (mediaPlayer->duration() > 0)
@@ -1029,7 +1029,7 @@ MediaUpload::startUpload()
}
void
-InputBar::finalizeUpload(MediaUpload *upload, QString url)
+InputBar::finalizeUpload(MediaUpload *upload, const QString &url)
{
auto mime = upload->mimetype();
auto filename = upload->filename();
|