Merge remote-tracking branch 'origin/master' into cross-signing

1 files changed, 6 insertions, 5 deletions

diff --git a/src/AvatarProvider.cpp b/src/AvatarProvider.cpp

index 603bb71a..b1751c33 100644
--- a/src/AvatarProvider.cpp
+++ b/src/AvatarProvider.cpp
@@ -34,10 +34,12 @@ resolve(const QString &avatarUrl, int size, QObject *receiver, AvatarCallback ca
 {
         const auto cacheKey = QString("%1_size_%2").arg(avatarUrl).arg(size);
 
-        if (avatarUrl.isEmpty())
+        QPixmap pixmap;
+        if (avatarUrl.isEmpty()) {
+                callback(pixmap);
                 return;
+        }
 
-        QPixmap pixmap;
         if (avatar_cache.find(cacheKey, &pixmap)) {
                 callback(pixmap);
                 return;
@@ -75,11 +77,10 @@ resolve(const QString &avatarUrl, int size, QObject *receiver, AvatarCallback ca
                                              opts.mxc_url,
                                              mtx::errors::to_string(err->matrix_error.errcode),
                                              err->matrix_error.error);
-                          return;
+                  } else {
+                          cache::saveImage(cacheKey.toStdString(), res);
                   }
 
-                  cache::saveImage(cacheKey.toStdString(), res);
-
                   emit proxy->avatarDownloaded(QByteArray(res.data(), res.size()));
           });
 }