about summary refs log tree commit diff
path: root/html.c
diff options
context:
space:
mode:
authorLars Hjemli <hjemli@gmail.com>2009-01-29 22:21:15 +0100
committerLars Hjemli <hjemli@gmail.com>2009-01-29 22:21:15 +0100
commit7efcef00b5aadf22f5be80ecd7b736398cf7f6b4 (patch)
tree6bfdb7c5499ba43eb9b302394adc7bfa7e517436 /html.c
parentCGIT 0.8.1.1 (diff)
downloadcgit-magenta-7efcef00b5aadf22f5be80ecd7b736398cf7f6b4.tar.xz
html.c: use correct escaping in html attributes
First, an apostrophe is not a quote. Second, we also need to escape
quotes. And finally, quotes are encoded as '&quot;', not '&quote;'.

Sighned-off-by: Lars Hjemli <hjemli@gmail.com>
Diffstat (limited to 'html.c')
-rw-r--r--html.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/html.c b/html.c

index d7d9fd7..66ba65d 100644 --- a/html.c +++ b/html.c
@@ -112,14 +112,16 @@ void html_attr(char *txt) char *t = txt; while(t && *t){ int c = *t; - if (c=='<' || c=='>' || c=='\'') { + if (c=='<' || c=='>' || c=='\'' || c=='\"') { write(htmlfd, txt, t - txt); if (c=='>') html("&gt;"); else if (c=='<') html("&lt;"); else if (c=='\'') - html("&quote;"); + html("&#x27;"); + else if (c=='"') + html("&quot;"); txt = t+1; } t++;