summary refs log tree commit diff
diff options
context:
space:
mode:
-rw-r--r--changelog.d/5633.bugfix1
-rw-r--r--synapse/handlers/room.py14
2 files changed, 14 insertions, 1 deletions
diff --git a/changelog.d/5633.bugfix b/changelog.d/5633.bugfix
new file mode 100644

index 0000000000..b2ff803b9d --- /dev/null +++ b/changelog.d/5633.bugfix
@@ -0,0 +1 @@ +Don't create broken room when power_level_content_override.users does not contain creator_id. \ No newline at end of file diff --git a/synapse/handlers/room.py b/synapse/handlers/room.py
index af7cfa7888..c1e5b6bd1b 100644 --- a/synapse/handlers/room.py +++ b/synapse/handlers/room.py
@@ -579,6 +579,18 @@ class RoomCreationHandler(BaseHandler): yield self.event_creation_handler.assert_accepted_privacy_policy(requester) + power_level_content_override = config.get("power_level_content_override") + if ( + power_level_content_override + and "users" in power_level_content_override + and user_id not in power_level_content_override["users"] + ): + raise SynapseError( + 400, + "Not a valid power_level_content_override: 'users' did not contain %s" + % (user_id,), + ) + visibility = config.get("visibility", None) is_public = visibility == "public" @@ -621,7 +633,7 @@ class RoomCreationHandler(BaseHandler): initial_state=initial_state, creation_content=creation_content, room_alias=room_alias, - power_level_content_override=config.get("power_level_content_override"), + power_level_content_override=power_level_content_override, creator_join_profile=creator_join_profile, )