diff options
| author | David Robertson <davidr@element.io> | 2022-06-14 18:28:26 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-06-14 18:28:26 +0100 |
| commit | c99b511db950bff5129e717a225de78b95b9b5ad (patch) | |
| tree | dade8b69e8bf3abf52f1a6f7824f2aa08f79e280 /tests/http | |
| parent | Up complement time outs (#13048) (diff) | |
| download | synapse-c99b511db950bff5129e717a225de78b95b9b5ad.tar.xz | |
Fix `destination_is` errors seen in sentry. (#13041)
* Rename test_fedclient to match its source file * Require at least one destination to be truthy * Explicitly validate user ID in profile endpoint GETs Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
Diffstat (limited to 'tests/http')
| -rw-r--r-- | tests/http/test_matrixfederationclient.py (renamed from tests/http/test_fedclient.py) | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/tests/http/test_fedclient.py b/tests/http/test_matrixfederationclient.py index 006dbab093..be9eaf34e8 100644 --- a/tests/http/test_fedclient.py +++ b/tests/http/test_matrixfederationclient.py @@ -617,3 +617,17 @@ class FederationClientTests(HomeserverTestCase): self.assertIsInstance(f.value, RequestSendFailed) self.assertTrue(transport.disconnecting) + + def test_build_auth_headers_rejects_falsey_destinations(self) -> None: + with self.assertRaises(ValueError): + self.cl.build_auth_headers(None, b"GET", b"https://example.com") + with self.assertRaises(ValueError): + self.cl.build_auth_headers(b"", b"GET", b"https://example.com") + with self.assertRaises(ValueError): + self.cl.build_auth_headers( + None, b"GET", b"https://example.com", destination_is=b"" + ) + with self.assertRaises(ValueError): + self.cl.build_auth_headers( + b"", b"GET", b"https://example.com", destination_is=b"" + ) |