summary refs log tree commit diff
path: root/synapse/storage/databases/main/room.py
diff options
context:
space:
mode:
authorSean Quah <8349537+squahtx@users.noreply.github.com>2021-12-14 12:34:30 +0000
committerGitHub <noreply@github.com>2021-12-14 12:34:30 +0000
commita4dce5b53dd460e7c6757648ff4a348b490c6213 (patch)
tree92e9f608c727a246002fffb2ff81b7cc410d6a55 /synapse/storage/databases/main/room.py
parentAdd missing type hints to synapse.http. (#11571) (diff)
downloadsynapse-a4dce5b53dd460e7c6757648ff4a348b490c6213.tar.xz
Remove redundant `COALESCE()`s around `COUNT()`s in database queries (#11570)
`COUNT()` never returns `NULL`. A `COUNT(*)` over 0 rows is 0 and a
`COUNT(NULL)` is also 0.
Diffstat (limited to 'synapse/storage/databases/main/room.py')
-rw-r--r--synapse/storage/databases/main/room.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/synapse/storage/databases/main/room.py b/synapse/storage/databases/main/room.py
index 28c4b65bbd..6cf6cc8484 100644
--- a/synapse/storage/databases/main/room.py
+++ b/synapse/storage/databases/main/room.py
@@ -217,7 +217,7 @@ class RoomWorkerStore(SQLBaseStore):
 
             sql = """
                 SELECT
-                    COALESCE(COUNT(*), 0)
+                    COUNT(*)
                 FROM (
                     %(published_sql)s
                 ) published