summary refs log tree commit diff
path: root/synapse/handlers/auth.py
diff options
context:
space:
mode:
authorPatrick Cloke <patrickc@matrix.org>2020-05-07 08:34:12 -0400
committerPatrick Cloke <patrickc@matrix.org>2020-05-07 08:34:14 -0400
commit4d3ebc36203ffaf2079024335d4bb285f1c6a00e (patch)
tree74958e67a67569d2e9c6bbf8ebdbef0e7f71e28b /synapse/handlers/auth.py
parentAdd a configuration setting for the dummy event threshold (#7422) (diff)
downloadsynapse-4d3ebc36203ffaf2079024335d4bb285f1c6a00e.tar.xz
Disable validation that a UI authentication session has not been modified during a request cycle.
Partial backout of 1c1242acba9694a3a4b1eb3b14ec0bac11ee4ff8 (#7068)
Diffstat (limited to 'synapse/handlers/auth.py')
-rw-r--r--synapse/handlers/auth.py12
1 files changed, 0 insertions, 12 deletions
diff --git a/synapse/handlers/auth.py b/synapse/handlers/auth.py

index 7613e5b6ab..a167498add 100644 --- a/synapse/handlers/auth.py +++ b/synapse/handlers/auth.py
@@ -329,18 +329,6 @@ class AuthHandler(BaseHandler): # isn't arbitrary. clientdict = session.clientdict - # Ensure that the queried operation does not vary between stages of - # the UI authentication session. This is done by generating a stable - # comparator based on the URI, method, and body (minus the auth dict) - # and storing it during the initial query. Subsequent queries ensure - # that this comparator has not changed. - comparator = (uri, method, clientdict) - if (session.uri, session.method, session.clientdict) != comparator: - raise SynapseError( - 403, - "Requested operation has changed during the UI authentication session.", - ) - if not authdict: raise InteractiveAuthIncompleteError( self._auth_dict_for_flows(flows, session.session_id)