diff options
author | Kegan Dougal <7190048+kegsay@users.noreply.github.com> | 2024-09-18 17:25:50 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-09-18 16:25:50 +0000 |
commit | 3c8a116e1a36a911aa92965836444f4473044f66 (patch) | |
tree | d911c30a901f09da849afdeff63a086c92984d2c /scripts-dev/mypy_synapse_plugin.py | |
parent | Add an Admin API endpoint to redact all a user's events (#17506) (diff) | |
download | synapse-3c8a116e1a36a911aa92965836444f4473044f66.tar.xz |
Sliding Sync: bugfix: ensure we can sync with SSS even with missing rooms (#17727)
Fixes https://github.com/element-hq/element-x-ios/issues/3300 Some rooms are missing from `sliding_sync_joined_rooms`. When this happens, the first call will succeed, but any subsequent calls for this room ID will cause the cache to return `None` for the room ID, rather than not having the key at all. This then causes the `<=` check to throw. Root cause: https://github.com/element-hq/synapse/issues/17726 ### Pull Request Checklist <!-- Please read https://element-hq.github.io/synapse/latest/development/contributing_guide.html before submitting your pull request --> * [x] Pull request is based on the develop branch * [ ] Pull request includes a [changelog file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog). The entry should: - Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from `EventStore` to `EventWorkerStore`.". - Use markdown where necessary, mostly for `code blocks`. - End with either a period (.) or an exclamation mark (!). - Start with a capital letter. - Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry. * [ ] [Code style](https://element-hq.github.io/synapse/latest/code_style.html) is correct (run the [linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters))
Diffstat (limited to 'scripts-dev/mypy_synapse_plugin.py')
0 files changed, 0 insertions, 0 deletions