summary refs log tree commit diff
path: root/docker/conf/log.config
diff options
context:
space:
mode:
authorErik Johnston <erik@matrix.org>2020-08-07 11:39:29 +0100
committerErik Johnston <erik@matrix.org>2020-08-11 18:10:46 +0100
commit0304ad0c3d79e44e78f9658e71f1e1533e3aa4e2 (patch)
tree4e439b0145e8eb2c8ff4fe27c8048fe4be265fe6 /docker/conf/log.config
parentReduce INFO logging (#8050) (diff)
downloadsynapse-0304ad0c3d79e44e78f9658e71f1e1533e3aa4e2.tar.xz
Move setting of Filter into code.
We do this to prevent foot guns. The default config uses a MemoryFilter,
but users are free to change to logging to files directly. If they do
then they have to ensure to set the `filters: [context]` on the right
handler, otherwise records get written with the wrong context.

Instead we move the logic to happen when we generate a record, which is
when we *log* rather than *handle*.

(It's possible to add filters to loggers in the config, however they
don't apply to descendant loggers and so they have to be manually set on
*every* logger used in the code base)
Diffstat (limited to 'docker/conf/log.config')
-rw-r--r--docker/conf/log.config6
1 files changed, 0 insertions, 6 deletions
diff --git a/docker/conf/log.config b/docker/conf/log.config
index ed418a57cd..491bbcc87a 100644
--- a/docker/conf/log.config
+++ b/docker/conf/log.config
@@ -4,16 +4,10 @@ formatters:
   precise:
    format: '%(asctime)s - %(name)s - %(lineno)d - %(levelname)s - %(request)s - %(message)s'
 
-filters:
-  context:
-    (): synapse.logging.context.LoggingContextFilter
-    request: ""
-
 handlers:
   console:
     class: logging.StreamHandler
     formatter: precise
-    filters: [context]
 
 loggers:
     synapse.storage.SQL: