diff options
| author | Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | 2021-10-25 16:21:09 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-10-25 15:21:09 +0100 |
| commit | da957a60e8958b08a52bd1404a89cf9bbcd033e0 (patch) | |
| tree | 34396e462897235ba464f220c13116ee2e874cf9 /changelog.d | |
| parent | Fix module API's `get_user_ip_and_agents` function when run on workers (#11112) (diff) | |
| download | synapse-da957a60e8958b08a52bd1404a89cf9bbcd033e0.tar.xz | |
Ensure that we correctly auth events returned by `send_join` (#11012)
This is the final piece of the jigsaw for #9595. As with other changes before this one (eg #10771), we need to make sure that we auth the auth events in the right order, and actually check that their predecessors haven't been rejected. To do this I've reused the existing code we use when persisting outliers elsewhere. I've removed the code for attempting to fetch missing auth_events - the events should have been present in the send_join response, so the likely reason they are missing is that we couldn't verify them, so requesting them again is unlikely to help. Instead, we simply drop any state which relies on those auth events, as we do at a backwards-extremity. See also matrix-org/complement#216 for a test for this.
Diffstat (limited to 'changelog.d')
| -rw-r--r-- | changelog.d/11012.bugfix | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/changelog.d/11012.bugfix b/changelog.d/11012.bugfix new file mode 100644 index 0000000000..13b8e5983b --- /dev/null +++ b/changelog.d/11012.bugfix @@ -0,0 +1 @@ +Fix a long-standing bug which meant that events received over federation were sometimes incorrectly accepted into the room state. |