summary refs log tree commit diff
diff options
context:
space:
mode:
authorErik Johnston <erik@matrix.org>2021-05-04 17:41:00 +0100
committerErik Johnston <erik@matrix.org>2021-05-04 17:57:46 +0100
commit7f237d5639fd4aa26ee6fda7c24280122b1d8ace (patch)
tree98d00a9538978b8995a75fac804c8acbd8083d31
parentRefactor keyring (diff)
downloadsynapse-7f237d5639fd4aa26ee6fda7c24280122b1d8ace.tar.xz
Remove key_ready
-rw-r--r--synapse/crypto/keyring.py35
1 files changed, 0 insertions, 35 deletions
diff --git a/synapse/crypto/keyring.py b/synapse/crypto/keyring.py

index 313d577f11..64aa1dc758 100644 --- a/synapse/crypto/keyring.py +++ b/synapse/crypto/keyring.py
@@ -90,7 +90,6 @@ class VerifyJsonRequest: minimum_valid_until_ts = attr.ib(type=int) request_name = attr.ib(type=str) key_ids = attr.ib(init=False, type=List[str]) - key_ready = attr.ib(default=attr.Factory(defer.Deferred), type=defer.Deferred) def __attrs_post_init__(self): self.key_ids = signature_ids(self.json_object, self.server_name) @@ -696,37 +695,3 @@ class ServerKeyFetcher(BaseV2KeyFetcher): keys.update(response_keys) return keys - - -async def _handle_key_deferred(verify_request: VerifyJsonRequest) -> None: - """Waits for the key to become available, and then performs a verification - - Args: - verify_request: - - Raises: - SynapseError if there was a problem performing the verification - """ - server_name = verify_request.server_name - with PreserveLoggingContext(): - _, key_id, verify_key = await verify_request.key_ready - - json_object = verify_request.json_object - - try: - verify_signed_json(json_object, server_name, verify_key) - except SignatureVerifyException as e: - logger.debug( - "Error verifying signature for %s:%s:%s with key %s: %s", - server_name, - verify_key.alg, - verify_key.version, - encode_verify_key_base64(verify_key), - str(e), - ) - raise SynapseError( - 401, - "Invalid signature for server %s with key %s:%s: %s" - % (server_name, verify_key.alg, verify_key.version, str(e)), - Codes.UNAUTHORIZED, - )