diff --git a/changelog.d/15024.bugfix b/changelog.d/15024.bugfix
new file mode 100644
index 0000000000..dddd406322
--- /dev/null
+++ b/changelog.d/15024.bugfix
@@ -0,0 +1 @@
+Fix bug where retried replication requests would return a failure. Introduced in v1.76.0.
diff --git a/changelog.d/15036.misc b/changelog.d/15036.misc
new file mode 100644
index 0000000000..b0adc9c9d1
--- /dev/null
+++ b/changelog.d/15036.misc
@@ -0,0 +1 @@
+Prepare for future database schema changes.
diff --git a/synapse/replication/http/_base.py b/synapse/replication/http/_base.py
index 908f3f1db7..c20d9c7e9d 100644
--- a/synapse/replication/http/_base.py
+++ b/synapse/replication/http/_base.py
@@ -426,6 +426,8 @@ class ReplicationEndpoint(metaclass=abc.ABCMeta):
code, response = await self.response_cache.wrap(
txn_id, self._handle_request, request, content, **kwargs
)
+ # Take a copy so we don't mutate things in the cache.
+ response = dict(response)
else:
# The `@cancellable` decorator may be applied to `_handle_request`. But we
# told `HttpServer.register_paths` that our handler is `_check_auth_and_handle`,
diff --git a/synapse/storage/schema/__init__.py b/synapse/storage/schema/__init__.py
index 19dbf2da7f..d3103a6c7a 100644
--- a/synapse/storage/schema/__init__.py
+++ b/synapse/storage/schema/__init__.py
@@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-SCHEMA_VERSION = 73 # remember to update the list below when updating
+SCHEMA_VERSION = 74 # remember to update the list below when updating
"""Represents the expectations made by the codebase about the database schema
This should be incremented whenever the codebase changes its requirements on the
@@ -78,7 +78,7 @@ Changes in SCHEMA_VERSION = 72:
- Unused column application_services_state.last_txn is dropped
- Cache invalidation stream id sequence now begins at 2 to match code expectation.
-Changes in SCHEMA_VERSION = 73;
+Changes in SCHEMA_VERSION = 73:
- thread_id column is added to event_push_actions, event_push_actions_staging
event_push_summary, receipts_linearized, and receipts_graph.
- Add table `event_failed_pull_attempts` to keep track when we fail to pull
@@ -86,6 +86,11 @@ Changes in SCHEMA_VERSION = 73;
- Add indexes to various tables (`event_failed_pull_attempts`, `insertion_events`,
`batch_events`) to make it easy to delete all associated rows when purging a room.
- `inserted_ts` column is added to `event_push_actions_staging` table.
+
+Changes in SCHEMA_VERSION = 74:
+ - A query on `event_stream_ordering` column has now been disambiguated (i.e. the
+ codebase can handle the `current_state_events`, `local_current_memberships` and
+ `room_memberships` tables having an `event_stream_ordering` column).
"""
|
