summary refs log tree commit diff
diff options
context:
space:
mode:
authorNicolas Werner <nicolas.werner@hotmail.de>2021-01-06 08:02:00 -0500
committerNicolas Werner <nicolas.werner@hotmail.de>2021-01-06 08:02:00 -0500
commit1db68109fc246880fca9476e84ff5949b116922c (patch)
tree0931664a49bc5180099ba782817d1fff7bae5c9b
parentMerge pull request #365 from Nheko-Reborn/typing (diff)
parentRemove sodium from flatpak (diff)
downloadnheko-1db68109fc246880fca9476e84ff5949b116922c.tar.xz
Merge branch 'macos-ci-fix' into 'master'
Macos ci fix

See merge request nheko-reborn/nheko!3
-rw-r--r--.ci/macos/Brewfile2
-rw-r--r--.gitlab-ci.yml3
-rw-r--r--io.github.NhekoReborn.Nheko.json10
-rw-r--r--src/LoginPage.cpp6
-rw-r--r--src/UserSettingsPage.cpp2
5 files changed, 7 insertions, 16 deletions
diff --git a/.ci/macos/Brewfile b/.ci/macos/Brewfile

index 7e9687c7..e7a62374 100644 --- a/.ci/macos/Brewfile +++ b/.ci/macos/Brewfile
@@ -1,12 +1,12 @@ tap "nlohmann/json" +brew "python3" brew "pkg-config" brew "clang-format" brew "cmake" brew "ninja" brew "openssl" brew "qt5" -brew "python3" brew "nlohmann_json" brew "gstreamer" brew "gst-plugins-base" diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 8a6775db..4fa41d37 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml
@@ -52,7 +52,8 @@ build-macos: tags: [macos] before_script: - brew update - - brew bundle --file=./.ci/macos/Brewfile + - brew reinstall --force python3 + - brew bundle --file=./.ci/macos/Brewfile --force --cleanup - pip3 install dmgbuild script: - export PATH=/usr/local/opt/qt/bin/:${PATH} diff --git a/io.github.NhekoReborn.Nheko.json b/io.github.NhekoReborn.Nheko.json
index 49e92311..7aba130b 100644 --- a/io.github.NhekoReborn.Nheko.json +++ b/io.github.NhekoReborn.Nheko.json
@@ -126,16 +126,6 @@ ] }, { - "name": "sodium", - "sources": [ - { - "sha256": "6f504490b342a4f8a4c4a02fc9b866cbef8622d5df4e5452b46be121e46636c1", - "type": "archive", - "url": "https://github.com/jedisct1/libsodium/releases/download/1.0.18-RELEASE/libsodium-1.0.18.tar.gz" - } - ] - }, - { "build-commands": [ "./bootstrap.sh --with-libraries=thread,system,iostreams --prefix=/app", "./b2 -d0 variant=release link=static threading=multi --layout=system", diff --git a/src/LoginPage.cpp b/src/LoginPage.cpp
index 39d0f9d6..dba5ba51 100644 --- a/src/LoginPage.cpp +++ b/src/LoginPage.cpp
@@ -315,14 +315,14 @@ LoginPage::checkHomeserverVersion() if (err || flows.flows.empty()) emit versionOkCb(LoginMethod::Password); - LoginMethod loginMethod = LoginMethod::Password; + LoginMethod loginMethod_ = LoginMethod::Password; for (const auto &flow : flows.flows) { if (flow.type == mtx::user_interactive::auth_types::sso) { - loginMethod = LoginMethod::SSO; + loginMethod_ = LoginMethod::SSO; break; } } - emit versionOk(loginMethod); + emit versionOk(loginMethod_); }); }); } diff --git a/src/UserSettingsPage.cpp b/src/UserSettingsPage.cpp
index 4ca3be49..7c7ef9ab 100644 --- a/src/UserSettingsPage.cpp +++ b/src/UserSettingsPage.cpp
@@ -54,7 +54,7 @@ QSharedPointer<UserSettings> UserSettings::instance_; UserSettings::UserSettings() { - connect(QCoreApplication::instance(), &QCoreApplication::aboutToQuit, [this]() { + connect(QCoreApplication::instance(), &QCoreApplication::aboutToQuit, []() { instance_.clear(); }); }