fix: send 204 even if event is invalid (discord does this, idk why)

1 files changed, 1 insertions, 3 deletions

diff --git a/src/api/routes/webhooks/#webhook_id/#token/github.ts b/src/api/routes/webhooks/#webhook_id/#token/github.ts

index a85f4b6b..5baf4e7b 100644
--- a/src/api/routes/webhooks/#webhook_id/#token/github.ts
+++ b/src/api/routes/webhooks/#webhook_id/#token/github.ts
@@ -355,10 +355,8 @@ const parseGitHubWebhook = (req: Request, res: Response, next: NextFunction) =>
 				},
 			];
 			break;
-		case "ping":
-			return res.status(204);
 		default:
-			return res.send(500);
+			return res.status(204).end(); // Yes, discord sends 204 even on invalid event
 	}
 
 	req.body = discordPayload;