From faf25e3a839934cb143afaefabc162a8c1baab11 Mon Sep 17 00:00:00 2001 From: "Paul \"LeoNerd\" Evans" Date: Mon, 18 Aug 2014 13:41:43 +0100 Subject: Allow room presence visibility between users who share a room --- tests/handlers/test_presence.py | 45 ++++++++++++++++++++++++++++++++++++----- 1 file changed, 40 insertions(+), 5 deletions(-) (limited to 'tests') diff --git a/tests/handlers/test_presence.py b/tests/handlers/test_presence.py index 61c2547af4..86bd8bb3f2 100644 --- a/tests/handlers/test_presence.py +++ b/tests/handlers/test_presence.py @@ -80,6 +80,14 @@ class PresenceStateTestCase(unittest.TestCase): return defer.succeed(allow) self.datastore.is_presence_visible = is_presence_visible + # Mock the RoomMemberHandler + room_member_handler = Mock(spec=[ + "get_rooms_for_user", + "get_room_members", + ]) + hs.handlers.room_member_handler = room_member_handler + logging.getLogger().debug("Mocking room_member_handler=%r", room_member_handler) + # Some local users to test with self.u_apple = hs.parse_userid("@apple:test") self.u_banana = hs.parse_userid("@banana:test") @@ -87,11 +95,21 @@ class PresenceStateTestCase(unittest.TestCase): self.handler = hs.get_handlers().presence_handler - hs.handlers.room_member_handler = Mock(spec=[ - "get_rooms_for_user", - ]) - hs.handlers.room_member_handler.get_rooms_for_user = ( - lambda u: defer.succeed([])) + self.room_members = [] + + def get_rooms_for_user(user): + if user in self.room_members: + return defer.succeed(["a-room"]) + else: + return defer.succeed([]) + room_member_handler.get_rooms_for_user = get_rooms_for_user + + def get_room_members(room_id): + if room_id == "a-room": + return defer.succeed(self.room_members) + else: + return defer.succeed([]) + room_member_handler.get_room_members = get_room_members self.mock_start = Mock() self.mock_stop = Mock() @@ -131,6 +149,21 @@ class PresenceStateTestCase(unittest.TestCase): ) mocked_get.assert_called_with("apple") + @defer.inlineCallbacks + def test_get_same_room_state(self): + mocked_get = self.datastore.get_presence_state + mocked_get.return_value = defer.succeed( + {"state": ONLINE, "status_msg": "Online"} + ) + + self.room_members = [self.u_apple, self.u_clementine] + + state = yield self.handler.get_state( + target_user=self.u_apple, auth_user=self.u_clementine + ) + + self.assertEquals({"state": ONLINE, "status_msg": "Online"}, state) + @defer.inlineCallbacks def test_get_disallowed_state(self): mocked_get = self.datastore.get_presence_state @@ -138,6 +171,8 @@ class PresenceStateTestCase(unittest.TestCase): {"state": ONLINE, "status_msg": "Online"} ) + self.room_members = [] + yield self.assertFailure( self.handler.get_state( target_user=self.u_apple, auth_user=self.u_clementine -- cgit 1.4.1