From d0dd14ccee0e3ad4c1ff4a50a911c21fe2e92a2f Mon Sep 17 00:00:00 2001 From: Jorik Schellekens Date: Thu, 11 Jul 2019 17:01:35 +0100 Subject: Remove unused function. --- synapse/logging/opentracing.py | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) (limited to 'synapse') diff --git a/synapse/logging/opentracing.py b/synapse/logging/opentracing.py index 9c50bbb0ff..949427a546 100644 --- a/synapse/logging/opentracing.py +++ b/synapse/logging/opentracing.py @@ -191,13 +191,6 @@ def start_active_span_follows_from(operation_name, contexts): return scope -@only_if_tracing -def close_active_span(): - """Closes the active span. This will close it's logcontext if the context - was made for the span""" - opentracing.tracer.scope_manager.active.__exit__(None, None, None) - - @only_if_tracing def set_tag(key, value): """Set's a tag on the active span""" @@ -213,6 +206,11 @@ def log_kv(key_values, timestamp=None): # Note: we don't have a get baggage items because we're trying to hide all # scope and span state from synapse. I think this method may also be useless # as a result + +# I also thinks it's dangerous with respect to pii. If the whitelisting +# is missconfigured or buggy span information will leak. This is no issue +# if it's jaeger span id's but baggage can contain any arbitrary data. I would +# suggest removing this. @only_if_tracing def set_baggage_item(key, value): """Attach baggage to the active span""" -- cgit 1.5.1