From e707e7b38d67240451d0818c1508bee900952bb0 Mon Sep 17 00:00:00 2001 From: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Date: Thu, 31 Jan 2019 15:34:17 +0000 Subject: Fix infinite loop when an event is redacted in a v3 room (#4535) --- synapse/storage/events_worker.py | 37 ++++++++++++++++++++++++++++++++----- 1 file changed, 32 insertions(+), 5 deletions(-) (limited to 'synapse') diff --git a/synapse/storage/events_worker.py b/synapse/storage/events_worker.py index 57dae324c7..1716be529a 100644 --- a/synapse/storage/events_worker.py +++ b/synapse/storage/events_worker.py @@ -161,6 +161,12 @@ class EventsWorkerStore(SQLBaseStore): log_ctx = LoggingContext.current_context() log_ctx.record_event_fetch(len(missing_events_ids)) + # Note that _enqueue_events is also responsible for turning db rows + # into FrozenEvents (via _get_event_from_row), which involves seeing if + # the events have been redacted, and if so pulling the redaction event out + # of the database to check it. + # + # _enqueue_events is a bit of a rubbish name but naming is hard. missing_events = yield self._enqueue_events( missing_events_ids, allow_rejected=allow_rejected, @@ -179,14 +185,35 @@ class EventsWorkerStore(SQLBaseStore): # instead. if not allow_rejected and entry.event.type == EventTypes.Redaction: if entry.event.internal_metadata.need_to_check_redaction(): - orig = yield self.get_event( - entry.event.redacts, + # XXX: we need to avoid calling get_event here. + # + # The problem is that we end up at this point when an event + # which has been redacted is pulled out of the database by + # _enqueue_events, because _enqueue_events needs to check the + # redaction before it can cache the redacted event. So obviously, + # calling get_event to get the redacted event out of the database + # gives us an infinite loop. + # + # For now (quick hack to fix during 0.99 release cycle), we just + # go and fetch the relevant row from the db, but it would be nice + # to think about how we can cache this rather than hit the db + # every time we access a redaction event. + # + # One thought on how to do this: + # 1. split _get_events up so that it is divided into (a) get the + # rawish event from the db/cache, (b) do the redaction/rejection + # filtering + # 2. have _get_event_from_row just call the first half of that + + orig_sender = yield self._simple_select_one_onecol( + table="events", + keyvalues={"event_id": entry.event.redacts}, + retcol="sender", allow_none=True, - allow_rejected=True, - get_prev_content=False, ) + expected_domain = get_domain_from_id(entry.event.sender) - if orig and get_domain_from_id(orig.sender) == expected_domain: + if orig_sender and get_domain_from_id(orig_sender) == expected_domain: # This redaction event is allowed. Mark as not needing a # recheck. entry.event.internal_metadata.recheck_redaction = False -- cgit 1.5.1 From 07dfe148de2fbc6eb22be662ed8216a6e11f6811 Mon Sep 17 00:00:00 2001 From: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Date: Thu, 31 Jan 2019 18:30:40 +0000 Subject: Add some debug for membership syncing issues (#4538) I can't figure out what's going on with #4422 and #4436; perhaps this will help. --- changelog.d/4538.misc | 1 + synapse/handlers/sync.py | 13 +++++++++++-- 2 files changed, 12 insertions(+), 2 deletions(-) create mode 100644 changelog.d/4538.misc (limited to 'synapse') diff --git a/changelog.d/4538.misc b/changelog.d/4538.misc new file mode 100644 index 0000000000..dbc878b09c --- /dev/null +++ b/changelog.d/4538.misc @@ -0,0 +1 @@ +Add some debug for membership syncing issues diff --git a/synapse/handlers/sync.py b/synapse/handlers/sync.py index 28857bfc1c..bd97241ab4 100644 --- a/synapse/handlers/sync.py +++ b/synapse/handlers/sync.py @@ -895,14 +895,17 @@ class SyncHandler(object): Returns: Deferred(SyncResult) """ - logger.info("Calculating sync response for %r", sync_config.user) - # NB: The now_token gets changed by some of the generate_sync_* methods, # this is due to some of the underlying streams not supporting the ability # to query up to a given point. # Always use the `now_token` in `SyncResultBuilder` now_token = yield self.event_sources.get_current_token() + logger.info( + "Calculating sync response for %r between %s and %s", + sync_config.user, since_token, now_token, + ) + user_id = sync_config.user.to_string() app_service = self.store.get_app_service_by_user_id(user_id) if app_service: @@ -1390,6 +1393,12 @@ class SyncHandler(object): room_entries = [] invited = [] for room_id, events in iteritems(mem_change_events_by_room_id): + logger.info( + "Membership changes in %s: [%s]", + room_id, + ", ".join(("%s (%s)" % (e.event_id, e.membership) for e in events)), + ) + non_joins = [e for e in events if e.membership != Membership.JOIN] has_join = len(non_joins) != len(events) -- cgit 1.5.1 From 85129d7068203c7fa1dfd5f68b6f6b412a5c7bd2 Mon Sep 17 00:00:00 2001 From: Richard van der Hoff Date: Thu, 31 Jan 2019 18:35:38 +0000 Subject: v0.99.0rc3 --- CHANGES.md | 21 +++++++++++++++++++++ changelog.d/4526.doc | 1 - changelog.d/4535.bugfix | 1 - changelog.d/4538.misc | 1 - synapse/__init__.py | 2 +- 5 files changed, 22 insertions(+), 4 deletions(-) delete mode 100644 changelog.d/4526.doc delete mode 100644 changelog.d/4535.bugfix delete mode 100644 changelog.d/4538.misc (limited to 'synapse') diff --git a/CHANGES.md b/CHANGES.md index e08b8771b8..458bbaf118 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,3 +1,24 @@ +Synapse 0.99.0rc3 (2019-01-31) +============================== + +Bugfixes +-------- + +- Fix infinite loop when an event is redacted in a v3 room ([\#4535](https://github.com/matrix-org/synapse/issues/4535)) + + +Improved Documentation +---------------------- + +- Update debian installation instructions ([\#4526](https://github.com/matrix-org/synapse/issues/4526)) + + +Internal Changes +---------------- + +- Add some debug for membership syncing issues ([\#4538](https://github.com/matrix-org/synapse/issues/4538)) + + Synapse 0.99.0rc2 (2019-01-30) ============================== diff --git a/changelog.d/4526.doc b/changelog.d/4526.doc deleted file mode 100644 index b7536e25f8..0000000000 --- a/changelog.d/4526.doc +++ /dev/null @@ -1 +0,0 @@ -Update debian installation instructions diff --git a/changelog.d/4535.bugfix b/changelog.d/4535.bugfix deleted file mode 100644 index facd344cdd..0000000000 --- a/changelog.d/4535.bugfix +++ /dev/null @@ -1 +0,0 @@ -Fix infinite loop when an event is redacted in a v3 room diff --git a/changelog.d/4538.misc b/changelog.d/4538.misc deleted file mode 100644 index dbc878b09c..0000000000 --- a/changelog.d/4538.misc +++ /dev/null @@ -1 +0,0 @@ -Add some debug for membership syncing issues diff --git a/synapse/__init__.py b/synapse/__init__.py index 5da59aa924..e5f680bb31 100644 --- a/synapse/__init__.py +++ b/synapse/__init__.py @@ -27,4 +27,4 @@ try: except ImportError: pass -__version__ = "0.99.0rc2" +__version__ = "0.99.0rc3" -- cgit 1.5.1