From c4675e1b24f06a72c323c8131eab4998b4e71af1 Mon Sep 17 00:00:00 2001
From: David Florness <david@florness.com>
Date: Wed, 2 Dec 2020 10:01:15 -0500
Subject: Add additional validation for the admin register endpoint. (#8837)

Raise a proper 400 error if the `mac` field is missing.
---
 synapse/rest/admin/users.py | 3 +++
 1 file changed, 3 insertions(+)

(limited to 'synapse/rest/admin')

diff --git a/synapse/rest/admin/users.py b/synapse/rest/admin/users.py
index b0ff5e1ead..90940ff185 100644
--- a/synapse/rest/admin/users.py
+++ b/synapse/rest/admin/users.py
@@ -420,6 +420,9 @@ class UserRegisterServlet(RestServlet):
         if user_type is not None and user_type not in UserTypes.ALL_USER_TYPES:
             raise SynapseError(400, "Invalid user type")
 
+        if "mac" not in body:
+            raise SynapseError(400, "mac must be specified", errcode=Codes.BAD_JSON)
+
         got_mac = body["mac"]
 
         want_mac_builder = hmac.new(
-- 
cgit 1.4.1