From 718ffcf8bbf83975a211a1b840de696c0eabec01 Mon Sep 17 00:00:00 2001
From: "Paul \"LeoNerd\" Evans" <paul@matrix.org>
Date: Thu, 18 Aug 2016 14:18:37 +0100
Subject: Since empty lookups now return 200/empty list not 404, we can safely
 log failures as exceptions

---
 synapse/appservice/api.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

(limited to 'synapse/appservice/api.py')

diff --git a/synapse/appservice/api.py b/synapse/appservice/api.py
index 39b4bff556..e05570cc8b 100644
--- a/synapse/appservice/api.py
+++ b/synapse/appservice/api.py
@@ -78,9 +78,8 @@ class ApplicationServiceApi(SimpleHttpClient):
         try:
             response = yield self.get_json(uri, fields)
             defer.returnValue(response)
-        except Exception:
-            # TODO: would be noisy to log lookup failures, but we want to log
-            # other things. Hrm.
+        except Exception as ex:
+            logger.warning("query_3pu to %s threw exception %s", uri, ex)
             defer.returnValue([])
 
     @defer.inlineCallbacks
-- 
cgit 1.4.1