From d4c4798a2548a53b63546a176f6dd350c4ad26bc Mon Sep 17 00:00:00 2001 From: Quentin Gliech Date: Thu, 25 Mar 2021 17:53:54 +0100 Subject: Use interpreter from $PATH instead of absolute paths in various scripts using /usr/bin/env (#9689) On NixOS, `bash` isn't under `/bin/bash` but rather in some directory in `$PATH`. Locally, I've been patching those scripts to make them work. `/usr/bin/env` seems to be the only [portable way](https://unix.stackexchange.com/questions/29608/why-is-it-better-to-use-usr-bin-env-name-instead-of-path-to-name-as-my) to use binaries from the PATH as interpreters. Signed-off-by: Quentin Gliech --- scripts-dev/lint.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'scripts-dev/lint.sh') diff --git a/scripts-dev/lint.sh b/scripts-dev/lint.sh index fe2965cd36..9761e97594 100755 --- a/scripts-dev/lint.sh +++ b/scripts-dev/lint.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # # Runs linting scripts over the local Synapse checkout # isort - sorts import statements -- cgit 1.5.1 From f380bb77d19e7dd4ee6f61cd489e240ee4aa8fc2 Mon Sep 17 00:00:00 2001 From: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Date: Tue, 30 Mar 2021 10:30:43 +0100 Subject: Use 'dmypy run' in lint.sh instead of 'mypy' (#9701) For it's obvious performance benefits. `dmypy` support landed in #9692. --- changelog.d/9701.misc | 1 + scripts-dev/lint.sh | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 changelog.d/9701.misc (limited to 'scripts-dev/lint.sh') diff --git a/changelog.d/9701.misc b/changelog.d/9701.misc new file mode 100644 index 0000000000..49fa7b3593 --- /dev/null +++ b/changelog.d/9701.misc @@ -0,0 +1 @@ +Use `dmypy run` in lint script for improved performance in type-checking while developing. \ No newline at end of file diff --git a/scripts-dev/lint.sh b/scripts-dev/lint.sh index 9761e97594..41415ee07b 100755 --- a/scripts-dev/lint.sh +++ b/scripts-dev/lint.sh @@ -95,4 +95,4 @@ isort "${files[@]}" python3 -m black "${files[@]}" ./scripts-dev/config-lint.sh flake8 "${files[@]}" -mypy +dmypy run -- cgit 1.5.1 From 5fe38e07e74869574b79f0d91e3d607069313352 Mon Sep 17 00:00:00 2001 From: Patrick Cloke Date: Wed, 31 Mar 2021 14:17:52 -0400 Subject: Revert "Use 'dmypy run' in lint.sh instead of 'mypy' (#9701)" (#9720) --- changelog.d/9720.misc | 1 + scripts-dev/lint.sh | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 changelog.d/9720.misc (limited to 'scripts-dev/lint.sh') diff --git a/changelog.d/9720.misc b/changelog.d/9720.misc new file mode 100644 index 0000000000..9dd0bc9cff --- /dev/null +++ b/changelog.d/9720.misc @@ -0,0 +1 @@ +Revert using `dmypy run` in lint script. diff --git a/scripts-dev/lint.sh b/scripts-dev/lint.sh index 41415ee07b..9761e97594 100755 --- a/scripts-dev/lint.sh +++ b/scripts-dev/lint.sh @@ -95,4 +95,4 @@ isort "${files[@]}" python3 -m black "${files[@]}" ./scripts-dev/config-lint.sh flake8 "${files[@]}" -dmypy run +mypy -- cgit 1.5.1