From 7cf0b9069f40acfbf84e64233a62231cd8e40e87 Mon Sep 17 00:00:00 2001 From: clokep Date: Wed, 6 Jul 2022 11:31:35 +0000 Subject: deploy: dcc7873700da4a818e84c44c6190525d39a854cb --- develop/development/cas.html | 2 +- develop/development/contributing_guide.html | 12 +- develop/development/database_schema.html | 2 +- develop/development/demo.html | 2 +- develop/development/dependencies.html | 2 +- develop/development/experimental_features.html | 2 +- develop/development/git.html | 2 +- .../development/internal_documentation/index.html | 2 +- develop/development/releases.html | 6 +- develop/development/reviews.html | 222 +++++++++++++++++++++ develop/development/room-dag-concepts.html | 2 +- develop/development/saml.html | 2 +- .../synapse_architecture/cancellation.html | 2 +- develop/development/url_previews.html | 2 +- 14 files changed, 245 insertions(+), 17 deletions(-) create mode 100644 develop/development/reviews.html (limited to 'develop/development') diff --git a/develop/development/cas.html b/develop/development/cas.html index 2403b04cc9..e6c4b762ca 100644 --- a/develop/development/cas.html +++ b/develop/development/cas.html @@ -76,7 +76,7 @@ diff --git a/develop/development/contributing_guide.html b/develop/development/contributing_guide.html index e770b68a95..2778bd52c4 100644 --- a/develop/development/contributing_guide.html +++ b/develop/development/contributing_guide.html @@ -76,7 +76,7 @@ @@ -376,7 +376,7 @@ install gotestfmt.<
  • git push your commit to your fork of Synapse;
  • on GitHub, create the Pull Request;
  • add a changelog entry and push it to your Pull Request;
    • -
  • for most contributors, that's all - however, if you are a member of the organization matrix-org, on GitHub, please request a review from matrix.org / Synapse Core.
    • +
  • that's it for now, a non-draft pull request will automatically request review from the team;
  • if you need to update your PR, please avoid rebasing and just add new commits to your branch.

    • Changelog

    @@ -525,7 +525,11 @@ be required.

  • If there is any error, fix the error.
    • -
  • If a developer has requested changes, make these changes and let us know if it is ready for a developer to review again.
    • +
  • If a developer has requested changes, make these changes and let us know if it is ready for a developer to review again. + +
  • Create a new commit with the changes.
  • Back to 1.
    • +
  • Once the pull request is ready for review again please re-request review from whichever developer did your initial +review (or leave a comment in the pull request that you believe all required changes have been done).

    • Once both the CI and the developers are happy, the patch will be merged into Synapse and released shortly!

    11. Find a new issue.

    diff --git a/develop/development/database_schema.html b/develop/development/database_schema.html index ec6132d4d6..bf2230d983 100644 --- a/develop/development/database_schema.html +++ b/develop/development/database_schema.html @@ -76,7 +76,7 @@ diff --git a/develop/development/demo.html b/develop/development/demo.html index 5ce1fe5b97..eac5b202ab 100644 --- a/develop/development/demo.html +++ b/develop/development/demo.html @@ -76,7 +76,7 @@ diff --git a/develop/development/dependencies.html b/develop/development/dependencies.html index ae81f5fc5a..4896de3a78 100644 --- a/develop/development/dependencies.html +++ b/develop/development/dependencies.html @@ -76,7 +76,7 @@ diff --git a/develop/development/experimental_features.html b/develop/development/experimental_features.html index 3fc032b567..66d1414c33 100644 --- a/develop/development/experimental_features.html +++ b/develop/development/experimental_features.html @@ -76,7 +76,7 @@ diff --git a/develop/development/git.html b/develop/development/git.html index d086750047..606a9ddb52 100644 --- a/develop/development/git.html +++ b/develop/development/git.html @@ -76,7 +76,7 @@ diff --git a/develop/development/internal_documentation/index.html b/develop/development/internal_documentation/index.html index eea61e365e..6d515fc55c 100644 --- a/develop/development/internal_documentation/index.html +++ b/develop/development/internal_documentation/index.html @@ -76,7 +76,7 @@ diff --git a/develop/development/releases.html b/develop/development/releases.html index 3d6abdb608..83277dc1d9 100644 --- a/develop/development/releases.html +++ b/develop/development/releases.html @@ -76,7 +76,7 @@ @@ -181,7 +181,7 @@ found in the security catego