From 0a778c135f37243277d1dbac2a6490455b228cfc Mon Sep 17 00:00:00 2001 From: Eric Eastwood Date: Fri, 26 Mar 2021 13:42:58 -0500 Subject: Make pip install faster in Docker build for Complement testing (#9610) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Make pip install faster in Docker build for [Complement](https://github.com/matrix-org/complement) testing. If files have changed in a `COPY` command, Docker will invalidate all of the layers below. So I changed the order of operations to install all dependencies before we `COPY synapse /synapse/synapse/`. This allows Docker to use our cached layer of dependencies even when we change the source of Synapse and speed up builds dramatically! `53.5s` -> `3.7s` builds 🤘 As an alternative, I did try using BuildKit caches but this still took 30 seconds overall on that step. 15 seconds to gather the dependencies from the cache and another 15 seconds to `Installing collected packages`. Fix https://github.com/matrix-org/synapse/issues/9364 --- changelog.d/9610.docker | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/9610.docker (limited to 'changelog.d/9610.docker') diff --git a/changelog.d/9610.docker b/changelog.d/9610.docker new file mode 100644 index 0000000000..056252a669 --- /dev/null +++ b/changelog.d/9610.docker @@ -0,0 +1 @@ +Speed up Docker builds and make it nicer to test against Complement while developing (install all dependencies before copying the project). -- cgit 1.4.1