From 0a363f9ca4b71187eb26b80dfa2cd72a35b1f8fd Mon Sep 17 00:00:00 2001
From: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Date: Mon, 22 Feb 2021 16:52:45 +0000
Subject: Remove cache for get_shared_rooms_for_users (#9416)

This PR remove the cache for the `get_shared_rooms_for_users` storage method (the db method driving the experimental "what rooms do I share with this user?" feature: [MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666)). Currently subsequent requests to the endpoint will return the same result, even if your shared rooms with that user have changed.

The cache was added in https://github.com/matrix-org/synapse/pull/7785, but we forgot to ensure it was invalidated appropriately.

Upon attempting to invalidate it, I found that the cache had to be entirely invalidated whenever a user (remote or local) joined or left a room. This didn't make for a very useful cache, especially for a function that may or may not be called very often. Thus, I've opted to remove it instead of invalidating it.
---
 changelog.d/9416.bugfix | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 changelog.d/9416.bugfix

(limited to 'changelog.d/9416.bugfix')

diff --git a/changelog.d/9416.bugfix b/changelog.d/9416.bugfix
new file mode 100644
index 0000000000..4d79cb2228
--- /dev/null
+++ b/changelog.d/9416.bugfix
@@ -0,0 +1 @@
+Fix a bug that caused multiple calls to the experimental `shared_rooms` endpoint to return stale results.
\ No newline at end of file
-- 
cgit 1.5.1