From f2d2ae03dae519a4f2035f1466fdd3429c71edc8 Mon Sep 17 00:00:00 2001 From: David Baker Date: Tue, 18 Jun 2019 22:51:24 +0100 Subject: Add some logging to 3pid invite sig verification (#5015) I had to add quite a lot of logging to diagnose a problem with 3pid invites - we only logged the one failure which isn't all that informative. NB. I'm not convinced the logic of this loop is right: I think it should just accept a single valid signature from a trusted source rather than fail if *any* signature is invalid. Also it should probably not skip the rest of middle loop if a check fails? However, I'm deliberately not changing the logic here. --- changelog.d/5015.misc | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/5015.misc (limited to 'changelog.d/5015.misc') diff --git a/changelog.d/5015.misc b/changelog.d/5015.misc new file mode 100644 index 0000000000..eeec85b92c --- /dev/null +++ b/changelog.d/5015.misc @@ -0,0 +1 @@ +Add logging to 3pid invite signature verification. -- cgit 1.4.1