From c4c1d170afcc78eee8b0a9c65fac666b70598989 Mon Sep 17 00:00:00 2001 From: Erik Johnston Date: Tue, 28 Nov 2017 15:19:15 +0000 Subject: Fix wrong avatars when inviting multiple users when creating room We reused the `content` dictionary between invite requests, which meant they could end up reusing the profile info for a previous user --- synapse/handlers/room.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/synapse/handlers/room.py b/synapse/handlers/room.py index 496f1fc39b..6a0431ba70 100644 --- a/synapse/handlers/room.py +++ b/synapse/handlers/room.py @@ -205,12 +205,12 @@ class RoomCreationHandler(BaseHandler): }, ratelimit=False) - content = {} - is_direct = config.get("is_direct", None) - if is_direct: - content["is_direct"] = is_direct - for invitee in invite_list: + content = {} + is_direct = config.get("is_direct", None) + if is_direct: + content["is_direct"] = is_direct + yield room_member_handler.update_membership( requester, UserID.from_string(invitee), -- cgit 1.4.1