From 342a502a1e08968dd2643af46eaf4105b086edf9 Mon Sep 17 00:00:00 2001 From: Sean Quah Date: Thu, 28 Apr 2022 16:29:58 +0100 Subject: Disable tests for the `@cancellable` flag on `BaseFederationServlet` methods Signed-off-by: Sean Quah --- synapse/federation/transport/server/_base.py | 2 ++ tests/federation/transport/server/test__base.py | 2 ++ 2 files changed, 4 insertions(+) diff --git a/synapse/federation/transport/server/_base.py b/synapse/federation/transport/server/_base.py index 73467bccf7..103861644a 100644 --- a/synapse/federation/transport/server/_base.py +++ b/synapse/federation/transport/server/_base.py @@ -376,6 +376,8 @@ class BaseFederationServlet: if is_method_cancellable(code): # The wrapper added by `self._wrap` will inherit the cancellable flag, # but the wrapper itself does not support cancellation yet. + # Once resolved, the cancellation tests in + # `tests/federation/transport/server/test__base.py` can be re-enabled. raise Exception( f"{self.__class__.__name__}.on_{method} has been marked as " "cancellable, but federation servlets do not support cancellation " diff --git a/tests/federation/transport/server/test__base.py b/tests/federation/transport/server/test__base.py index bd90caa6ca..7d02311610 100644 --- a/tests/federation/transport/server/test__base.py +++ b/tests/federation/transport/server/test__base.py @@ -59,6 +59,8 @@ class BaseFederationServletCancellationTests( ): """Tests for `BaseFederationServlet` cancellation.""" + skip = "`BaseFederationServlet` does not support cancellation yet." + path = f"{CancellableFederationServlet.PREFIX}{CancellableFederationServlet.PATH}" def create_test_resource(self): -- cgit 1.4.1