summary refs log tree commit diff
path: root/synapse (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Remove special casing of `m.room.aliases` events (#7034)Patrick Cloke2020-03-172-27/+1
|
* Revert "Add options to disable setting profile info for prevent changes. ↵Richard van der Hoff2020-03-173-49/+0
| | | | | | | (#7053)" This reverts commit 54dd28621b070ca67de9f773fe9a89e1f4dc19da, reversing changes made to 6640460d054e8f4444046a34bdf638921b31c01e.
* Populate the room version from state events (#7070)Brendan Abolivier2020-03-162-0/+62
| | | | | Fixes #7065 This is basically the same as https://github.com/matrix-org/synapse/pull/6847 except it tries to populate events from `state_events` rather than `current_state_events`, since the latter might have been cleared from the state of some rooms too early, leaving them with a `NULL` room version.
* Fix buggy condition in account validity handler (#7074)Brendan Abolivier2020-03-161-1/+5
|
* Merge pull request #7067 from matrix-org/babolivier/saml_error_moarBrendan Abolivier2020-03-132-23/+72
|\ | | | | Move the default SAML2 error HTML to a dedicated file
| * Use innerText instead of innerHTMLBrendan Abolivier2020-03-131-1/+2
| |
| * LintBrendan Abolivier2020-03-111-2/+1
| |
| * Put the file in the templates directoryBrendan Abolivier2020-03-111-12/+21
| |
| * Update wording and configBrendan Abolivier2020-03-112-2/+5
| |
| * Move the default SAML2 error HTML to a dedicated fileBrendan Abolivier2020-03-112-18/+55
| | | | | | | | | | Also add some JS to it to process any error we might have in the URI (see #6893).
* | Add type annotations and comments to auth handler (#7063)Patrick Cloke2020-03-121-89/+104
| |
* | Refactor a bitBrendan Abolivier2020-03-111-28/+30
| |
* | Also don't fail on aliases events in this caseBrendan Abolivier2020-03-111-1/+1
| |
* | LintBrendan Abolivier2020-03-111-1/+5
| |
* | Also don't filter out events sent by ignored users when checking state ↵Brendan Abolivier2020-03-111-1/+1
| | | | | | | | visibility
* | Fix conditionBrendan Abolivier2020-03-111-1/+1
| |
* | Don't filter out dummy events when we're checking the visibility of stateBrendan Abolivier2020-03-112-9/+8
|/
* Add options to disable setting profile info for prevent changes. (#7053)Brendan Abolivier2020-03-103-0/+49
|\
| * Update synapse/config/registration.pyDirk Klimpel2020-03-101-1/+1
| | | | | | Co-Authored-By: Brendan Abolivier <github@brendanabolivier.com>
| * lint, fix testsdklimpel2020-03-091-1/+3
| |
| * updates after reviewdklimpel2020-03-093-18/+24
| |
| * add disable_3pid_changesdklimpel2020-03-082-0/+16
| |
| * lint2dklimpel2020-03-081-2/+2
| |
| * lintdklimpel2020-03-081-4/+2
| |
| * changelogdklimpel2020-03-082-4/+10
| |
| * Add options to disable setting profile info for prevent changes.dklimpel2020-03-082-0/+21
| |
* | Rephrase default messageBrendan Abolivier2020-03-101-2/+2
| |
* | Hopefully mypy is happy nowBrendan Abolivier2020-03-102-3/+10
| |
* | Attempt at appeasing the gods of mypyBrendan Abolivier2020-03-101-1/+1
| |
* | LintBrendan Abolivier2020-03-101-1/+1
| |
* | SAML2: render a comprehensible error page if something goes wrongBrendan Abolivier2020-03-103-2/+62
| | | | | | | | | | | | If an error happened while processing a SAML AuthN response, or a client ends up doing a `GET` request to `/authn_response`, then render a customisable error page rather than a confusing error.
* | Merge pull request #7055 from ↵Brendan Abolivier2020-03-092-18/+20
|\ \ | | | | | | | | | | | | matrix-org/babolivier/get_time_of_last_push_action_before Move get_time_of_last_push_action_before to the EventPushActionsWorkerStore
| * | Fix undefined `room_id` in `make_summary_text`Brendan Abolivier2020-03-091-1/+3
| | | | | | | | | | | | | | | This would break notifications about un-named rooms when processing notifications in a batch.
| * | Move `get_time_of_last_push_action_before` to the `EventPushActionsWorkerStore`Brendan Abolivier2020-03-091-17/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #7054 I also had a look at the rest of the functions in `EventPushActionsStore` and in the push notifications send code and it looks to me like there shouldn't be any other method with this issue in this part of the codebase.
* | | Remove special auth and redaction rules for aliases events in experimental ↵Patrick Cloke2020-03-095-19/+22
| | | | | | | | | | | | room ver. (#7037)
* | | Merge pull request #7045 from matrix-org/babolivier/room_keys_checkBrendan Abolivier2020-03-091-0/+7
|\ \ \ | | | | | | | | Make sure that is_verified is a boolean when processing room keys
| * | | LintBrendan Abolivier2020-03-061-2/+1
| | | |
| * | | Mention the session ID in the error messageBrendan Abolivier2020-03-061-2/+3
| | | |
| * | | LintBrendan Abolivier2020-03-061-1/+2
| | | |
| * | | Make sure that is_verified is a boolean when processing room keysBrendan Abolivier2020-03-061-0/+6
| |/ /
* | | Add type hints to logging/context.py (#6309)Neil Pilgrim2020-03-071-47/+74
| | | | | | | | | | | | | | | | | | * Add type hints to logging/context.py Signed-off-by: neiljp (Neil Pilgrim) <github@kepier.clara.net>
* | | Break down monthly active users by appservice_id (#7030)Neil Johnson2020-03-062-1/+44
|/ / | | | | | | | | * Break down monthly active users by appservice_id and emit via prometheus. Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* | Convert remote key resource REST layer to async/await. (#7020)Patrick Cloke2020-03-051-7/+4
| |
* | Store room_versions in EventBase objects (#6875)Richard van der Hoff2020-03-054-32/+62
| | | | | | | | | | | | | | This is a bit fiddly because it all has to be done on one fell swoop: * Wherever we create a new event, pass in the room version (and check it matches the format version) * When we prune an event, use the room version of the unpruned event to create the pruned version. * When we pass an event over the replication protocol, pass the room version over alongside it, and use it when deserialising the event again.
* | Hide extremities dummy events from clientsBrendan Abolivier2020-03-041-0/+3
| |
* | Allow deleting an alias if the user has sufficient power level (#6986)Patrick Cloke2020-03-042-40/+76
| |
* | Read the room version from database when fetching events (#6874)Richard van der Hoff2020-03-041-16/+68
| | | | | | | | | | This is a precursor to giving EventBase objects the knowledge of which room version they belong to.
* | Merge branch 'master' into developBrendan Abolivier2020-03-039-34/+219
|\ \
| * | v1.11.1Brendan Abolivier2020-03-031-1/+1
| | |
| * | Fix wrong handler being used in SAML handlerBrendan Abolivier2020-03-031-3/+2
| | |
| * | Factor out complete_sso_login and expose it to the Module APIBrendan Abolivier2020-03-034-57/+96
| | |
| * | Add a whitelist for the SSO confirmation step.Richard van der Hoff2020-03-022-8/+36
| | |
| * | Merge remote-tracking branch 'origin/release-v1.11.1' into release-v1.11.1Richard van der Hoff2020-03-022-10/+12
| |\ \
| | * | Fixed set a user as an admin with the new API (#6928)Dirk Klimpel2020-03-022-10/+12
| | | | | | | | | | | | | | | | Fix #6910
| * | | Add a confirmation step to the SSO login flowBrendan Abolivier2020-03-025-6/+126
| |/ /
* | / Validate the alt_aliases property of canonical alias events (#6971)Patrick Cloke2020-03-034-15/+62
| |/ |/|
* | Always return a deferred from `get_current_state_deltas`. (#7019)Erik Johnston2020-03-021-1/+3
| | | | | | | | | | This currently causes presence notify code to log exceptions when there is no state changes to process. This doesn't actually cause any problems as we'd simply do nothing anyway.
* | Add some type annotations to the federation base & client classes (#6995)Patrick Cloke2020-02-282-28/+42
| |
* | Fixed set a user as an admin with the new API (#6928)Dirk Klimpel2020-02-282-10/+12
| | | | | | Fix #6910
* | Merge remote-tracking branch 'origin/release-v1.11.1' into developPatrick Cloke2020-02-271-6/+8
|\|
| * Cast a coroutine into a Deferred in the federation base (#6996)Patrick Cloke2020-02-261-6/+8
| | | | | | | | Properly convert a coroutine into a Deferred in federation_base to fix an error when joining a room.
* | Don't refuse to start worker if media listener configured. (#7002)Erik Johnston2020-02-271-14/+20
| | | | | | | | | | | | | | | | Instead lets just warn if the worker has a media listener configured but has the media repository disabled. Previously non media repository workers would just ignore the media listener.
* | Add some type annotations in `synapse.storage` (#6987)Richard van der Hoff2020-02-276-82/+266
| | | | | | | | | | I cracked, and added some type definitions in synapse.storage.
* | Store room version on invite (#6983)Richard van der Hoff2020-02-264-2/+68
| | | | | | | | | | When we get an invite over federation, store the room version in the rooms table. The general idea here is that, when we pull the invite out again, we'll want to know what room_version it belongs to (so that we can later redact it if need be). So we need to store it somewhere...
* | Port PresenceHandler to async/await (#6991)Erik Johnston2020-02-264-109/+99
| |
* | Updated warning for incorrect database collation/ctype (#6985)Uday Bansal2020-02-261-3/+7
| | | | | | Signed-off-by: Uday Bansal <43824981+udaybansal19@users.noreply.github.com>
* | Ensure 'deactivated' parameter is a boolean on user admin API, Fix error ↵Andrew Morgan2020-02-262-4/+8
| | | | | | | | handling of call to deactivate user (#6990)
* | Sanity-check database before running upgrades (#6982)Richard van der Hoff2020-02-252-17/+32
| | | | | | | | | | | | Some of the database deltas rely on `config.server_name` being set correctly, so we should check that it is before running the deltas. Fixes #6870.
* | Merge worker apps into one. (#6964)Erik Johnston2020-02-2513-2317/+1045
| |
* | Remove redundant store_room call (#6979)Richard van der Hoff2020-02-241-23/+0
| | | | | | | | | | `_process_received_pdu` is only called by `on_receive_pdu`, which ignores any events for unknown rooms, so this is redundant.
* | Upsert room version when we join over federation (#6968)Richard van der Hoff2020-02-242-10/+29
| | | | | | | | | | | | | | | | This is intended as a precursor to storing room versions when we receive an invite over federation, but has the happy side-effect of fixing #3374 at last. In short: change the store_room with try/except to a proper upsert which updates the right columns.
* | Fix minor issues with email config (#6962)Richard van der Hoff2020-02-241-36/+30
| | | | | | | | | | | | * Give `notif_template_html`, `notif_template_text` default values (fixes #6960) * Don't complain if `smtp_host` and `smtp_port` are unset, since they have sensible defaults (fixes #6961) * Set the example for `enable_notifs` to `True`, for consistency and because it's more useful * Raise errors as ConfigError rather than RuntimeError for nicer formatting
* | No longer use room alias events to calculate room names for push ↵Patrick Cloke2020-02-211-22/+14
| | | | | | | | notifications. (#6966)
* | Change displayname of user as admin in rooms (#6876)Dirk Klimpel2020-02-211-1/+11
| |
* | Stop returning aliases as part of the room list. (#6970)Patrick Cloke2020-02-211-9/+0
| |
* | Publishing/removing from the directory requires a power level greater than ↵Patrick Cloke2020-02-211-5/+5
| | | | | | | | canonical aliases.
* | Clarify list/set/dict/tuple comprehensions and enforce via flake8 (#6957)Patrick Cloke2020-02-2153-168/+159
| | | | | | | | Ensure good comprehension hygiene using flake8-comprehensions.
* | Merge pull request #6967 from matrix-org/rav/increase_max_events_behindRichard van der Hoff2020-02-211-1/+1
|\ \ | | | | | | Increase MAX_EVENTS_BEHIND for replication clients
| * | Increase MAX_EVENTS_BEHIND for replication clientsErik Johnston2020-02-211-1/+1
| | |
* | | Merge branch 'master' into developRichard van der Hoff2020-02-212-6/+6
|\ \ \ | |/ / |/| / | |/
| * 1.11.0 v1.11.0 github/release-v1.11.0 release-v1.11.0Richard van der Hoff2020-02-211-1/+1
| |
| * Small grammar fixes to the ACME v1 deprecation notice (#6944)Andrew Morgan2020-02-211-5/+5
| | | | | | Some small fixes to the copy in #6907.
* | Do not send alias events when creating / upgrading a room (#6941)Patrick Cloke2020-02-202-40/+15
| | | | | | Stop emitting room alias update events during room creation/upgrade.
* | don't insert into the device table for remote cross-signing keys (#6956)Hubert Chathi2020-02-201-15/+18
| |
* | Add some clarifications to README.md in the database schema directory. (#6615)Ruben Barkow-Kuder2020-02-201-8/+16
| | | | | | Signed-off-by: Ruben Barkow-Kuder <github@r.z11.de>
* | Minor perf fixes to `get_auth_chain_ids`.Erik Johnston2020-02-192-7/+5
| |
* | Freeze allocated objects on startup. (#6953)Erik Johnston2020-02-191-0/+9
| | | | | | | | | | This may make gc go a bit faster as the gc will know things like caches/data stores etc. are frozen without having to check.
* | Reduce auth chains fetched during v2 state res. (#6952)Erik Johnston2020-02-193-11/+34
|/ | | | | | The state res v2 algorithm only cares about the difference between auth chains, so we can pass in the known common state to the `get_auth_chain` storage function so that it can ignore those events.
* 1.11.0rc1Richard van der Hoff2020-02-191-1/+1
|
* Revert `get_auth_chain_ids` changes (#6951)Erik Johnston2020-02-191-28/+0
|
* Merge pull request #6949 from matrix-org/rav/list_room_aliases_peekableRichard van der Hoff2020-02-197-84/+77
|\ | | | | Make room alias lists peekable
| * Make room alias lists peekableRichard van der Hoff2020-02-191-1/+3
| | | | | | | | | | | | As per https://github.com/matrix-org/matrix-doc/pull/2432#pullrequestreview-360566830, make room alias lists accessible to users outside world_readable rooms.
| * Add `allow_departed_users` param to `check_in_room_or_world_readable`Richard van der Hoff2020-02-195-15/+33
| | | | | | | | | | | | | | ... and set it everywhere it's called. while we're here, rename it for consistency with `check_user_in_room` (and to help check that I haven't missed any instances)
| * Refactor the membership check methods in AuthRichard van der Hoff2020-02-183-71/+44
| | | | | | | | | | these were getting a bit unwieldy, so let's combine `check_joined_room` and `check_user_was_in_room` into a single `check_user_in_room`.
* | Move MSC2432 stuff onto unstable prefix (#6948)Richard van der Hoff2020-02-192-1/+9
| | | | | | it's not in the spec yet, so needs to be unstable. Also add a feature flag for it. Also add a test for admin users.
* | Tiny optimisation for _get_handler_for_request (#6950)Richard van der Hoff2020-02-191-1/+3
| | | | | | | | we have hundreds of path_regexes (see #5118), so let's not convert the same bytes to str for each of them.
* | Increase DB/CPU perf of `_is_server_still_joined` check. (#6936)Erik Johnston2020-02-192-15/+59
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Increase DB/CPU perf of `_is_server_still_joined` check. For rooms with large amount of state a single user leaving could cause us to go and load a lot of membership events and then pull out membership state in a large number of batches. * Newsfile * Update synapse/storage/persist_events.py Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> * Fix adding if too soon * Update docstring * Review comments * Woops typo Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Merge pull request #6945 from matrix-org/babolivier/fix-retention-debug-logBrendan Abolivier2020-02-191-1/+1
|\ \ | | | | | | Fix log in message retention purge jobs
| * | Fix log in message retention purge jobsBrendan Abolivier2020-02-181-1/+1
| | |
* | | Limit size of get_auth_chain_ids query (#6947)Erik Johnston2020-02-191-18/+23
| |/ |/|
* | Implement GET /_matrix/client/r0/rooms/{roomId}/aliases (#6939)Richard van der Hoff2020-02-182-1/+39
| | | | | | | | | | per matrix-org/matrix-doc#2432
* | Merge pull request #6872 from matrix-org/rav/dictpropertyRichard van der Hoff2020-02-181-81/+118
|\ \ | | | | | | Rewrite _EventInternalMetadata to back it with a dict
| * | Rewrite _EventInternalMetadata to back it with a _dictRichard van der Hoff2020-02-141-16/+39
| | | | | | | | | | | | Mostly, this gives mypy an easier time.
| * | Replace _event_dict_property with DictPropertyRichard van der Hoff2020-02-141-65/+79
| | | | | | | | | | | | | | | this amounts to the same thing, but replaces `_event_dict` with `_dict`, and removes some of the function layers generated by `property`.
* | | Merge pull request #6907 from matrix-org/babolivier/acme-configBrendan Abolivier2020-02-182-1/+34
|\ \ \ | |_|/ |/| | Add mention and warning about ACME v1 deprecation to the TLS config
| * | Make the log more noticeableBrendan Abolivier2020-02-181-1/+2
| | |
| * | Print the error as an error log and raise the same exception we gotBrendan Abolivier2020-02-181-9/+10
| | |
| * | Linters are hard but in they end they just want what's best for usBrendan Abolivier2020-02-131-1/+1
| | |
| * | LintBrendan Abolivier2020-02-131-6/+7
| | |
| * | LintBrendan Abolivier2020-02-131-7/+6
| | |
| * | Add a separator for the config warningBrendan Abolivier2020-02-131-1/+1
| | |
| * | Add a comprehensive error when failing to register for an ACME accountBrendan Abolivier2020-02-131-1/+13
| | |
| * | Add mention and warning about ACME v1 deprecation to the Synapse configBrendan Abolivier2020-02-131-0/+19
| | |
* | | Increase perf of `get_auth_chain_ids` used in state res v2. (#6937)Erik Johnston2020-02-181-0/+23
| | | | | | | | | We do this by moving the recursive query to be fully in the DB.
* | | Stop sending events when creating or deleting aliases (#6904)Patrick Cloke2020-02-182-40/+41
| | | | | | | | | Stop sending events when creating or deleting associations (room aliases). Send an updated canonical alias event if one of the alt_aliases is deleted.
* | | Merge branch 'master' into developRichard van der Hoff2020-02-171-1/+1
|\ \ \
| * | | 1.10.1 v1.10.1 github/release-v1.10.1 release-v1.10.1Richard van der Hoff2020-02-171-1/+1
| | | |
| * | | wait for current_state_events_membership before ↵Richard van der Hoff2020-02-171-2/+5
| | | | | | | | | | | | | | | | delete_old_current_state_events (#6924)
* | | | Raise the default power levels for invites, tombstones and server acls (#6834)Andrew Morgan2020-02-171-1/+9
| | | |
* | | | wait for current_state_events_membership before ↵Richard van der Hoff2020-02-171-2/+5
| | | | | | | | | | | | | | | | delete_old_current_state_events (#6924)
* | | | Add type hints to the spam check module (#6915)Patrick Cloke2020-02-142-22/+34
| | | | | | | | | | | | | | | | Add typing information to the spam checker modules.
* | | | Add a warning about indentation to generated config (#6920)Richard van der Hoff2020-02-141-2/+14
| |_|/ |/| | | | | Fixes #6916.
* | | Filter the results of user directory searching via the spam checker (#6888)Patrick Cloke2020-02-142-2/+39
| | | | | | | | | Add a method to the spam checker to filter the user directory results.
* | | Remove m.lazy_load_members from unstable features since it is in CS r0.5.0 ↵Aaron Raimist2020-02-131-1/+0
| |/ |/| | | | | | | | | | | (#6877) Fixes #5528
* | Return a 404 for admin api user lookup if user not found (#6901)Andrew Morgan2020-02-121-1/+4
| |
* | Merge branch 'master' into developBrendan Abolivier2020-02-121-1/+1
|\|
| * 1.10.0Brendan Abolivier2020-02-121-1/+1
| |
* | Merge branch 'release-v1.10.0' into developRichard van der Hoff2020-02-111-1/+1
|\|
| * 1.10.0rc5 v1.10.0rc5Richard van der Hoff2020-02-111-1/+1
| |
* | Merge branch 'release-v1.10.0' into developRichard van der Hoff2020-02-112-1/+2
|\|
| * 1.10.0rc4Richard van der Hoff2020-02-111-1/+1
| |
| * filter out m.room.aliases from /sync state blocks (#6884)Matthew Hodgson2020-02-101-0/+1
| | | | | | We forgot to filter out aliases from /sync state blocks as well as the timeline.
* | Reject device display names that are too long (#6882)Patrick Cloke2020-02-101-1/+13
| | | | | | | | | | | | | | | | * Reject device display names that are too long. Too long is currently defined as 100 characters in length. * Add a regression test for rejecting a too long device display name.
* | Merge tag 'v1.10.0rc3' into developRichard van der Hoff2020-02-102-1/+8
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.10.0rc3 (2020-02-10) ============================== Features -------- - Filter out m.room.aliases from the CS API to mitigate abuse while a better solution is specced. ([\#6878](https://github.com/matrix-org/synapse/issues/6878)) Internal Changes ---------------- - Fix continuous integration failures with old versions of `pip`, which were introduced by a release of the `zipp` library. ([\#6880](https://github.com/matrix-org/synapse/issues/6880))
| * 1.10.0rc3 v1.10.0rc3Richard van der Hoff2020-02-101-1/+1
| |
| * filter out m.room.aliases from the CS API until a better solution is specced ↵Matthew Hodgson2020-02-101-0/+7
| | | | | | | | | | (#6878) We're in the middle of properly mitigating spam caused by malicious aliases being added to a room. However, until this work fully lands, we temporarily filter out all m.room.aliases events from /sync and /messages on the CS API, to remove abusive aliases. This is considered acceptable as m.room.aliases events were never a reliable record of the given alias->id mapping and were purely informational, and in their current state do more harm than good.
* | Add support for putting fed user query API on workers (#6873)Erik Johnston2020-02-073-21/+23
| |
* | Remove unused `get_room_stats_state` method. (#6869)Richard van der Hoff2020-02-071-25/+0
| |
* | Add a `make_event_from_dict` method (#6858)Richard van der Hoff2020-02-073-12/+19
| | | | | | | | | | | | | | ... and use it in places where it's trivial to do so. This will make it easier to pass room versions into the FrozenEvent constructors.
* | Add typing to synapse.federation.sender (#6871)Erik Johnston2020-02-076-105/+130
| |
* | Allow moving group read APIs to workers (#6866)Erik Johnston2020-02-077-687/+713
| |
* | Admin api to add an email address (#6789)Dirk Klimpel2020-02-073-0/+49
| |
* | remove unused room_version_to_event_format (#6857)Richard van der Hoff2020-02-071-23/+1
| |
* | Merge pull request #6856 from matrix-org/rav/redact_changes/6Richard van der Hoff2020-02-073-58/+46
|\ \ | | | | | | Pass room_version into `event_from_pdu_json`
| * | Pass room_version into `event_from_pdu_json`Richard van der Hoff2020-02-063-58/+46
| | | | | | | | | | | | It's called from all over the shop, so this one's a bit messy.
* | | Limit the number of events that can be requested when backfilling events (#6864)Patrick Cloke2020-02-061-0/+4
|/ / | | | | Limit the maximum number of events requested when backfilling events.
* | pass room version into FederationClient.send_join (#6854)Richard van der Hoff2020-02-062-30/+33
| | | | | | | | ... which allows us to sanity-check the create event.
* | Allow empty federation_certificate_verification_whitelist (#6849)timfi2020-02-061-0/+2
| |
* | Third party event rules Update (#6781)PeerD2020-02-062-4/+9
| |
* | Reduce amount of logging at INFO level. (#6862)Erik Johnston2020-02-0611-21/+21
| | | | | | | | | | | | | | | | A lot of the things we log at INFO are now a bit superfluous, so lets make them DEBUG logs to reduce the amount we log by default. Co-Authored-By: Brendan Abolivier <babolivier@matrix.org> Co-authored-by: Brendan Abolivier <github@brendanabolivier.com>
* | Merge pull request #6823 from matrix-org/rav/redact_changes/5Richard van der Hoff2020-02-062-19/+13
|\ \ | | | | | | pass room versions around
| * | Simplify `room_version` handling in `FederationClient.send_invite`Richard van der Hoff2020-02-051-10/+6
| | |
| * | Pass room version object into `FederationClient.get_pdu`Richard van der Hoff2020-02-052-9/+7
| | |
* | | Merge tag 'v1.10.0rc2' into developErik Johnston2020-02-067-22/+73
|\ \ \ | |/ / |/| / | |/ | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.10.0rc2 (2020-02-06) ============================== Bugfixes -------- - Fix an issue with cross-signing where device signatures were not sent to remote servers. ([\#6844](https://github.com/matrix-org/synapse/issues/6844)) - Fix to the unknown remote device detection which was introduced in 1.10.rc1. ([\#6848](https://github.com/matrix-org/synapse/issues/6848)) Internal Changes ---------------- - Detect unexpected sender keys on remote encrypted events and resync device lists. ([\#6850](https://github.com/matrix-org/synapse/issues/6850))
| * 1.10.0rc2Erik Johnston2020-02-061-1/+1
| |
| * Check sender_key matches on inbound encrypted events. (#6850)Erik Johnston2020-02-052-14/+66
| | | | | | If they don't then the device lists are probably out of sync.
| * Merge pull request #6844 from matrix-org/uhoreg/cross_signing_fix_device_fedHubert Chathi2020-02-051-0/+10
| | | | | | add device signatures to device key query results
| * Fix detecting unknown devices from remote encrypted events. (#6848)Erik Johnston2020-02-045-7/+6
| | | | | | | | | | | | | | | | We were looking at the wrong event type (`m.room.encryption` vs `m.room.encrypted`). Also fixup the duplicate `EvenTypes` entries. Introduced in #6776.
* | Merge pull request #6840 from matrix-org/rav/federation_client_asyncRichard van der Hoff2020-02-051-136/+142
|\ \ | | | | | | Port much of `synapse.federation.federation_client` to async/await
| * | make FederationClient._do_send_invite asyncRichard van der Hoff2020-02-051-10/+7
| | |
| * | Apply suggestions from code reviewRichard van der Hoff2020-02-051-2/+4
| | | | | | | | | Co-Authored-By: Erik Johnston <erik@matrix.org>
| * | Merge remote-tracking branch 'origin/develop' into rav/federation_client_asyncRichard van der Hoff2020-02-043-348/+379
| |\ \
| * | | make FederationClient.send_invite asyncRichard van der Hoff2020-02-031-6/+5
| | | |
| * | | make FederationClient.get_missing_events asyncRichard van der Hoff2020-02-031-20/+20
| | | |
| * | | make FederationClient._do_send_leave asyncRichard van der Hoff2020-02-031-4/+3
| | | |
| * | | make FederationClient.send_leave.send_request asyncRichard van der Hoff2020-02-031-5/+2
| | | |
| * | | make FederationClient._do_send_join asyncRichard van der Hoff2020-02-031-4/+3
| | | |
| * | | make FederationClient.send_join.send_request asyncRichard van der Hoff2020-02-031-4/+3
| | | |
| * | | make FederationClient.make_membership_event.send_request asyncRichard van der Hoff2020-02-031-4/+3
| | | |
| * | | make FederationClient._try_destination_list asyncRichard van der Hoff2020-02-031-10/+26
| | | |
| * | | make FederationClient.send_leave asyncRichard van der Hoff2020-02-031-10/+9
| | | |
| * | | make FederationClient.send_join asyncRichard van der Hoff2020-02-031-11/+13
| | | |
| * | | make FederationClient.make_membership_event asyncRichard van der Hoff2020-02-031-10/+11
| | | |
| * | | make FederationClient.get_event_auth asyncRichard van der Hoff2020-02-031-6/+4
| | | |
| * | | make FederationClient.get_room_state_ids asyncRichard van der Hoff2020-02-031-4/+5
| | | |
| * | | make FederationClient.get_pdu asyncRichard van der Hoff2020-02-031-15/+17
| | | |
| * | | make FederationClient.backfill asyncRichard van der Hoff2020-02-031-15/+11
| | | |
* | | | Reduce performance logging to DEBUG (#6833)Michael Kaye2020-02-051-1/+1
| | | | | | | | | | | | | | | | | | | | * Reduce tnx performance logging to DEBUG * Changelog.d
* | | | Database updates to populate rooms.room_version (#6847)Richard van der Hoff2020-02-042-0/+57
| | | | | | | | | | | | We're going to need this so that we can figure out how to handle redactions when fetching events from the database.
* | | | Merge pull request #6844 from matrix-org/uhoreg/cross_signing_fix_device_fedHubert Chathi2020-02-041-0/+10
|\ \ \ \ | |_|/ / |/| | | add device signatures to device key query results
| * | | add device signatures to device key query resultsHubert Chathi2020-02-041-0/+10
| | | |
* | | | Merge pull request #6837 from matrix-org/rav/federation_asyncRichard van der Hoff2020-02-043-235/+211
|\ \ \ \ | |/ / / |/| / / | |/ / Port much of `synapse.handlers.federation` to async/await.
| * | make FederationHandler.send_invite asyncRichard van der Hoff2020-02-032-6/+4
| | |
| * | make FederationHandler.on_get_missing_events asyncRichard van der Hoff2020-02-031-5/+4
| | |
| * | make FederationHandler.user_joined_room asyncRichard van der Hoff2020-02-031-3/+3
| | |
| * | make FederationHandler._clean_room_for_join asyncRichard van der Hoff2020-02-031-4/+4
| | |
| * | make FederationHandler._notify_persisted_event asyncRichard van der Hoff2020-02-031-4/+6
| | |
| * | make FederationHandler.persist_events_and_notify asyncRichard van der Hoff2020-02-031-10/+10
| | |
| * | make FederationHandler._make_and_verify_event asyncRichard van der Hoff2020-02-031-5/+10
| | |
| * | make FederationHandler.do_remotely_reject_invite asyncRichard van der Hoff2020-02-032-8/+11
| | |
| * | make FederationHandler._check_for_soft_fail asyncRichard van der Hoff2020-02-031-13/+9
| | |
| * | make FederationHandler._persist_auth_tree asyncRichard van der Hoff2020-02-031-11/+7
| | |
| * | make FederationHandler.do_invite_join asyncRichard van der Hoff2020-02-032-18/+18
| | |
| * | make FederationHandler.on_event_auth asyncRichard van der Hoff2020-02-031-5/+4
| | |
| * | make FederationHandler.on_exchange_third_party_invite_request asyncRichard van der Hoff2020-02-031-14/+12
| | |
| * | make FederationHandler.construct_auth_difference asyncRichard van der Hoff2020-02-031-3/+4
| | |
| * | make FederationHandler._update_context_for_auth_events asyncRichard van der Hoff2020-02-031-10/+10
| | |
| * | make FederationHandler._update_auth_events_and_context_for_auth asyncRichard van der Hoff2020-02-031-20/+21
| | |
| * | make FederationHandler.do_auth asyncRichard van der Hoff2020-02-031-10/+14
| | |
| * | make FederationHandler._prep_event asyncRichard van der Hoff2020-02-031-23/+10
| | |
| * | make FederationHandler._handle_new_event asyncRichard van der Hoff2020-02-031-6/+7
| | |
| * | make FederationHandler._handle_new_events asyncRichard van der Hoff2020-02-031-8/+6
| | |
| * | make FederationHandler.on_make_leave_request asyncRichard van der Hoff2020-02-031-13/+10
| | |
| * | make FederationHandler.on_send_leave_request asyncRichard van der Hoff2020-02-031-5/+3
| | |
| * | make FederationHandler.on_make_join_request asyncRichard van der Hoff2020-02-031-13/+10
| | |
| * | make FederationHandler.on_invite_request asyncRichard van der Hoff2020-02-031-5/+4
| | |
| * | make FederationHandler.on_send_join_request asyncRichard van der Hoff2020-02-031-9/+7
| | |
| * | make FederationHandler.on_query_auth asyncRichard van der Hoff2020-02-031-7/+6
| | |
* | | Add typing to SyncHandler (#6821)Erik Johnston2020-02-032-348/+375
| | | | | | | | | | | | Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | | Fix stacktraces when using ObservableDeferred and async/await (#6836)Erik Johnston2020-02-031-0/+4
|/ /
* | Allow URL-encoded user IDs on user admin api paths (#6825)Andrew Morgan2020-02-031-2/+2
| |
* | Fix `room_version` in `on_invite_request` flow (#6827)Richard van der Hoff2020-02-032-7/+10
|/ | | | I messed this up a bit in #6805, but fortunately we weren't actually doing anything with the room_version so it didn't matter that it was a str not a RoomVersion.
* 1.10.0rc1Erik Johnston2020-01-311-1/+1
|
* Fix deleting of stale marker for device lists (#6819)Erik Johnston2020-01-311-7/+7
| | | | We were in fact only deleting stale marker when we got an incremental update, rather than when we did a full resync.
* pass room_version into compute_event_signature (#6807)Richard van der Hoff2020-01-312-9/+24
|
* Merge pull request #6806 from matrix-org/rav/redact_changes/3Richard van der Hoff2020-01-313-37/+39
|\ | | | | Pass room_version into add_hashes_and_signatures
| * Pass room_version into add_hashes_and_signaturesRichard van der Hoff2020-01-302-8/+14
| |
| * Pass room_version into create_local_event_from_event_dictRichard van der Hoff2020-01-302-25/+19
| |
| * Store the room version in EventBuilderRichard van der Hoff2020-01-301-5/+7
| |
* | Merge pull request #6820 from matrix-org/rav/get_room_version_idRichard van der Hoff2020-01-3110-35/+58
|\ \ | | | | | | Make `get_room_version` return a RoomVersion object
| * | Add `get_room_version` methodRichard van der Hoff2020-01-312-5/+26
| | | | | | | | | | | | So that we can start factoring out some of this boilerplatey boilerplate.
| * | s/get_room_version/get_room_version_id/Richard van der Hoff2020-01-319-30/+32
| | | | | | | | | | | | | | | ... to make way for a forthcoming get_room_version which returns a RoomVersion object.
* | | Fix bug with getting missing auth event during join 500'ed (#6810)Erik Johnston2020-01-311-1/+5
|/ /
* | pass room version into FederationHandler.on_invite_request (#6805)Richard van der Hoff2020-01-302-4/+4
| |
* | Log when we delete room in bg update (#6816)Erik Johnston2020-01-301-0/+2
|/
* MSC2260: Block direct sends of m.room.aliases events (#6794)Richard van der Hoff2020-01-301-0/+12
| | | | | as per MSC2260
* Backgroud update to clean out rooms from current state (#6802)Erik Johnston2020-01-302-2/+125
|
* Resync remote device list when detected as stale. (#6786)Erik Johnston2020-01-302-4/+24
|
* Fix sending server up commands from workers (#6811)Erik Johnston2020-01-304-13/+34
| | | | Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* When server leaves room check for stale device lists. (#6801)Erik Johnston2020-01-302-6/+82
| | | | | | | | | When a server leaves a room it may stop sharing a room with remote users, and thus not get any updates to their device lists. So we need to check for this case and delete those device lists from the cache. We don't need to do this if we stop sharing a room because the remote user leaves the room, because we track that case via looking at membership changes.
* When a client asks for remote keys check if should resync. (#6797)Erik Johnston2020-01-301-3/+29
| | | | | | If we detect that the remote users' keys may have changed then we should attempt to resync against the remote server rather than using the (potentially) stale local cache.
* Type defintions for use in refactoring for redaction changes (#6803)Richard van der Hoff2020-01-303-4/+12
| | | | | | | | | | * Bump signedjson to 1.1 ... so that we can use the type definitions * Fix breakage caused by upgrade to signedjson 1.1 Thanks, @illicitonion...
* Remove unused DeviceRow class (#6800)Erik Johnston2020-01-291-20/+1
|
* Make /directory/room/<alias> handle restrictive power levelsRichard van der Hoff2020-01-291-1/+6
| | | | | Fixes a bug where the alias would be added, but `PUT /directory/room/<alias>` would return a 403.
* Set the PL for aliases events to 0.Richard van der Hoff2020-01-292-3/+16
|
* Factor out a `copy_power_levels_contents` methodRichard van der Hoff2020-01-292-13/+47
| | | | I'm going to need another copy (hah!) of this.
* Fix race in federation sender that delayed device updates. (#6799)Erik Johnston2020-01-292-30/+22
| | | | | | | | | | | | We were sending device updates down both the federation stream and device streams. This mean there was a race if the federation sender worker processed the federation stream first, as when the sender checked if there were new device updates the slaved ID generator hadn't been updated with the new stream IDs and so returned nothing. This situation is correctly handled by events/receipts/etc by not sending updates down the federation stream and instead having the federation sender worker listen on the other streams and poke the transaction queues as appropriate.
* Delete current state when server leaves a room (#6792)Erik Johnston2020-01-292-75/+197
| | | | | | Otherwise its just stale data, which may get deleted later anyway so can't be relied on. It's also a bit of a shotgun if we're trying to get the current state of a room we're not in.
* Fix bug when querying remote user keys that require a resync. (#6796)Erik Johnston2020-01-291-1/+2
| | | | We ended up only returning a single device, rather than all of them.
* Fix outbound federation request metrics (#6795)Erik Johnston2020-01-281-0/+4
|
* Merge pull request #6787 from matrix-org/rav/msc2260Richard van der Hoff2020-01-282-5/+35
|\ | | | | Implement updated auth rules from MSC2260
| * fix bad variable refRichard van der Hoff2020-01-281-1/+1
| |
| * Implement updated auth rules from MSC2260Richard van der Hoff2020-01-282-5/+35
| |
* | Detect unknown remote devices and mark cache as stale (#6776)Erik Johnston2020-01-285-8/+125
|/ | | | We just mark the fact that the cache may be stale in the database for now.
* Pass room version object into event_auth.check and check_redaction (#6788)Richard van der Hoff2020-01-286-27/+48
| | | | | | | These are easier to work with than the strings and we normally have one around. This fixes `FederationHander._persist_auth_tree` which was passing a RoomVersion object into event_auth.check instead of a string.
* Warn if postgres database has non-C locale. (#6734)Erik Johnston2020-01-283-0/+52
| | | As using non-C locale can cause issues on upgrading OS.
* Merge branch 'master' into developErik Johnston2020-01-282-2/+8
|\
| * 1.9.1 v1.9.1 github/release-v1.9.1 release-v1.9.1Erik Johnston2020-01-281-1/+1
| |
| * Fix setting `mau_limit_reserved_threepids` config (#6793)Erik Johnston2020-01-281-1/+7
| | | | | | | | | | Calling the invalidation function during initialisation of the data stores introduces a circular dependency, causing Synapse to fail to start.
* | Add `rooms.room_version` column (#6729)Erik Johnston2020-01-277-71/+251
| | | | | | This is so that we don't have to rely on pulling it out from `current_state_events` table.