summary refs log tree commit diff
path: root/synapse (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Pass room_version into `event_from_pdu_json`Richard van der Hoff2020-02-063-58/+46
| | | | It's called from all over the shop, so this one's a bit messy.
* pass room version into FederationClient.send_join (#6854)Richard van der Hoff2020-02-062-30/+33
| | | | ... which allows us to sanity-check the create event.
* Allow empty federation_certificate_verification_whitelist (#6849)timfi2020-02-061-0/+2
|
* Third party event rules Update (#6781)PeerD2020-02-062-4/+9
|
* Reduce amount of logging at INFO level. (#6862)Erik Johnston2020-02-0611-21/+21
| | | | | | | | A lot of the things we log at INFO are now a bit superfluous, so lets make them DEBUG logs to reduce the amount we log by default. Co-Authored-By: Brendan Abolivier <babolivier@matrix.org> Co-authored-by: Brendan Abolivier <github@brendanabolivier.com>
* Merge pull request #6823 from matrix-org/rav/redact_changes/5Richard van der Hoff2020-02-062-19/+13
|\ | | | | pass room versions around
| * Simplify `room_version` handling in `FederationClient.send_invite`Richard van der Hoff2020-02-051-10/+6
| |
| * Pass room version object into `FederationClient.get_pdu`Richard van der Hoff2020-02-052-9/+7
| |
* | Merge tag 'v1.10.0rc2' into developErik Johnston2020-02-067-22/+73
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.10.0rc2 (2020-02-06) ============================== Bugfixes -------- - Fix an issue with cross-signing where device signatures were not sent to remote servers. ([\#6844](https://github.com/matrix-org/synapse/issues/6844)) - Fix to the unknown remote device detection which was introduced in 1.10.rc1. ([\#6848](https://github.com/matrix-org/synapse/issues/6848)) Internal Changes ---------------- - Detect unexpected sender keys on remote encrypted events and resync device lists. ([\#6850](https://github.com/matrix-org/synapse/issues/6850))
| * 1.10.0rc2Erik Johnston2020-02-061-1/+1
| |
| * Check sender_key matches on inbound encrypted events. (#6850)Erik Johnston2020-02-052-14/+66
| | | | | | If they don't then the device lists are probably out of sync.
| * Merge pull request #6844 from matrix-org/uhoreg/cross_signing_fix_device_fedHubert Chathi2020-02-051-0/+10
| | | | | | add device signatures to device key query results
| * Fix detecting unknown devices from remote encrypted events. (#6848)Erik Johnston2020-02-045-7/+6
| | | | | | | | | | | | | | | | We were looking at the wrong event type (`m.room.encryption` vs `m.room.encrypted`). Also fixup the duplicate `EvenTypes` entries. Introduced in #6776.
* | Merge pull request #6840 from matrix-org/rav/federation_client_asyncRichard van der Hoff2020-02-051-136/+142
|\ \ | | | | | | Port much of `synapse.federation.federation_client` to async/await
| * | make FederationClient._do_send_invite asyncRichard van der Hoff2020-02-051-10/+7
| | |
| * | Apply suggestions from code reviewRichard van der Hoff2020-02-051-2/+4
| | | | | | | | | Co-Authored-By: Erik Johnston <erik@matrix.org>
| * | Merge remote-tracking branch 'origin/develop' into rav/federation_client_asyncRichard van der Hoff2020-02-043-348/+379
| |\ \
| * | | make FederationClient.send_invite asyncRichard van der Hoff2020-02-031-6/+5
| | | |
| * | | make FederationClient.get_missing_events asyncRichard van der Hoff2020-02-031-20/+20
| | | |
| * | | make FederationClient._do_send_leave asyncRichard van der Hoff2020-02-031-4/+3
| | | |
| * | | make FederationClient.send_leave.send_request asyncRichard van der Hoff2020-02-031-5/+2
| | | |
| * | | make FederationClient._do_send_join asyncRichard van der Hoff2020-02-031-4/+3
| | | |
| * | | make FederationClient.send_join.send_request asyncRichard van der Hoff2020-02-031-4/+3
| | | |
| * | | make FederationClient.make_membership_event.send_request asyncRichard van der Hoff2020-02-031-4/+3
| | | |
| * | | make FederationClient._try_destination_list asyncRichard van der Hoff2020-02-031-10/+26
| | | |
| * | | make FederationClient.send_leave asyncRichard van der Hoff2020-02-031-10/+9
| | | |
| * | | make FederationClient.send_join asyncRichard van der Hoff2020-02-031-11/+13
| | | |
| * | | make FederationClient.make_membership_event asyncRichard van der Hoff2020-02-031-10/+11
| | | |
| * | | make FederationClient.get_event_auth asyncRichard van der Hoff2020-02-031-6/+4
| | | |
| * | | make FederationClient.get_room_state_ids asyncRichard van der Hoff2020-02-031-4/+5
| | | |
| * | | make FederationClient.get_pdu asyncRichard van der Hoff2020-02-031-15/+17
| | | |
| * | | make FederationClient.backfill asyncRichard van der Hoff2020-02-031-15/+11
| | | |
* | | | Reduce performance logging to DEBUG (#6833)Michael Kaye2020-02-051-1/+1
| | | | | | | | | | | | | | | | | | | | * Reduce tnx performance logging to DEBUG * Changelog.d
* | | | Database updates to populate rooms.room_version (#6847)Richard van der Hoff2020-02-042-0/+57
| | | | | | | | | | | | We're going to need this so that we can figure out how to handle redactions when fetching events from the database.
* | | | Merge pull request #6844 from matrix-org/uhoreg/cross_signing_fix_device_fedHubert Chathi2020-02-041-0/+10
|\ \ \ \ | |_|/ / |/| | | add device signatures to device key query results
| * | | add device signatures to device key query resultsHubert Chathi2020-02-041-0/+10
| | | |
* | | | Merge pull request #6837 from matrix-org/rav/federation_asyncRichard van der Hoff2020-02-043-235/+211
|\ \ \ \ | |/ / / |/| / / | |/ / Port much of `synapse.handlers.federation` to async/await.
| * | make FederationHandler.send_invite asyncRichard van der Hoff2020-02-032-6/+4
| | |
| * | make FederationHandler.on_get_missing_events asyncRichard van der Hoff2020-02-031-5/+4
| | |
| * | make FederationHandler.user_joined_room asyncRichard van der Hoff2020-02-031-3/+3
| | |
| * | make FederationHandler._clean_room_for_join asyncRichard van der Hoff2020-02-031-4/+4
| | |
| * | make FederationHandler._notify_persisted_event asyncRichard van der Hoff2020-02-031-4/+6
| | |
| * | make FederationHandler.persist_events_and_notify asyncRichard van der Hoff2020-02-031-10/+10
| | |
| * | make FederationHandler._make_and_verify_event asyncRichard van der Hoff2020-02-031-5/+10
| | |
| * | make FederationHandler.do_remotely_reject_invite asyncRichard van der Hoff2020-02-032-8/+11
| | |
| * | make FederationHandler._check_for_soft_fail asyncRichard van der Hoff2020-02-031-13/+9
| | |
| * | make FederationHandler._persist_auth_tree asyncRichard van der Hoff2020-02-031-11/+7
| | |
| * | make FederationHandler.do_invite_join asyncRichard van der Hoff2020-02-032-18/+18
| | |
| * | make FederationHandler.on_event_auth asyncRichard van der Hoff2020-02-031-5/+4
| | |
| * | make FederationHandler.on_exchange_third_party_invite_request asyncRichard van der Hoff2020-02-031-14/+12
| | |
| * | make FederationHandler.construct_auth_difference asyncRichard van der Hoff2020-02-031-3/+4
| | |
| * | make FederationHandler._update_context_for_auth_events asyncRichard van der Hoff2020-02-031-10/+10
| | |
| * | make FederationHandler._update_auth_events_and_context_for_auth asyncRichard van der Hoff2020-02-031-20/+21
| | |
| * | make FederationHandler.do_auth asyncRichard van der Hoff2020-02-031-10/+14
| | |
| * | make FederationHandler._prep_event asyncRichard van der Hoff2020-02-031-23/+10
| | |
| * | make FederationHandler._handle_new_event asyncRichard van der Hoff2020-02-031-6/+7
| | |
| * | make FederationHandler._handle_new_events asyncRichard van der Hoff2020-02-031-8/+6
| | |
| * | make FederationHandler.on_make_leave_request asyncRichard van der Hoff2020-02-031-13/+10
| | |
| * | make FederationHandler.on_send_leave_request asyncRichard van der Hoff2020-02-031-5/+3
| | |
| * | make FederationHandler.on_make_join_request asyncRichard van der Hoff2020-02-031-13/+10
| | |
| * | make FederationHandler.on_invite_request asyncRichard van der Hoff2020-02-031-5/+4
| | |
| * | make FederationHandler.on_send_join_request asyncRichard van der Hoff2020-02-031-9/+7
| | |
| * | make FederationHandler.on_query_auth asyncRichard van der Hoff2020-02-031-7/+6
| | |
* | | Add typing to SyncHandler (#6821)Erik Johnston2020-02-032-348/+375
| | | | | | | | | | | | Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | | Fix stacktraces when using ObservableDeferred and async/await (#6836)Erik Johnston2020-02-031-0/+4
|/ /
* | Allow URL-encoded user IDs on user admin api paths (#6825)Andrew Morgan2020-02-031-2/+2
| |
* | Fix `room_version` in `on_invite_request` flow (#6827)Richard van der Hoff2020-02-032-7/+10
|/ | | | I messed this up a bit in #6805, but fortunately we weren't actually doing anything with the room_version so it didn't matter that it was a str not a RoomVersion.
* 1.10.0rc1Erik Johnston2020-01-311-1/+1
|
* Fix deleting of stale marker for device lists (#6819)Erik Johnston2020-01-311-7/+7
| | | | We were in fact only deleting stale marker when we got an incremental update, rather than when we did a full resync.
* pass room_version into compute_event_signature (#6807)Richard van der Hoff2020-01-312-9/+24
|
* Merge pull request #6806 from matrix-org/rav/redact_changes/3Richard van der Hoff2020-01-313-37/+39
|\ | | | | Pass room_version into add_hashes_and_signatures
| * Pass room_version into add_hashes_and_signaturesRichard van der Hoff2020-01-302-8/+14
| |
| * Pass room_version into create_local_event_from_event_dictRichard van der Hoff2020-01-302-25/+19
| |
| * Store the room version in EventBuilderRichard van der Hoff2020-01-301-5/+7
| |
* | Merge pull request #6820 from matrix-org/rav/get_room_version_idRichard van der Hoff2020-01-3110-35/+58
|\ \ | | | | | | Make `get_room_version` return a RoomVersion object
| * | Add `get_room_version` methodRichard van der Hoff2020-01-312-5/+26
| | | | | | | | | | | | So that we can start factoring out some of this boilerplatey boilerplate.
| * | s/get_room_version/get_room_version_id/Richard van der Hoff2020-01-319-30/+32
| | | | | | | | | | | | | | | ... to make way for a forthcoming get_room_version which returns a RoomVersion object.
* | | Fix bug with getting missing auth event during join 500'ed (#6810)Erik Johnston2020-01-311-1/+5
|/ /
* | pass room version into FederationHandler.on_invite_request (#6805)Richard van der Hoff2020-01-302-4/+4
| |
* | Log when we delete room in bg update (#6816)Erik Johnston2020-01-301-0/+2
|/
* MSC2260: Block direct sends of m.room.aliases events (#6794)Richard van der Hoff2020-01-301-0/+12
| | | | | as per MSC2260
* Backgroud update to clean out rooms from current state (#6802)Erik Johnston2020-01-302-2/+125
|
* Resync remote device list when detected as stale. (#6786)Erik Johnston2020-01-302-4/+24
|
* Fix sending server up commands from workers (#6811)Erik Johnston2020-01-304-13/+34
| | | | Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* When server leaves room check for stale device lists. (#6801)Erik Johnston2020-01-302-6/+82
| | | | | | | | | When a server leaves a room it may stop sharing a room with remote users, and thus not get any updates to their device lists. So we need to check for this case and delete those device lists from the cache. We don't need to do this if we stop sharing a room because the remote user leaves the room, because we track that case via looking at membership changes.
* When a client asks for remote keys check if should resync. (#6797)Erik Johnston2020-01-301-3/+29
| | | | | | If we detect that the remote users' keys may have changed then we should attempt to resync against the remote server rather than using the (potentially) stale local cache.
* Type defintions for use in refactoring for redaction changes (#6803)Richard van der Hoff2020-01-303-4/+12
| | | | | | | | | | * Bump signedjson to 1.1 ... so that we can use the type definitions * Fix breakage caused by upgrade to signedjson 1.1 Thanks, @illicitonion...
* Remove unused DeviceRow class (#6800)Erik Johnston2020-01-291-20/+1
|
* Make /directory/room/<alias> handle restrictive power levelsRichard van der Hoff2020-01-291-1/+6
| | | | | Fixes a bug where the alias would be added, but `PUT /directory/room/<alias>` would return a 403.
* Set the PL for aliases events to 0.Richard van der Hoff2020-01-292-3/+16
|
* Factor out a `copy_power_levels_contents` methodRichard van der Hoff2020-01-292-13/+47
| | | | I'm going to need another copy (hah!) of this.
* Fix race in federation sender that delayed device updates. (#6799)Erik Johnston2020-01-292-30/+22
| | | | | | | | | | | | We were sending device updates down both the federation stream and device streams. This mean there was a race if the federation sender worker processed the federation stream first, as when the sender checked if there were new device updates the slaved ID generator hadn't been updated with the new stream IDs and so returned nothing. This situation is correctly handled by events/receipts/etc by not sending updates down the federation stream and instead having the federation sender worker listen on the other streams and poke the transaction queues as appropriate.
* Delete current state when server leaves a room (#6792)Erik Johnston2020-01-292-75/+197
| | | | | | Otherwise its just stale data, which may get deleted later anyway so can't be relied on. It's also a bit of a shotgun if we're trying to get the current state of a room we're not in.
* Fix bug when querying remote user keys that require a resync. (#6796)Erik Johnston2020-01-291-1/+2
| | | | We ended up only returning a single device, rather than all of them.
* Fix outbound federation request metrics (#6795)Erik Johnston2020-01-281-0/+4
|
* Merge pull request #6787 from matrix-org/rav/msc2260Richard van der Hoff2020-01-282-5/+35
|\ | | | | Implement updated auth rules from MSC2260
| * fix bad variable refRichard van der Hoff2020-01-281-1/+1
| |
| * Implement updated auth rules from MSC2260Richard van der Hoff2020-01-282-5/+35
| |
* | Detect unknown remote devices and mark cache as stale (#6776)Erik Johnston2020-01-285-8/+125
|/ | | | We just mark the fact that the cache may be stale in the database for now.
* Pass room version object into event_auth.check and check_redaction (#6788)Richard van der Hoff2020-01-286-27/+48
| | | | | | | These are easier to work with than the strings and we normally have one around. This fixes `FederationHander._persist_auth_tree` which was passing a RoomVersion object into event_auth.check instead of a string.
* Warn if postgres database has non-C locale. (#6734)Erik Johnston2020-01-283-0/+52
| | | As using non-C locale can cause issues on upgrading OS.
* Merge branch 'master' into developErik Johnston2020-01-282-2/+8
|\
| * 1.9.1 v1.9.1 release-v1.9.1Erik Johnston2020-01-281-1/+1
| |
| * Fix setting `mau_limit_reserved_threepids` config (#6793)Erik Johnston2020-01-281-1/+7
| | | | | | | | | | Calling the invalidation function during initialisation of the data stores introduces a circular dependency, causing Synapse to fail to start.
* | Add `rooms.room_version` column (#6729)Erik Johnston2020-01-277-71/+251
| | | | | | This is so that we don't have to rely on pulling it out from `current_state_events` table.
* | Propagate cache invalidates from workers to other workers. (#6748)Erik Johnston2020-01-273-5/+28
| | | | | | Currently if a worker invalidates a cache it will be streamed to master, which then didn't forward those to other workers.
* | Validate client_secret parameter (#6767)Andrew Morgan2020-01-244-6/+41
| |
* | Make 'event.redacts' never raise. (#6771)Erik Johnston2020-01-233-6/+26
| | | | | | | | | | | | There are quite a few places that we assume that a redaction event has a corresponding `redacts` key, which is not always the case. So lets cheekily make it so that event.redacts just returns None instead.
* | Merge branch 'master' into developBrendan Abolivier2020-01-231-1/+1
|\|
| * 1.9.0Brendan Abolivier2020-01-231-1/+1
| |
* | a bit of debugging for media storage providers (#6757)Richard van der Hoff2020-01-232-0/+7
| | | | | | | | | | | | * a bit of debugging for media storage providers * changelog
* | Minor fixes to user admin api (#6761)Richard van der Hoff2020-01-231-9/+5
| | | | | | | | * don't insist on a password (this is valid if you have an SSO login) * fix reference to undefined `requester`
* | Remove unnecessary abstractions in admin handler (#6751)Andrew Morgan2020-01-223-73/+10
|/
* 1.9.0rc1Brendan Abolivier2020-01-221-1/+1
|
* Admin API to list, filter and sort rooms (#6720)Andrew Morgan2020-01-225-3/+224
|
* Fix typo in _select_thumbnailBrendan Abolivier2020-01-221-1/+1
|
* Fix and add test to deprecated quarantine media admin api (#6756)Andrew Morgan2020-01-221-1/+1
|
* Allow monthly active user limiting support for worker mode, fixes #4639. (#6742)Neil Johnson2020-01-225-82/+99
|
* Allow streaming cache invalidate all to workers. (#6749)Erik Johnston2020-01-224-15/+63
|
* Add a DeltaState to track changes to be made to current state (#6716)Erik Johnston2020-01-202-99/+111
|
* Fixup synapse.rest to pass mypy (#6732)Erik Johnston2020-01-209-33/+45
|
* Fix `/events/:event_id` deprecated API. (#6731)Erik Johnston2020-01-201-1/+1
|
* Fixup synapse.api to pass mypy (#6733)Erik Johnston2020-01-203-4/+9
|
* Fix changing password via user admin API. (#6730)Erik Johnston2020-01-201-2/+2
|
* Fix empty account_validity config blockAndrew Morgan2020-01-201-1/+2
|
* Add more logging around message retention policies support (#6717)Brendan Abolivier2020-01-172-0/+21
| | | So we can debug issues like #6683 more easily
* bump version to v1.9.0.dev2 v1.9.0.dev2Richard van der Hoff2020-01-171-1/+1
|
* Fix syntax error in run_upgrade for schema 57 (#6728)Satsuki Yanagi2020-01-171-3/+4
| | | | | | | Fix #6727 Related #6655 Co-authored-by: Erik Johnston <erikj@jki.re>
* Merge pull request #6714 from matrix-org/babolivier/retention_select_eventBrendan Abolivier2020-01-173-7/+7
|\ | | | | Fix instantiation of message retention purge jobs
| * Fixup diffBrendan Abolivier2020-01-161-6/+7
| |
| * Remove get_room_event_after_stream_ordering entirelyBrendan Abolivier2020-01-162-58/+13
| |
| * LintBrendan Abolivier2020-01-161-6/+12
| |
| * Correctly order when selecting before stream orderingBrendan Abolivier2020-01-151-2/+5
| |
| * Fix typoBrendan Abolivier2020-01-151-1/+1
| |
| * Fix instantiation of message retention purge jobsBrendan Abolivier2020-01-152-13/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When figuring out which topological token to start a purge job at, we need to do the following: 1. Figure out a timestamp before which events will be purged 2. Select the first stream ordering after that timestamp 3. Select info about the first event after that stream ordering 4. Build a topological token from that info In some situations (e.g. quiet rooms with a short max_lifetime), there might not be an event after the stream ordering at step 3, therefore we abort the purge with the error `No event found`. To mitigate that, this patch fetches the first event _before_ the stream ordering, instead of after.
* | bump version to v1.9.0.dev1 v1.9.0.dev1Richard van der Hoff2020-01-171-1/+1
| |
* | Merge pull request #6724 from matrix-org/rav/log_saml_attributesRichard van der Hoff2020-01-179-24/+66
|\ \ | | | | | | Log saml assertions rather than the whole response
| * | Log saml assertions rather than the whole responseRichard van der Hoff2020-01-162-1/+25
| | | | | | | | | | | | | | | | | | ... since the whole response is huge. We even need to break up the assertions, since kibana otherwise truncates them.
| * | move batch_iter to a separate moduleRichard van der Hoff2020-01-168-23/+41
| | |
* | | Delegate remote_user_id mapping to the saml mapping provider (#6723)Richard van der Hoff2020-01-172-6/+22
| | | | | | | | | Turns out that figuring out a remote user id for the SAML user isn't quite as obvious as it seems. Factor it out to the SamlMappingProvider so that it's easy to control.
* | | Wake up transaction queue when remote server comes back online (#6706)Erik Johnston2020-01-179-7/+129
| | | | | | | | | | | | | | | This will be used to retry outbound transactions to a remote server if we think it might have come back up.
* | | Clarify the `account_validity` and `email` sections of the sample ↵Richard van der Hoff2020-01-173-140/+167
|/ / | | | | | | | | | | | | | | | | | | | | configuration. (#6685) Generally try to make this more comprehensible, and make it match the conventions. I've removed the documentation for all the settings which allow you to change the names of the template files, because I can't really see why they are useful.
* | Add StateMap type alias (#6715)Erik Johnston2020-01-1613-93/+114
| |
* | Add org.matrix.e2e_cross_signing to unstable_features in /versions as per ↵Neil Johnson2020-01-161-0/+2
| | | | | | | | MSC1756 (#6712)
* | Port synapse.replication.tcp to async/await (#6666)Erik Johnston2020-01-1613-104/+78
| | | | | | | | | | | | | | | | | | | | * Port synapse.replication.tcp to async/await * Newsfile * Correctly document type of on_<FOO> functions as async * Don't be overenthusiastic with the asyncing....
* | Fix purge_room admin API (#6711)Erik Johnston2020-01-151-1/+1
| |
* | Remove duplicate session check in web fallback servlet (#6702)Andrew Morgan2020-01-151-4/+0
| |
* | Merge branch 'develop' into rav/module_api_extensionsRichard van der Hoff2020-01-1536-240/+682
|\ \
| * | Implement RedirectException (#6687)Richard van der Hoff2020-01-152-5/+35
| | | | | | | | | | | | | | | Allow REST endpoint implemnentations to raise a RedirectException, which will redirect the user's browser to a given location.
| * | Add `local_current_membership` table (#6655)Erik Johnston2020-01-1513-89/+247
| |/ | | | | | | | | | | | | Currently we rely on `current_state_events` to figure out what rooms a user was in and their last membership event in there. However, if the server leaves the room then the table may be cleaned up and that information is lost. So lets add a table that separately holds that information.
| * Process EDUs in parallel with PDUs. (#6697)Erik Johnston2020-01-141-12/+58
| | | | | | | | This means that things like to device messages don't get blocked behind processing PDUs, which can potentially take *ages*.
| * Fixup synapse.replication to pass mypy checks (#6667)Erik Johnston2020-01-1410-86/+103
| |
| * Quarantine media by ID or user ID (#6681)Andrew Morgan2020-01-132-3/+181
| |
| * Kill off RegistrationError (#6691)Richard van der Hoff2020-01-132-15/+3
| | | | | | This is pretty pointless. Let's just use SynapseError.
| * Don't assign numeric IDs for empty usernames (#6690)Richard van der Hoff2020-01-131-1/+1
| | | | | | | | Fix a bug where we would assign a numeric userid if somebody tried registering with an empty username
| * Merge pull request #6689 from matrix-org/rav/saml_mapping_provider_updatesRichard van der Hoff2020-01-131-6/+16
| |\ | | | | | | Updates to the SAML mapping provider API
| | * Pass client redirect URL into SAML mapping providersRichard van der Hoff2020-01-121-4/+11
| | |
| | * Pass the module_api into the SamlMappingProviderRichard van der Hoff2020-01-121-2/+5
| | | | | | | | | | | | | | | ... for consistency with other modules, and because we'll need it sooner or later and it will be a pain to introduce later.
| * | Allow additional_resources to implement Resource directly (#6686)Richard van der Hoff2020-01-131-2/+11
| | | | | | | | | | | | | | | | | | AdditionalResource really doesn't add any value, and it gets in the way for resources which want to support child resources or the like. So, if the resource object already implements the IResource interface, don't bother wrapping it.
| * | Fix exceptions on requests for non-ascii urls (#6682)Richard van der Hoff2020-01-131-1/+1
| | | | | | | | | Fixes #6402
| * | comment for run_in_backgroundRichard van der Hoff2020-01-121-0/+3
| | |
| * | Refuse to start if sqlite is older than 3.11.0Richard van der Hoff2020-01-092-4/+7
| | |
| * | Check postgres version in check_databaseRichard van der Hoff2020-01-091-13/+12
| | | | | | | | | | | | | | | this saves doing it on each connection, and will allow us to pass extra options in.
| * | Modify check_database to take a connection rather than a cursorRichard van der Hoff2020-01-093-10/+11
| |/ | | | | | | We might not need the cursor at all.
* | Handle `config` not being set for synapse plugin modulesRichard van der Hoff2020-01-121-1/+1
| | | | | | | | | | Some modules don't need any config, so having to define a `config` property just to keep the loader happy is a bit annoying.
* | Cleanups and additions to the module APIRichard van der Hoff2020-01-122-6/+59
|/ | | | | | | | | | | Add some useful things, such as error types and logcontext handling, to the API. Make `hs` a private member to dissuade people from using it (hopefully they aren't already). Add a couple of new methods (`record_user_external_id` and `generate_short_term_login_token`).
* Allow admin users to create or modify users without a shared secret (#6495)Manuel Stahl2020-01-094-0/+155
| | | Signed-off-by: Manuel Stahl <manuel.stahl@awesome-technologies.de>
* Merge branch 'master' into developErik Johnston2020-01-091-1/+1
|\
| * 1.8.0Erik Johnston2020-01-091-1/+1
| |
* | Merge pull request #6664 from matrix-org/erikj/media_admin_apisErik Johnston2020-01-082-120/+130
|\ \ | | | | | | Fix media repo admin APIs when using a media worker.
| * | Shuffle the codeErik Johnston2020-01-081-25/+16
| | |
| * | CommentsErik Johnston2020-01-081-0/+3
| | |
| * | Do not rely on streaming events, as media repo doesn'tErik Johnston2020-01-081-12/+26
| | |
| * | Import RoomStore in media worker to fix admin APIsErik Johnston2020-01-081-0/+2
| | |
| * | Move media admin store functions to worker storeErik Johnston2020-01-081-120/+120
| | |
* | | Merge remote-tracking branch 'origin/release-v1.8.0' into developRichard van der Hoff2020-01-082-24/+10
|\ \ \ | | |/ | |/|
| * | Fix GET request on /_synapse/admin/v2/users endpoint (#6563)Manuel Stahl2020-01-081-2/+2
| | | | | | | | | | | | Fixes #6552
| * | Back out ill-advised notary server hackery (#6657)Richard van der Hoff2020-01-081-22/+8
| |/ | | | | | | | | | | | | | | | | | | | | This was ill-advised. We can't modify verify_keys here, because the response object has already been signed by the requested key. Furthermore, it's somewhat unnecessary because existing versions of Synapse (which get upset that the notary key isn't present in verify_keys) will fall back to a direct fetch via `/key/v2/server`. Also: more tests for fetching keys via perspectives: it would be nice if we actually tested when our fetcher can't talk to our notary impl.
* | Correctly proxy remote group HTTP errors. (#6654)Erik Johnston2020-01-071-0/+16
| | | | | | | | | | e.g. if remote returns a 404 then that shouldn't be treated as an error but should be proxied through.
* | Merge pull request #6621 from matrix-org/babolivier/purge_job_config_typoBrendan Abolivier2020-01-071-5/+5
|\ \ | |/ |/| Fix a typo in the purge jobs configuration example
| * RewordBrendan Abolivier2020-01-071-3/+3
| |
| * Change the example from 5min to 12hBrendan Abolivier2020-01-071-4/+4
| | | | | | | | Have a purge job running every 5min is probably not something we want to advise admins to do as a sort-of default.
| * Fix a typo in the purge jobs configuration exampleBrendan Abolivier2020-01-031-1/+1
| |
* | 1.8.0rc1Erik Johnston2020-01-071-1/+1
| |
* | Merge pull request #6652 from matrix-org/babolivier/depth_missing_eventsBrendan Abolivier2020-01-072-3/+3
|\ \ | | | | | | Fix conditions failing if min_depth = 0
| * | Fix conditions failing if min_depth = 0Brendan Abolivier2020-01-072-3/+3
| |/ | | | | | | This could result in Synapse not fetching prev_events for new events in the room if it has missed some events.
* | Add a background update to clear tombstoned rooms from the directory (#6648)Richard van der Hoff2020-01-074-1/+100
| | | | | | | | | | | | * Add a background update to clear tombstoned rooms from the directory * use the ABC metaclass
* | Async/await for background updates (#6647)Richard van der Hoff2020-01-071-16/+20
| | | | | | | | so that bg update routines can be async
* | Merge pull request #6645 from matrix-org/rav/fix_synchrotron_errorRichard van der Hoff2020-01-072-15/+47
|\ \ | | | | | | Fix exceptions in the synchrotron worker log when events are rejected.
| * | Fix exceptions in log when rejected event is replicatedRichard van der Hoff2020-01-061-2/+9
| | |
| * | async/await for SyncReplicationHandler.process_and_notifyRichard van der Hoff2020-01-061-5/+4
| | |
| * | Clarify documentation on get_event* methodsRichard van der Hoff2020-01-061-9/+35
| | | | | | | | | | | | Make it clearer how they behave in the face of rejected and/or missing events.
* | | Merge pull request #6629 from matrix-org/rav/kill_event_reference_hashesRichard van der Hoff2020-01-064-87/+49
|\ \ \ | |/ / |/| | Remove a bunch of unused code from event creation
| * | Remove unused get_latest_event_ids_and_hashes_in_roomRichard van der Hoff2020-01-061-42/+0
| | |
| * | Remove unused get_prev_events_and_hashes_for_roomRichard van der Hoff2020-01-061-30/+0
| | |
| * | Remove unused hashes and depths from _update_membership paramsRichard van der Hoff2020-01-061-13/+4
| | |
| * | Remove unused hashes and depths from create_event paramsRichard van der Hoff2020-01-062-17/+12
| | |
| * | Remove unused hashes and depths from create_new_client_event paramsRichard van der Hoff2020-01-062-12/+26
| | |
| * | replace get_prev_events_and_hashes_for_room with get_prev_events_for_room in ↵Richard van der Hoff2020-01-062-9/+38
| | | | | | | | | | | | create_new_client_event
| * | rename get_prev_events_for_room to get_prev_events_and_hashes_for_roomRichard van der Hoff2020-01-063-5/+10
| | | | | | | | | | | | ... to make way for a new method which just returns the event ids
* | | Fix some test failures when frozen_dicts are enabled (#6642)Richard van der Hoff2020-01-064-11/+19
| | | | | | | | | | | | Fixes #4026
* | | Add experimental 'databases' config (#6580)Erik Johnston2020-01-062-13/+63
| | |
* | | Fix an error which was thrown by the PresenceHandler _on_shutdown handler. ↵Richard van der Hoff2020-01-061-7/+2
| | | | | | | | | | | | (#6640)
* | | Fix exception when fetching notary server's old keys (#6625)Richard van der Hoff2020-01-061-6/+7
| | | | | | | | | | | | | | | | | | Lift the restriction that *all* the keys used for signing v2 key responses be present in verify_keys. Fixes #6596.
* | | Workaround for error when fetching notary's own key (#6620)Richard van der Hoff2020-01-061-8/+22
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | * Kill off redundant SynapseRequestFactory We already get the Site via the Channel, so there's no need for a dedicated RequestFactory: we can just use the right constructor. * Workaround for error when fetching notary's own key As a notary server, when we return our own keys, include all of our signing keys in verify_keys. This is a workaround for #6596.
* | Fix power levels being incorrectly set in old and new rooms after a room ↵Andrew Morgan2020-01-061-7/+10
| | | | | | | | | | | | upgrade (#6633) Modify a copy of an upgraded room's PL before sending to the new room
* | Automate generation of the sample and debian log configs (#6627)Richard van der Hoff2020-01-031-1/+8
| |
* | Raise an error if someone tries to use the log_file config option (#6626)Richard van der Hoff2020-01-032-3/+16
| | | | | | | | This has caused some confusion for people who didn't notice it going away.
* | Remove unused, undocumented "content repo" resource (#6628)Richard van der Hoff2020-01-036-123/+2
| | | | | | | | | | | | This looks like it got half-killed back in #888. Fixes #6567.
* | Kill off redundant SynapseRequestFactory (#6619)Richard van der Hoff2020-01-031-15/+3
| | | | | | | | We already get the Site via the Channel, so there's no need for a dedicated RequestFactory: we can just use the right constructor.
* | Reduce the reconnect time when replication fails. (#6617)Richard van der Hoff2020-01-031-1/+2
|/
* Merge branch 'master' into developRichard van der Hoff2019-12-312-16/+38
|\
| * 1.7.3 v1.7.3 release-v1.7.3Richard van der Hoff2019-12-311-1/+1
| |
| * Hacks to work around #6605 (#6608)Richard van der Hoff2019-12-311-15/+37
| | | | | | | | | | When we have an event which refers to non-existent auth_events, ignore said events rather than exploding in a ball of fire. Fixes #6605.
* | Merge branch 'master' into developRichard van der Hoff2019-12-202-2/+5
|\|
| * 1.7.2 v1.7.2 release-v1.7.2Richard van der Hoff2019-12-201-1/+1
| |
| * Backport fixes to sqlite upgrade from develop (#6578)Richard van der Hoff2019-12-201-1/+9
| | | | | | | | | | Only run prepare_database on connection for in-memory databases. Fixes #6569.
| * Fix exceptions when attempting to backfill (#6576)Richard van der Hoff2019-12-201-1/+4
| | | | | | Fixes #6575
* | Split state groups into a separate data store (#6296)Erik Johnston2019-12-2024-1162/+1152
| |
* | Change EventContext to use the Storage class (#6564)Erik Johnston2019-12-2013-39/+49
| |
* | Explode on duplicate delta file names. (#6565)Erik Johnston2019-12-191-0/+18
| |
* | Port some admin handlers to async/await (#6559)Erik Johnston2019-12-193-56/+45
| |
* | Improve diagnostics on database upgrade failure (#6570)Richard van der Hoff2019-12-192-8/+6
| | | | | | | | `Failed to upgrade database` is not helpful, and it's unlikely that UPGRADE.rst has anything useful.
* | Fix sdnotify with acme enabled (#6571)Richard van der Hoff2019-12-191-3/+7
| | | | | | | | | | | | | | If acme was enabled, the sdnotify startup hook would never be run because we would try to add it to a hook which had already fired. There's no need to delay it: we can sdnotify as soon as we've started the listeners.
* | Add an export_signing_key script (#6546)Richard van der Hoff2019-12-191-8/+15
| | | | | | | | | | I want to do some key rotation, and it is silly that we don't have a way to do this.
* | Clean up startup for the pusher (#6558)Richard van der Hoff2019-12-184-43/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Remove redundant python2 support code `str.decode()` doesn't exist on python3, so presumably this code was doing nothing * Filter out pushers with corrupt data When we get a row with unparsable json, drop the row, rather than returning a row with null `data`, which will then cause an explosion later on. * Improve logging when we can't start a pusher Log the ID to help us understand the problem * Make email pusher setup more robust We know we'll have a `data` member, since that comes from the database. What we *don't* know is if that is a dict, and if that has a `brand` member, and if that member is a string.
* | Add delta file to fix missing default table data (#6555)Andrew Morgan2019-12-183-15/+23
| |
* | Add database config class (#6513)Erik Johnston2019-12-189-73/+160
| | | | | | | | | | This encapsulates config for a given database and is the way to get new connections.
* | Merge branch 'master' into developRichard van der Hoff2019-12-181-1/+1
|\|
| * 1.7.1Richard van der Hoff2019-12-181-1/+1
| |
* | Merge release-v1.7.1 into developRichard van der Hoff2019-12-184-10/+16
|\|
| * Fix bug where we added duplicate event IDs as auth_events (#6560)Erik Johnston2019-12-171-7/+8
| |
| * Add auth events as per spec. (#6556)Erik Johnston2019-12-161-67/+34
| | | | | | | | | | Previously we tried to be clever and filter out some unnecessary event IDs to keep the auth chain small, but that had some annoying interactions with state res v2 so we stop doing that for now.
| * Merge pull request #6553 from matrix-org/babolivier/fix-context-filterBrendan Abolivier2019-12-162-3/+7
| |\ | | | | | | Use the filtered version of an event when responding to /context requests for that event
| | * Incorporate reviewBrendan Abolivier2019-12-161-1/+1
| | |
| | * Update the documentation of the filtering functionBrendan Abolivier2019-12-161-1/+2
| | |
| | * Use the filtered version of an event when responding to /context requests ↵Brendan Abolivier2019-12-161-1/+4
| | | | | | | | | | | | | | | | | | for that event Sometimes the filtering function can return a pruned version of an event (on top of either the event itself or an empty list), if it thinks the user should be able to see that there's an event there but not the content of that event. Therefore, the previous logic of 'if filtered is empty then we can use the event we retrieved from the database' is flawed, and we should use the event returned by the filtering function.
| * | Exclude rejected state events when calculating state at backwards extrems ↵Richard van der Hoff2019-12-161-1/+1
| | | | | | | | | | | | | | | (#6527) This fixes a weird bug where, if you were determined enough, you could end up with a rejected event forming part of the state at a backwards-extremity. Authing that backwards extrem would then lead to us trying to pull the rejected event from the db (with allow_rejected=False), which would fail with a 404.
| * | Persist auth/state events at backwards extremities when we fetch them (#6526)Richard van der Hoff2019-12-162-165/+82
| | | | | | | | | | | | The main point here is to make sure that the state returned by _get_state_in_room has been authed before we try to use it as state in the room.
| * | sanity-checking for events used in state res (#6531)Richard van der Hoff2019-12-164-43/+124
| | | | | | | | | | | | | | | When we perform state resolution, check that all of the events involved are in the right room.
| * | Sanity-check room ids in event auth (#6530)Richard van der Hoff2019-12-161-0/+12
| | | | | | | | | | | | When we do an event auth operation, check that all of the events involved are in the right room.
| * | Check the room_id of events when fetching room state/auth (#6524)Richard van der Hoff2019-12-161-24/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we request the state/auth_events to populate a backwards extremity (on backfill or in the case of missing events in a transaction push), we should check that the returned events are in the right room rather than blindly using them in the room state or auth chain. Given that _get_events_from_store_or_dest takes a room_id, it seems clear that it should be sanity-checking the room_id of the requested events, so let's do it there.
| * | Add `include_event_in_state` to _get_state_for_room (#6521)Richard van der Hoff2019-12-161-18/+21
| | | | | | | | | | | | | | | | | | Make it return the state *after* the requested event, rather than the one before it. This is a bit easier and requires fewer calls to get_events_from_store_or_dest.
| * | Move get_state methods into FederationHandler (#6503)Richard van der Hoff2019-12-162-86/+106
| | | | | | | | | | | | | | | This is a non-functional refactor as a precursor to some other work.
| * | Refactor get_events_from_store_or_dest to return a dict (#6501)Richard van der Hoff2019-12-161-29/+15
| |/ | | | | | | | | There was a bunch of unnecessary conversion back and forth between dict and list going on here. We can simplify a bunch of the code.
* | Remove unused `get_pagination_rows` methods. (#6557)Erik Johnston2019-12-173-18/+0
| | | | | | Remove unused get_pagination_rows methods
* | Add auth events as per spec. (#6556)Erik Johnston2019-12-161-67/+34
| | | | | | | | | | Previously we tried to be clever and filter out some unnecessary event IDs to keep the auth chain small, but that had some annoying interactions with state res v2 so we stop doing that for now.
* | Add option to allow profile queries without sharing a room (#6523)Will Hunt2019-12-162-1/+18
| |
* | Exclude rejected state events when calculating state at backwards extrems ↵Richard van der Hoff2019-12-161-1/+1
| | | | | | | | | | (#6527) This fixes a weird bug where, if you were determined enough, you could end up with a rejected event forming part of the state at a backwards-extremity. Authing that backwards extrem would then lead to us trying to pull the rejected event from the db (with allow_rejected=False), which would fail with a 404.
* | Persist auth/state events at backwards extremities when we fetch them (#6526)Richard van der Hoff2019-12-162-169/+82
| | | | | | The main point here is to make sure that the state returned by _get_state_in_room has been authed before we try to use it as state in the room.