summary refs log tree commit diff
path: root/synapse (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Set Server header in SynapseRequestRichard van der Hoff2018-05-1023-27/+28
| | | | | | | | | | | | (instead of everywhere that writes a response. Or rather, the subset of places which write responses where we haven't forgotten it). This also means that we don't have to have the mysterious version_string attribute in anything with a request handler. Unfortunately it does mean that we have to pass the version string wherever we instantiate a SynapseSite, which has been c&ped 150 times, but that is code that ought to be cleaned up anyway really.
* Remove redundant request_handler decoratorRichard van der Hoff2018-05-107-38/+42
| | | | | | This is needless complexity; we might as well use the wrapper directly. Also rename wrap_request_handler->wrap_json_request_handler.
* Factor wrap_request_handler_with_logging out of wrap_request_handlerRichard van der Hoff2018-05-101-54/+66
| | | | ... so that it can be used on non-JSON endpoints
* Remove include_metrics paramRichard van der Hoff2018-05-101-17/+7
| | | | | The metrics are now available via the request, so this is redundant and can go away at last.
* Move outgoing_responses_counter handling to RequestMetricsRichard van der Hoff2018-05-102-4/+2
| | | | it's much neater there.
* Bump requests_counter in wrapped_request_handlerRichard van der Hoff2018-05-101-4/+11
| | | | less magic
* Move RequestMetrics handling into SynapseRequest.processing()Richard van der Hoff2018-05-102-24/+64
| | | | | It fits quite nicely here, and opens the path to getting rid of the "include_metrics" mess.
* Make RequestMetrics take a raw time rather than a clockRichard van der Hoff2018-05-102-6/+6
| | | | ... which is going to make it easier to move around.
* Move request_id management into SynapseRequestRichard van der Hoff2018-05-102-15/+25
|
* Move RequestsMetrics to its own fileRichard van der Hoff2018-05-092-124/+151
| | | | | | This is useful in its own right, because server.py is full of stuff; but more importantly, I want to do some refactoring that will cause a circular reference as it is.
* Merge pull request #3199 from matrix-org/erikj/pagination_syncErik Johnston2018-05-092-45/+54
|\ | | | | Refactor sync APIs to reuse pagination API
| * Add comment to sync as to why code path is splitErik Johnston2018-05-091-0/+5
| |
| * Refactor sync APIs to reuse pagination APIErik Johnston2018-05-092-44/+48
| | | | | | | | | | | | The sync API often returns events in a topological rather than stream ordering, e.g. when the user joined the room or on initial sync. When this happens we can reuse existing pagination storage functions.
| * Don't unnecessarily require token to be stream tokenErik Johnston2018-05-091-1/+1
| | | | | | | | | | This allows calling the `get_recent_event_ids_for_room` function in more situations.
* | Merge pull request #3198 from matrix-org/erikj/fixup_return_paginationErik Johnston2018-05-093-8/+22
|\ \ | | | | | | Refactor get_recent_events_for_room return type
| * | Fix returned token is no longer a tupleErik Johnston2018-05-091-1/+1
| | |
| * | Fix up commentErik Johnston2018-05-091-1/+1
| | |
| * | Merge branch 'develop' of github.com:matrix-org/synapse into ↵Erik Johnston2018-05-093-8/+10
| |\ \ | | |/ | |/| | | | erikj/fixup_return_pagination
| * | Refactor get_recent_events_for_room return typeErik Johnston2018-05-093-7/+21
| | | | | | | | | | | | | | | | | | There is no reason to return a tuple of tokens when the last token is always the token passed as an argument. Changing it makes it consistent with other storage APIs
* | | Merge branch 'develop' of github.com:matrix-org/synapse into ↵Erik Johnston2018-05-093-8/+10
|\ \ \ | | |/ | |/| | | | erikj/remove_membership_change
| * | Merge pull request #3196 from matrix-org/erikj/pagination_returnErik Johnston2018-05-091-28/+49
| |\ \ | | | | | | | | Refactor pagination DB API to return concrete type
| | * | Update commentsErik Johnston2018-05-091-5/+6
| | |/
| * | Merge pull request #3195 from matrix-org/erikj/pagination_refactorErik Johnston2018-05-091-51/+27
| |\ \ | | | | | | | | Refactor recent events func to use pagination func
| * \ \ Merge pull request #3193 from matrix-org/erikj/pagination_refactorErik Johnston2018-05-091-110/+99
| |\ \ \ | | | | | | | | | | Refactor /context to reuse pagination storage functions
| * \ \ \ Merge pull request #3190 from mujx/notif-token-fixRichard van der Hoff2018-05-081-1/+1
| |\ \ \ \ | | | | | | | | | | | | notifications: Convert next_token to string according to the spec
| | * | | | notifications: Convert next_token to string according to the specKonstantinos Sideris2018-05-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently the parameter is serialized as an integer. Signed-off-by: Konstantinos Sideris <sideris.konstantin@gmail.com>
| * | | | | Note that label values can be anythingErik Johnston2018-05-031-1/+2
| | | | | |
| * | | | | Fix metrics that have integer value labelsErik Johnston2018-05-031-1/+1
| |/ / / /
* | | | / Remove unused code path from member change DB funcErik Johnston2018-05-091-24/+10
| |_|_|/ |/| | | | | | | | | | | | | | | The function is never called without a from_key, so we can remove all the handling for that scenario.
* | | | Refactor pagination DB API to return concrete typeErik Johnston2018-05-091-28/+48
| |_|/ |/| | | | | | | | | | | This makes it easier to document what is being returned by the storage functions and what some functions expect as arguments.
* | | Remove unused from_token paramErik Johnston2018-05-091-7/+4
| | |
* | | Refactor recent events func to use pagination funcErik Johnston2018-05-091-48/+27
| |/ |/| | | | | This also removes a cache that is unlikely to ever get hit.
* | Fix up comments and make function privateErik Johnston2018-05-091-7/+7
| |
* | Reuse existing pagination code for context APIErik Johnston2018-05-081-75/+15
| |
* | Parse tokens before calling DB functionErik Johnston2018-05-081-14/+18
| |
* | Only fetch required fields from databaseErik Johnston2018-05-081-1/+2
| |
* | Split paginate_room_events storage functionErik Johnston2018-05-081-28/+72
|/
* Merge remote-tracking branch 'origin/develop' into rav/warn_on_logcontext_failRichard van der Hoff2018-05-03137-1294/+2609
|\
| * Merge pull request #3183 from matrix-org/rav/moar_logcontext_leaksRichard van der Hoff2018-05-031-3/+14
| |\ | | | | | | Fix logcontext leaks in rate limiter
| | * Fix logcontext leaks in rate limiterRichard van der Hoff2018-05-031-3/+14
| | |
| * | Merge pull request #3182 from Half-Shot/hs/fix-twisted-shutdownRichard van der Hoff2018-05-031-3/+8
| |\ \ | | | | | | | | Fix 'Unhandled Error' logs with Twisted 18.4
| | * | Don't abortConnection() if the transport connection has already closed.Will Hunt2018-05-031-3/+8
| | | |
| * | | Merge pull request #3178 from matrix-org/rav/fix_request_timeoutsRichard van der Hoff2018-05-031-1/+1
| |\ \ \ | | |_|/ | |/| | fix http request timeout code
| | * | add missing param to cancelled_to_request_timed_out_errorRichard van der Hoff2018-05-021-1/+1
| | | | | | | | | | | | | | | | This gets two arguments, not one.
| * | | Merge pull request #3141 from matrix-org/erikj/fixup_stateErik Johnston2018-05-031-37/+67
| |\ \ \ | | | | | | | | | | Refactor event storage to prepare for changes in state calculations
| | * | | Fix up grammarErik Johnston2018-05-031-3/+3
| | | | |
| | * | | Refactor event storage to not require stateErik Johnston2018-04-271-37/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is in preparation for using contexts that may or may not have the current_state_ids set. This will allow us to avoid unnecessarily pulling out state for an event on the master process when using workers. We also add a check to see if the state groups of the old extremities are the same as the new ones.
| * | | | Merge pull request #3161 from NotAFile/remove-v1authRichard van der Hoff2018-05-033-12/+6
| |\ \ \ \ | | | | | | | | | | | | Make Client-Server API return 403 for invalid token
| | * | | | Burminate v1authAdrian Tschira2018-04-303-12/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This closes #2602 v1auth was created to account for the differences in status code between the v1 and v2_alpha revisions of the protocol (401 vs 403 for invalid tokens). However since those protocols were merged, this makes the r0 version/endpoint internally inconsistent, and violates the specification for the r0 endpoint. This might break clients that rely on this inconsistency with the specification. This is said to affect the legacy angular reference client. However, I feel that restoring parity with the spec is more important. Either way, it is critical to inform developers about this change, in case they rely on the illegal behaviour. Signed-off-by: Adrian Tschira <nota@notafile.com>
| * | | | | Merge pull request #3175 from matrix-org/erikj/escape_metric_valuesErik Johnston2018-05-031-2/+28
| |\ \ \ \ \ | | |_|_|/ / | |/| | | | Escape label values in prometheus metrics
| | * | | | Make _escape_character take MatchObjectErik Johnston2018-05-021-2/+10
| | | | | |
| | * | | | Escape label values in prometheus metricsErik Johnston2018-05-021-2/+20
| | | | | |
| * | | | | Merge pull request #3170 from matrix-org/rav/more_logcontext_leaksRichard van der Hoff2018-05-021-22/+38
| |\ \ \ \ \ | | | | | | | | | | | | | | Fix a class of logcontext leaks
| | * | | | | Merge branch 'develop' into rav/more_logcontext_leaksRichard van der Hoff2018-05-022-2/+2
| | |\| | | |
| | * | | | | Fix a class of logcontext leaksRichard van der Hoff2018-05-021-22/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | So, it turns out that if you have a first `Deferred` `D1`, you can add a callback which returns another `Deferred` `D2`, and `D2` must then complete before any further callbacks on `D1` will execute (and later callbacks on `D1` get the *result* of `D2` rather than `D2` itself). So, `D1` might have `called=True` (as in, it has started running its callbacks), but any new callbacks added to `D1` won't get run until `D2` completes - so if you `yield D1` in an `inlineCallbacks` function, your `yield` will 'block'. In conclusion: some of our assumptions in `logcontext` were invalid. We need to make sure that we don't optimise out the logcontext juggling when this situation happens. Fortunately, it is easy to detect by checking `D1.paused`.
| * | | | | | Fix logcontext leak in media repoRichard van der Hoff2018-05-022-1/+4
| | |/ / / / | |/| | | | | | | | | | | | | | | | Make FileResponder.write_to_consumer uphold the logcontext contract
| * | | | | Merge pull request #3168 from matrix-org/rav/fix_logformatterRichard van der Hoff2018-05-021-1/+1
| |\ \ \ \ \ | | | | | | | | | | | | | | Fix incorrect reference to StringIO
| | * | | | | Fix incorrect reference to StringIORichard van der Hoff2018-05-021-1/+1
| | |/ / / / | | | | | | | | | | | | | | | | | | This was introduced in 4f2f5171
| * | | | | Merge branch 'master' into developNeil Johnson2018-05-011-1/+1
| |\ \ \ \ \ | | |/ / / / | |/| | | |
| | * | | | Update __init__.pyNeil Johnson2018-05-011-1/+1
| | | | | | | | | | | | | | | | | | bump version
| * | | | | Merge branch 'release-v0.28.1' into developRichard van der Hoff2018-05-013-4/+26
| |\| | | | | | |/ / / | |/| | |
| | * | | Merge commit '33f469b' into release-v0.28.1Richard van der Hoff2018-05-013-4/+26
| | |\ \ \
| | | * | | Apply some limits to depth to counter abuseRichard van der Hoff2018-05-013-4/+26
| | | |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * When creating a new event, cap its depth to 2^63 - 1 * When receiving events, reject any without a sensible depth As per https://docs.google.com/document/d/1I3fi2S-XnpO45qrpCsowZv8P8dHcNZ4fsBsbOW7KABI
| | * / / Miscellaneous fixes to python_dependenciesRichard van der Hoff2018-05-011-1/+19
| | |/ / | | | | | | | | | | | | | | | | | | | | * add some doc about wtf this thing does * pin Twisted to < 18.4 * add explicit dep on six (fixes #3089)
| * | | Fixes #3135 - Replace _OpenSSLECCurve with crypto.get_elliptic_curve (#3157)Will Hunt2018-04-302-8/+8
| | | | | | | | | | | | | | | | | | | | fixes #3135 Signed-off-by: Will Hunt will@half-shot.uk
| * | | add guard for None on purge_history apiKrombel2018-04-301-1/+14
| | | |
| * | | Merge pull request #3129 from matrix-org/matthew/fix_group_dupsMatthew Hodgson2018-04-301-0/+57
| |\ \ \ | | | | | | | | | | remove duplicates from groups tables
| | * | | fix missing importMatthew Hodgson2018-04-281-0/+1
| | | | |
| | * | | pep8Matthew Hodgson2018-04-281-3/+5
| | | | |
| | * | | make it work with sqliteMatthew Hodgson2018-04-282-34/+54
| | | | |
| | * | | remove duplicates from groups tablesMatthew Hodgson2018-04-251-0/+34
| | | | | | | | | | | | | | | | | | | | | | | | | and rename inconsistently named indexes. Based on https://github.com/matrix-org/synapse/pull/3128 - thanks @vurpo\!
| * | | | Merge pull request #3143 from matrix-org/rav/remove_redundant_preserve_fnRichard van der Hoff2018-04-301-4/+2
| |\ \ \ \ | | | | | | | | | | | | Remove redundant call to preserve_fn
| | * | | | Remove redundant call to preserve_fnRichard van der Hoff2018-04-301-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | submit_event_for_as doesn't return a deferred anyway, so this is pointless.
| * | | | | Merge pull request #3144 from ↵Richard van der Hoff2018-04-301-1/+7
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | matrix-org/rav/run_in_background_exception_handling Trap exceptions thrown within run_in_background
| | * | | | | Trap exceptions thrown within run_in_backgroundRichard van der Hoff2018-04-271-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Turn any exceptions that get thrown synchronously within run_in_background into Failures instead.
| * | | | | | Merge pull request #3102 from NotAFile/py3-attributeerrorRichard van der Hoff2018-04-301-3/+15
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | Make event properties raise AttributeError instead
| | * | | | | | add comment explaining attributeerrorAdrian Tschira2018-04-301-0/+3
| | | | | | | |
| | * | | | | | Make event properties raise AttributeError insteadAdrian Tschira2018-04-151-3/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | They raised KeyError before. I'm changing this because the code uses hasattr() to check for the presence of a key. This worked accidentally before, because hasattr() silences all exceptions in python 2. However, in python3, this isn't the case anymore. I had a look around to see if anything depended on this raising a KeyError and I couldn't find anything. Of course, I could have simply missed it. Signed-off-by: Adrian Tschira <nota@notafile.com>
| * | | | | | | Merge pull request #3152 from NotAFile/py3-local-importsRichard van der Hoff2018-04-304-7/+7
| |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | make imports local
| | * | | | | | | make imports localAdrian Tschira2018-04-284-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Adrian Tschira <nota@notafile.com>
| * | | | | | | | Merge pull request #3153 from NotAFile/py3-httplibRichard van der Hoff2018-04-301-3/+3
| |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | move httplib import to six
| | * | | | | | | | move httplib import to sixAdrian Tschira2018-04-281-3/+3
| | |/ / / / / / /
| * | | | | | | | Merge pull request #3151 from NotAFile/py3-xrange-1Richard van der Hoff2018-04-309-11/+28
| |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Move more xrange to six
| | * \ \ \ \ \ \ \ Merge branch 'develop' into py3-xrange-1Richard van der Hoff2018-04-3039-110/+143
| | |\ \ \ \ \ \ \ \
| | * | | | | | | | | Move more xrange to sixAdrian Tschira2018-04-289-11/+28
| | | |/ / / / / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | plus a bonus next() Signed-off-by: Adrian Tschira <nota@notafile.com>
| * | | | | | | | | Merge pull request #3150 from NotAFile/py3-listcomp-yieldRichard van der Hoff2018-04-301-5/+9
| |\ \ \ \ \ \ \ \ \ | | |_|/ / / / / / / | |/| | | | | | | | Don't yield in list comprehensions
| | * | | | | | | | Don't yield in list comprehensionsAdrian Tschira2018-04-281-5/+9
| | |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I've tried to grep for more of this with no success. Signed-off-by: Adrian Tschira <nota@notafile.com>
| * | | | | | | | Merge pull request #3085 from NotAFile/py3-config-text-modeRichard van der Hoff2018-04-302-4/+4
| |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Open config file in non-bytes mode
| | * | | | | | | | open log_config in text mode tooAdrian Tschira2018-04-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Adrian Tschira <nota@notafile.com>
| | * | | | | | | | Open config file in non-bytes modeAdrian Tschira2018-04-101-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Nothing written into it is encoded, so it makes little sense, but it does break in python3 the way it was before. The variable names were adjusted to be less misleading. Signed-off-by: Adrian Tschira <nota@notafile.com>
| * | | | | | | | | Merge pull request #3084 from NotAFile/py3-certs-byte-modeRichard van der Hoff2018-04-301-2/+2
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Open certificate files as bytes
| | * | | | | | | | | Open certificate files as bytesAdrian Tschira2018-04-101-2/+2
| | |/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | That's what pyOpenSSL expects on python3 Signed-off-by: Adrian Tschira <nota@notafile.com>
| * | | | | | | | | Merge pull request #3154 from NotAFile/py3-stringioRichard van der Hoff2018-04-302-3/+3
| |\ \ \ \ \ \ \ \ \ | | |_|_|_|_|/ / / / | |/| | | | | | | | Replace stringIO imports with six
| | * | | | | | | | replace stringIO importsAdrian Tschira2018-04-282-3/+3
| | | |/ / / / / / | | |/| | | | | |
| * | | | | | | | Merge pull request #3155 from NotAFile/py3-bytes-1Richard van der Hoff2018-04-304-7/+10
| |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | more bytes strings
| | * | | | | | | | more bytes stringsAdrian Tschira2018-04-294-7/+10
| | |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Adrian Tschira <nota@notafile.com>
| * | | | | | | | Merge pull request #3140 from matrix-org/rav/use_run_in_backgroundRichard van der Hoff2018-04-3022-72/+98
| |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Use run_in_background in preference to preserve_fn
| | * | | | | | | | pep8; remove spurious importRichard van der Hoff2018-04-271-1/+1
| | | | | | | | | |
| | * | | | | | | | Merge remote-tracking branch 'origin/develop' into rav/use_run_in_backgroundRichard van der Hoff2018-04-2726-257/+388
| | |\ \ \ \ \ \ \ \
| | * | | | | | | | | Use run_in_background in preference to preserve_fnRichard van der Hoff2018-04-2722-71/+97
| | | |_|_|_|/ / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While I was going through uses of preserve_fn for other PRs, I converted places which only use the wrapped function once to use run_in_background, to avoid creating the function object.
| * | | | | | | | | Merge pull request #3156 from NotAFile/py3-hmac-bytesRichard van der Hoff2018-04-302-11/+15
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Construct HMAC as bytes on py3
| | * | | | | | | | | Construct HMAC as bytes on py3Adrian Tschira2018-04-292-11/+15
| | | |_|/ / / / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Adrian Tschira <nota@notafile.com>
| * | | | | | | | | Merge pull request #3108 from NotAFile/py3-six-urlparseRichard van der Hoff2018-04-306-11/+11
| |\ \ \ \ \ \ \ \ \ | | |/ / / / / / / / | |/| | | | | | | | Use six.moves.urlparse
| | * | | | | | | | Use six.moves.urlparseAdrian Tschira2018-04-156-11/+11
| | | |_|_|/ / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The imports were shuffled around a bunch in py3 Signed-off-by: Adrian Tschira <nota@notafile.com>
| * | | | | | | | Merge remote-tracking branch 'origin/develop' into rav/deferred_timeoutRichard van der Hoff2018-04-2726-257/+388
| |\ \ \ \ \ \ \ \ | | | |_|/ / / / / | | |/| | | | | |
| | * | | | | | | Merge pull request #3142 from matrix-org/rav/reraiseRichard van der Hoff2018-04-272-13/+24
| | |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | reraise exceptions more carefully
| | | * | | | | | | reraise exceptions more carefullyRichard van der Hoff2018-04-272-13/+24
| | | | |/ / / / / | | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We need to be careful (under python 2, at least) that when we reraise an exception after doing some error handling, we actually reraise the original exception rather than anything that might have been raised (and handled) during the error handling.
| | * | | | | | | Merge pull request #3136 from matrix-org/rav/fix_dependenciesRichard van der Hoff2018-04-271-1/+19
| | |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Miscellaneous fixes to python_dependencies
| | | * | | | | | | Miscellaneous fixes to python_dependenciesRichard van der Hoff2018-04-261-1/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * add some doc about wtf this thing does * pin Twisted to < 18.4 * add explicit dep on six (fixes #3089)
| | * | | | | | | | Merge pull request #3138 from matrix-org/rav/catch_unhandled_exceptionsRichard van der Hoff2018-04-2720-237/+335
| | |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Improve exception handling for background processes
| | | * | | | | | | | Improve exception handling for background processesRichard van der Hoff2018-04-2720-237/+335
| | | | |/ / / / / / | | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There were a bunch of places where we fire off a process to happen in the background, but don't have any exception handling on it - instead relying on the unhandled error being logged when the relevent deferred gets garbage-collected. This is unsatisfactory for a number of reasons: - logging on garbage collection is best-effort and may happen some time after the error, if at all - it can be hard to figure out where the error actually happened. - it is logged as a scary CRITICAL error which (a) I always forget to grep for and (b) it's not really CRITICAL if a background process we don't care about fails. So this is an attempt to add exception handling to everything we fire off into the background.
| | * | | | | | | | Merge pull request #3139 from matrix-org/rav/consume_errorsRichard van der Hoff2018-04-273-5/+9
| | |\ \ \ \ \ \ \ \ | | | |_|_|_|_|_|/ / | | |/| | | | | | | Add missing consumeErrors to improve exception handling
| | | * | | | | | | Add missing consumeErrorsRichard van der Hoff2018-04-273-5/+9
| | | |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In general we want defer.gatherResults to consumeErrors, rather than having exceptions hanging around and getting logged as CRITICAL unhandled errors.
| | * / / / / / / update changelog and bump version to 0.28.0 v0.28.0 release-v0.28.0-rc1Neil Johnson2018-04-261-1/+1
| | |/ / / / / /
| * | | | | | | Merge branch 'develop' into rav/deferred_timeoutRichard van der Hoff2018-04-275-14/+99
| |\| | | | | |
| | * | | | | | Fix media admin APIsErik Johnston2018-04-261-2/+2
| | | | | | | |
| | * | | | | | Also fix reindexing of searchErik Johnston2018-04-251-1/+1
| | | | | | | |
| | * | | | | | Fix quarantine media admin APIErik Johnston2018-04-251-1/+1
| | | |_|_|/ / | | |/| | | |
| | * | | | | Bump version and update changelog v0.28.0-rc1Neil Johnson2018-04-241-1/+1
| | | | | | |
| | * | | | | Merge pull request #3118 from matrix-org/rav/reject_prev_eventsRichard van der Hoff2018-04-232-9/+94
| | |\ \ \ \ \ | | | |/ / / / | | |/| | | | Reject events which have lots of prev_events
| | | * | | | Remove spurious paramRichard van der Hoff2018-04-231-1/+0
| | | | | | |
| | | * | | | accept stupid events over backfillRichard van der Hoff2018-04-201-4/+9
| | | | | | |
| | | * | | | Add some commentsRichard van der Hoff2018-04-182-5/+35
| | | | | | |
| | | * | | | Check events on backfill tooRichard van der Hoff2018-04-181-15/+42
| | | | | | |
| | | * | | | Reject events which have too many auth_events or prev_eventsRichard van der Hoff2018-04-181-4/+28
| | | |/ / / | | | | | | | | | | | | | | | | | | | | | | | | ... this should protect us from being dossed by people making silly events (deliberately or otherwise)
| * | | | | Backport deferred.addTimeoutRichard van der Hoff2018-04-275-14/+90
| | | | | | | | | | | | | | | | | | | | | | | | Twisted 16.0 doesn't have addTimeout, so let's backport it.
| * | | | | Use deferred.addTimeout instead of time_bound_deferredRichard van der Hoff2018-04-235-97/+59
| |/ / / / | | | | | | | | | | | | | | | This doesn't feel like a wheel we need to reinvent.
| * | | | Merge pull request #3106 from NotAFile/py3-six-itervalues-1Richard van der Hoff2018-04-204-11/+18
| |\ \ \ \ | | | | | | | | | | | | Use six.itervalues in some places
| | * | | | Use six.itervalues in some placesAdrian Tschira2018-04-154-11/+18
| | |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | There's more where that came from Signed-off-by: Adrian Tschira <nota@notafile.com>
| * | | | Merge pull request #3107 from NotAFile/py3-bool-nonzeroRichard van der Hoff2018-04-203-0/+9
| |\ \ \ \ | | | | | | | | | | | | add __bool__ alias to __nonzero__ methods
| | * | | | add __bool__ alias to __nonzero__ methodsAdrian Tschira2018-04-153-0/+9
| | |/ / / | | | | | | | | | | | | | | | Signed-off-by: Adrian Tschira <nota@notafile.com>
| * | | | Merge pull request #3110 from NotAFile/py3-six-queueRichard van der Hoff2018-04-202-4/+6
| |\ \ \ \ | | | | | | | | | | | | Replace Queue with six.moves.queue
| | * | | | Replace Queue with six.moves.queueAdrian Tschira2018-04-162-4/+6
| | |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | and a six.range change which I missed the last time Signed-off-by: Adrian Tschira <nota@notafile.com>
| * | | | Merge pull request #3103 from NotAFile/py3-baseexcepton-messageRichard van der Hoff2018-04-201-4/+4
| |\ \ \ \ | | | | | | | | | | | | Use str(e) instead of e.message
| | * | | | Use str(e) instead of e.messageAdrian Tschira2018-04-151-4/+4
| | |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Doing this I learned e.message was pretty shortlived, added in 2.6, they realized it was a bad idea and deprecated it in 2.7 Signed-off-by: Adrian Tschira <nota@notafile.com>
| * | | | Merge pull request #3093 from matrix-org/rav/response_cache_wrapRichard van der Hoff2018-04-206-79/+111
| |\ \ \ \ | | | | | | | | | | | | Refactor ResponseCache usage
| | * | | | Reinstate linearizer for federation_server.on_context_state_requestRichard van der Hoff2018-04-201-5/+11
| | | | | |
| | * | | | ResponseCache: fix handling of completed resultsRichard van der Hoff2018-04-131-13/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Turns out that ObservableDeferred.observe doesn't return a deferred if the result is already completed. Fix handling and improve documentation.
| | * | | | Refactor ResponseCache usageRichard van der Hoff2018-04-126-67/+87
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds a `.wrap` method to ResponseCache which wraps up the boilerplate of a (get, set) pair, and then use it throughout the codebase. This will be largely non-functional, but does include the following functional changes: * federation_server.on_context_state_request: drops use of _server_linearizer which looked redundant and could cause incorrect cache misses by yielding between the get and the set. * RoomListHandler.get_remote_public_room_list(): fixes logcontext leaks * the wrap function includes some logging. I'm hoping this won't be too noisy on production.
| * | | | | Merge pull request #3117 from matrix-org/rav/refactor_have_eventsRichard van der Hoff2018-04-203-27/+55
| |\ \ \ \ \ | | | | | | | | | | | | | | Refactor store.have_events
| | * | | | | Refactor store.have_eventsRichard van der Hoff2018-04-203-27/+55
| | | |/ / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | It turns out that most of the time we were calling have_events, we were only using half of the result. Replace have_events with have_seen_events and get_rejection_reasons, so that we can see what's going on a bit more clearly.
| * / | | | Avoid creating events with huge numbers of prev_eventsRichard van der Hoff2018-04-163-54/+94
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | In most cases, we limit the number of prev_events for a given event to 10 events. This fixes a particular code path which created events with huge numbers of prev_events.
| * | | | Merge branch 'master' of https://github.com/matrix-org/synapse into developNeil Johnson2018-04-132-2/+2
| |\ \ \ \
| | * | | | Bump version and Change log v0.27.4 release-v0.27.0Neil Johnson2018-04-131-1/+1
| | | | | |
| | * | | | Bump canonicaljson to 1.1.3Richard van der Hoff2018-04-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | 1.1.2 was a bit broken too :/
| | * | | | Update canonicaljson dependencyRichard van der Hoff2018-04-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1.1.0 and 1.1.1 were broken, so we're updating this to help people make sure they don't end up on a broken version. Also, 1.1.0 is speedier...
| * | | | | fix federation_domain_whitelistMatthew Hodgson2018-04-131-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | we were checking the wrong server_name on inbound requests
| * | | | | revert last to PR properlyMatthew Hodgson2018-04-131-6/+6
| | | | | |
| * | | | | correctly auth inbound federation_domain_whitelist reqsMatthew Hodgson2018-04-131-6/+6
| | | | | |
| * | | | | Merge branch 'master' of https://github.com/matrix-org/synapse into developNeil Johnson2018-04-131-1/+1
| |\| | | |
| | * | | | bump version/changelogNeil Johnson2018-04-111-1/+1
| | | | | |
| | * | | | Merge commit '11d2609da70af797405241cdf7d9df19db5628f2' of ↵Neil Johnson2018-04-111-48/+80
| | |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | https://github.com/matrix-org/synapse into release-v0.27.0
| * | | | | | Revert "Use sortedcontainers instead of blist"Richard van der Hoff2018-04-133-10/+10
| | |_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 9fbe70a7dc3afabfdac176ba1f4be32dd44602aa. It turns out that sortedcontainers.SortedDict is not an exact match for blist.sorteddict; in particular, `popitem()` removes things from the opposite end of the dict. This is trivial to fix, but I want to add some unit tests, and potentially some more thought about it, before we do so.
| * | | | | Merge pull request #3092 from matrix-org/rav/response_cache_metricsRichard van der Hoff2018-04-126-7/+21
| |\ \ \ \ \ | | | | | | | | | | | | | | Add metrics for ResponseCache
| | * | | | | Add metrics for ResponseCacheRichard van der Hoff2018-04-106-7/+21
| | | | | | |
| * | | | | | Format docstringErik Johnston2018-04-121-2/+3
| | | | | | |
| * | | | | | Merge branch 'develop' of github.com:matrix-org/synapse into ↵Erik Johnston2018-04-122-2/+51
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | erikj/processed_event_lag
| | * \ \ \ \ \ Merge pull request #3059 from matrix-org/rav/doc_response_cacheRichard van der Hoff2018-04-121-0/+32
| | |\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Document the behaviour of ResponseCache
| | | * | | | | | Document the behaviour of ResponseCacheRichard van der Hoff2018-04-041-0/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | it looks like everything that uses ResponseCache expects to have to `make_deferred_yieldable` its results. It's debatable whether that is the best approach, but let's document it for now to avoid further confusion.
| | * | | | | | | Merge pull request #3088 from matrix-org/erikj/as_parallelErik Johnston2018-04-121-2/+19
| | |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Send events to ASes concurrently
| | | * | | | | | | Send events to ASes concurrentlyErik Johnston2018-04-111-2/+19
| | | | | | | | | |
| * | | | | | | | | Doc we raise on unknown eventErik Johnston2018-04-121-2/+3
| | | | | | | | | |
| * | | | | | | | | s/list/tupleErik Johnston2018-04-121-2/+2
| | | | | | | | | |
| * | | | | | | | | Set all metrics at the same timeErik Johnston2018-04-122-10/+10
| | | | | | | | | |
| * | | | | | | | | Track last processed event received_tsErik Johnston2018-04-114-0/+52
| | | | | | | | | |
| * | | | | | | | | Track where event stream processing have gotten up toErik Johnston2018-04-114-0/+24
| | | | | | | | | |
| * | | | | | | | | Add GaugeMetricErik Johnston2018-04-112-1/+38
| |/ / / / / / / /
| * | | | | | | | Merge pull request #2760 from Valodim/pypyRichard van der Hoff2018-04-117-13/+24
| |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Synapse on PyPy
| | * | | | | | | | Don't disable GC when running on PyPyVincent Breitmoser2018-04-101-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PyPy's incminimark GC can't be triggered manually. From what I observed there are no obvious issues with just letting it run normally. And unlike CPython, it actually returns unused RAM to the system. Signed-off-by: Vincent Breitmoser <look@my.amazin.horse>
| | * | | | | | | | In DomainSpecificString, override __repr__ in addition to __str__Vincent Breitmoser2018-04-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For some reason, string interpolation on a DomainSpecificString object like "%r" % (domainSpecificStringObj) fails under PyPy, because the default __repr__ implementation wants to iterate over the object. I'm not sure why that happens, but overriding __repr__ instead of __str__ fixes this problem, and is arguably the more appropriate thing to do anyways.
| | * | | | | | | | Fix pep8 error on psycopg2cffi hackRichard van der Hoff2018-04-101-6/+5
| | | | | | | | | |
| | * | | | | | | | Use psycopg2cffi module instead of psycopg2 if running on pypyVincent Breitmoser2018-04-102-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The psycopg2 package isn't available for PyPy. This commit adds a check if the runtime is PyPy, and if it is uses psycopg2cffi module in favor of psycopg2. This is almost a drop-in replacement, except for one place where an additional cast to string is required.
| | * | | | | | | | Use sortedcontainers instead of blistVincent Breitmoser2018-04-103-10/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit drop-in replaces blist with SortedContainers. They are written in pure python so work with pypy, but perform as good as native implementations, at least in a couple benchmarks: http://www.grantjenks.com/docs/sortedcontainers/performance.html
| * | | | | | | | | fix typoNeil Johnson2018-04-101-2/+2
| | | | | | | | | |
| * | | | | | | | | Merge pull request #3079 from matrix-org/erikj/limit_concurrent_sendsErik Johnston2018-04-102-55/+56
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Limit concurrent event sends for a room
| | * | | | | | | | | Note why we're limiting concurrent event sendsErik Johnston2018-04-101-0/+5
| | | | | | | | | | |
| | * | | | | | | | | Limit concurrent event sends for a roomErik Johnston2018-04-091-49/+50
| | | | | | | | | | |
| | * | | | | | | | | Use create_and_send_nonmember_event everywhereErik Johnston2018-04-091-6/+1
| | | | | | | | | | |
| * | | | | | | | | | Merge pull request #3078 from matrix-org/erikj/federation_senderErik Johnston2018-04-101-15/+41
| |\ \ \ \ \ \ \ \ \ \ | | |_|_|_|_|_|_|_|/ / | |/| | | | | | | | | Send federation events concurrently
| | * | | | | | | | | Use run_in_background insteadErik Johnston2018-04-101-1/+1
| | | | | | | | | | |
| | * | | | | | | | | Preserve log contexts correctlyErik Johnston2018-04-101-1/+4
| | | | | | | | | | |
| | * | | | | | | | | Log event ID on exceptionErik Johnston2018-04-101-1/+4
| | | | | | | | | | |
| | * | | | | | | | | Handle all events in a room correctlyErik Johnston2018-04-091-1/+2
| | | | | | | | | | |
| | * | | | | | | | | Send federation events concurrentlyErik Johnston2018-04-091-4/+18
| | | | | | | | | | |
| | * | | | | | | | | Handle exceptions in get_hosts_for_room when sending events over federationErik Johnston2018-04-091-11/+16
| | |/ / / / / / / /
| * | | | | | | | | Merge branch 'release-v0.27.0' of https://github.com/matrix-org/synapse into ↵Neil Johnson2018-04-102-7/+7
| |\ \ \ \ \ \ \ \ \ | | |_|_|/ / / / / / | |/| | | | | / / / | | | |_|_|_|/ / / | | |/| | | | | | develop
| | * | | | | | | remove errant print v0.27.3-rc2Neil Johnson2018-04-091-1/+1
| | | | | | | | |
| | * | | | | | | Fix msec to sec, againNeil Johnson2018-04-091-3/+3
| | | | | | | | |
| | * | | | | | | Fix msec to secNeil Johnson2018-04-091-1/+1
| | | | | | | | |
| | * | | | | | | Fix psycopg2 interpolationNeil Johnson2018-04-091-5/+5
| | | | | | | | |
| | * | | | | | | version bump v0.27.3-rc2Neil Johnson2018-04-091-1/+1
| | | | | | | | |
| | * | | | | | | Merge branch 'develop' of https://github.com/matrix-org/synapse into ↵Neil Johnson2018-04-0931-151/+613
| | |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | release-v0.27.0
| | * | | | | | | | bump version to release candidateNeil Johnson2018-04-091-1/+1
| | | | | | | | | |
| | * | | | | | | | bump version v0.27.3-rc1Neil Johnson2018-04-091-1/+1
| | | | | | | | | |
| * | | | | | | | | Merge pull request #3082 from matrix-org/erikj/urlencode_pathsErik Johnston2018-04-101-48/+80
| |\ \ \ \ \ \ \ \ \ | | |_|_|_|/ / / / / | |/| | | | | | / / | | | |_|_|_|_|/ / | | |/| | | | | | URL quote path segments over federation
| | * | | | | | | Ensure slashes are escapedErik Johnston2018-04-101-1/+1
| | | | | | | | |
| | * | | | | | | URL quote path segments over federationErik Johnston2018-04-101-48/+80
| | | |/ / / / / | | |/| | | | |
| * | | | | | | Merge pull request #2996 from krombel/allow_auto_join_roomsRichard van der Hoff2018-04-102-34/+34
| |\ \ \ \ \ \ \ | | |_|_|_|_|/ / | |/| | | | | | move handling of auto_join_rooms to RegisterHandler
| | * | | | | | Merge branch 'develop' of into allow_auto_join_roomsKrombel2018-03-2848-101/+155
| | |\ \ \ \ \ \
| | * | | | | | | move handling of auto_join_rooms to RegisterHandlerKrombel2018-03-142-34/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently the handling of auto_join_rooms only works when a user registers itself via public register api. Registrations via registration_shared_secret and ModuleApi do not work This auto_joins the users in the registration handler which enables the auto join feature for all 3 registration paths. This is related to issue #2725 Signed-Off-by: Matthias Kesler <krombel@krombel.de>
| * | | | | | | | Merge pull request #3061 from NotAFile/add-some-byte-stringsRichard van der Hoff2018-04-095-13/+13
| |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Add b prefixes to some strings that are bytes in py3
| | * | | | | | | | Add b prefixes to some strings that are bytes in py3Adrian Tschira2018-04-045-13/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This has no effect on python2 Signed-off-by: Adrian Tschira <nota@notafile.com>
| * | | | | | | | | Merge pull request #3073 from NotAFile/use-six-reraiseRichard van der Hoff2018-04-091-1/+3
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Replace old-style raise with six.reraise
| | * | | | | | | | | Replace old-style raise with six.reraiseAdrian Tschira2018-04-061-1/+3
| | | |_|_|_|_|/ / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The old style raise is invalid syntax in python3. As noted in the docs, this adds one more frame in the traceback, but I think this is acceptable: <ipython-input-7-bcc5cba3de3f> in <module>() 16 except: 17 pass ---> 18 six.reraise(*x) /usr/lib/python3.6/site-packages/six.py in reraise(tp, value, tb) 691 if value.__traceback__ is not tb: 692 raise value.with_traceback(tb) --> 693 raise value 694 finally: 695 value = None <ipython-input-7-bcc5cba3de3f> in <module>() 9 10 try: ---> 11 x() 12 except: 13 x = sys.exc_info() Also note that this uses six, which is not formally a dependency yet, but is included indirectly since most packages depend on it. Signed-off-by: Adrian Tschira <nota@notafile.com>
| * | | | | | | | | Merge pull request #2938 from dklug/developRichard van der Hoff2018-04-091-1/+4
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Return 401 for invalid access_token on logout
| | * | | | | | | | | Return 401 for invalid access_token on logoutdklug2018-03-021-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Duncan Klug <dklug@ucmerced.edu>
| * | | | | | | | | | Merge pull request #3074 from NotAFile/fix-py3-printsRichard van der Hoff2018-04-091-5/+5
| |\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | use python3-compatible prints
| | * | | | | | | | | | use python3-compatible printsAdrian Tschira2018-04-061-5/+5
| | | |/ / / / / / / / | | |/| | | | | | | |
| * | | | | | | | | | Merge pull request #3075 from NotAFile/six-type-checksRichard van der Hoff2018-04-093-6/+12
| |\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Replace some type checks with six type checks
| | * | | | | | | | | | Replace some type checks with six type checksAdrian Tschira2018-04-073-6/+12
| | |/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Adrian Tschira <nota@notafile.com>
| * | | | | | | | | | Merge pull request #3016 from silkeh/improve-service-lookupsRichard van der Hoff2018-04-091-95/+8
| |\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Improve handling of SRV records for federation connections
| | * | | | | | | | | | Remove address resolution of hosts in SRV recordsSilke2018-04-041-95/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Silke Hofstra <silke@slxh.eu>
| * | | | | | | | | | | Merge pull request #3080 from matrix-org/rav/fix_500_on_rejoinRichard van der Hoff2018-04-091-0/+8
| |\ \ \ \ \ \ \ \ \ \ \ | | |_|_|_|_|_|_|/ / / / | |/| | | | | | | | | | Return a 404 rather than a 500 on rejoining empty rooms
| | * | | | | | | | | | Return a 404 rather than a 500 on rejoining empty roomsRichard van der Hoff2018-04-091-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Filter ourselves out of the server list before checking for an empty remote host list, to fix 500 error Fixes #2141
| * | | | | | | | | | | Revert "Merge pull request #3066 from matrix-org/rav/remove_redundant_metrics"Richard van der Hoff2018-04-092-0/+51
| | |_|/ / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We aren't ready to release this yet, so I'm reverting it for now. This reverts commit d1679a4ed7947b0814e0f2af9b888a16c588f1a1, reversing changes made to e089100c6231541c446e37e157dec8feed02d283.
| * | | | | | | | | | Merge pull request #3046 from matrix-org/dbkr/join_groupLuke Barnard2018-04-065-25/+133
| |\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Implement group join API
| | * | | | | | | | | | de-lint, quote consistencyLuke Barnard2018-04-061-2/+2
| | | | | | | | | | | |
| | * | | | | | | | | | Explicitly grab individual columns from group objectLuke Barnard2018-04-061-6/+8
| | | | | | | | | | | |
| | * | | | | | | | | | When exposing group state, return is_openly_joinableLuke Barnard2018-04-061-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | as opposed to join_policy, which is really only pertinent to the synapse implementation of the group server. By doing this we keep the group server concept extensible by allowing arbitrarily complex rules for deciding whether a group is openly joinable.
| | * | | | | | | | | | By default, join policy is "invite"Luke Barnard2018-04-061-1/+1
| | | | | | | | | | | |
| | * | | | | | | | | | add_user -> _add_userLuke Barnard2018-04-061-3/+3
| | | | | | | | | | | |
| | * | | | | | | | | | pep8Luke Barnard2018-04-062-2/+4
| | | | | | | | | | | |
| | * | | | | | | | | | Get group_info from existing call to check_group_is_oursLuke Barnard2018-04-061-5/+1
| | | | | | | | | | | |
| | * | | | | | | | | | Don't use redundant inlineCallbacksLuke Barnard2018-04-061-4/+1
| | | | | | | | | | | |
| | * | | | | | | | | | join_rule -> join_policyLuke Barnard2018-04-061-1/+1
| | | | | | | | | | | |
| | * | | | | | | | | | is_joinable -> join_ruleLuke Barnard2018-04-062-5/+2
| | | | | | | | | | | |
| | * | | | | | | | | | Fix federation client `set_group_joinable` typoLuke Barnard2018-04-061-1/+1
| | | | | | | | | | | |
| | * | | | | | | | | | Factor out add_user from accept_invite and join_groupLuke Barnard2018-04-061-41/+29
| | | | | | | | | | | |
| | * | | | | | | | | | pep8David Baker2018-04-061-1/+2
| | | | | | | | | | | |
| | * | | | | | | | | | Implement group join APIDavid Baker2018-04-065-4/+124
| | | | | | | | | | | |
| * | | | | | | | | | | Add response size metricsErik Johnston2018-04-061-0/+7
| |/ / / / / / / / / /
| * / / / / / / / / / use PUT instead of POST for federating groups/m.join_policyKrombel2018-04-063-3/+7
| |/ / / / / / / / /
| * | | | | | | | | more verbosity in synctlRichard van der Hoff2018-04-061-0/+1
| | | | | | | | | |
| * | | | | | | | | Merge pull request #2986 from jplatte/join_reponse_room_idRichard van der Hoff2018-04-051-1/+6
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Add room_id to the response of `rooms/{roomId}/join`
| | * | | | | | | | | Add room_id to the response of `rooms/{roomId}/join`Jonas Platte2018-03-131-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #2349
| * | | | | | | | | | Merge pull request #3068 from matrix-org/rav/fix_cache_invalidationRichard van der Hoff2018-04-051-26/+38
| |\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Improve database cache performance
| | * | | | | | | | | | Fix overzealous cache invalidationRichard van der Hoff2018-04-051-26/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes an issue where a cache invalidation would invalidate *all* pending entries, rather than just the entry that we intended to invalidate.
| * | | | | | | | | | | Merge pull request #3066 from matrix-org/rav/remove_redundant_metricsRichard van der Hoff2018-04-052-51/+0
| |\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | Remove redundant metrics which were deprecated in 0.27.0.
| | * | | | | | | | | | | Remove redundant metrics which were deprecated in 0.27.0.Richard van der Hoff2018-04-042-51/+0
| | |/ / / / / / / / / /
| * | | | | | | | | | | Merge pull request #3045 from matrix-org/dbkr/group_joinableLuke Barnard2018-04-058-0/+157
| |\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | Add joinability for groups
| | * | | | | | | | | | | NON NULL -> NOT NULLLuke Barnard2018-04-051-1/+1
| | | | | | | | | | | | |
| | * | | | | | | | | | | Use "/settings/" (plural)Luke Barnard2018-04-053-3/+3
| | | | | | | | | | | | |
| | * | | | | | | | | | | Use DEFAULT join_policy of "invite" in dbLuke Barnard2018-04-051-1/+1
| | | | | | | | | | | | |
| | * | | | | | | | | | | Document set_group_join_policyLuke Barnard2018-04-051-0/+6
| | | | | | | | | | | | |
| | * | | | | | | | | | | Use join_policy API instead of joinableLuke Barnard2018-04-037-23/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The API is now under /groups/$group_id/setting/m.join_policy and expects a JSON blob of the shape ```json { "m.join_policy": { "type": "invite" } } ``` where "invite" could alternatively be "open".
| | * | | | | | | | | | | This should probably be a PUTDavid Baker2018-03-281-1/+1
| | | | | | | | | | | | |
| | * | | | | | | | | | | OK, smallint it is thenDavid Baker2018-03-281-1/+1
| | | | | | | | | | | | |
| | * | | | | | | | | | | Grr. Copy the definition from is_adminDavid Baker2018-03-281-1/+1
| | | | | | | | | | | | |
| | * | | | | | | | | | | pep8David Baker2018-03-281-2/+1
| | | | | | | | | | | | |
| | * | | | | | | | | | | Make column definition that works on both dbsDavid Baker2018-03-281-1/+1
| | | | | | | | | | | | |
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-09-21 10:36:45 +0000