Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #7067 from matrix-org/babolivier/saml_error_moar | Brendan Abolivier | 2020-03-13 | 2 | -23/+72 |
|\ | | | | | Move the default SAML2 error HTML to a dedicated file | ||||
| * | Use innerText instead of innerHTML | Brendan Abolivier | 2020-03-13 | 1 | -1/+2 |
| | | |||||
| * | Lint | Brendan Abolivier | 2020-03-11 | 1 | -2/+1 |
| | | |||||
| * | Put the file in the templates directory | Brendan Abolivier | 2020-03-11 | 1 | -12/+21 |
| | | |||||
| * | Update wording and config | Brendan Abolivier | 2020-03-11 | 2 | -2/+5 |
| | | |||||
| * | Move the default SAML2 error HTML to a dedicated file | Brendan Abolivier | 2020-03-11 | 2 | -18/+55 |
| | | | | | | | | | | Also add some JS to it to process any error we might have in the URI (see #6893). | ||||
* | | Add type annotations and comments to auth handler (#7063) | Patrick Cloke | 2020-03-12 | 1 | -89/+104 |
| | | |||||
* | | Refactor a bit | Brendan Abolivier | 2020-03-11 | 1 | -28/+30 |
| | | |||||
* | | Also don't fail on aliases events in this case | Brendan Abolivier | 2020-03-11 | 1 | -1/+1 |
| | | |||||
* | | Lint | Brendan Abolivier | 2020-03-11 | 1 | -1/+5 |
| | | |||||
* | | Also don't filter out events sent by ignored users when checking state ↵ | Brendan Abolivier | 2020-03-11 | 1 | -1/+1 |
| | | | | | | | | visibility | ||||
* | | Fix condition | Brendan Abolivier | 2020-03-11 | 1 | -1/+1 |
| | | |||||
* | | Don't filter out dummy events when we're checking the visibility of state | Brendan Abolivier | 2020-03-11 | 2 | -9/+8 |
|/ | |||||
* | Add options to disable setting profile info for prevent changes. (#7053) | Brendan Abolivier | 2020-03-10 | 3 | -0/+49 |
|\ | |||||
| * | Update synapse/config/registration.py | Dirk Klimpel | 2020-03-10 | 1 | -1/+1 |
| | | | | | | Co-Authored-By: Brendan Abolivier <github@brendanabolivier.com> | ||||
| * | lint, fix tests | dklimpel | 2020-03-09 | 1 | -1/+3 |
| | | |||||
| * | updates after review | dklimpel | 2020-03-09 | 3 | -18/+24 |
| | | |||||
| * | add disable_3pid_changes | dklimpel | 2020-03-08 | 2 | -0/+16 |
| | | |||||
| * | lint2 | dklimpel | 2020-03-08 | 1 | -2/+2 |
| | | |||||
| * | lint | dklimpel | 2020-03-08 | 1 | -4/+2 |
| | | |||||
| * | changelog | dklimpel | 2020-03-08 | 2 | -4/+10 |
| | | |||||
| * | Add options to disable setting profile info for prevent changes. | dklimpel | 2020-03-08 | 2 | -0/+21 |
| | | |||||
* | | Rephrase default message | Brendan Abolivier | 2020-03-10 | 1 | -2/+2 |
| | | |||||
* | | Hopefully mypy is happy now | Brendan Abolivier | 2020-03-10 | 2 | -3/+10 |
| | | |||||
* | | Attempt at appeasing the gods of mypy | Brendan Abolivier | 2020-03-10 | 1 | -1/+1 |
| | | |||||
* | | Lint | Brendan Abolivier | 2020-03-10 | 1 | -1/+1 |
| | | |||||
* | | SAML2: render a comprehensible error page if something goes wrong | Brendan Abolivier | 2020-03-10 | 3 | -2/+62 |
| | | | | | | | | | | | | If an error happened while processing a SAML AuthN response, or a client ends up doing a `GET` request to `/authn_response`, then render a customisable error page rather than a confusing error. | ||||
* | | Merge pull request #7055 from ↵ | Brendan Abolivier | 2020-03-09 | 2 | -18/+20 |
|\ \ | | | | | | | | | | | | | matrix-org/babolivier/get_time_of_last_push_action_before Move get_time_of_last_push_action_before to the EventPushActionsWorkerStore | ||||
| * | | Fix undefined `room_id` in `make_summary_text` | Brendan Abolivier | 2020-03-09 | 1 | -1/+3 |
| | | | | | | | | | | | | | | | This would break notifications about un-named rooms when processing notifications in a batch. | ||||
| * | | Move `get_time_of_last_push_action_before` to the `EventPushActionsWorkerStore` | Brendan Abolivier | 2020-03-09 | 1 | -17/+17 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #7054 I also had a look at the rest of the functions in `EventPushActionsStore` and in the push notifications send code and it looks to me like there shouldn't be any other method with this issue in this part of the codebase. | ||||
* | | | Remove special auth and redaction rules for aliases events in experimental ↵ | Patrick Cloke | 2020-03-09 | 5 | -19/+22 |
| | | | | | | | | | | | | room ver. (#7037) | ||||
* | | | Merge pull request #7045 from matrix-org/babolivier/room_keys_check | Brendan Abolivier | 2020-03-09 | 1 | -0/+7 |
|\ \ \ | | | | | | | | | Make sure that is_verified is a boolean when processing room keys | ||||
| * | | | Lint | Brendan Abolivier | 2020-03-06 | 1 | -2/+1 |
| | | | | |||||
| * | | | Mention the session ID in the error message | Brendan Abolivier | 2020-03-06 | 1 | -2/+3 |
| | | | | |||||
| * | | | Lint | Brendan Abolivier | 2020-03-06 | 1 | -1/+2 |
| | | | | |||||
| * | | | Make sure that is_verified is a boolean when processing room keys | Brendan Abolivier | 2020-03-06 | 1 | -0/+6 |
| |/ / | |||||
* | | | Add type hints to logging/context.py (#6309) | Neil Pilgrim | 2020-03-07 | 1 | -47/+74 |
| | | | | | | | | | | | | | | | | | | * Add type hints to logging/context.py Signed-off-by: neiljp (Neil Pilgrim) <github@kepier.clara.net> | ||||
* | | | Break down monthly active users by appservice_id (#7030) | Neil Johnson | 2020-03-06 | 2 | -1/+44 |
|/ / | | | | | | | | | * Break down monthly active users by appservice_id and emit via prometheus. Co-authored-by: Brendan Abolivier <babolivier@matrix.org> | ||||
* | | Convert remote key resource REST layer to async/await. (#7020) | Patrick Cloke | 2020-03-05 | 1 | -7/+4 |
| | | |||||
* | | Store room_versions in EventBase objects (#6875) | Richard van der Hoff | 2020-03-05 | 4 | -32/+62 |
| | | | | | | | | | | | | | | This is a bit fiddly because it all has to be done on one fell swoop: * Wherever we create a new event, pass in the room version (and check it matches the format version) * When we prune an event, use the room version of the unpruned event to create the pruned version. * When we pass an event over the replication protocol, pass the room version over alongside it, and use it when deserialising the event again. | ||||
* | | Hide extremities dummy events from clients | Brendan Abolivier | 2020-03-04 | 1 | -0/+3 |
| | | |||||
* | | Allow deleting an alias if the user has sufficient power level (#6986) | Patrick Cloke | 2020-03-04 | 2 | -40/+76 |
| | | |||||
* | | Read the room version from database when fetching events (#6874) | Richard van der Hoff | 2020-03-04 | 1 | -16/+68 |
| | | | | | | | | | | This is a precursor to giving EventBase objects the knowledge of which room version they belong to. | ||||
* | | Merge branch 'master' into develop | Brendan Abolivier | 2020-03-03 | 9 | -34/+219 |
|\ \ | |||||
| * | | v1.11.1 | Brendan Abolivier | 2020-03-03 | 1 | -1/+1 |
| | | | |||||
| * | | Fix wrong handler being used in SAML handler | Brendan Abolivier | 2020-03-03 | 1 | -3/+2 |
| | | | |||||
| * | | Factor out complete_sso_login and expose it to the Module API | Brendan Abolivier | 2020-03-03 | 4 | -57/+96 |
| | | | |||||
| * | | Add a whitelist for the SSO confirmation step. | Richard van der Hoff | 2020-03-02 | 2 | -8/+36 |
| | | | |||||
| * | | Merge remote-tracking branch 'origin/release-v1.11.1' into release-v1.11.1 | Richard van der Hoff | 2020-03-02 | 2 | -10/+12 |
| |\ \ | |||||
| | * | | Fixed set a user as an admin with the new API (#6928) | Dirk Klimpel | 2020-03-02 | 2 | -10/+12 |
| | | | | | | | | | | | | | | | | Fix #6910 | ||||
| * | | | Add a confirmation step to the SSO login flow | Brendan Abolivier | 2020-03-02 | 5 | -6/+126 |
| |/ / | |||||
* | / | Validate the alt_aliases property of canonical alias events (#6971) | Patrick Cloke | 2020-03-03 | 4 | -15/+62 |
| |/ |/| | |||||
* | | Always return a deferred from `get_current_state_deltas`. (#7019) | Erik Johnston | 2020-03-02 | 1 | -1/+3 |
| | | | | | | | | | | This currently causes presence notify code to log exceptions when there is no state changes to process. This doesn't actually cause any problems as we'd simply do nothing anyway. | ||||
* | | Add some type annotations to the federation base & client classes (#6995) | Patrick Cloke | 2020-02-28 | 2 | -28/+42 |
| | | |||||
* | | Fixed set a user as an admin with the new API (#6928) | Dirk Klimpel | 2020-02-28 | 2 | -10/+12 |
| | | | | | | Fix #6910 | ||||
* | | Merge remote-tracking branch 'origin/release-v1.11.1' into develop | Patrick Cloke | 2020-02-27 | 1 | -6/+8 |
|\| | |||||
| * | Cast a coroutine into a Deferred in the federation base (#6996) | Patrick Cloke | 2020-02-26 | 1 | -6/+8 |
| | | | | | | | | Properly convert a coroutine into a Deferred in federation_base to fix an error when joining a room. | ||||
* | | Don't refuse to start worker if media listener configured. (#7002) | Erik Johnston | 2020-02-27 | 1 | -14/+20 |
| | | | | | | | | | | | | | | | | Instead lets just warn if the worker has a media listener configured but has the media repository disabled. Previously non media repository workers would just ignore the media listener. | ||||
* | | Add some type annotations in `synapse.storage` (#6987) | Richard van der Hoff | 2020-02-27 | 6 | -82/+266 |
| | | | | | | | | | | I cracked, and added some type definitions in synapse.storage. | ||||
* | | Store room version on invite (#6983) | Richard van der Hoff | 2020-02-26 | 4 | -2/+68 |
| | | | | | | | | | | When we get an invite over federation, store the room version in the rooms table. The general idea here is that, when we pull the invite out again, we'll want to know what room_version it belongs to (so that we can later redact it if need be). So we need to store it somewhere... | ||||
* | | Port PresenceHandler to async/await (#6991) | Erik Johnston | 2020-02-26 | 4 | -109/+99 |
| | | |||||
* | | Updated warning for incorrect database collation/ctype (#6985) | Uday Bansal | 2020-02-26 | 1 | -3/+7 |
| | | | | | | Signed-off-by: Uday Bansal <43824981+udaybansal19@users.noreply.github.com> | ||||
* | | Ensure 'deactivated' parameter is a boolean on user admin API, Fix error ↵ | Andrew Morgan | 2020-02-26 | 2 | -4/+8 |
| | | | | | | | | handling of call to deactivate user (#6990) | ||||
* | | Sanity-check database before running upgrades (#6982) | Richard van der Hoff | 2020-02-25 | 2 | -17/+32 |
| | | | | | | | | | | | | Some of the database deltas rely on `config.server_name` being set correctly, so we should check that it is before running the deltas. Fixes #6870. | ||||
* | | Merge worker apps into one. (#6964) | Erik Johnston | 2020-02-25 | 13 | -2317/+1045 |
| | | |||||
* | | Remove redundant store_room call (#6979) | Richard van der Hoff | 2020-02-24 | 1 | -23/+0 |
| | | | | | | | | | | `_process_received_pdu` is only called by `on_receive_pdu`, which ignores any events for unknown rooms, so this is redundant. | ||||
* | | Upsert room version when we join over federation (#6968) | Richard van der Hoff | 2020-02-24 | 2 | -10/+29 |
| | | | | | | | | | | | | | | | | This is intended as a precursor to storing room versions when we receive an invite over federation, but has the happy side-effect of fixing #3374 at last. In short: change the store_room with try/except to a proper upsert which updates the right columns. | ||||
* | | Fix minor issues with email config (#6962) | Richard van der Hoff | 2020-02-24 | 1 | -36/+30 |
| | | | | | | | | | | | | * Give `notif_template_html`, `notif_template_text` default values (fixes #6960) * Don't complain if `smtp_host` and `smtp_port` are unset, since they have sensible defaults (fixes #6961) * Set the example for `enable_notifs` to `True`, for consistency and because it's more useful * Raise errors as ConfigError rather than RuntimeError for nicer formatting | ||||
* | | No longer use room alias events to calculate room names for push ↵ | Patrick Cloke | 2020-02-21 | 1 | -22/+14 |
| | | | | | | | | notifications. (#6966) | ||||
* | | Change displayname of user as admin in rooms (#6876) | Dirk Klimpel | 2020-02-21 | 1 | -1/+11 |
| | | |||||
* | | Stop returning aliases as part of the room list. (#6970) | Patrick Cloke | 2020-02-21 | 1 | -9/+0 |
| | | |||||
* | | Publishing/removing from the directory requires a power level greater than ↵ | Patrick Cloke | 2020-02-21 | 1 | -5/+5 |
| | | | | | | | | canonical aliases. | ||||
* | | Clarify list/set/dict/tuple comprehensions and enforce via flake8 (#6957) | Patrick Cloke | 2020-02-21 | 53 | -168/+159 |
| | | | | | | | | Ensure good comprehension hygiene using flake8-comprehensions. | ||||
* | | Merge pull request #6967 from matrix-org/rav/increase_max_events_behind | Richard van der Hoff | 2020-02-21 | 1 | -1/+1 |
|\ \ | | | | | | | Increase MAX_EVENTS_BEHIND for replication clients | ||||
| * | | Increase MAX_EVENTS_BEHIND for replication clients | Erik Johnston | 2020-02-21 | 1 | -1/+1 |
| | | | |||||
* | | | Merge branch 'master' into develop | Richard van der Hoff | 2020-02-21 | 2 | -6/+6 |
|\ \ \ | |/ / |/| / | |/ | |||||
| * | 1.11.0 v1.11.0 github/release-v1.11.0 release-v1.11.0 | Richard van der Hoff | 2020-02-21 | 1 | -1/+1 |
| | | |||||
| * | Small grammar fixes to the ACME v1 deprecation notice (#6944) | Andrew Morgan | 2020-02-21 | 1 | -5/+5 |
| | | | | | | Some small fixes to the copy in #6907. | ||||
* | | Do not send alias events when creating / upgrading a room (#6941) | Patrick Cloke | 2020-02-20 | 2 | -40/+15 |
| | | | | | | Stop emitting room alias update events during room creation/upgrade. | ||||
* | | don't insert into the device table for remote cross-signing keys (#6956) | Hubert Chathi | 2020-02-20 | 1 | -15/+18 |
| | | |||||
* | | Add some clarifications to README.md in the database schema directory. (#6615) | Ruben Barkow-Kuder | 2020-02-20 | 1 | -8/+16 |
| | | | | | | Signed-off-by: Ruben Barkow-Kuder <github@r.z11.de> | ||||
* | | Minor perf fixes to `get_auth_chain_ids`. | Erik Johnston | 2020-02-19 | 2 | -7/+5 |
| | | |||||
* | | Freeze allocated objects on startup. (#6953) | Erik Johnston | 2020-02-19 | 1 | -0/+9 |
| | | | | | | | | | | This may make gc go a bit faster as the gc will know things like caches/data stores etc. are frozen without having to check. | ||||
* | | Reduce auth chains fetched during v2 state res. (#6952) | Erik Johnston | 2020-02-19 | 3 | -11/+34 |
|/ | | | | | | The state res v2 algorithm only cares about the difference between auth chains, so we can pass in the known common state to the `get_auth_chain` storage function so that it can ignore those events. | ||||
* | 1.11.0rc1 | Richard van der Hoff | 2020-02-19 | 1 | -1/+1 |
| | |||||
* | Revert `get_auth_chain_ids` changes (#6951) | Erik Johnston | 2020-02-19 | 1 | -28/+0 |
| | |||||
* | Merge pull request #6949 from matrix-org/rav/list_room_aliases_peekable | Richard van der Hoff | 2020-02-19 | 7 | -84/+77 |
|\ | | | | | Make room alias lists peekable | ||||
| * | Make room alias lists peekable | Richard van der Hoff | 2020-02-19 | 1 | -1/+3 |
| | | | | | | | | | | | | As per https://github.com/matrix-org/matrix-doc/pull/2432#pullrequestreview-360566830, make room alias lists accessible to users outside world_readable rooms. | ||||
| * | Add `allow_departed_users` param to `check_in_room_or_world_readable` | Richard van der Hoff | 2020-02-19 | 5 | -15/+33 |
| | | | | | | | | | | | | | | ... and set it everywhere it's called. while we're here, rename it for consistency with `check_user_in_room` (and to help check that I haven't missed any instances) | ||||
| * | Refactor the membership check methods in Auth | Richard van der Hoff | 2020-02-18 | 3 | -71/+44 |
| | | | | | | | | | | these were getting a bit unwieldy, so let's combine `check_joined_room` and `check_user_was_in_room` into a single `check_user_in_room`. | ||||
* | | Move MSC2432 stuff onto unstable prefix (#6948) | Richard van der Hoff | 2020-02-19 | 2 | -1/+9 |
| | | | | | | it's not in the spec yet, so needs to be unstable. Also add a feature flag for it. Also add a test for admin users. | ||||
* | | Tiny optimisation for _get_handler_for_request (#6950) | Richard van der Hoff | 2020-02-19 | 1 | -1/+3 |
| | | | | | | | | we have hundreds of path_regexes (see #5118), so let's not convert the same bytes to str for each of them. | ||||
* | | Increase DB/CPU perf of `_is_server_still_joined` check. (#6936) | Erik Johnston | 2020-02-19 | 2 | -15/+59 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Increase DB/CPU perf of `_is_server_still_joined` check. For rooms with large amount of state a single user leaving could cause us to go and load a lot of membership events and then pull out membership state in a large number of batches. * Newsfile * Update synapse/storage/persist_events.py Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> * Fix adding if too soon * Update docstring * Review comments * Woops typo Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | ||||
* | | Merge pull request #6945 from matrix-org/babolivier/fix-retention-debug-log | Brendan Abolivier | 2020-02-19 | 1 | -1/+1 |
|\ \ | | | | | | | Fix log in message retention purge jobs | ||||
| * | | Fix log in message retention purge jobs | Brendan Abolivier | 2020-02-18 | 1 | -1/+1 |
| | | | |||||
* | | | Limit size of get_auth_chain_ids query (#6947) | Erik Johnston | 2020-02-19 | 1 | -18/+23 |
| |/ |/| | |||||
* | | Implement GET /_matrix/client/r0/rooms/{roomId}/aliases (#6939) | Richard van der Hoff | 2020-02-18 | 2 | -1/+39 |
| | | | | | | | | | | per matrix-org/matrix-doc#2432 | ||||
* | | Merge pull request #6872 from matrix-org/rav/dictproperty | Richard van der Hoff | 2020-02-18 | 1 | -81/+118 |
|\ \ | | | | | | | Rewrite _EventInternalMetadata to back it with a dict | ||||
| * | | Rewrite _EventInternalMetadata to back it with a _dict | Richard van der Hoff | 2020-02-14 | 1 | -16/+39 |
| | | | | | | | | | | | | Mostly, this gives mypy an easier time. | ||||
| * | | Replace _event_dict_property with DictProperty | Richard van der Hoff | 2020-02-14 | 1 | -65/+79 |
| | | | | | | | | | | | | | | | this amounts to the same thing, but replaces `_event_dict` with `_dict`, and removes some of the function layers generated by `property`. | ||||
* | | | Merge pull request #6907 from matrix-org/babolivier/acme-config | Brendan Abolivier | 2020-02-18 | 2 | -1/+34 |
|\ \ \ | |_|/ |/| | | Add mention and warning about ACME v1 deprecation to the TLS config | ||||
| * | | Make the log more noticeable | Brendan Abolivier | 2020-02-18 | 1 | -1/+2 |
| | | | |||||
| * | | Print the error as an error log and raise the same exception we got | Brendan Abolivier | 2020-02-18 | 1 | -9/+10 |
| | | | |||||
| * | | Linters are hard but in they end they just want what's best for us | Brendan Abolivier | 2020-02-13 | 1 | -1/+1 |
| | | | |||||
| * | | Lint | Brendan Abolivier | 2020-02-13 | 1 | -6/+7 |
| | | | |||||
| * | | Lint | Brendan Abolivier | 2020-02-13 | 1 | -7/+6 |
| | | | |||||
| * | | Add a separator for the config warning | Brendan Abolivier | 2020-02-13 | 1 | -1/+1 |
| | | | |||||
| * | | Add a comprehensive error when failing to register for an ACME account | Brendan Abolivier | 2020-02-13 | 1 | -1/+13 |
| | | | |||||
| * | | Add mention and warning about ACME v1 deprecation to the Synapse config | Brendan Abolivier | 2020-02-13 | 1 | -0/+19 |
| | | | |||||
* | | | Increase perf of `get_auth_chain_ids` used in state res v2. (#6937) | Erik Johnston | 2020-02-18 | 1 | -0/+23 |
| | | | | | | | | | We do this by moving the recursive query to be fully in the DB. | ||||
* | | | Stop sending events when creating or deleting aliases (#6904) | Patrick Cloke | 2020-02-18 | 2 | -40/+41 |
| | | | | | | | | | Stop sending events when creating or deleting associations (room aliases). Send an updated canonical alias event if one of the alt_aliases is deleted. | ||||
* | | | Merge branch 'master' into develop | Richard van der Hoff | 2020-02-17 | 1 | -1/+1 |
|\ \ \ | |||||
| * | | | 1.10.1 v1.10.1 github/release-v1.10.1 release-v1.10.1 | Richard van der Hoff | 2020-02-17 | 1 | -1/+1 |
| | | | | |||||
| * | | | wait for current_state_events_membership before ↵ | Richard van der Hoff | 2020-02-17 | 1 | -2/+5 |
| | | | | | | | | | | | | | | | | delete_old_current_state_events (#6924) | ||||
* | | | | Raise the default power levels for invites, tombstones and server acls (#6834) | Andrew Morgan | 2020-02-17 | 1 | -1/+9 |
| | | | | |||||
* | | | | wait for current_state_events_membership before ↵ | Richard van der Hoff | 2020-02-17 | 1 | -2/+5 |
| | | | | | | | | | | | | | | | | delete_old_current_state_events (#6924) | ||||
* | | | | Add type hints to the spam check module (#6915) | Patrick Cloke | 2020-02-14 | 2 | -22/+34 |
| | | | | | | | | | | | | | | | | Add typing information to the spam checker modules. | ||||
* | | | | Add a warning about indentation to generated config (#6920) | Richard van der Hoff | 2020-02-14 | 1 | -2/+14 |
| |_|/ |/| | | | | | Fixes #6916. | ||||
* | | | Filter the results of user directory searching via the spam checker (#6888) | Patrick Cloke | 2020-02-14 | 2 | -2/+39 |
| | | | | | | | | | Add a method to the spam checker to filter the user directory results. | ||||
* | | | Remove m.lazy_load_members from unstable features since it is in CS r0.5.0 ↵ | Aaron Raimist | 2020-02-13 | 1 | -1/+0 |
| |/ |/| | | | | | | | | | | | (#6877) Fixes #5528 | ||||
* | | Return a 404 for admin api user lookup if user not found (#6901) | Andrew Morgan | 2020-02-12 | 1 | -1/+4 |
| | | |||||
* | | Merge branch 'master' into develop | Brendan Abolivier | 2020-02-12 | 1 | -1/+1 |
|\| | |||||
| * | 1.10.0 | Brendan Abolivier | 2020-02-12 | 1 | -1/+1 |
| | | |||||
* | | Merge branch 'release-v1.10.0' into develop | Richard van der Hoff | 2020-02-11 | 1 | -1/+1 |
|\| | |||||
| * | 1.10.0rc5 v1.10.0rc5 | Richard van der Hoff | 2020-02-11 | 1 | -1/+1 |
| | | |||||
* | | Merge branch 'release-v1.10.0' into develop | Richard van der Hoff | 2020-02-11 | 2 | -1/+2 |
|\| | |||||
| * | 1.10.0rc4 | Richard van der Hoff | 2020-02-11 | 1 | -1/+1 |
| | | |||||
| * | filter out m.room.aliases from /sync state blocks (#6884) | Matthew Hodgson | 2020-02-10 | 1 | -0/+1 |
| | | | | | | We forgot to filter out aliases from /sync state blocks as well as the timeline. | ||||
* | | Reject device display names that are too long (#6882) | Patrick Cloke | 2020-02-10 | 1 | -1/+13 |
| | | | | | | | | | | | | | | | | * Reject device display names that are too long. Too long is currently defined as 100 characters in length. * Add a regression test for rejecting a too long device display name. | ||||
* | | Merge tag 'v1.10.0rc3' into develop | Richard van der Hoff | 2020-02-10 | 2 | -1/+8 |
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.10.0rc3 (2020-02-10) ============================== Features -------- - Filter out m.room.aliases from the CS API to mitigate abuse while a better solution is specced. ([\#6878](https://github.com/matrix-org/synapse/issues/6878)) Internal Changes ---------------- - Fix continuous integration failures with old versions of `pip`, which were introduced by a release of the `zipp` library. ([\#6880](https://github.com/matrix-org/synapse/issues/6880)) | ||||
| * | 1.10.0rc3 v1.10.0rc3 | Richard van der Hoff | 2020-02-10 | 1 | -1/+1 |
| | | |||||
| * | filter out m.room.aliases from the CS API until a better solution is specced ↵ | Matthew Hodgson | 2020-02-10 | 1 | -0/+7 |
| | | | | | | | | | | (#6878) We're in the middle of properly mitigating spam caused by malicious aliases being added to a room. However, until this work fully lands, we temporarily filter out all m.room.aliases events from /sync and /messages on the CS API, to remove abusive aliases. This is considered acceptable as m.room.aliases events were never a reliable record of the given alias->id mapping and were purely informational, and in their current state do more harm than good. | ||||
* | | Add support for putting fed user query API on workers (#6873) | Erik Johnston | 2020-02-07 | 3 | -21/+23 |
| | | |||||
* | | Remove unused `get_room_stats_state` method. (#6869) | Richard van der Hoff | 2020-02-07 | 1 | -25/+0 |
| | | |||||
* | | Add a `make_event_from_dict` method (#6858) | Richard van der Hoff | 2020-02-07 | 3 | -12/+19 |
| | | | | | | | | | | | | | | ... and use it in places where it's trivial to do so. This will make it easier to pass room versions into the FrozenEvent constructors. | ||||
* | | Add typing to synapse.federation.sender (#6871) | Erik Johnston | 2020-02-07 | 6 | -105/+130 |
| | | |||||
* | | Allow moving group read APIs to workers (#6866) | Erik Johnston | 2020-02-07 | 7 | -687/+713 |
| | | |||||
* | | Admin api to add an email address (#6789) | Dirk Klimpel | 2020-02-07 | 3 | -0/+49 |
| | | |||||
* | | remove unused room_version_to_event_format (#6857) | Richard van der Hoff | 2020-02-07 | 1 | -23/+1 |
| | | |||||
* | | Merge pull request #6856 from matrix-org/rav/redact_changes/6 | Richard van der Hoff | 2020-02-07 | 3 | -58/+46 |
|\ \ | | | | | | | Pass room_version into `event_from_pdu_json` | ||||
| * | | Pass room_version into `event_from_pdu_json` | Richard van der Hoff | 2020-02-06 | 3 | -58/+46 |
| | | | | | | | | | | | | It's called from all over the shop, so this one's a bit messy. | ||||
* | | | Limit the number of events that can be requested when backfilling events (#6864) | Patrick Cloke | 2020-02-06 | 1 | -0/+4 |
|/ / | | | | | Limit the maximum number of events requested when backfilling events. | ||||
* | | pass room version into FederationClient.send_join (#6854) | Richard van der Hoff | 2020-02-06 | 2 | -30/+33 |
| | | | | | | | | ... which allows us to sanity-check the create event. | ||||
* | | Allow empty federation_certificate_verification_whitelist (#6849) | timfi | 2020-02-06 | 1 | -0/+2 |
| | | |||||
* | | Third party event rules Update (#6781) | PeerD | 2020-02-06 | 2 | -4/+9 |
| | | |||||
* | | Reduce amount of logging at INFO level. (#6862) | Erik Johnston | 2020-02-06 | 11 | -21/+21 |
| | | | | | | | | | | | | | | | | A lot of the things we log at INFO are now a bit superfluous, so lets make them DEBUG logs to reduce the amount we log by default. Co-Authored-By: Brendan Abolivier <babolivier@matrix.org> Co-authored-by: Brendan Abolivier <github@brendanabolivier.com> | ||||
* | | Merge pull request #6823 from matrix-org/rav/redact_changes/5 | Richard van der Hoff | 2020-02-06 | 2 | -19/+13 |
|\ \ | | | | | | | pass room versions around | ||||
| * | | Simplify `room_version` handling in `FederationClient.send_invite` | Richard van der Hoff | 2020-02-05 | 1 | -10/+6 |
| | | | |||||
| * | | Pass room version object into `FederationClient.get_pdu` | Richard van der Hoff | 2020-02-05 | 2 | -9/+7 |
| | | | |||||
* | | | Merge tag 'v1.10.0rc2' into develop | Erik Johnston | 2020-02-06 | 7 | -22/+73 |
|\ \ \ | |/ / |/| / | |/ | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.10.0rc2 (2020-02-06) ============================== Bugfixes -------- - Fix an issue with cross-signing where device signatures were not sent to remote servers. ([\#6844](https://github.com/matrix-org/synapse/issues/6844)) - Fix to the unknown remote device detection which was introduced in 1.10.rc1. ([\#6848](https://github.com/matrix-org/synapse/issues/6848)) Internal Changes ---------------- - Detect unexpected sender keys on remote encrypted events and resync device lists. ([\#6850](https://github.com/matrix-org/synapse/issues/6850)) | ||||
| * | 1.10.0rc2 | Erik Johnston | 2020-02-06 | 1 | -1/+1 |
| | | |||||
| * | Check sender_key matches on inbound encrypted events. (#6850) | Erik Johnston | 2020-02-05 | 2 | -14/+66 |
| | | | | | | If they don't then the device lists are probably out of sync. | ||||
| * | Merge pull request #6844 from matrix-org/uhoreg/cross_signing_fix_device_fed | Hubert Chathi | 2020-02-05 | 1 | -0/+10 |
| | | | | | | add device signatures to device key query results | ||||
| * | Fix detecting unknown devices from remote encrypted events. (#6848) | Erik Johnston | 2020-02-04 | 5 | -7/+6 |
| | | | | | | | | | | | | | | | | We were looking at the wrong event type (`m.room.encryption` vs `m.room.encrypted`). Also fixup the duplicate `EvenTypes` entries. Introduced in #6776. | ||||
* | | Merge pull request #6840 from matrix-org/rav/federation_client_async | Richard van der Hoff | 2020-02-05 | 1 | -136/+142 |
|\ \ | | | | | | | Port much of `synapse.federation.federation_client` to async/await | ||||
| * | | make FederationClient._do_send_invite async | Richard van der Hoff | 2020-02-05 | 1 | -10/+7 |
| | | | |||||
| * | | Apply suggestions from code review | Richard van der Hoff | 2020-02-05 | 1 | -2/+4 |
| | | | | | | | | | Co-Authored-By: Erik Johnston <erik@matrix.org> | ||||
| * | | Merge remote-tracking branch 'origin/develop' into rav/federation_client_async | Richard van der Hoff | 2020-02-04 | 3 | -348/+379 |
| |\ \ | |||||
| * | | | make FederationClient.send_invite async | Richard van der Hoff | 2020-02-03 | 1 | -6/+5 |
| | | | | |||||
| * | | | make FederationClient.get_missing_events async | Richard van der Hoff | 2020-02-03 | 1 | -20/+20 |
| | | | | |||||
| * | | | make FederationClient._do_send_leave async | Richard van der Hoff | 2020-02-03 | 1 | -4/+3 |
| | | | | |||||
| * | | | make FederationClient.send_leave.send_request async | Richard van der Hoff | 2020-02-03 | 1 | -5/+2 |
| | | | | |||||
| * | | | make FederationClient._do_send_join async | Richard van der Hoff | 2020-02-03 | 1 | -4/+3 |
| | | | | |||||
| * | | | make FederationClient.send_join.send_request async | Richard van der Hoff | 2020-02-03 | 1 | -4/+3 |
| | | | | |||||
| * | | | make FederationClient.make_membership_event.send_request async | Richard van der Hoff | 2020-02-03 | 1 | -4/+3 |
| | | | | |||||
| * | | | make FederationClient._try_destination_list async | Richard van der Hoff | 2020-02-03 | 1 | -10/+26 |
| | | | | |||||
| * | | | make FederationClient.send_leave async | Richard van der Hoff | 2020-02-03 | 1 | -10/+9 |
| | | | | |||||
| * | | | make FederationClient.send_join async | Richard van der Hoff | 2020-02-03 | 1 | -11/+13 |
| | | | | |||||
| * | | | make FederationClient.make_membership_event async | Richard van der Hoff | 2020-02-03 | 1 | -10/+11 |
| | | | | |||||
| * | | | make FederationClient.get_event_auth async | Richard van der Hoff | 2020-02-03 | 1 | -6/+4 |
| | | | | |||||
| * | | | make FederationClient.get_room_state_ids async | Richard van der Hoff | 2020-02-03 | 1 | -4/+5 |
| | | | | |||||
| * | | | make FederationClient.get_pdu async | Richard van der Hoff | 2020-02-03 | 1 | -15/+17 |
| | | | | |||||
| * | | | make FederationClient.backfill async | Richard van der Hoff | 2020-02-03 | 1 | -15/+11 |
| | | | | |||||
* | | | | Reduce performance logging to DEBUG (#6833) | Michael Kaye | 2020-02-05 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | * Reduce tnx performance logging to DEBUG * Changelog.d | ||||
* | | | | Database updates to populate rooms.room_version (#6847) | Richard van der Hoff | 2020-02-04 | 2 | -0/+57 |
| | | | | | | | | | | | | We're going to need this so that we can figure out how to handle redactions when fetching events from the database. | ||||
* | | | | Merge pull request #6844 from matrix-org/uhoreg/cross_signing_fix_device_fed | Hubert Chathi | 2020-02-04 | 1 | -0/+10 |
|\ \ \ \ | |_|/ / |/| | | | add device signatures to device key query results | ||||
| * | | | add device signatures to device key query results | Hubert Chathi | 2020-02-04 | 1 | -0/+10 |
| | | | | |||||
* | | | | Merge pull request #6837 from matrix-org/rav/federation_async | Richard van der Hoff | 2020-02-04 | 3 | -235/+211 |
|\ \ \ \ | |/ / / |/| / / | |/ / | Port much of `synapse.handlers.federation` to async/await. | ||||
| * | | make FederationHandler.send_invite async | Richard van der Hoff | 2020-02-03 | 2 | -6/+4 |
| | | | |||||
| * | | make FederationHandler.on_get_missing_events async | Richard van der Hoff | 2020-02-03 | 1 | -5/+4 |
| | | | |||||
| * | | make FederationHandler.user_joined_room async | Richard van der Hoff | 2020-02-03 | 1 | -3/+3 |
| | | | |||||
| * | | make FederationHandler._clean_room_for_join async | Richard van der Hoff | 2020-02-03 | 1 | -4/+4 |
| | | | |||||
| * | | make FederationHandler._notify_persisted_event async | Richard van der Hoff | 2020-02-03 | 1 | -4/+6 |
| | | | |||||
| * | | make FederationHandler.persist_events_and_notify async | Richard van der Hoff | 2020-02-03 | 1 | -10/+10 |
| | | | |||||
| * | | make FederationHandler._make_and_verify_event async | Richard van der Hoff | 2020-02-03 | 1 | -5/+10 |
| | | | |||||
| * | | make FederationHandler.do_remotely_reject_invite async | Richard van der Hoff | 2020-02-03 | 2 | -8/+11 |
| | | | |||||
| * | | make FederationHandler._check_for_soft_fail async | Richard van der Hoff | 2020-02-03 | 1 | -13/+9 |
| | | | |||||
| * | | make FederationHandler._persist_auth_tree async | Richard van der Hoff | 2020-02-03 | 1 | -11/+7 |
| | | | |||||
| * | | make FederationHandler.do_invite_join async | Richard van der Hoff | 2020-02-03 | 2 | -18/+18 |
| | | | |||||
| * | | make FederationHandler.on_event_auth async | Richard van der Hoff | 2020-02-03 | 1 | -5/+4 |
| | | | |||||
| * | | make FederationHandler.on_exchange_third_party_invite_request async | Richard van der Hoff | 2020-02-03 | 1 | -14/+12 |
| | | | |||||
| * | | make FederationHandler.construct_auth_difference async | Richard van der Hoff | 2020-02-03 | 1 | -3/+4 |
| | | | |||||
| * | | make FederationHandler._update_context_for_auth_events async | Richard van der Hoff | 2020-02-03 | 1 | -10/+10 |
| | | | |||||
| * | | make FederationHandler._update_auth_events_and_context_for_auth async | Richard van der Hoff | 2020-02-03 | 1 | -20/+21 |
| | | | |||||
| * | | make FederationHandler.do_auth async | Richard van der Hoff | 2020-02-03 | 1 | -10/+14 |
| | | | |||||
| * | | make FederationHandler._prep_event async | Richard van der Hoff | 2020-02-03 | 1 | -23/+10 |
| | | | |||||
| * | | make FederationHandler._handle_new_event async | Richard van der Hoff | 2020-02-03 | 1 | -6/+7 |
| | | | |||||
| * | | make FederationHandler._handle_new_events async | Richard van der Hoff | 2020-02-03 | 1 | -8/+6 |
| | | | |||||
| * | | make FederationHandler.on_make_leave_request async | Richard van der Hoff | 2020-02-03 | 1 | -13/+10 |
| | | | |||||
| * | | make FederationHandler.on_send_leave_request async | Richard van der Hoff | 2020-02-03 | 1 | -5/+3 |
| | | | |||||
| * | | make FederationHandler.on_make_join_request async | Richard van der Hoff | 2020-02-03 | 1 | -13/+10 |
| | | | |||||
| * | | make FederationHandler.on_invite_request async | Richard van der Hoff | 2020-02-03 | 1 | -5/+4 |
| | | | |||||
| * | | make FederationHandler.on_send_join_request async | Richard van der Hoff | 2020-02-03 | 1 | -9/+7 |
| | | | |||||
| * | | make FederationHandler.on_query_auth async | Richard van der Hoff | 2020-02-03 | 1 | -7/+6 |
| | | | |||||
* | | | Add typing to SyncHandler (#6821) | Erik Johnston | 2020-02-03 | 2 | -348/+375 |
| | | | | | | | | | | | | Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | ||||
* | | | Fix stacktraces when using ObservableDeferred and async/await (#6836) | Erik Johnston | 2020-02-03 | 1 | -0/+4 |
|/ / | |||||
* | | Allow URL-encoded user IDs on user admin api paths (#6825) | Andrew Morgan | 2020-02-03 | 1 | -2/+2 |
| | | |||||
* | | Fix `room_version` in `on_invite_request` flow (#6827) | Richard van der Hoff | 2020-02-03 | 2 | -7/+10 |
|/ | | | | I messed this up a bit in #6805, but fortunately we weren't actually doing anything with the room_version so it didn't matter that it was a str not a RoomVersion. | ||||
* | 1.10.0rc1 | Erik Johnston | 2020-01-31 | 1 | -1/+1 |
| | |||||
* | Fix deleting of stale marker for device lists (#6819) | Erik Johnston | 2020-01-31 | 1 | -7/+7 |
| | | | | We were in fact only deleting stale marker when we got an incremental update, rather than when we did a full resync. | ||||
* | pass room_version into compute_event_signature (#6807) | Richard van der Hoff | 2020-01-31 | 2 | -9/+24 |
| | |||||
* | Merge pull request #6806 from matrix-org/rav/redact_changes/3 | Richard van der Hoff | 2020-01-31 | 3 | -37/+39 |
|\ | | | | | Pass room_version into add_hashes_and_signatures | ||||
| * | Pass room_version into add_hashes_and_signatures | Richard van der Hoff | 2020-01-30 | 2 | -8/+14 |
| | | |||||
| * | Pass room_version into create_local_event_from_event_dict | Richard van der Hoff | 2020-01-30 | 2 | -25/+19 |
| | | |||||
| * | Store the room version in EventBuilder | Richard van der Hoff | 2020-01-30 | 1 | -5/+7 |
| | | |||||
* | | Merge pull request #6820 from matrix-org/rav/get_room_version_id | Richard van der Hoff | 2020-01-31 | 10 | -35/+58 |
|\ \ | | | | | | | Make `get_room_version` return a RoomVersion object | ||||
| * | | Add `get_room_version` method | Richard van der Hoff | 2020-01-31 | 2 | -5/+26 |
| | | | | | | | | | | | | So that we can start factoring out some of this boilerplatey boilerplate. | ||||
| * | | s/get_room_version/get_room_version_id/ | Richard van der Hoff | 2020-01-31 | 9 | -30/+32 |
| | | | | | | | | | | | | | | | ... to make way for a forthcoming get_room_version which returns a RoomVersion object. | ||||
* | | | Fix bug with getting missing auth event during join 500'ed (#6810) | Erik Johnston | 2020-01-31 | 1 | -1/+5 |
|/ / | |||||
* | | pass room version into FederationHandler.on_invite_request (#6805) | Richard van der Hoff | 2020-01-30 | 2 | -4/+4 |
| | | |||||
* | | Log when we delete room in bg update (#6816) | Erik Johnston | 2020-01-30 | 1 | -0/+2 |
|/ | |||||
* | MSC2260: Block direct sends of m.room.aliases events (#6794) | Richard van der Hoff | 2020-01-30 | 1 | -0/+12 |
| | | | | | as per MSC2260 | ||||
* | Backgroud update to clean out rooms from current state (#6802) | Erik Johnston | 2020-01-30 | 2 | -2/+125 |
| | |||||
* | Resync remote device list when detected as stale. (#6786) | Erik Johnston | 2020-01-30 | 2 | -4/+24 |
| | |||||
* | Fix sending server up commands from workers (#6811) | Erik Johnston | 2020-01-30 | 4 | -13/+34 |
| | | | | Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> | ||||
* | When server leaves room check for stale device lists. (#6801) | Erik Johnston | 2020-01-30 | 2 | -6/+82 |
| | | | | | | | | | When a server leaves a room it may stop sharing a room with remote users, and thus not get any updates to their device lists. So we need to check for this case and delete those device lists from the cache. We don't need to do this if we stop sharing a room because the remote user leaves the room, because we track that case via looking at membership changes. | ||||
* | When a client asks for remote keys check if should resync. (#6797) | Erik Johnston | 2020-01-30 | 1 | -3/+29 |
| | | | | | | If we detect that the remote users' keys may have changed then we should attempt to resync against the remote server rather than using the (potentially) stale local cache. | ||||
* | Type defintions for use in refactoring for redaction changes (#6803) | Richard van der Hoff | 2020-01-30 | 3 | -4/+12 |
| | | | | | | | | | | * Bump signedjson to 1.1 ... so that we can use the type definitions * Fix breakage caused by upgrade to signedjson 1.1 Thanks, @illicitonion... | ||||
* | Remove unused DeviceRow class (#6800) | Erik Johnston | 2020-01-29 | 1 | -20/+1 |
| | |||||
* | Make /directory/room/<alias> handle restrictive power levels | Richard van der Hoff | 2020-01-29 | 1 | -1/+6 |
| | | | | | Fixes a bug where the alias would be added, but `PUT /directory/room/<alias>` would return a 403. | ||||
* | Set the PL for aliases events to 0. | Richard van der Hoff | 2020-01-29 | 2 | -3/+16 |
| | |||||
* | Factor out a `copy_power_levels_contents` method | Richard van der Hoff | 2020-01-29 | 2 | -13/+47 |
| | | | | I'm going to need another copy (hah!) of this. | ||||
* | Fix race in federation sender that delayed device updates. (#6799) | Erik Johnston | 2020-01-29 | 2 | -30/+22 |
| | | | | | | | | | | | | We were sending device updates down both the federation stream and device streams. This mean there was a race if the federation sender worker processed the federation stream first, as when the sender checked if there were new device updates the slaved ID generator hadn't been updated with the new stream IDs and so returned nothing. This situation is correctly handled by events/receipts/etc by not sending updates down the federation stream and instead having the federation sender worker listen on the other streams and poke the transaction queues as appropriate. | ||||
* | Delete current state when server leaves a room (#6792) | Erik Johnston | 2020-01-29 | 2 | -75/+197 |
| | | | | | | Otherwise its just stale data, which may get deleted later anyway so can't be relied on. It's also a bit of a shotgun if we're trying to get the current state of a room we're not in. | ||||
* | Fix bug when querying remote user keys that require a resync. (#6796) | Erik Johnston | 2020-01-29 | 1 | -1/+2 |
| | | | | We ended up only returning a single device, rather than all of them. | ||||
* | Fix outbound federation request metrics (#6795) | Erik Johnston | 2020-01-28 | 1 | -0/+4 |
| | |||||
* | Merge pull request #6787 from matrix-org/rav/msc2260 | Richard van der Hoff | 2020-01-28 | 2 | -5/+35 |
|\ | | | | | Implement updated auth rules from MSC2260 | ||||
| * | fix bad variable ref | Richard van der Hoff | 2020-01-28 | 1 | -1/+1 |
| | | |||||
| * | Implement updated auth rules from MSC2260 | Richard van der Hoff | 2020-01-28 | 2 | -5/+35 |
| | | |||||
* | | Detect unknown remote devices and mark cache as stale (#6776) | Erik Johnston | 2020-01-28 | 5 | -8/+125 |
|/ | | | | We just mark the fact that the cache may be stale in the database for now. | ||||
* | Pass room version object into event_auth.check and check_redaction (#6788) | Richard van der Hoff | 2020-01-28 | 6 | -27/+48 |
| | | | | | | | These are easier to work with than the strings and we normally have one around. This fixes `FederationHander._persist_auth_tree` which was passing a RoomVersion object into event_auth.check instead of a string. | ||||
* | Warn if postgres database has non-C locale. (#6734) | Erik Johnston | 2020-01-28 | 3 | -0/+52 |
| | | | As using non-C locale can cause issues on upgrading OS. | ||||
* | Merge branch 'master' into develop | Erik Johnston | 2020-01-28 | 2 | -2/+8 |
|\ | |||||
| * | 1.9.1 v1.9.1 github/release-v1.9.1 release-v1.9.1 | Erik Johnston | 2020-01-28 | 1 | -1/+1 |
| | | |||||
| * | Fix setting `mau_limit_reserved_threepids` config (#6793) | Erik Johnston | 2020-01-28 | 1 | -1/+7 |
| | | | | | | | | | | Calling the invalidation function during initialisation of the data stores introduces a circular dependency, causing Synapse to fail to start. | ||||
* | | Add `rooms.room_version` column (#6729) | Erik Johnston | 2020-01-27 | 7 | -71/+251 |
| | | | | | | This is so that we don't have to rely on pulling it out from `current_state_events` table. | ||||
* | | Propagate cache invalidates from workers to other workers. (#6748) | Erik Johnston | 2020-01-27 | 3 | -5/+28 |
| | | | | | | Currently if a worker invalidates a cache it will be streamed to master, which then didn't forward those to other workers. | ||||
* | | Validate client_secret parameter (#6767) | Andrew Morgan | 2020-01-24 | 4 | -6/+41 |
| | | |||||
* | | Make 'event.redacts' never raise. (#6771) | Erik Johnston | 2020-01-23 | 3 | -6/+26 |
| | | | | | | | | | | | | There are quite a few places that we assume that a redaction event has a corresponding `redacts` key, which is not always the case. So lets cheekily make it so that event.redacts just returns None instead. | ||||
* | | Merge branch 'master' into develop | Brendan Abolivier | 2020-01-23 | 1 | -1/+1 |
|\| |