summary refs log tree commit diff
path: root/synapse (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Port some admin handlers to async/await (#6559)Erik Johnston2019-12-193-56/+45
|
* Improve diagnostics on database upgrade failure (#6570)Richard van der Hoff2019-12-192-8/+6
| | | | `Failed to upgrade database` is not helpful, and it's unlikely that UPGRADE.rst has anything useful.
* Fix sdnotify with acme enabled (#6571)Richard van der Hoff2019-12-191-3/+7
| | | | | | | If acme was enabled, the sdnotify startup hook would never be run because we would try to add it to a hook which had already fired. There's no need to delay it: we can sdnotify as soon as we've started the listeners.
* Add an export_signing_key script (#6546)Richard van der Hoff2019-12-191-8/+15
| | | | | I want to do some key rotation, and it is silly that we don't have a way to do this.
* Clean up startup for the pusher (#6558)Richard van der Hoff2019-12-184-43/+37
| | | | | | | | | | | | | | | | | | | | | | | * Remove redundant python2 support code `str.decode()` doesn't exist on python3, so presumably this code was doing nothing * Filter out pushers with corrupt data When we get a row with unparsable json, drop the row, rather than returning a row with null `data`, which will then cause an explosion later on. * Improve logging when we can't start a pusher Log the ID to help us understand the problem * Make email pusher setup more robust We know we'll have a `data` member, since that comes from the database. What we *don't* know is if that is a dict, and if that has a `brand` member, and if that member is a string.
* Add delta file to fix missing default table data (#6555)Andrew Morgan2019-12-183-15/+23
|
* Add database config class (#6513)Erik Johnston2019-12-189-73/+160
| | | | | This encapsulates config for a given database and is the way to get new connections.
* Merge branch 'master' into developRichard van der Hoff2019-12-181-1/+1
|\
| * 1.7.1Richard van der Hoff2019-12-181-1/+1
| |
* | Merge release-v1.7.1 into developRichard van der Hoff2019-12-184-10/+16
|\|
| * Fix bug where we added duplicate event IDs as auth_events (#6560)Erik Johnston2019-12-171-7/+8
| |
| * Add auth events as per spec. (#6556)Erik Johnston2019-12-161-67/+34
| | | | | | | | | | Previously we tried to be clever and filter out some unnecessary event IDs to keep the auth chain small, but that had some annoying interactions with state res v2 so we stop doing that for now.
| * Merge pull request #6553 from matrix-org/babolivier/fix-context-filterBrendan Abolivier2019-12-162-3/+7
| |\ | | | | | | Use the filtered version of an event when responding to /context requests for that event
| | * Incorporate reviewBrendan Abolivier2019-12-161-1/+1
| | |
| | * Update the documentation of the filtering functionBrendan Abolivier2019-12-161-1/+2
| | |
| | * Use the filtered version of an event when responding to /context requests ↵Brendan Abolivier2019-12-161-1/+4
| | | | | | | | | | | | | | | | | | for that event Sometimes the filtering function can return a pruned version of an event (on top of either the event itself or an empty list), if it thinks the user should be able to see that there's an event there but not the content of that event. Therefore, the previous logic of 'if filtered is empty then we can use the event we retrieved from the database' is flawed, and we should use the event returned by the filtering function.
| * | Exclude rejected state events when calculating state at backwards extrems ↵Richard van der Hoff2019-12-161-1/+1
| | | | | | | | | | | | | | | (#6527) This fixes a weird bug where, if you were determined enough, you could end up with a rejected event forming part of the state at a backwards-extremity. Authing that backwards extrem would then lead to us trying to pull the rejected event from the db (with allow_rejected=False), which would fail with a 404.
| * | Persist auth/state events at backwards extremities when we fetch them (#6526)Richard van der Hoff2019-12-162-165/+82
| | | | | | | | | | | | The main point here is to make sure that the state returned by _get_state_in_room has been authed before we try to use it as state in the room.
| * | sanity-checking for events used in state res (#6531)Richard van der Hoff2019-12-164-43/+124
| | | | | | | | | | | | | | | When we perform state resolution, check that all of the events involved are in the right room.
| * | Sanity-check room ids in event auth (#6530)Richard van der Hoff2019-12-161-0/+12
| | | | | | | | | | | | When we do an event auth operation, check that all of the events involved are in the right room.
| * | Check the room_id of events when fetching room state/auth (#6524)Richard van der Hoff2019-12-161-24/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we request the state/auth_events to populate a backwards extremity (on backfill or in the case of missing events in a transaction push), we should check that the returned events are in the right room rather than blindly using them in the room state or auth chain. Given that _get_events_from_store_or_dest takes a room_id, it seems clear that it should be sanity-checking the room_id of the requested events, so let's do it there.
| * | Add `include_event_in_state` to _get_state_for_room (#6521)Richard van der Hoff2019-12-161-18/+21
| | | | | | | | | | | | | | | | | | Make it return the state *after* the requested event, rather than the one before it. This is a bit easier and requires fewer calls to get_events_from_store_or_dest.
| * | Move get_state methods into FederationHandler (#6503)Richard van der Hoff2019-12-162-86/+106
| | | | | | | | | | | | | | | This is a non-functional refactor as a precursor to some other work.
| * | Refactor get_events_from_store_or_dest to return a dict (#6501)Richard van der Hoff2019-12-161-29/+15
| |/ | | | | | | | | There was a bunch of unnecessary conversion back and forth between dict and list going on here. We can simplify a bunch of the code.
* | Remove unused `get_pagination_rows` methods. (#6557)Erik Johnston2019-12-173-18/+0
| | | | | | Remove unused get_pagination_rows methods
* | Add auth events as per spec. (#6556)Erik Johnston2019-12-161-67/+34
| | | | | | | | | | Previously we tried to be clever and filter out some unnecessary event IDs to keep the auth chain small, but that had some annoying interactions with state res v2 so we stop doing that for now.
* | Add option to allow profile queries without sharing a room (#6523)Will Hunt2019-12-162-1/+18
| |
* | Exclude rejected state events when calculating state at backwards extrems ↵Richard van der Hoff2019-12-161-1/+1
| | | | | | | | | | (#6527) This fixes a weird bug where, if you were determined enough, you could end up with a rejected event forming part of the state at a backwards-extremity. Authing that backwards extrem would then lead to us trying to pull the rejected event from the db (with allow_rejected=False), which would fail with a 404.
* | Persist auth/state events at backwards extremities when we fetch them (#6526)Richard van der Hoff2019-12-162-169/+82
| | | | | | The main point here is to make sure that the state returned by _get_state_in_room has been authed before we try to use it as state in the room.
* | Automatically delete empty groups/communities (#6453)Werner Sembach2019-12-162-0/+34
| | | | | | Signed-off-by: Werner Sembach <werner.sembach@fau.de>
* | sanity-checking for events used in state res (#6531)Richard van der Hoff2019-12-134-43/+124
| | | | | | | | | | | | | | When we perform state resolution, check that all of the events involved are in the right room.
* | Sanity-check room ids in event auth (#6530)Richard van der Hoff2019-12-131-0/+12
| | | | | | | | When we do an event auth operation, check that all of the events involved are in the right room.
* | Merge pull request #6537 from matrix-org/erikj/bump_mypy_versionErik Johnston2019-12-136-6/+11
|\ \ | | | | | | Bump mypy version
| * | Bump version of mypyErik Johnston2019-12-126-6/+11
| | |
* | | Merge branch 'master' into developErik Johnston2019-12-131-1/+1
|\ \ \ | | |/ | |/|
| * | 1.7.0Erik Johnston2019-12-131-1/+1
| | |
* | | Merge pull request #6496 from matrix-org/erikj/initial_sync_asnycErik Johnston2019-12-131-52/+44
|\ \ \ | | | | | | | | Port synapse.handlers.initial_sync to async/await
| * \ \ Merge branch 'develop' of github.com:matrix-org/synapse into ↵Erik Johnston2019-12-1170-693/+1121
| |\ \ \ | | | | | | | | | | | | | | | erikj/initial_sync_asnyc
| * | | | Port synapse.handlers.initial_sync to async/awaitErik Johnston2019-12-091-52/+44
| | | | |
* | | | | look up cross-signing keys from the DB in bulk (#6486)Hubert Chathi2019-12-123-13/+241
| | | | |
* | | | | Fix redacted events being returned in search results ordered by "recent" (#6522)Andrew Morgan2019-12-121-3/+8
| |_|_|/ |/| | |
* | | | Check the room_id of events when fetching room state/auth (#6524)Richard van der Hoff2019-12-121-23/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we request the state/auth_events to populate a backwards extremity (on backfill or in the case of missing events in a transaction push), we should check that the returned events are in the right room rather than blindly using them in the room state or auth chain. Given that _get_events_from_store_or_dest takes a room_id, it seems clear that it should be sanity-checking the room_id of the requested events, so let's do it there.
* | | | Merge pull request #6511 from matrix-org/erikj/remove_db_config_from_appsErik Johnston2019-12-1213-62/+12
|\ \ \ \ | |_|/ / |/| | | Move database config from apps into HomeServer object
| * | | Add new config param to docstring and add typesErik Johnston2019-12-111-1/+3
| | | |
| * | | Remove database config parsing from apps.Erik Johnston2019-12-1013-62/+10
| | | |
* | | | Add `include_event_in_state` to _get_state_for_room (#6521)Richard van der Hoff2019-12-111-22/+28
| | | | | | | | | | | | | | | | | | | | Make it return the state *after* the requested event, rather than the one before it. This is a bit easier and requires fewer calls to get_events_from_store_or_dest.
* | | | Merge pull request #6517 from matrix-org/rav/event_auth/13Richard van der Hoff2019-12-112-98/+88
|\ \ \ \ | | | | | | | | | | Port some of FederationHandler to async/await
| * | | | convert to async: FederationHandler._process_received_pduRichard van der Hoff2019-12-111-11/+10
| | | | | | | | | | | | | | | | | | | | also fix user_joined_room to consistently return deferreds
| * | | | convert to async: FederationHandler._get_state_for_roomRichard van der Hoff2019-12-111-21/+21
| | | | | | | | | | | | | | | | | | | | ... and _get_events_from_store_or_dest
| * | | | convert to async: FederationHandler.on_receive_pduRichard van der Hoff2019-12-111-27/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | and associated functions: * on_receive_pdu * handle_queued_pdus * get_missing_events_for_pdu
| * | | | Convert federation backfill to asyncRichard van der Hoff2019-12-112-39/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PaginationHandler.get_messages is only called by RoomMessageListRestServlet, which is async. Chase the code path down from there: - FederationHandler.maybe_backfill (and nested try_backfill) - FederationHandler.backfill
* | | | | Merge pull request #6504 from matrix-org/erikj/account_validity_async_awaitErik Johnston2019-12-112-55/+45
|\ \ \ \ \ | |/ / / / |/| | | | Port handlers.account_validity to async/await.
| * | | | Port handlers.account_validity to async/await.Erik Johnston2019-12-102-47/+41
| | | | |
| * | | | Port handlers.account_data to async/await.Erik Johnston2019-12-101-9/+5
| |/ / /
* | | | Clean up some logging (#6515)Richard van der Hoff2019-12-111-18/+19
| | | | | | | | | | | | | | | | This just makes some of the logging easier to follow when things start going wrong.
* | | | Merge tag 'v1.7.0rc2' into developErik Johnston2019-12-114-8/+18
|\ \ \ \ | | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.7.0rc2 (2019-12-11) ============================= Bugfixes -------- - Fix incorrect error message for invalid requests when setting user's avatar URL. ([\#6497](https://github.com/matrix-org/synapse/issues/6497)) - Fix support for SQLite 3.7. ([\#6499](https://github.com/matrix-org/synapse/issues/6499)) - Fix regression where sending email push would not work when using a pusher worker. ([\#6507](https://github.com/matrix-org/synapse/issues/6507), [\#6509](https://github.com/matrix-org/synapse/issues/6509))
| * | | 1.7.0rc2 v1.7.0rc2Erik Johnston2019-12-111-1/+1
| | | |
| * | | Back out change preventing setting null avatar URLsErik Johnston2019-12-111-6/+6
| | | |
| * | | Merge branch 'erikj/fix_sqlite_7' of github.com:matrix-org/synapse into ↵Erik Johnston2019-12-116-14/+49
| |\ \ \ | | | | | | | | | | | | | | | release-v1.7.0
| * | | | Give the server config to the RoomWorkerStoreBrendan Abolivier2019-12-101-0/+5
| | | | |
| * | | | Make the PusherSlaveStore inherit from the slave RoomStoreBrendan Abolivier2019-12-101-1/+6
| | | | | | | | | | | | | | | | | | | | So that it has access to the get_retention_policy_for_room function which is required by filter_events_for_client.
* | | | | Prevent redacted events from appearing in message search (#6377)Andrew Morgan2019-12-115-43/+77
| | | | |
* | | | | Add dev script to generate full SQL schema files (#6394)Andrew Morgan2019-12-112-19/+13
| | | | |
* | | | | Prevent message search in upgraded rooms we're not in (#6385)Andrew Morgan2019-12-113-16/+40
| | | | |
* | | | | Merge pull request #6349 from matrix-org/babolivier/msc1802Brendan Abolivier2019-12-114-28/+140
|\ \ \ \ \ | | | | | | | | | | | | Implement v2 APIs for send_join and send_leave
| * \ \ \ \ Merge branch 'develop' into babolivier/msc1802Brendan Abolivier2019-12-05147-2521/+3950
| |\ \ \ \ \
| * | | | | | LintBrendan Abolivier2019-11-111-3/+2
| | | | | | |
| * | | | | | LintBrendan Abolivier2019-11-111-3/+1
| | | | | | |
| * | | | | | Fix prefix for v2/send_leaveBrendan Abolivier2019-11-111-0/+2
| | | | | | |
| * | | | | | Add server-side support to the v2 APIBrendan Abolivier2019-11-112-14/+33
| | | | | | |
| * | | | | | Implement v2 API for send_leaveBrendan Abolivier2019-11-112-5/+56
| | | | | | |
| * | | | | | Add missing yieldBrendan Abolivier2019-11-111-1/+1
| | | | | | |
| * | | | | | Implement v2 API for send_joinBrendan Abolivier2019-11-112-8/+51
| | | | | | |
* | | | | | | Move get_state methods into FederationHandler (#6503)Richard van der Hoff2019-12-102-86/+106
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a non-functional refactor as a precursor to some other work.
* | | | | | | Allow SAML username provider plugins (#6411)Andrew Morgan2019-12-102-88/+296
| | | | | | |
* | | | | | | Merge pull request #6510 from matrix-org/erikj/phone_home_stats_dbErik Johnston2019-12-101-2/+4
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Phone home stats DB reporting should not assume a single DB.
| * | | | | | | Phone home stats DB reporting should not assume a single DB.Erik Johnston2019-12-101-2/+4
| | |_|_|_|/ / | |/| | | | |
* | | | | | | Fix race which caused deleted devices to reappear (#6514)Richard van der Hoff2019-12-101-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Stop the `update_client_ips` background job from recreating deleted devices.
* | | | | | | Refactor get_events_from_store_or_dest to return a dict (#6501)Richard van der Hoff2019-12-101-29/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There was a bunch of unnecessary conversion back and forth between dict and list going on here. We can simplify a bunch of the code.
* | | | | | | Remove redundant code from event authorisation implementation. (#6502)Richard van der Hoff2019-12-101-6/+2
| | | | | | |
* | | | | | | Merge pull request #6505 from matrix-org/erikj/make_deferred_yiedableErik Johnston2019-12-101-1/+10
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Fix `make_deferred_yieldable` to work with coroutines
| * | | | | | | Update commentErik Johnston2019-12-101-2/+4
| | | | | | | |
| * | | | | | | Fix make_deferred_yieldable to work with coroutinesErik Johnston2019-12-101-1/+8
| |/ / / / / /
* | | | | | | Merge pull request #6499 from matrix-org/erikj/fix_sqlite_7Erik Johnston2019-12-105-11/+41
|\ \ \ \ \ \ \ | | |_|_|_|/ / | |/| | | | | Fix support for SQLite 3.7.
| * | | | | | Drop unused indexErik Johnston2019-12-104-13/+18
| | | | | | |
| * | | | | | Convert _censor_redactions to async since it awaits on coroutinesErik Johnston2019-12-101-11/+9
| | | | | | |
| * | | | | | Only start censor background job after indices are createdErik Johnston2019-12-102-2/+9
| | | | | | |
| * | | | | | Fix support for SQLite 3.7.Erik Johnston2019-12-093-2/+22
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | Partial indices support was added in 3.8.0, so we need to use the background updates that handles this correctly.
* | | | | | Merge pull request #6506 from matrix-org/erikj/remove_snapshot_cacheErik Johnston2019-12-102-105/+8
|\ \ \ \ \ \ | |/ / / / / |/| | | | / | | |_|_|/ | |/| | | Remove SnapshotCache in favour of ResponseCache
| * | | | Remove SnapshotCache in favour of ResponseCacheErik Johnston2019-12-092-105/+8
| | | | |
* | | | | Merge tag 'v1.7.0rc1' into developNeil Johnson2019-12-091-1/+1
|\ \ \ \ \ | | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.7.0rc1 (2019-12-09) ============================= Features -------- - Implement per-room message retention policies. ([\#5815](https://github.com/matrix-org/synapse/issues/5815), [\#6436](https://github.com/matrix-org/synapse/issues/6436)) - Add etag and count fields to key backup endpoints to help clients guess if there are new keys. ([\#5858](https://github.com/matrix-org/synapse/issues/5858)) - Add `/admin/v2/users` endpoint with pagination. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#5925](https://github.com/matrix-org/synapse/issues/5925)) - Require User-Interactive Authentication for `/account/3pid/add`, meaning the user's password will be required to add a third-party ID to their account. ([\#6119](https://github.com/matrix-org/synapse/issues/6119)) - Implement the `/_matrix/federation/unstable/net.atleastfornow/state/<context>` API as drafted in MSC2314. ([\#6176](https://github.com/matrix-org/synapse/issues/6176)) - Configure privacy-preserving settings by default for the room directory. ([\#6354](https://github.com/matrix-org/synapse/issues/6354)) - Add ephemeral messages support by partially implementing [MSC2228](https://github.com/matrix-org/matrix-doc/pull/2228). ([\#6409](https://github.com/matrix-org/synapse/issues/6409)) - Add support for [MSC 2367](https://github.com/matrix-org/matrix-doc/pull/2367), which allows specifying a reason on all membership events. ([\#6434](https://github.com/matrix-org/synapse/issues/6434)) Bugfixes -------- - Transfer non-standard power levels on room upgrade. ([\#6237](https://github.com/matrix-org/synapse/issues/6237)) - Fix error from the Pillow library when uploading RGBA images. ([\#6241](https://github.com/matrix-org/synapse/issues/6241)) - Correctly apply the event filter to the `state`, `events_before` and `events_after` fields in the response to `/context` requests. ([\#6329](https://github.com/matrix-org/synapse/issues/6329)) - Fix caching devices for remote users when using workers, so that we don't attempt to refetch (and potentially fail) each time a user requests devices. ([\#6332](https://github.com/matrix-org/synapse/issues/6332)) - Prevent account data syncs getting lost across TCP replication. ([\#6333](https://github.com/matrix-org/synapse/issues/6333)) - Fix bug: TypeError in `register_user()` while using LDAP auth module. ([\#6406](https://github.com/matrix-org/synapse/issues/6406)) - Fix an intermittent exception when handling read-receipts. ([\#6408](https://github.com/matrix-org/synapse/issues/6408)) - Fix broken guest registration when there are existing blocks of numeric user IDs. ([\#6420](https://github.com/matrix-org/synapse/issues/6420)) - Fix startup error when http proxy is defined. ([\#6421](https://github.com/matrix-org/synapse/issues/6421)) - Fix error when using synapse_port_db on a vanilla synapse db. ([\#6449](https://github.com/matrix-org/synapse/issues/6449)) - Fix uploading multiple cross signing signatures for the same user. ([\#6451](https://github.com/matrix-org/synapse/issues/6451)) - Fix bug which lead to exceptions being thrown in a loop when a cross-signed device is deleted. ([\#6462](https://github.com/matrix-org/synapse/issues/6462)) - Fix `synapse_port_db` not exiting with a 0 code if something went wrong during the port process. ([\#6470](https://github.com/matrix-org/synapse/issues/6470)) - Improve sanity-checking when receiving events over federation. ([\#6472](https://github.com/matrix-org/synapse/issues/6472)) - Fix inaccurate per-block Prometheus metrics. ([\#6491](https://github.com/matrix-org/synapse/issues/6491)) - Fix small performance regression for sending invites. ([\#6493](https://github.com/matrix-org/synapse/issues/6493)) - Back out cross-signing code added in Synapse 1.5.0, which caused a performance regression. ([\#6494](https://github.com/matrix-org/synapse/issues/6494)) Improved Documentation ---------------------- - Update documentation and variables in user contributed systemd reference file. ([\#6369](https://github.com/matrix-org/synapse/issues/6369), [\#6490](https://github.com/matrix-org/synapse/issues/6490)) - Fix link in the user directory documentation. ([\#6388](https://github.com/matrix-org/synapse/issues/6388)) - Add build instructions to the docker readme. ([\#6390](https://github.com/matrix-org/synapse/issues/6390)) - Switch Ubuntu package install recommendation to use python3 packages in INSTALL.md. ([\#6443](https://github.com/matrix-org/synapse/issues/6443)) - Write some docs for the quarantine_media api. ([\#6458](https://github.com/matrix-org/synapse/issues/6458)) - Convert CONTRIBUTING.rst to markdown (among other small fixes). ([\#6461](https://github.com/matrix-org/synapse/issues/6461)) Deprecations and Removals ------------------------- - Remove admin/v1/users_paginate endpoint. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#5925](https://github.com/matrix-org/synapse/issues/5925)) - Remove fallback for federation with old servers which lack the /federation/v1/state_ids API. ([\#6488](https://github.com/matrix-org/synapse/issues/6488)) Internal Changes ---------------- - Add benchmarks for structured logging and improve output performance. ([\#6266](https://github.com/matrix-org/synapse/issues/6266)) - Improve the performance of outputting structured logging. ([\#6322](https://github.com/matrix-org/synapse/issues/6322)) - Refactor some code in the event authentication path for clarity. ([\#6343](https://github.com/matrix-org/synapse/issues/6343), [\#6468](https://github.com/matrix-org/synapse/issues/6468), [\#6480](https://github.com/matrix-org/synapse/issues/6480)) - Clean up some unnecessary quotation marks around the codebase. ([\#6362](https://github.com/matrix-org/synapse/issues/6362)) - Complain on startup instead of 500'ing during runtime when `public_baseurl` isn't set when necessary. ([\#6379](https://github.com/matrix-org/synapse/issues/6379)) - Add a test scenario to make sure room history purges don't break `/messages` in the future. ([\#6392](https://github.com/matrix-org/synapse/issues/6392)) - Clarifications for the email configuration settings. ([\#6423](https://github.com/matrix-org/synapse/issues/6423)) - Add more tests to the blacklist when running in worker mode. ([\#6429](https://github.com/matrix-org/synapse/issues/6429)) - Refactor data store layer to support multiple databases in the future. ([\#6454](https://github.com/matrix-org/synapse/issues/6454), [\#6464](https://github.com/matrix-org/synapse/issues/6464), [\#6469](https://github.com/matrix-org/synapse/issues/6469), [\#6487](https://github.com/matrix-org/synapse/issues/6487)) - Port synapse.rest.client.v1 to async/await. ([\#6482](https://github.com/matrix-org/synapse/issues/6482)) - Port synapse.rest.client.v2_alpha to async/await. ([\#6483](https://github.com/matrix-org/synapse/issues/6483)) - Port SyncHandler to async/await. ([\#6484](https://github.com/matrix-org/synapse/issues/6484))
| * | | | 1.7.0rc1 v1.7.0rc1Neil Johnson2019-12-091-1/+1
| | | | |
* | | | | Better errors regarding changing avatar_url (#6497)Andrew Morgan2019-12-091-3/+8
|/ / / /
* | | | Back out perf regression from get_cross_signing_keys_from_cache. (#6494)Neil Johnson2019-12-091-30/+8
| | | | | | | | | | | | Back out cross-signing code added in Synapse 1.5.0, which caused a performance regression.
* | | | Merge pull request #6487 from matrix-org/erikj/pass_in_dbErik Johnston2019-12-0946-183/+214
|\ \ \ \ | |/ / / |/| | | Pass in Database object to data stores.
| * | | Fix commentErik Johnston2019-12-091-1/+1
| | | | | | | | | | | | | | | | Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
| * | | Fix port db scriptErik Johnston2019-12-061-1/+1
| | | |
| * | | Move start up DB checks to main data store.Erik Johnston2019-12-062-18/+12
| | | |
| * | | Pass Database into the data storeErik Johnston2019-12-065-28/+24
| | | |
| * | | Move are_all_users_on_domain checks to main data store.Erik Johnston2019-12-063-24/+24
| | | |
| * | | Change DataStores to accept 'database' param.Erik Johnston2019-12-0640-112/+153
| | | |
* | | | Merge pull request #6493 from matrix-org/erikj/invite_state_configErik Johnston2019-12-091-1/+3
|\ \ \ \ | | | | | | | | | | Pull out room_invite_state_types config option once.
| * | | | Pull out room_invite_state_types config option once.Erik Johnston2019-12-091-1/+3
| |/ / / | | | | | | | | | | | | Pulling things out of config is currently surprisingly expensive.
* | | | Fix inaccurate per-block metrics (#6491)Richard van der Hoff2019-12-091-42/+18
| | | | | | | | | | | | | | | | | | | | `Measure` incorrectly assumed that it was the only thing being done by the parent `LoggingContext`. For instance, during a "renew group attestations" operation, hundreds of `outbound_request` calls could take place in parallel, all using the same `LoggingContext`. This would mean that any resources used during *any* of those calls would be reported against *all* of them, producing wildly inaccurate results. Instead, we now give each `Measure` block its own `LoggingContext` (using the parent `LoggingContext` mechanism to ensure that the log lines look correct and that the metrics are ultimately propogated to the top level for reporting against requests/backgrond tasks).
* | | | Remove fallback for missing /federation/v1/state_ids API (#6488)Richard van der Hoff2019-12-092-96/+17
| | | | | | | | | | | | | | | | This API was added way back in 0.17.0; the code here is annoying to maintain and entirely redundant.
* | | | Merge pull request #6484 from matrix-org/erikj/port_sync_handlerErik Johnston2019-12-097-177/+164
|\ \ \ \ | |/ / / |/| | | Port SyncHandler to async/await
| * | | Fixup functions to consistently return deferredsErik Johnston2019-12-064-7/+7
| | | |
| * | | Port SyncHandler to async/awaitErik Johnston2019-12-054-173/+160
| | | |
* | | | Merge branch 'develop' of github.com:matrix-org/synapse into ↵Erik Johnston2019-12-0641-817/+675
|\ \ \ \ | | |_|/ | |/| | | | | | erikj/make_database_class
| * | | Replace /admin/v1/users_paginate endpoint with /admin/v2/users (#5925)Manuel Stahl2019-12-056-109/+114
| |/ /
| * | Port rest.client.v2Erik Johnston2019-12-0523-505/+361
| | |
| * | Port rest/v1 to async/awaitErik Johnston2019-12-0511-167/+118
| | |
| * | Stronger typing in the federation handler (#6480)Richard van der Hoff2019-12-051-24/+57
| | | | | | | | | | | | | | | replace the event_info dict with an attrs thing
| * | Sanity-check the rooms of auth events before pulling them in. (#6472)Richard van der Hoff2019-12-051-9/+25
| | |
* | | Remove unused varErik Johnston2019-12-061-2/+0
| | |
* | | Move background update handling out of storeErik Johnston2019-12-0519-148/+165
| | |
* | | CommentsErik Johnston2019-12-053-5/+16
| | |
* | | Move DB pool and helper functions into dedicated Database classErik Johnston2019-12-0547-2195/+2274
|/ /
* | Merge pull request #6464 from matrix-org/erikj/make_public_sql_baseErik Johnston2019-12-0546-519/+512
|\ \ | | | | | | Clean up SQLBaseStore private function usage
| * | Remove underscore from SQLBaseStore functionsErik Johnston2019-12-0444-501/+493
| | |
| * | Don't call SQLBaseStore methods from outside storesErik Johnston2019-12-044-19/+20
| | |
* | | Merge pull request #6470 from matrix-org/babolivier/port_db_ci_failureBrendan Abolivier2019-12-041-2/+10
|\ \ \ | | | | | | | | Make synapse_port_db exit with a non-0 code if something failed
| * | | Fix background updates for synapse_port_dbBrendan Abolivier2019-12-041-2/+10
| |/ /
* / / get rid of (most of) have_events from ↵Richard van der Hoff2019-12-042-72/+24
|/ / | | | | | | | | | | | | | | | | | | | | | | | | _update_auth_events_and_context_for_auth (#6468) have_events was a map from event_id to rejection reason (or None) for events which are in our local database. It was used as filter on the list of event_ids being passed into get_events_as_list. However, since get_events_as_list will ignore any event_ids that are unknown or rejected, we can equivalently just leave it to get_events_as_list to do the filtering. That means that we don't have to keep `have_events` up-to-date, and can use `have_seen_events` instead of `get_seen_events_with_rejection` in the one place we do need it.
* | Merge pull request #6454 from matrix-org/erikj/clean_base_StoreErik Johnston2019-12-048-192/+221
|\ \ | | | | | | Move things out of SQLBaseStore
| * | Revert "Move get_user_count_txn out of base store"Erik Johnston2019-12-042-12/+12
| | | | | | | | | | | | | | | | | | This reverts commit 00f0d67566cdfe8eae44aeae1c982c42a255cfcd. Its going to get removed soon, so lets not make merge conflicts.
| * | _CURRENT_STATE_CACHE_NAME is publicErik Johnston2019-12-042-5/+5
| | |
| * | Move get_user_count_txn out of base storeErik Johnston2019-12-042-12/+12
| | |
| * | Move cache invalidation to main data storeErik Johnston2019-12-046-113/+143
| | |
| * | Move event fetch vars to EventWorkStoreErik Johnston2019-12-044-14/+15
| | |
| * | Move account validity bg updates to registration storeErik Johnston2019-12-042-66/+64
| | |
* | | Merge pull request #6441 from syamgk/fix-parameter-mismatchErik Johnston2019-12-041-1/+1
|\ \ \ | | | | | | | | Fix issue #6406 parameter mismatch
| * | | Issue #6406 Fix parameter mismatchSyam G Krishnan2019-12-041-1/+1
| | | | | | | | | | | | | | | | Signed-off-by: Syam G Krishnan <syamgk01@gmail.com>
* | | | Merge pull request #6329 from matrix-org/babolivier/context_filtersBrendan Abolivier2019-12-045-3/+23
|\ \ \ \ | |_|/ / |/| | | Filter state, events_before and events_after in /context requests
| * | | Merge branch 'develop' into babolivier/context_filtersBrendan Abolivier2019-12-0487-1315/+3016
| |\ \ \
| * | | | Incorporate reviewBrendan Abolivier2019-12-041-2/+1
| | | | |
| * | | | Also filter state eventsBrendan Abolivier2019-11-061-1/+7
| | | | |
| * | | | Only filter if a filter was providedBrendan Abolivier2019-11-051-4/+6
| | | | |
| * | | | Update copyrightBrendan Abolivier2019-11-051-1/+2
| | | | |
| * | | | Update copyrightsBrendan Abolivier2019-11-054-1/+11
| | | | |
| * | | | Filter events_before and events_after in /context requestsBrendan Abolivier2019-11-051-2/+4
| | | | | | | | | | | | | | | | | | | | While the current version of the spec doesn't say much about how this endpoint uses filters (see https://github.com/matrix-org/matrix-doc/issues/2338), the current implementation is that some fields of an EventFilter apply (the ones that are used when running the SQL query) and others don't (the ones that are used by the filter itself) because we don't call event_filter.filter(...). This seems counter-intuitive and probably not what we want so this commit fixes it.
* | | | | Merge pull request #6451 from matrix-org/uhoreg/cross_signing_signatures_indexErik Johnston2019-12-042-1/+24
|\ \ \ \ \ | | | | | | | | | | | | make cross signing signature index non-unique
| * | | | | apply changes from reviewHubert Chathi2019-12-031-1/+2
| | | | | |
| * | | | | make cross signing signature index non-uniqueHubert Chathi2019-12-022-1/+23
| | | | | |
* | | | | | privacy by default for room dir (#6355)Neil Johnson2019-12-041-12/+14
| | | | | | | | | | | | | | | | | | | | | | | | Ensure that the the default settings for the room directory are that the it is hidden from public view by default.
* | | | | | Fix exception when a cross-signed device is deleted (#6462)Richard van der Hoff2019-12-041-4/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (hopefully) ... and deobfuscate the relevant bit of code.
* | | | | | Add ephemeral messages support (MSC2228) (#6409)Brendan Abolivier2019-12-036-7/+277
| |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implement part [MSC2228](https://github.com/matrix-org/matrix-doc/pull/2228). The parts that differ are: * the feature is hidden behind a configuration flag (`enable_ephemeral_messages`) * self-destruction doesn't happen for state events * only implement support for the `m.self_destruct_after` field (not the `m.self_destruct` one) * doesn't send synthetic redactions to clients because for this specific case we consider the clients to be able to destroy an event themselves, instead we just censor it (by pruning its JSON) in the database
* | | | | Add benchmarks for structured logging performance (#6266)Amber Brown2019-12-031-0/+1
|/ / / /
* | | | Transfer power level state events on room upgrade (#6237)Andrew Morgan2019-12-021-5/+31
| | | |
* | | | Fix: Pillow error when uploading RGBA image (#3325) (#6241)Filip Štědronský2019-12-021-1/+4
| |/ / |/| | | | | Signed-Off-By: Filip Štědronský <g@regnarg.cz>
* | | Add User-Interactive Auth to /account/3pid/add (#6119)Andrew Morgan2019-11-291-0/+5
| | |
* | | Merge pull request #6434 from matrix-org/erikj/msc2367_membership_reasonsErik Johnston2019-11-295-10/+21
|\ \ \ | | | | | | | | Implement MSC 2367 - Membership Reasons
| * | | Propagate reason in remotely rejected invitesErik Johnston2019-11-284-9/+20
| | | |
| * | | MSC2367 Allow reason field on all member eventsErik Johnston2019-11-281-1/+1
| | | |
* | | | Merge pull request #6436 from matrix-org/babolivier/fix-state-retrievalBrendan Abolivier2019-11-292-9/+19
|\ \ \ \ | | | | | | | | | | Discard retention policies when retrieving state
| * | | | LintBrendan Abolivier2019-11-281-4/+8
| | | | |
| * | | | Discard retention policies when retrieving stateBrendan Abolivier2019-11-282-9/+15
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | Purge jobs don't delete the latest event in a room in order to keep the forward extremity and not break the room. On the other hand, get_state_events, when given an at_token argument calls filter_events_for_client to know if the user can see the event that matches that (sync) token. That function uses the retention policies of the events it's given to filter out those that are too old from a client's view. Some clients, such as Riot, when loading a room, request the list of members for the latest sync token it knows about, and get confused to the point of refusing to send any message if the server tells it that it can't get that information. This can happen very easily with the message retention feature turned on and a room with low activity so that the last event sent becomes too old according to the room's retention policy. An easy and clean fix for that issue is to discard the room's retention policies when retrieving state.
* | | | Merge branch 'master' into developAndrew Morgan2019-11-281-1/+1
|\ \ \ \ | |/ / / |/| | |
| * | | 1.6.1 v1.6.1 github/release-v1.6.1 release-v1.6.1Andrew Morgan2019-11-281-1/+1
| | | |
| * | | Remove local threepids on account deactivation (#6426)Andrew Morgan2019-11-282-0/+16
| | | |
| * | | Fix startup error when http proxy is defined. (#6421)Richard van der Hoff2019-11-272-4/+4
| | | | | | | | | | | | | | | | | | | | Guess I only tested this on python 2 :/ Fixes #6419.
* | | | Remove local threepids on account deactivation (#6426)Andrew Morgan2019-11-282-0/+16
| | | |
* | | | Clarifications for the email configuration settings. (#6423)Richard van der Hoff2019-11-281-1/+16
| | | | | | | | | | | | Cf #6422
* | | | Implementation of MSC2314 (#6176)Amber Brown2019-11-282-12/+20
| | | |
* | | | add etag and count to key backup endpoints (#5858)Hubert Chathi2019-11-274-120/+261
| | | |
* | | | Merge pull request #6358 from matrix-org/babolivier/message_retentionBrendan Abolivier2019-11-2710-8/+698
|\ \ \ \ | | | | | | | | | | Implement message retention policies (MSC1763)
| * \ \ \ Merge branch 'develop' into babolivier/message_retentionBrendan Abolivier2019-11-2672-1202/+2058
| |\ \ \ \
| * | | | | Fix worker modeBrendan Abolivier2019-11-191-56/+56
| | | | | |
| * | | | | Fix 3PID invite exchangeBrendan Abolivier2019-11-191-1/+1
| | | | | |
| * | | | | Lint againBrendan Abolivier2019-11-191-1/+1
| | | | | |
| * | | | | Lint againBrendan Abolivier2019-11-191-1/+1
| | | | | |
| * | | | | LintBrendan Abolivier2019-11-193-51/+54
| | | | | |
| * | | | | Don't apply retention policy based filtering on state eventsBrendan Abolivier2019-11-061-6/+9
| | | | | | | | | | | | | | | | | | | | | | | | As per MSC1763, 'Retention is only considered for non-state events.', so don't filter out state events based on the room's retention policy.
| * | | | | Implement per-room message retention policiesBrendan Abolivier2019-11-0410-6/+690
| | | | | |
* | | | | | Remove assertion and provide a clear warning on startup for missing ↵Andrew Morgan2019-11-262-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | public_baseurl (#6379)
* | | | | | Merge pull request #6343 from matrix-org/rav/event_auth/4Richard van der Hoff2019-11-261-37/+44
|\ \ \ \ \ \ | | | | | | | | | | | | | | Refactor _update_auth_events_and_context_for_auth
| * | | | | | remove confusing fixmeRichard van der Hoff2019-11-261-6/+0
| | | | | | |
| * | | | | | Merge remote-tracking branch 'origin/develop' into rav/event_auth/4Richard van der Hoff2019-11-1821-42/+52
| |\ \ \ \ \ \
| * | | | | | | Use get_events_as_list rather than lots of calls to get_eventRichard van der Hoff2019-11-081-16/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's more efficient and clearer.
| * | | | | | | Update some docstrings and commentsRichard van der Hoff2019-11-081-8/+31
| | | | | | | |
| * | | | | | | Simplify _update_auth_events_and_context_for_authRichard van der Hoff2019-11-081-11/+9
| | |_|_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | move event_key calculation into _update_context_for_auth_events, since it's only used there.
* | | | | | | Fix startup error when http proxy is defined. (#6421)Richard van der Hoff2019-11-262-4/+4
| |_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | Guess I only tested this on python 2 :/ Fixes #6419.
* | | | | | Don't construct a setErik Johnston2019-11-261-6/+3
| | | | | |
* | | | | | Fix find_next_generated_user_id_localpartErik Johnston2019-11-261-10/+7
| | | | | |
* | | | | | Merge branch 'master' into developAndrew Morgan2019-11-262-2/+2
|\ \ \ \ \ \ | | |_|_|/ / | |/| | | |
| * | | | | 1.6.0 v1.6.0 github/release-v1.6.0 release-v1.6.0Andrew Morgan2019-11-261-1/+1
| | | | | |
| * | | | | Fix phone home stats (#6418)Erik Johnston2019-11-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Fix phone home stats
* | | | | | Prevent account_data content from being sent over TCP replication (#6333)Andrew Morgan2019-11-262-7/+6
|\ \ \ \ \ \
| * \ \ \ \ \ Merge branch 'develop' of github.com:matrix-org/synapse into ↵Andrew Morgan2019-11-141-1/+1
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | anoa/fix_account_data_sync * 'develop' of github.com:matrix-org/synapse: Blacklist PurgeRoomTestCase (#6361) Set room version default to 5
| * | | | | | | lintAndrew Morgan2019-11-081-2/+1
| | | | | | | |
| * | | | | | | Remove content from being sent for account data rdata streamAndrew Morgan2019-11-082-6/+6
| | |_|/ / / / | |/| | | | |
* | | | | | | Merge pull request #6332 from matrix-org/erikj/query_devices_fixErik Johnston2019-11-263-4/+98
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Fix caching devices for remote servers in worker.
| * | | | | | | Fixup docsErik Johnston2019-11-261-1/+5
| | | | | | | |
| * | | | | | | Fix caching devices for remote servers in worker.Erik Johnston2019-11-053-4/+94
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the `/keys/query` API is hit on client_reader worker Synapse may decide that it needs to resync some remote deivces. Usually this happens on master, and then gets cached. However, that fails on workers and so it falls back to fetching devices from remotes directly, which may in turn fail if the remote is down.
* | | | | | | | Make sure that we close cursors before returning from a query (#6408)Richard van der Hoff2019-11-252-10/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are lots of words in the comment as to why this is a good idea. Fixes #6403.
* | | | | | | | Merge tag 'v1.6.0rc2' into developRichard van der Hoff2019-11-252-19/+26
|\ \ \ \ \ \ \ \ | | |_|_|/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.6.0rc2 (2019-11-25) ============================= Bugfixes -------- - Fix a bug which could cause the background database update hander for event labels to get stuck in a loop raising exceptions. ([\#6407](https://github.com/matrix-org/synapse/issues/6407))
| * | | | | | | 1.6.0rc2 v1.6.0rc2Richard van der Hoff2019-11-251-1/+1
| | | | | | | |
| * | | | | | | Fix exceptions from background database update for event labels. (#6407)Richard van der Hoff2019-11-251-18/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add some exception handling here so that events whose json cannot be parsed are ignored rather than getting us stuck in a loop. Fixes #6404.
* | | | | | | | Improve the performance of structured logging (#6322)Amber Brown2019-11-262-30/+90
| | | | | | | |
* | | | | | | | Clean up newline quote marks around the codebase (#6362)Andrew Morgan2019-11-2125-46/+42
|/ / / / / / /
* | | | | | | 1.6.0rc1 v1.6.0rc1Andrew Morgan2019-11-201-1/+1
| | | | | | |
* | | | | | | Move admin endpoints into separate files (#6308)Manuel Stahl2019-11-204-555/+621
| | | | | | |
* | | | | | | Merge pull request #6335 from matrix-org/erikj/rc_login_cleanupsBrendan Abolivier2019-11-202-70/+125
|\ \ \ \ \ \ \ | |_|_|_|/ / / |/| | | | | | Only do `rc_login` ratelimiting on succesful login.
| * | | | | | LintBrendan Abolivier2019-11-201-1/+3
| | | | | | |
| * | | | | | Apply suggestions from code reviewErik Johnston2019-11-182-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-Authored-By: Brendan Abolivier <babolivier@matrix.org>
| * | | | | | Add failed auth ratelimiting to UIAErik Johnston2019-11-061-1/+32
| | | | | | |
| * | | | | | Only do `rc_login` ratelimiting on succesful login.Erik Johnston2019-11-062-72/+94
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We were doing this in a number of places which meant that some login code paths incremented the counter multiple times. It was also applying ratelimiting to UIA endpoints, which was probably not intentional. In particular, some custom auth modules were calling `check_user_exists`, which incremented the counters, meaning that people would fail to login sometimes.
* | | | | | Replace UPDATE with UPSERT on device_max_stream_id table (#6363)Andrew Morgan2019-11-151-2/+15
| | | | | |
* | | | | | Fix guest -> real account upgrade with account validity enabled (#6359)Andrew Morgan2019-11-141-6/+3
| | | | | |
* | | | | | Merge branch 'develop' of github.com:matrix-org/synapse into ↵Andrew Morgan2019-11-141-1/+1
|\ \ \ \ \ \ | | |_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | anoa/homeserver_copy * 'develop' of github.com:matrix-org/synapse: Blacklist PurgeRoomTestCase (#6361) Set room version default to 5
| * | | | | Merge pull request #6220 from matrix-org/neilj/set_room_version_default_to_5Brendan Abolivier2019-11-141-1/+1
| |\ \ \ \ \ | | |_|/ / / | |/| | | | Set room version default to 5
| | * | | | Set room version default to 5Neil Johnson2019-10-191-1/+1
| | | | | |
* | | | | | A couple more instancesAndrew Morgan2019-11-122-2/+2
| | | | | |
* | | | | | Replace instance variations of homeserver with correct case/spacingAndrew Morgan2019-11-1218-31/+31
|/ / / / /
* | | | | Merge pull request #6340 from matrix-org/babolivier/pagination_queryBrendan Abolivier2019-11-081-8/+32
|\ \ \ \ \ | | | | | | | | | | | | Fix the SQL SELECT query in _paginate_room_events_txn
| * | | | | Incorporate reviewBrendan Abolivier2019-11-081-12/+12
| | | | | |
| * | | | | LintBrendan Abolivier2019-11-071-2/+2
| | | | | |
| * | | | | Only join on event_labels if we're filtering on labelsBrendan Abolivier2019-11-071-9/+24
| | | | | |
| * | | | | Handle lack of filterBrendan Abolivier2019-11-071-5/+3
| | | | | |
| * | | | | Fix the SQL SELECT query in _paginate_room_events_txnBrendan Abolivier2019-11-071-2/+13
| | | | | | | | | | | | | | | | | | | | | | | | Doing a SELECT DISTINCT when paginating is quite expensive, because it requires the engine to do sorting on the entire events table. However, we only need to run it if we're filtering on 2+ labels, so this PR is changing the request so that DISTINCT is only used then.
* | | | | | Merge pull request #6295 from matrix-org/erikj/split_purge_historyErik Johnston2019-11-085-174/+323
|\ \ \ \ \ \ | | | | | | | | | | | | | | Split purge API into events vs state and add PurgeEventsStorage
| * | | | | | Move type annotation into docstringErik Johnston2019-11-081-3/+3
| | | | | | |
| * | | | | | Fix deleting state groups during room purge.Erik Johnston2019-11-061-13/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | And fix the tests to actually test that things got deleted.
| * | | | | | Use correct type annotationErik Johnston2019-11-061-2/+2
| | | | | | |
| * | | | | | Merge branch 'develop' of github.com:matrix-org/synapse into ↵Erik Johnston2019-11-053-83/+94
| |\ \ \ \ \ \ | | | |_|_|_|/ | | |/| | | | | | | | | | | erikj/split_purge_history
| * | | | | | Change to not require a state_groups.room_id index.Erik Johnston2019-11-044-53/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This does mean that we won't clean up orphaned state groups (i.e. state groups that were persisted but the associated event wasn't).
| * | | | | | Merge branch 'develop' of github.com:matrix-org/synapse into ↵Erik Johnston2019-11-0464-336/+1288
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | erikj/split_purge_history
| * | | | | | | Fix up commentErik Johnston2019-11-011-2/+1
| | | | | | | |
| * | | | | | | Update log line to lie a little lessErik Johnston2019-10-311-1/+1
| | | | | | | |
| * | | | | | | Add state_groups.room_id indexErik Johnston2019-10-312-0/+24
| | | | | | | |
| * | | | | | | DocstringsErik Johnston2019-10-311-3/+11
| | | | | | | |
| * | | | | | | Fix purge room APIErik Johnston2019-10-311-5/+8
| | | | | | | |
| * | | | | | | Merge branch 'develop' of github.com:matrix-org/synapse into ↵Erik Johnston2019-10-3179-218/+562
| |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | erikj/split_purge_history
| * | | | | | | | Split purge API into events vs stateErik Johnston2019-10-305-177/+300
| | | | | | | | |
* | | | | | | | | Merge pull request #6310 from matrix-org/babolivier/msc2326_bg_updateBrendan Abolivier2019-11-072-0/+80
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | MSC2326: Add background update to take previous events into account
| * | | | | | | | | Update synapse/storage/data_stores/main/events_bg_updates.pyBrendan Abolivier2019-11-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
| * | | | | | | | | Update synapse/storage/data_stores/main/events_bg_updates.pyBrendan Abolivier2019-11-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
| * | | | | | | | | Copy resultsBrendan Abolivier2019-11-071-1/+3
| | | | | | | | | |
| * | | | | | | | | Revert "Back to using cursor_to_dict"Brendan Abolivier2019-11-071-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 1186612d6cd728e6b7ed7806579db3cea7410b54.
| * | | | | | | | | Back to using cursor_to_dictBrendan Abolivier2019-11-071-9/+9
| | | | | | | | | |
| * | | | | | | | | Initialise value before loopingBrendan Abolivier2019-11-071-4/+8
| | | | | | | | | |
| * | | | | | | | | Incorporate reviewBrendan Abolivier2019-11-071-14/+9
| | | | | | | | | |
| * | | | | | | | | Fix field nameBrendan Abolivier2019-11-061-1/+1
| | | | | | | | | |
| * | | | | | | | | Update insertBrendan Abolivier2019-11-061-1/+6
| | | | | | | | | |
| * | | | | | | | | Merge branch 'develop' into babolivier/msc2326_bg_updateBrendan Abolivier2019-11-046-92/+189
| |\ \ \ \ \ \ \ \ \ | | | |_|_|/ / / / / | | |/| | | | | | |
| * | | | | | | | | Print out the actual number of affected rowsBrendan Abolivier2019-11-041-4/+4
| | | | | | | | | |
| * | | | | | | | | Correctly order resultsBrendan Abolivier2019-11-041-5/+5
| | | | | | | | | |
| * | | | | | | | | TODOBrendan Abolivier2019-11-041-0/+2
| | | | | | | | | |
| * | | | | | | | | Fix exit conditionBrendan Abolivier2019-11-041-1/+3
| | | | | | | | | |
| * | | | | | | | | LintBrendan Abolivier2019-11-041-6/+3
| | | | | | | | | |