Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Filter the results of user directory searching via the spam checker (#6888) | Patrick Cloke | 2020-02-14 | 2 | -2/+39 |
| | | | Add a method to the spam checker to filter the user directory results. | ||||
* | Remove m.lazy_load_members from unstable features since it is in CS r0.5.0 ↵ | Aaron Raimist | 2020-02-13 | 1 | -1/+0 |
| | | | | | | | (#6877) Fixes #5528 | ||||
* | Return a 404 for admin api user lookup if user not found (#6901) | Andrew Morgan | 2020-02-12 | 1 | -1/+4 |
| | |||||
* | Merge branch 'master' into develop | Brendan Abolivier | 2020-02-12 | 1 | -1/+1 |
|\ | |||||
| * | 1.10.0 | Brendan Abolivier | 2020-02-12 | 1 | -1/+1 |
| | | |||||
* | | Merge branch 'release-v1.10.0' into develop | Richard van der Hoff | 2020-02-11 | 1 | -1/+1 |
|\| | |||||
| * | 1.10.0rc5 v1.10.0rc5 | Richard van der Hoff | 2020-02-11 | 1 | -1/+1 |
| | | |||||
* | | Merge branch 'release-v1.10.0' into develop | Richard van der Hoff | 2020-02-11 | 2 | -1/+2 |
|\| | |||||
| * | 1.10.0rc4 | Richard van der Hoff | 2020-02-11 | 1 | -1/+1 |
| | | |||||
| * | filter out m.room.aliases from /sync state blocks (#6884) | Matthew Hodgson | 2020-02-10 | 1 | -0/+1 |
| | | | | | | We forgot to filter out aliases from /sync state blocks as well as the timeline. | ||||
* | | Reject device display names that are too long (#6882) | Patrick Cloke | 2020-02-10 | 1 | -1/+13 |
| | | | | | | | | | | | | | | | | * Reject device display names that are too long. Too long is currently defined as 100 characters in length. * Add a regression test for rejecting a too long device display name. | ||||
* | | Merge tag 'v1.10.0rc3' into develop | Richard van der Hoff | 2020-02-10 | 2 | -1/+8 |
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.10.0rc3 (2020-02-10) ============================== Features -------- - Filter out m.room.aliases from the CS API to mitigate abuse while a better solution is specced. ([\#6878](https://github.com/matrix-org/synapse/issues/6878)) Internal Changes ---------------- - Fix continuous integration failures with old versions of `pip`, which were introduced by a release of the `zipp` library. ([\#6880](https://github.com/matrix-org/synapse/issues/6880)) | ||||
| * | 1.10.0rc3 v1.10.0rc3 | Richard van der Hoff | 2020-02-10 | 1 | -1/+1 |
| | | |||||
| * | filter out m.room.aliases from the CS API until a better solution is specced ↵ | Matthew Hodgson | 2020-02-10 | 1 | -0/+7 |
| | | | | | | | | | | (#6878) We're in the middle of properly mitigating spam caused by malicious aliases being added to a room. However, until this work fully lands, we temporarily filter out all m.room.aliases events from /sync and /messages on the CS API, to remove abusive aliases. This is considered acceptable as m.room.aliases events were never a reliable record of the given alias->id mapping and were purely informational, and in their current state do more harm than good. | ||||
* | | Add support for putting fed user query API on workers (#6873) | Erik Johnston | 2020-02-07 | 3 | -21/+23 |
| | | |||||
* | | Remove unused `get_room_stats_state` method. (#6869) | Richard van der Hoff | 2020-02-07 | 1 | -25/+0 |
| | | |||||
* | | Add a `make_event_from_dict` method (#6858) | Richard van der Hoff | 2020-02-07 | 3 | -12/+19 |
| | | | | | | | | | | | | | | ... and use it in places where it's trivial to do so. This will make it easier to pass room versions into the FrozenEvent constructors. | ||||
* | | Add typing to synapse.federation.sender (#6871) | Erik Johnston | 2020-02-07 | 6 | -105/+130 |
| | | |||||
* | | Allow moving group read APIs to workers (#6866) | Erik Johnston | 2020-02-07 | 7 | -687/+713 |
| | | |||||
* | | Admin api to add an email address (#6789) | Dirk Klimpel | 2020-02-07 | 3 | -0/+49 |
| | | |||||
* | | remove unused room_version_to_event_format (#6857) | Richard van der Hoff | 2020-02-07 | 1 | -23/+1 |
| | | |||||
* | | Merge pull request #6856 from matrix-org/rav/redact_changes/6 | Richard van der Hoff | 2020-02-07 | 3 | -58/+46 |
|\ \ | | | | | | | Pass room_version into `event_from_pdu_json` | ||||
| * | | Pass room_version into `event_from_pdu_json` | Richard van der Hoff | 2020-02-06 | 3 | -58/+46 |
| | | | | | | | | | | | | It's called from all over the shop, so this one's a bit messy. | ||||
* | | | Limit the number of events that can be requested when backfilling events (#6864) | Patrick Cloke | 2020-02-06 | 1 | -0/+4 |
|/ / | | | | | Limit the maximum number of events requested when backfilling events. | ||||
* | | pass room version into FederationClient.send_join (#6854) | Richard van der Hoff | 2020-02-06 | 2 | -30/+33 |
| | | | | | | | | ... which allows us to sanity-check the create event. | ||||
* | | Allow empty federation_certificate_verification_whitelist (#6849) | timfi | 2020-02-06 | 1 | -0/+2 |
| | | |||||
* | | Third party event rules Update (#6781) | PeerD | 2020-02-06 | 2 | -4/+9 |
| | | |||||
* | | Reduce amount of logging at INFO level. (#6862) | Erik Johnston | 2020-02-06 | 11 | -21/+21 |
| | | | | | | | | | | | | | | | | A lot of the things we log at INFO are now a bit superfluous, so lets make them DEBUG logs to reduce the amount we log by default. Co-Authored-By: Brendan Abolivier <babolivier@matrix.org> Co-authored-by: Brendan Abolivier <github@brendanabolivier.com> | ||||
* | | Merge pull request #6823 from matrix-org/rav/redact_changes/5 | Richard van der Hoff | 2020-02-06 | 2 | -19/+13 |
|\ \ | | | | | | | pass room versions around | ||||
| * | | Simplify `room_version` handling in `FederationClient.send_invite` | Richard van der Hoff | 2020-02-05 | 1 | -10/+6 |
| | | | |||||
| * | | Pass room version object into `FederationClient.get_pdu` | Richard van der Hoff | 2020-02-05 | 2 | -9/+7 |
| | | | |||||
* | | | Merge tag 'v1.10.0rc2' into develop | Erik Johnston | 2020-02-06 | 7 | -22/+73 |
|\ \ \ | |/ / |/| / | |/ | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.10.0rc2 (2020-02-06) ============================== Bugfixes -------- - Fix an issue with cross-signing where device signatures were not sent to remote servers. ([\#6844](https://github.com/matrix-org/synapse/issues/6844)) - Fix to the unknown remote device detection which was introduced in 1.10.rc1. ([\#6848](https://github.com/matrix-org/synapse/issues/6848)) Internal Changes ---------------- - Detect unexpected sender keys on remote encrypted events and resync device lists. ([\#6850](https://github.com/matrix-org/synapse/issues/6850)) | ||||
| * | 1.10.0rc2 | Erik Johnston | 2020-02-06 | 1 | -1/+1 |
| | | |||||
| * | Check sender_key matches on inbound encrypted events. (#6850) | Erik Johnston | 2020-02-05 | 2 | -14/+66 |
| | | | | | | If they don't then the device lists are probably out of sync. | ||||
| * | Merge pull request #6844 from matrix-org/uhoreg/cross_signing_fix_device_fed | Hubert Chathi | 2020-02-05 | 1 | -0/+10 |
| | | | | | | add device signatures to device key query results | ||||
| * | Fix detecting unknown devices from remote encrypted events. (#6848) | Erik Johnston | 2020-02-04 | 5 | -7/+6 |
| | | | | | | | | | | | | | | | | We were looking at the wrong event type (`m.room.encryption` vs `m.room.encrypted`). Also fixup the duplicate `EvenTypes` entries. Introduced in #6776. | ||||
* | | Merge pull request #6840 from matrix-org/rav/federation_client_async | Richard van der Hoff | 2020-02-05 | 1 | -136/+142 |
|\ \ | | | | | | | Port much of `synapse.federation.federation_client` to async/await | ||||
| * | | make FederationClient._do_send_invite async | Richard van der Hoff | 2020-02-05 | 1 | -10/+7 |
| | | | |||||
| * | | Apply suggestions from code review | Richard van der Hoff | 2020-02-05 | 1 | -2/+4 |
| | | | | | | | | | Co-Authored-By: Erik Johnston <erik@matrix.org> | ||||
| * | | Merge remote-tracking branch 'origin/develop' into rav/federation_client_async | Richard van der Hoff | 2020-02-04 | 3 | -348/+379 |
| |\ \ | |||||
| * | | | make FederationClient.send_invite async | Richard van der Hoff | 2020-02-03 | 1 | -6/+5 |
| | | | | |||||
| * | | | make FederationClient.get_missing_events async | Richard van der Hoff | 2020-02-03 | 1 | -20/+20 |
| | | | | |||||
| * | | | make FederationClient._do_send_leave async | Richard van der Hoff | 2020-02-03 | 1 | -4/+3 |
| | | | | |||||
| * | | | make FederationClient.send_leave.send_request async | Richard van der Hoff | 2020-02-03 | 1 | -5/+2 |
| | | | | |||||
| * | | | make FederationClient._do_send_join async | Richard van der Hoff | 2020-02-03 | 1 | -4/+3 |
| | | | | |||||
| * | | | make FederationClient.send_join.send_request async | Richard van der Hoff | 2020-02-03 | 1 | -4/+3 |
| | | | | |||||
| * | | | make FederationClient.make_membership_event.send_request async | Richard van der Hoff | 2020-02-03 | 1 | -4/+3 |
| | | | | |||||
| * | | | make FederationClient._try_destination_list async | Richard van der Hoff | 2020-02-03 | 1 | -10/+26 |
| | | | | |||||
| * | | | make FederationClient.send_leave async | Richard van der Hoff | 2020-02-03 | 1 | -10/+9 |
| | | | | |||||
| * | | | make FederationClient.send_join async | Richard van der Hoff | 2020-02-03 | 1 | -11/+13 |
| | | | | |||||
| * | | | make FederationClient.make_membership_event async | Richard van der Hoff | 2020-02-03 | 1 | -10/+11 |
| | | | | |||||
| * | | | make FederationClient.get_event_auth async | Richard van der Hoff | 2020-02-03 | 1 | -6/+4 |
| | | | | |||||
| * | | | make FederationClient.get_room_state_ids async | Richard van der Hoff | 2020-02-03 | 1 | -4/+5 |
| | | | | |||||
| * | | | make FederationClient.get_pdu async | Richard van der Hoff | 2020-02-03 | 1 | -15/+17 |
| | | | | |||||
| * | | | make FederationClient.backfill async | Richard van der Hoff | 2020-02-03 | 1 | -15/+11 |
| | | | | |||||
* | | | | Reduce performance logging to DEBUG (#6833) | Michael Kaye | 2020-02-05 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | * Reduce tnx performance logging to DEBUG * Changelog.d | ||||
* | | | | Database updates to populate rooms.room_version (#6847) | Richard van der Hoff | 2020-02-04 | 2 | -0/+57 |
| | | | | | | | | | | | | We're going to need this so that we can figure out how to handle redactions when fetching events from the database. | ||||
* | | | | Merge pull request #6844 from matrix-org/uhoreg/cross_signing_fix_device_fed | Hubert Chathi | 2020-02-04 | 1 | -0/+10 |
|\ \ \ \ | |_|/ / |/| | | | add device signatures to device key query results | ||||
| * | | | add device signatures to device key query results | Hubert Chathi | 2020-02-04 | 1 | -0/+10 |
| | | | | |||||
* | | | | Merge pull request #6837 from matrix-org/rav/federation_async | Richard van der Hoff | 2020-02-04 | 3 | -235/+211 |
|\ \ \ \ | |/ / / |/| / / | |/ / | Port much of `synapse.handlers.federation` to async/await. | ||||
| * | | make FederationHandler.send_invite async | Richard van der Hoff | 2020-02-03 | 2 | -6/+4 |
| | | | |||||
| * | | make FederationHandler.on_get_missing_events async | Richard van der Hoff | 2020-02-03 | 1 | -5/+4 |
| | | | |||||
| * | | make FederationHandler.user_joined_room async | Richard van der Hoff | 2020-02-03 | 1 | -3/+3 |
| | | | |||||
| * | | make FederationHandler._clean_room_for_join async | Richard van der Hoff | 2020-02-03 | 1 | -4/+4 |
| | | | |||||
| * | | make FederationHandler._notify_persisted_event async | Richard van der Hoff | 2020-02-03 | 1 | -4/+6 |
| | | | |||||
| * | | make FederationHandler.persist_events_and_notify async | Richard van der Hoff | 2020-02-03 | 1 | -10/+10 |
| | | | |||||
| * | | make FederationHandler._make_and_verify_event async | Richard van der Hoff | 2020-02-03 | 1 | -5/+10 |
| | | | |||||
| * | | make FederationHandler.do_remotely_reject_invite async | Richard van der Hoff | 2020-02-03 | 2 | -8/+11 |
| | | | |||||
| * | | make FederationHandler._check_for_soft_fail async | Richard van der Hoff | 2020-02-03 | 1 | -13/+9 |
| | | | |||||
| * | | make FederationHandler._persist_auth_tree async | Richard van der Hoff | 2020-02-03 | 1 | -11/+7 |
| | | | |||||
| * | | make FederationHandler.do_invite_join async | Richard van der Hoff | 2020-02-03 | 2 | -18/+18 |
| | | | |||||
| * | | make FederationHandler.on_event_auth async | Richard van der Hoff | 2020-02-03 | 1 | -5/+4 |
| | | | |||||
| * | | make FederationHandler.on_exchange_third_party_invite_request async | Richard van der Hoff | 2020-02-03 | 1 | -14/+12 |
| | | | |||||
| * | | make FederationHandler.construct_auth_difference async | Richard van der Hoff | 2020-02-03 | 1 | -3/+4 |
| | | | |||||
| * | | make FederationHandler._update_context_for_auth_events async | Richard van der Hoff | 2020-02-03 | 1 | -10/+10 |
| | | | |||||
| * | | make FederationHandler._update_auth_events_and_context_for_auth async | Richard van der Hoff | 2020-02-03 | 1 | -20/+21 |
| | | | |||||
| * | | make FederationHandler.do_auth async | Richard van der Hoff | 2020-02-03 | 1 | -10/+14 |
| | | | |||||
| * | | make FederationHandler._prep_event async | Richard van der Hoff | 2020-02-03 | 1 | -23/+10 |
| | | | |||||
| * | | make FederationHandler._handle_new_event async | Richard van der Hoff | 2020-02-03 | 1 | -6/+7 |
| | | | |||||
| * | | make FederationHandler._handle_new_events async | Richard van der Hoff | 2020-02-03 | 1 | -8/+6 |
| | | | |||||
| * | | make FederationHandler.on_make_leave_request async | Richard van der Hoff | 2020-02-03 | 1 | -13/+10 |
| | | | |||||
| * | | make FederationHandler.on_send_leave_request async | Richard van der Hoff | 2020-02-03 | 1 | -5/+3 |
| | | | |||||
| * | | make FederationHandler.on_make_join_request async | Richard van der Hoff | 2020-02-03 | 1 | -13/+10 |
| | | | |||||
| * | | make FederationHandler.on_invite_request async | Richard van der Hoff | 2020-02-03 | 1 | -5/+4 |
| | | | |||||
| * | | make FederationHandler.on_send_join_request async | Richard van der Hoff | 2020-02-03 | 1 | -9/+7 |
| | | | |||||
| * | | make FederationHandler.on_query_auth async | Richard van der Hoff | 2020-02-03 | 1 | -7/+6 |
| | | | |||||
* | | | Add typing to SyncHandler (#6821) | Erik Johnston | 2020-02-03 | 2 | -348/+375 |
| | | | | | | | | | | | | Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | ||||
* | | | Fix stacktraces when using ObservableDeferred and async/await (#6836) | Erik Johnston | 2020-02-03 | 1 | -0/+4 |
|/ / | |||||
* | | Allow URL-encoded user IDs on user admin api paths (#6825) | Andrew Morgan | 2020-02-03 | 1 | -2/+2 |
| | | |||||
* | | Fix `room_version` in `on_invite_request` flow (#6827) | Richard van der Hoff | 2020-02-03 | 2 | -7/+10 |
|/ | | | | I messed this up a bit in #6805, but fortunately we weren't actually doing anything with the room_version so it didn't matter that it was a str not a RoomVersion. | ||||
* | 1.10.0rc1 | Erik Johnston | 2020-01-31 | 1 | -1/+1 |
| | |||||
* | Fix deleting of stale marker for device lists (#6819) | Erik Johnston | 2020-01-31 | 1 | -7/+7 |
| | | | | We were in fact only deleting stale marker when we got an incremental update, rather than when we did a full resync. | ||||
* | pass room_version into compute_event_signature (#6807) | Richard van der Hoff | 2020-01-31 | 2 | -9/+24 |
| | |||||
* | Merge pull request #6806 from matrix-org/rav/redact_changes/3 | Richard van der Hoff | 2020-01-31 | 3 | -37/+39 |
|\ | | | | | Pass room_version into add_hashes_and_signatures | ||||
| * | Pass room_version into add_hashes_and_signatures | Richard van der Hoff | 2020-01-30 | 2 | -8/+14 |
| | | |||||
| * | Pass room_version into create_local_event_from_event_dict | Richard van der Hoff | 2020-01-30 | 2 | -25/+19 |
| | | |||||
| * | Store the room version in EventBuilder | Richard van der Hoff | 2020-01-30 | 1 | -5/+7 |
| | | |||||
* | | Merge pull request #6820 from matrix-org/rav/get_room_version_id | Richard van der Hoff | 2020-01-31 | 10 | -35/+58 |
|\ \ | | | | | | | Make `get_room_version` return a RoomVersion object | ||||
| * | | Add `get_room_version` method | Richard van der Hoff | 2020-01-31 | 2 | -5/+26 |
| | | | | | | | | | | | | So that we can start factoring out some of this boilerplatey boilerplate. | ||||
| * | | s/get_room_version/get_room_version_id/ | Richard van der Hoff | 2020-01-31 | 9 | -30/+32 |
| | | | | | | | | | | | | | | | ... to make way for a forthcoming get_room_version which returns a RoomVersion object. | ||||
* | | | Fix bug with getting missing auth event during join 500'ed (#6810) | Erik Johnston | 2020-01-31 | 1 | -1/+5 |
|/ / | |||||
* | | pass room version into FederationHandler.on_invite_request (#6805) | Richard van der Hoff | 2020-01-30 | 2 | -4/+4 |
| | | |||||
* | | Log when we delete room in bg update (#6816) | Erik Johnston | 2020-01-30 | 1 | -0/+2 |
|/ | |||||
* | MSC2260: Block direct sends of m.room.aliases events (#6794) | Richard van der Hoff | 2020-01-30 | 1 | -0/+12 |
| | | | | | as per MSC2260 | ||||
* | Backgroud update to clean out rooms from current state (#6802) | Erik Johnston | 2020-01-30 | 2 | -2/+125 |
| | |||||
* | Resync remote device list when detected as stale. (#6786) | Erik Johnston | 2020-01-30 | 2 | -4/+24 |
| | |||||
* | Fix sending server up commands from workers (#6811) | Erik Johnston | 2020-01-30 | 4 | -13/+34 |
| | | | | Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> | ||||
* | When server leaves room check for stale device lists. (#6801) | Erik Johnston | 2020-01-30 | 2 | -6/+82 |
| | | | | | | | | | When a server leaves a room it may stop sharing a room with remote users, and thus not get any updates to their device lists. So we need to check for this case and delete those device lists from the cache. We don't need to do this if we stop sharing a room because the remote user leaves the room, because we track that case via looking at membership changes. | ||||
* | When a client asks for remote keys check if should resync. (#6797) | Erik Johnston | 2020-01-30 | 1 | -3/+29 |
| | | | | | | If we detect that the remote users' keys may have changed then we should attempt to resync against the remote server rather than using the (potentially) stale local cache. | ||||
* | Type defintions for use in refactoring for redaction changes (#6803) | Richard van der Hoff | 2020-01-30 | 3 | -4/+12 |
| | | | | | | | | | | * Bump signedjson to 1.1 ... so that we can use the type definitions * Fix breakage caused by upgrade to signedjson 1.1 Thanks, @illicitonion... | ||||
* | Remove unused DeviceRow class (#6800) | Erik Johnston | 2020-01-29 | 1 | -20/+1 |
| | |||||
* | Make /directory/room/<alias> handle restrictive power levels | Richard van der Hoff | 2020-01-29 | 1 | -1/+6 |
| | | | | | Fixes a bug where the alias would be added, but `PUT /directory/room/<alias>` would return a 403. | ||||
* | Set the PL for aliases events to 0. | Richard van der Hoff | 2020-01-29 | 2 | -3/+16 |
| | |||||
* | Factor out a `copy_power_levels_contents` method | Richard van der Hoff | 2020-01-29 | 2 | -13/+47 |
| | | | | I'm going to need another copy (hah!) of this. | ||||
* | Fix race in federation sender that delayed device updates. (#6799) | Erik Johnston | 2020-01-29 | 2 | -30/+22 |
| | | | | | | | | | | | | We were sending device updates down both the federation stream and device streams. This mean there was a race if the federation sender worker processed the federation stream first, as when the sender checked if there were new device updates the slaved ID generator hadn't been updated with the new stream IDs and so returned nothing. This situation is correctly handled by events/receipts/etc by not sending updates down the federation stream and instead having the federation sender worker listen on the other streams and poke the transaction queues as appropriate. | ||||
* | Delete current state when server leaves a room (#6792) | Erik Johnston | 2020-01-29 | 2 | -75/+197 |
| | | | | | | Otherwise its just stale data, which may get deleted later anyway so can't be relied on. It's also a bit of a shotgun if we're trying to get the current state of a room we're not in. | ||||
* | Fix bug when querying remote user keys that require a resync. (#6796) | Erik Johnston | 2020-01-29 | 1 | -1/+2 |
| | | | | We ended up only returning a single device, rather than all of them. | ||||
* | Fix outbound federation request metrics (#6795) | Erik Johnston | 2020-01-28 | 1 | -0/+4 |
| | |||||
* | Merge pull request #6787 from matrix-org/rav/msc2260 | Richard van der Hoff | 2020-01-28 | 2 | -5/+35 |
|\ | | | | | Implement updated auth rules from MSC2260 | ||||
| * | fix bad variable ref | Richard van der Hoff | 2020-01-28 | 1 | -1/+1 |
| | | |||||
| * | Implement updated auth rules from MSC2260 | Richard van der Hoff | 2020-01-28 | 2 | -5/+35 |
| | | |||||
* | | Detect unknown remote devices and mark cache as stale (#6776) | Erik Johnston | 2020-01-28 | 5 | -8/+125 |
|/ | | | | We just mark the fact that the cache may be stale in the database for now. | ||||
* | Pass room version object into event_auth.check and check_redaction (#6788) | Richard van der Hoff | 2020-01-28 | 6 | -27/+48 |
| | | | | | | | These are easier to work with than the strings and we normally have one around. This fixes `FederationHander._persist_auth_tree` which was passing a RoomVersion object into event_auth.check instead of a string. | ||||
* | Warn if postgres database has non-C locale. (#6734) | Erik Johnston | 2020-01-28 | 3 | -0/+52 |
| | | | As using non-C locale can cause issues on upgrading OS. | ||||
* | Merge branch 'master' into develop | Erik Johnston | 2020-01-28 | 2 | -2/+8 |
|\ | |||||
| * | 1.9.1 v1.9.1 github/release-v1.9.1 release-v1.9.1 | Erik Johnston | 2020-01-28 | 1 | -1/+1 |
| | | |||||
| * | Fix setting `mau_limit_reserved_threepids` config (#6793) | Erik Johnston | 2020-01-28 | 1 | -1/+7 |
| | | | | | | | | | | Calling the invalidation function during initialisation of the data stores introduces a circular dependency, causing Synapse to fail to start. | ||||
* | | Add `rooms.room_version` column (#6729) | Erik Johnston | 2020-01-27 | 7 | -71/+251 |
| | | | | | | This is so that we don't have to rely on pulling it out from `current_state_events` table. | ||||
* | | Propagate cache invalidates from workers to other workers. (#6748) | Erik Johnston | 2020-01-27 | 3 | -5/+28 |
| | | | | | | Currently if a worker invalidates a cache it will be streamed to master, which then didn't forward those to other workers. | ||||
* | | Validate client_secret parameter (#6767) | Andrew Morgan | 2020-01-24 | 4 | -6/+41 |
| | | |||||
* | | Make 'event.redacts' never raise. (#6771) | Erik Johnston | 2020-01-23 | 3 | -6/+26 |
| | | | | | | | | | | | | There are quite a few places that we assume that a redaction event has a corresponding `redacts` key, which is not always the case. So lets cheekily make it so that event.redacts just returns None instead. | ||||
* | | Merge branch 'master' into develop | Brendan Abolivier | 2020-01-23 | 1 | -1/+1 |
|\| | |||||
| * | 1.9.0 | Brendan Abolivier | 2020-01-23 | 1 | -1/+1 |
| | | |||||
* | | a bit of debugging for media storage providers (#6757) | Richard van der Hoff | 2020-01-23 | 2 | -0/+7 |
| | | | | | | | | | | | | * a bit of debugging for media storage providers * changelog | ||||
* | | Minor fixes to user admin api (#6761) | Richard van der Hoff | 2020-01-23 | 1 | -9/+5 |
| | | | | | | | | * don't insist on a password (this is valid if you have an SSO login) * fix reference to undefined `requester` | ||||
* | | Remove unnecessary abstractions in admin handler (#6751) | Andrew Morgan | 2020-01-22 | 3 | -73/+10 |
|/ | |||||
* | 1.9.0rc1 | Brendan Abolivier | 2020-01-22 | 1 | -1/+1 |
| | |||||
* | Admin API to list, filter and sort rooms (#6720) | Andrew Morgan | 2020-01-22 | 5 | -3/+224 |
| | |||||
* | Fix typo in _select_thumbnail | Brendan Abolivier | 2020-01-22 | 1 | -1/+1 |
| | |||||
* | Fix and add test to deprecated quarantine media admin api (#6756) | Andrew Morgan | 2020-01-22 | 1 | -1/+1 |
| | |||||
* | Allow monthly active user limiting support for worker mode, fixes #4639. (#6742) | Neil Johnson | 2020-01-22 | 5 | -82/+99 |
| | |||||
* | Allow streaming cache invalidate all to workers. (#6749) | Erik Johnston | 2020-01-22 | 4 | -15/+63 |
| | |||||
* | Add a DeltaState to track changes to be made to current state (#6716) | Erik Johnston | 2020-01-20 | 2 | -99/+111 |
| | |||||
* | Fixup synapse.rest to pass mypy (#6732) | Erik Johnston | 2020-01-20 | 9 | -33/+45 |
| | |||||
* | Fix `/events/:event_id` deprecated API. (#6731) | Erik Johnston | 2020-01-20 | 1 | -1/+1 |
| | |||||
* | Fixup synapse.api to pass mypy (#6733) | Erik Johnston | 2020-01-20 | 3 | -4/+9 |
| | |||||
* | Fix changing password via user admin API. (#6730) | Erik Johnston | 2020-01-20 | 1 | -2/+2 |
| | |||||
* | Fix empty account_validity config block | Andrew Morgan | 2020-01-20 | 1 | -1/+2 |
| | |||||
* | Add more logging around message retention policies support (#6717) | Brendan Abolivier | 2020-01-17 | 2 | -0/+21 |
| | | | So we can debug issues like #6683 more easily | ||||
* | bump version to v1.9.0.dev2 v1.9.0.dev2 | Richard van der Hoff | 2020-01-17 | 1 | -1/+1 |
| | |||||
* | Fix syntax error in run_upgrade for schema 57 (#6728) | Satsuki Yanagi | 2020-01-17 | 1 | -3/+4 |
| | | | | | | | Fix #6727 Related #6655 Co-authored-by: Erik Johnston <erikj@jki.re> | ||||
* | Merge pull request #6714 from matrix-org/babolivier/retention_select_event | Brendan Abolivier | 2020-01-17 | 3 | -7/+7 |
|\ | | | | | Fix instantiation of message retention purge jobs | ||||
| * | Fixup diff | Brendan Abolivier | 2020-01-16 | 1 | -6/+7 |
| | | |||||
| * | Remove get_room_event_after_stream_ordering entirely | Brendan Abolivier | 2020-01-16 | 2 | -58/+13 |
| | | |||||
| * | Lint | Brendan Abolivier | 2020-01-16 | 1 | -6/+12 |
| | | |||||
| * | Correctly order when selecting before stream ordering | Brendan Abolivier | 2020-01-15 | 1 | -2/+5 |
| | | |||||
| * | Fix typo | Brendan Abolivier | 2020-01-15 | 1 | -1/+1 |
| | | |||||
| * | Fix instantiation of message retention purge jobs | Brendan Abolivier | 2020-01-15 | 2 | -13/+48 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When figuring out which topological token to start a purge job at, we need to do the following: 1. Figure out a timestamp before which events will be purged 2. Select the first stream ordering after that timestamp 3. Select info about the first event after that stream ordering 4. Build a topological token from that info In some situations (e.g. quiet rooms with a short max_lifetime), there might not be an event after the stream ordering at step 3, therefore we abort the purge with the error `No event found`. To mitigate that, this patch fetches the first event _before_ the stream ordering, instead of after. | ||||
* | | bump version to v1.9.0.dev1 v1.9.0.dev1 | Richard van der Hoff | 2020-01-17 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #6724 from matrix-org/rav/log_saml_attributes | Richard van der Hoff | 2020-01-17 | 9 | -24/+66 |
|\ \ | | | | | | | Log saml assertions rather than the whole response | ||||
| * | | Log saml assertions rather than the whole response | Richard van der Hoff | 2020-01-16 | 2 | -1/+25 |
| | | | | | | | | | | | | | | | | | | ... since the whole response is huge. We even need to break up the assertions, since kibana otherwise truncates them. | ||||
| * | | move batch_iter to a separate module | Richard van der Hoff | 2020-01-16 | 8 | -23/+41 |
| | | | |||||
* | | | Delegate remote_user_id mapping to the saml mapping provider (#6723) | Richard van der Hoff | 2020-01-17 | 2 | -6/+22 |
| | | | | | | | | | Turns out that figuring out a remote user id for the SAML user isn't quite as obvious as it seems. Factor it out to the SamlMappingProvider so that it's easy to control. | ||||
* | | | Wake up transaction queue when remote server comes back online (#6706) | Erik Johnston | 2020-01-17 | 9 | -7/+129 |
| | | | | | | | | | | | | | | | This will be used to retry outbound transactions to a remote server if we think it might have come back up. | ||||
* | | | Clarify the `account_validity` and `email` sections of the sample ↵ | Richard van der Hoff | 2020-01-17 | 3 | -140/+167 |
|/ / | | | | | | | | | | | | | | | | | | | | | configuration. (#6685) Generally try to make this more comprehensible, and make it match the conventions. I've removed the documentation for all the settings which allow you to change the names of the template files, because I can't really see why they are useful. | ||||
* | | Add StateMap type alias (#6715) | Erik Johnston | 2020-01-16 | 13 | -93/+114 |
| | | |||||
* | | Add org.matrix.e2e_cross_signing to unstable_features in /versions as per ↵ | Neil Johnson | 2020-01-16 | 1 | -0/+2 |
| | | | | | | | | MSC1756 (#6712) | ||||
* | | Port synapse.replication.tcp to async/await (#6666) | Erik Johnston | 2020-01-16 | 13 | -104/+78 |
| | | | | | | | | | | | | | | | | | | | | * Port synapse.replication.tcp to async/await * Newsfile * Correctly document type of on_<FOO> functions as async * Don't be overenthusiastic with the asyncing.... | ||||
* | | Fix purge_room admin API (#6711) | Erik Johnston | 2020-01-15 | 1 | -1/+1 |
| | | |||||
* | | Remove duplicate session check in web fallback servlet (#6702) | Andrew Morgan | 2020-01-15 | 1 | -4/+0 |
| | | |||||
* | | Merge branch 'develop' into rav/module_api_extensions | Richard van der Hoff | 2020-01-15 | 36 | -240/+682 |
|\ \ | |||||
| * | | Implement RedirectException (#6687) | Richard van der Hoff | 2020-01-15 | 2 | -5/+35 |
| | | | | | | | | | | | | | | | Allow REST endpoint implemnentations to raise a RedirectException, which will redirect the user's browser to a given location. | ||||
| * | | Add `local_current_membership` table (#6655) | Erik Johnston | 2020-01-15 | 13 | -89/+247 |
| |/ | | | | | | | | | | | | | Currently we rely on `current_state_events` to figure out what rooms a user was in and their last membership event in there. However, if the server leaves the room then the table may be cleaned up and that information is lost. So lets add a table that separately holds that information. | ||||
| * | Process EDUs in parallel with PDUs. (#6697) | Erik Johnston | 2020-01-14 | 1 | -12/+58 |
| | | | | | | | | This means that things like to device messages don't get blocked behind processing PDUs, which can potentially take *ages*. | ||||
| * | Fixup synapse.replication to pass mypy checks (#6667) | Erik Johnston | 2020-01-14 | 10 | -86/+103 |
| | | |||||
| * | Quarantine media by ID or user ID (#6681) | Andrew Morgan | 2020-01-13 | 2 | -3/+181 |
| | | |||||
| * | Kill off RegistrationError (#6691) | Richard van der Hoff | 2020-01-13 | 2 | -15/+3 |
| | | | | | | This is pretty pointless. Let's just use SynapseError. | ||||
| * | Don't assign numeric IDs for empty usernames (#6690) | Richard van der Hoff | 2020-01-13 | 1 | -1/+1 |
| | | | | | | | | Fix a bug where we would assign a numeric userid if somebody tried registering with an empty username | ||||
| * | Merge pull request #6689 from matrix-org/rav/saml_mapping_provider_updates | Richard van der Hoff | 2020-01-13 | 1 | -6/+16 |
| |\ | | | | | | | Updates to the SAML mapping provider API | ||||
| | * | Pass client redirect URL into SAML mapping providers | Richard van der Hoff | 2020-01-12 | 1 | -4/+11 |
| | | | |||||
| | * | Pass the module_api into the SamlMappingProvider | Richard van der Hoff | 2020-01-12 | 1 | -2/+5 |
| | | | | | | | | | | | | | | | ... for consistency with other modules, and because we'll need it sooner or later and it will be a pain to introduce later. | ||||
| * | | Allow additional_resources to implement Resource directly (#6686) | Richard van der Hoff | 2020-01-13 | 1 | -2/+11 |
| | | | | | | | | | | | | | | | | | | AdditionalResource really doesn't add any value, and it gets in the way for resources which want to support child resources or the like. So, if the resource object already implements the IResource interface, don't bother wrapping it. | ||||
| * | | Fix exceptions on requests for non-ascii urls (#6682) | Richard van der Hoff | 2020-01-13 | 1 | -1/+1 |
| | | | | | | | | | Fixes #6402 | ||||
| * | | comment for run_in_background | Richard van der Hoff | 2020-01-12 | 1 | -0/+3 |
| | | | |||||
| * | | Refuse to start if sqlite is older than 3.11.0 | Richard van der Hoff | 2020-01-09 | 2 | -4/+7 |
| | | | |||||
| * | | Check postgres version in check_database | Richard van der Hoff | 2020-01-09 | 1 | -13/+12 |
| | | | | | | | | | | | | | | | this saves doing it on each connection, and will allow us to pass extra options in. | ||||
| * | | Modify check_database to take a connection rather than a cursor | Richard van der Hoff | 2020-01-09 | 3 | -10/+11 |
| |/ | | | | | | | We might not need the cursor at all. | ||||
* | | Handle `config` not being set for synapse plugin modules | Richard van der Hoff | 2020-01-12 | 1 | -1/+1 |
| | | | | | | | | | | Some modules don't need any config, so having to define a `config` property just to keep the loader happy is a bit annoying. | ||||
* | | Cleanups and additions to the module API | Richard van der Hoff | 2020-01-12 | 2 | -6/+59 |
|/ | | | | | | | | | | | Add some useful things, such as error types and logcontext handling, to the API. Make `hs` a private member to dissuade people from using it (hopefully they aren't already). Add a couple of new methods (`record_user_external_id` and `generate_short_term_login_token`). | ||||
* | Allow admin users to create or modify users without a shared secret (#6495) | Manuel Stahl | 2020-01-09 | 4 | -0/+155 |
| | | | Signed-off-by: Manuel Stahl <manuel.stahl@awesome-technologies.de> | ||||
* | Merge branch 'master' into develop | Erik Johnston | 2020-01-09 | 1 | -1/+1 |
|\ | |||||
| * | 1.8.0 | Erik Johnston | 2020-01-09 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #6664 from matrix-org/erikj/media_admin_apis | Erik Johnston | 2020-01-08 | 2 | -120/+130 |
|\ \ | | | | | | | Fix media repo admin APIs when using a media worker. | ||||
| * | | Shuffle the code | Erik Johnston | 2020-01-08 | 1 | -25/+16 |
| | | | |||||
| * | | Comments | Erik Johnston | 2020-01-08 | 1 | -0/+3 |
| | | | |||||
| * | | Do not rely on streaming events, as media repo doesn't | Erik Johnston | 2020-01-08 | 1 | -12/+26 |
| | | | |||||
| * | | Import RoomStore in media worker to fix admin APIs | Erik Johnston | 2020-01-08 | 1 | -0/+2 |
| | | | |||||
| * | | Move media admin store functions to worker store | Erik Johnston | 2020-01-08 | 1 | -120/+120 |
| | | | |||||
* | | | Merge remote-tracking branch 'origin/release-v1.8.0' into develop | Richard van der Hoff | 2020-01-08 | 2 | -24/+10 |
|\ \ \ | | |/ | |/| | |||||
| * | | Fix GET request on /_synapse/admin/v2/users endpoint (#6563) | Manuel Stahl | 2020-01-08 | 1 | -2/+2 |
| | | | | | | | | | | | | Fixes #6552 | ||||
| * | | Back out ill-advised notary server hackery (#6657) | Richard van der Hoff | 2020-01-08 | 1 | -22/+8 |
| |/ | | | | | | | | | | | | | | | | | | | | | This was ill-advised. We can't modify verify_keys here, because the response object has already been signed by the requested key. Furthermore, it's somewhat unnecessary because existing versions of Synapse (which get upset that the notary key isn't present in verify_keys) will fall back to a direct fetch via `/key/v2/server`. Also: more tests for fetching keys via perspectives: it would be nice if we actually tested when our fetcher can't talk to our notary impl. | ||||
* | | Correctly proxy remote group HTTP errors. (#6654) | Erik Johnston | 2020-01-07 | 1 | -0/+16 |
| | | | | | | | | | | e.g. if remote returns a 404 then that shouldn't be treated as an error but should be proxied through. | ||||
* | | Merge pull request #6621 from matrix-org/babolivier/purge_job_config_typo | Brendan Abolivier | 2020-01-07 | 1 | -5/+5 |
|\ \ | |/ |/| | Fix a typo in the purge jobs configuration example | ||||
| * | Reword | Brendan Abolivier | 2020-01-07 | 1 | -3/+3 |
| | | |||||
| * | Change the example from 5min to 12h | Brendan Abolivier | 2020-01-07 | 1 | -4/+4 |
| | | | | | | | | Have a purge job running every 5min is probably not something we want to advise admins to do as a sort-of default. | ||||
| * | Fix a typo in the purge jobs configuration example | Brendan Abolivier | 2020-01-03 | 1 | -1/+1 |
| | | |||||
* | | 1.8.0rc1 | Erik Johnston | 2020-01-07 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #6652 from matrix-org/babolivier/depth_missing_events | Brendan Abolivier | 2020-01-07 | 2 | -3/+3 |
|\ \ | | | | | | | Fix conditions failing if min_depth = 0 | ||||
| * | | Fix conditions failing if min_depth = 0 | Brendan Abolivier | 2020-01-07 | 2 | -3/+3 |
| |/ | | | | | | | This could result in Synapse not fetching prev_events for new events in the room if it has missed some events. | ||||
* | | Add a background update to clear tombstoned rooms from the directory (#6648) | Richard van der Hoff | 2020-01-07 | 4 | -1/+100 |
| | | | | | | | | | | | | * Add a background update to clear tombstoned rooms from the directory * use the ABC metaclass | ||||
* | | Async/await for background updates (#6647) | Richard van der Hoff | 2020-01-07 | 1 | -16/+20 |
| | | | | | | | | so that bg update routines can be async | ||||
* | | Merge pull request #6645 from matrix-org/rav/fix_synchrotron_error | Richard van der Hoff | 2020-01-07 | 2 | -15/+47 |
|\ \ | | | | | | | Fix exceptions in the synchrotron worker log when events are rejected. | ||||
| * | | Fix exceptions in log when rejected event is replicated | Richard van der Hoff | 2020-01-06 | 1 | -2/+9 |
| | | | |||||
| * | | async/await for SyncReplicationHandler.process_and_notify | Richard van der Hoff | 2020-01-06 | 1 | -5/+4 |
| | | | |||||
| * | | Clarify documentation on get_event* methods | Richard van der Hoff | 2020-01-06 | 1 | -9/+35 |
| | | | | | | | | | | | | Make it clearer how they behave in the face of rejected and/or missing events. | ||||
* | | | Merge pull request #6629 from matrix-org/rav/kill_event_reference_hashes | Richard van der Hoff | 2020-01-06 | 4 | -87/+49 |
|\ \ \ | |/ / |/| | | Remove a bunch of unused code from event creation | ||||
| * | | Remove unused get_latest_event_ids_and_hashes_in_room | Richard van der Hoff | 2020-01-06 | 1 | -42/+0 |
| | | | |||||
| * | | Remove unused get_prev_events_and_hashes_for_room | Richard van der Hoff | 2020-01-06 | 1 | -30/+0 |
| | | | |||||
| * | | Remove unused hashes and depths from _update_membership params | Richard van der Hoff | 2020-01-06 | 1 | -13/+4 |
| | | | |||||
| * | | Remove unused hashes and depths from create_event params | Richard van der Hoff | 2020-01-06 | 2 | -17/+12 |
| | | | |||||
| * | | Remove unused hashes and depths from create_new_client_event params | Richard van der Hoff | 2020-01-06 | 2 | -12/+26 |
| | | | |||||
| * | | replace get_prev_events_and_hashes_for_room with get_prev_events_for_room in ↵ | Richard van der Hoff | 2020-01-06 | 2 | -9/+38 |
| | | | | | | | | | | | | create_new_client_event | ||||
| * | | rename get_prev_events_for_room to get_prev_events_and_hashes_for_room | Richard van der Hoff | 2020-01-06 | 3 | -5/+10 |
| | | | | | | | | | | | | ... to make way for a new method which just returns the event ids | ||||
* | | | Fix some test failures when frozen_dicts are enabled (#6642) | Richard van der Hoff | 2020-01-06 | 4 | -11/+19 |
| | | | | | | | | | | | | Fixes #4026 | ||||
* | | | Add experimental 'databases' config (#6580) | Erik Johnston | 2020-01-06 | 2 | -13/+63 |
| | | | |||||
* | | | Fix an error which was thrown by the PresenceHandler _on_shutdown handler. ↵ | Richard van der Hoff | 2020-01-06 | 1 | -7/+2 |
| | | | | | | | | | | | | (#6640) | ||||
* | | | Fix exception when fetching notary server's old keys (#6625) | Richard van der Hoff | 2020-01-06 | 1 | -6/+7 |
| | | | | | | | | | | | | | | | | | | Lift the restriction that *all* the keys used for signing v2 key responses be present in verify_keys. Fixes #6596. | ||||
* | | | Workaround for error when fetching notary's own key (#6620) | Richard van der Hoff | 2020-01-06 | 1 | -8/+22 |
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | * Kill off redundant SynapseRequestFactory We already get the Site via the Channel, so there's no need for a dedicated RequestFactory: we can just use the right constructor. * Workaround for error when fetching notary's own key As a notary server, when we return our own keys, include all of our signing keys in verify_keys. This is a workaround for #6596. | ||||
* | | Fix power levels being incorrectly set in old and new rooms after a room ↵ | Andrew Morgan | 2020-01-06 | 1 | -7/+10 |
| | | | | | | | | | | | | upgrade (#6633) Modify a copy of an upgraded room's PL before sending to the new room | ||||
* | | Automate generation of the sample and debian log configs (#6627) | Richard van der Hoff | 2020-01-03 | 1 | -1/+8 |
| | | |||||
* | | Raise an error if someone tries to use the log_file config option (#6626) | Richard van der Hoff | 2020-01-03 | 2 | -3/+16 |
| | | | | | | | | This has caused some confusion for people who didn't notice it going away. | ||||
* | | Remove unused, undocumented "content repo" resource (#6628) | Richard van der Hoff | 2020-01-03 | 6 | -123/+2 |
| | | | | | | | | | | | | This looks like it got half-killed back in #888. Fixes #6567. | ||||
* | | Kill off redundant SynapseRequestFactory (#6619) | Richard van der Hoff | 2020-01-03 | 1 | -15/+3 |
| | | | | | | | | We already get the Site via the Channel, so there's no need for a dedicated RequestFactory: we can just use the right constructor. | ||||
* | | Reduce the reconnect time when replication fails. (#6617) | Richard van der Hoff | 2020-01-03 | 1 | -1/+2 |
|/ | |||||
* | Merge branch 'master' into develop | Richard van der Hoff | 2019-12-31 | 2 | -16/+38 |
|\ | |||||
| * | 1.7.3 v1.7.3 github/release-v1.7.3 release-v1.7.3 | Richard van der Hoff | 2019-12-31 | 1 | -1/+1 |
| | | |||||
| * | Hacks to work around #6605 (#6608) | Richard van der Hoff | 2019-12-31 | 1 | -15/+37 |
| | | | | | | | | | | When we have an event which refers to non-existent auth_events, ignore said events rather than exploding in a ball of fire. Fixes #6605. | ||||
* | | Merge branch 'master' into develop | Richard van der Hoff | 2019-12-20 | 2 | -2/+5 |
|\| | |||||
| * | 1.7.2 v1.7.2 github/release-v1.7.2 release-v1.7.2 | Richard van der Hoff | 2019-12-20 | 1 | -1/+1 |
| | | |||||
| * | Backport fixes to sqlite upgrade from develop (#6578) | Richard van der Hoff | 2019-12-20 | 1 | -1/+9 |
| | | | | | | | | | | Only run prepare_database on connection for in-memory databases. Fixes #6569. | ||||
| * | Fix exceptions when attempting to backfill (#6576) | Richard van der Hoff | 2019-12-20 | 1 | -1/+4 |
| | | | | | | Fixes #6575 | ||||
* | | Split state groups into a separate data store (#6296) | Erik Johnston | 2019-12-20 | 24 | -1162/+1152 |
| | | |||||
* | | Change EventContext to use the Storage class (#6564) | Erik Johnston | 2019-12-20 | 13 | -39/+49 |
| | | |||||
* | | Explode on duplicate delta file names. (#6565) | Erik Johnston | 2019-12-19 | 1 | -0/+18 |
| | | |||||
* | | Port some admin handlers to async/await (#6559) | Erik Johnston | 2019-12-19 | 3 | -56/+45 |
| | | |||||
* | | Improve diagnostics on database upgrade failure (#6570) | Richard van der Hoff | 2019-12-19 | 2 | -8/+6 |
| | | | | | | | | `Failed to upgrade database` is not helpful, and it's unlikely that UPGRADE.rst has anything useful. | ||||
* | | Fix sdnotify with acme enabled (#6571) | Richard van der Hoff | 2019-12-19 | 1 | -3/+7 |
| | | | | | | | | | | | | | | If acme was enabled, the sdnotify startup hook would never be run because we would try to add it to a hook which had already fired. There's no need to delay it: we can sdnotify as soon as we've started the listeners. | ||||
* | | Add an export_signing_key script (#6546) | Richard van der Hoff | 2019-12-19 | 1 | -8/+15 |
| | | | | | | | | | | I want to do some key rotation, and it is silly that we don't have a way to do this. | ||||
* | | Clean up startup for the pusher (#6558) | Richard van der Hoff | 2019-12-18 | 4 | -43/+37 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Remove redundant python2 support code `str.decode()` doesn't exist on python3, so presumably this code was doing nothing * Filter out pushers with corrupt data When we get a row with unparsable json, drop the row, rather than returning a row with null `data`, which will then cause an explosion later on. * Improve logging when we can't start a pusher Log the ID to help us understand the problem * Make email pusher setup more robust We know we'll have a `data` member, since that comes from the database. What we *don't* know is if that is a dict, and if that has a `brand` member, and if that member is a string. | ||||
* | | Add delta file to fix missing default table data (#6555) | Andrew Morgan | 2019-12-18 | 3 | -15/+23 |
| | |