summary refs log tree commit diff
path: root/synapse (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Merge tag 'v1.36.0rc2' into developErik Johnston2021-06-111-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | Synapse 1.36.0rc2 (2021-06-11) ============================== Bugfixes -------- - Fix a bug which caused presence updates to stop working some time after a restart, when using a presence writer worker. Broke in v1.33.0. ([\#10149](https://github.com/matrix-org/synapse/issues/10149)) - Fix a bug when using federation sender worker where it would send out more presence updates than necessary, leading to high resource usage. Broke in v1.33.0. ([\#10163](https://github.com/matrix-org/synapse/issues/10163)) - Fix a bug where Synapse could send the same presence update to a remote twice. ([\#10165](https://github.com/matrix-org/synapse/issues/10165))
| * 1.36.0rc2Erik Johnston2021-06-111-1/+1
| |
| * Only send a presence state to a destination once (#10165)Erik Johnston2021-06-111-13/+12
| | | | | | | | It turns out that we were sending the same presence state to a remote potentially multiple times.
| * Fix sending presence over federation when using workers (#10163)Erik Johnston2021-06-111-6/+19
| | | | | | | | | | | | When using a federation sender we'd send out all local presence updates over federation even when they shouldn't be. Fixes #10153.
| * Fix bug when running presence off master (#10149)Erik Johnston2021-06-112-1/+16
| | | | | | Hopefully fixes #10027.
* | Only send a presence state to a destination once (#10165)Erik Johnston2021-06-111-13/+12
| | | | | | | | It turns out that we were sending the same presence state to a remote potentially multiple times.
* | Support for database schema version ranges (#9933)Richard van der Hoff2021-06-114-76/+108
| | | | | | This is essentially an implementation of the proposal made at https://hackmd.io/@richvdh/BJYXQMQHO, though the details have ended up looking slightly different.
* | Fix sending presence over federation when using workers (#10163)Erik Johnston2021-06-111-6/+19
| | | | | | | | | | | | When using a federation sender we'd send out all local presence updates over federation even when they shouldn't be. Fixes #10153.
* | Clean up a broken import in admin_cmd.py (#10154)Andrew Morgan2021-06-111-2/+0
| |
* | Fix bug when running presence off master (#10149)Erik Johnston2021-06-112-1/+16
| | | | | | Hopefully fixes #10027.
* | Add metrics to track how often events are `soft_failed` (#10156)Eric Eastwood2021-06-111-0/+7
| | | | | | | | | | | | | | | | | | | | | | Spawned from missing messages we were seeing on `matrix.org` from a federated Gtiter bridged room, https://gitlab.com/gitterHQ/webapp/-/issues/2770. The underlying issue in Synapse is tracked by https://github.com/matrix-org/synapse/issues/10066 where the message and join event race and the message is `soft_failed` before the `join` event reaches the remote federated server. Less soft_failed events = better and usually this should only trigger for events where people are doing bad things and trying to fuzz and fake everything.
* | Mention that you need to configure max upload size in reverse proxy as well ↵Aaron Raimist2021-06-101-0/+4
| | | | | | | | | | (#10122) Signed-off-by: Aaron Raimist <aaron@raim.ist>
* | Integrate knock rooms with the public rooms directory (#9359)Andrew Morgan2021-06-092-5/+10
| | | | | | | | | | | | | | | | | | | | This PR implements the ["Changes regarding the Public Rooms Directory"](https://github.com/Sorunome/matrix-doc/blob/soru/knock/proposals/2403-knock.md#changes-regarding-the-public-rooms-directory) section of knocking MSC2403. Specifically, it: * Allows rooms with `join_rule` "knock" to be returned by the query behind the public rooms directory * Adds the field `join_rule` to each room entry returned by a public rooms directory query, so clients can know whether to attempt a join or knock on a room Based on https://github.com/matrix-org/synapse/issues/6739. Complement tests for this change: https://github.com/matrix-org/complement/pull/72
* | Implement knock feature (#6739)Sorunome2021-06-0926-116/+1217
| | | | | | | | | | | | This PR aims to implement the knock feature as proposed in https://github.com/matrix-org/matrix-doc/pull/2403 Signed-off-by: Sorunome mail@sorunome.de Signed-off-by: Andrew Morgan andrewm@element.io
* | Limit the number of in-flight /keys/query requests from a single device. ↵Patrick Cloke2021-06-092-170/+185
| | | | | | | | (#10144)
* | Clean up the interface for injecting opentracing over HTTP (#10143)Richard van der Hoff2021-06-093-92/+25
| | | | | | | | | | | | | | * Remove unused helper functions * Clean up the interface for injecting opentracing over HTTP * changelog
* | Add type hints to the federation server transport. (#10080)Patrick Cloke2021-06-084-75/+193
|/
* 1.36.0rc1Andrew Morgan2021-06-081-1/+1
|
* Fix logging context when opening new DB connection (#10141)Erik Johnston2021-06-081-3/+9
| | | | Fixes #10140
* Correct type hints for parse_string(s)_from_args. (#10137)Patrick Cloke2021-06-086-83/+130
|
* When joining a remote room limit the number of events we concurrently check ↵Erik Johnston2021-06-084-256/+201
| | | | | signatures/hashes for (#10117) If we do hundreds of thousands at once the memory overhead can easily reach 500+ MB.
* Handle /backfill returning no events (#10133)Erik Johnston2021-06-081-13/+25
| | | Fixes #10123
* More database opentracing (#10136)Richard van der Hoff2021-06-071-2/+5
| | | Add a couple of extra logs/spans, to give a bit of a better idea.
* opentracing: use a consistent name for background processes (#10135)Richard van der Hoff2021-06-072-2/+4
| | | | ... otherwise we tend to get a namespace clash between the bg process and the functions that it calls.
* Always update AS last_pos, even on no events (#10107)14mRh4X0r2021-06-071-13/+12
| | | | | | | | | | Fixes #1834. `get_new_events_for_appservice` internally calls `get_events_as_list`, which will filter out any rejected events. If all returned events are filtered out, `_notify_interested_services` will return without updating the last handled stream position. If there are 100 consecutive such events, processing will halt altogether. Breaking the loop is now done by checking whether we're up-to-date with `current_max` in the loop condition, instead of relying on an empty `events` list. Signed-off-by: Willem Mulder <14mRh4X0r@gmail.com>
* Add missing type hints to the admin API servlets (#10105)Dirk Klimpel2021-06-075-40/+47
|
* Delete completes to-device messages earlier in /sync (#10124)Richard van der Hoff2021-06-071-10/+11
| | | | I hope this will improve https://github.com/matrix-org/synapse/issues/9564.
* Don't try and backfill the same room in parallel. (#10116)Erik Johnston2021-06-041-0/+8
| | | | | If backfilling is slow then the client may time out and retry, causing Synapse to start a new `/backfill` before the existing backfill has finished, duplicating work.
* Limit number of events in a replication request (#10118)Erik Johnston2021-06-041-2/+3
| | | Fixes #9956.
* Enable Prometheus metrics for the jaeger client library (#10112)Richard van der Hoff2021-06-041-0/+3
|
* Add OpenTracing for database activity. (#10113)Richard van der Hoff2021-06-032-33/+59
| | | | | | | | | | This adds quite a lot of OpenTracing decoration for database activity. Specifically it adds tracing at four different levels: * emit a span for each "interaction" - ie, the top level database function that we tend to call "transaction", but isn't really, because it can end up as multiple transactions. * emit a span while we hold a database connection open * emit a span for each database transaction - actual actual transaction. * emit a span for each database query. I'm aware this might be quite a lot of overhead, but even just running it on a local Synapse it looks really interesting, and I hope the overhead can be offset just by turning down the sampling frequency and finding other ways of tracing requests of interest (eg, the `force_tracing_for_users` setting).
* Improve opentracing annotations for Notifier (#10111)Richard van der Hoff2021-06-031-33/+33
| | | | | | | The existing tracing reports an error each time there is a timeout, which isn't really representative. Additionally, we log things about the way `wait_for_events` works (eg, the result of the callback) to the *parent* span, which is confusing.
* r0.6.1 support: /rooms/:roomId/aliases endpoint (#9224)Travis Ralston2021-06-031-1/+1
| | | | | | [MSC2432](https://github.com/matrix-org/matrix-doc/pull/2432) added this endpoint originally but it has since been included in the spec for nearly a year. This is progress towards https://github.com/matrix-org/synapse/issues/8334
* Merge branch 'master' into developPatrick Cloke2021-06-031-1/+1
|\
| * 1.35.1Patrick Cloke2021-06-031-1/+1
| |
| * Do not show invite-only rooms in spaces summary (unless joined/invited). ↵Patrick Cloke2021-06-031-10/+9
| | | | | | | | (#10109)
* | Add new admin APIs to remove media by media ID from quarantine. (#10044)Dirk Klimpel2021-06-022-10/+50
| | | | | | | | | | Related to: #6681, #5956, #10040 Signed-off-by: Dirk Klimpel dirk@klimpel.org
* | Rewrite the KeyRing (#10035)Erik Johnston2021-06-024-378/+281
| |
* | Do not show invite-only rooms in spaces summary (unless joined/invited). ↵Patrick Cloke2021-06-021-10/+9
| | | | | | | | (#10109)
* | Make /sync do less state res (#10102)Erik Johnston2021-06-021-2/+2
| |
* | Merge branch 'master' into developAndrew Morgan2021-06-013-2/+21
|\|
| * 1.35.0Andrew Morgan2021-06-011-1/+1
| |
| * 1.35.0rc3Erik Johnston2021-05-281-1/+1
| |
| * Merge remote-tracking branch 'origin/release-v1.35.0' into release-v1.35Erik Johnston2021-05-281-1/+1
| |\
| * | Limit the number of events sent over replication when persisting events. ↵Brendan Abolivier2021-05-281-7/+10
| | | | | | | | | | | | (#10082)
| * | Log method and path when dropping request due to size limit (#10091)Erik Johnston2021-05-281-1/+3
| | |
| * | Allow response of `/send_join` to be larger. (#10093)Erik Johnston2021-05-282-1/+20
| | | | | | | | | Fixes #10087.
* | | add a cache to have_seen_event (#9953)Richard van der Hoff2021-06-014-19/+81
| | | | | | | | | Empirically, this helped my server considerably when handling gaps in Matrix HQ. The problem was that we would repeatedly call have_seen_events for the same set of (50K or so) auth_events, each of which would take many minutes to complete, even though it's only an index scan.
* | | Fix opentracing inject to use the SpanContext, not the Span (#10074)Brad Murray2021-06-011-5/+5
| | | | | | | | | Signed-off-by: Brad Murray brad@beeper.com
* | | Set opentracing priority before setting other tags (#10092)Richard van der Hoff2021-05-284-11/+31
| | | | | | | | | ... because tags on spans which aren't being sampled get thrown away.
* | | Log method and path when dropping request due to size limit (#10091)Erik Johnston2021-05-281-1/+3
| | |
* | | Add `parse_strings_from_args` to get `prev_events` array (#10048)Eric Eastwood2021-05-281-43/+153
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Split out from https://github.com/matrix-org/synapse/pull/9247 Strings: - `parse_string` - `parse_string_from_args` - `parse_strings_from_args` For comparison with ints: - `parse_integer` - `parse_integer_from_args` Previous discussions: - https://github.com/matrix-org/synapse/pull/9247#discussion_r573195687 - https://github.com/matrix-org/synapse/pull/9247#discussion_r574214156 - https://github.com/matrix-org/synapse/pull/9247#discussion_r573264791 Signed-off-by: Eric Eastwood <erice@element.io>
* | | Move some more endpoints off master (#10084)Erik Johnston2021-05-272-6/+6
| | |
* | | Make reason and score optional for report_event (#10077)Callum Brown2021-05-272-10/+5
| | | | | | | | | | | | | | | | | | Implements MSC2414: https://github.com/matrix-org/matrix-doc/pull/2414 See #8551 Signed-off-by: Callum Brown <callum@calcuode.com>
* | | Limit the number of events sent over replication when persisting events. ↵Brendan Abolivier2021-05-271-7/+10
| | | | | | | | | | | | (#10082)
* | | Merge tag 'v1.35.0rc2' into developErik Johnston2021-05-272-2/+2
|\ \ \ | | |/ | |/| | | | | | | | | | | | | | | | | | | | | | Synapse 1.35.0rc2 (2021-05-27) ============================== Bugfixes -------- - Fix a bug introduced in v1.35.0rc1 when calling the spaces summary API via a GET request. ([\#10079](https://github.com/matrix-org/synapse/issues/10079))
| * | 1.35.0rc2 v1.35.0rc2 github/release-v1.35.0 release-v1.35.0Erik Johnston2021-05-271-1/+1
| |/
| * Pass the origin when calculating the spaces summary over GET. (#10079)Patrick Cloke2021-05-271-1/+1
| | | | | | | | Fixes a bug due to conflicting PRs which were merged. (One added a new caller to a method, the other added a new parameter to the same method.)
* | Fix up `BatchingQueue` (#10078)Erik Johnston2021-05-271-22/+48
| | | | | | Fixes #10068
* | Remove redundant code to reload tls cert (#10054)Richard van der Hoff2021-05-272-23/+4
| | | | | | | | | | we don't need to reload the tls cert if we don't have any tls listeners. Follow-up to #9280.
* | Combine `LruCache.invalidate` and `invalidate_many` (#9973)Richard van der Hoff2021-05-2710-49/+48
| | | | | | | | | | | | | | | | | | | | * Make `invalidate` and `invalidate_many` do the same thing ... so that we can do either over the invalidation replication stream, and also because they always confused me a bit. * Kill off `invalidate_many` * changelog
* | Remove the experimental spaces enabled flag. (#10063)Patrick Cloke2021-05-264-34/+8
| | | | | | | | In lieu of just always enabling the unstable spaces endpoint and unstable room version.
* | Add an admin API for unprotecting local media from quarantine (#10040)Dirk Klimpel2021-05-262-5/+30
|/ | | Signed-off-by: Dirk Klimpel dirk@klimpel.org
* 1.35.0rc1 v1.35.0rc1Erik Johnston2021-05-251-1/+1
|
* Add missing type hints to synapse.util (#9982)Patrick Cloke2021-05-246-23/+27
|
* Remove tls_fingerprints option (#9280)Jerin J Titus2021-05-243-61/+0
| | | | Signed-off-by: Jerin J Titus <72017981+jerinjtitus@users.noreply.github.com>
* Remove `keylen` from `LruCache`. (#9993)Richard van der Hoff2021-05-248-51/+73
| | | | | | | `keylen` seems to be a thing that is frequently incorrectly set, and we don't really need it. The only time it was used was to figure out if we had removed a subtree in `del_multi`, which we can do better by changing `TreeCache.pop` to return a different type (`TreeCacheNode`). Commits should be independently reviewable.
* Enable experimental spaces by default. (#10011)Patrick Cloke2021-05-242-2/+19
| | | | The previous spaces_enabled flag now defaults to true and is exposed in the sample config.
* Fix `get_state_ids_for_event` return type typo to match what the function ↵Eric Eastwood2021-05-241-1/+1
| | | | | actually does (#10050) It looks like a typo copy/paste from `get_state_for_event` above.
* Don't hammer the database for destination retry timings every ~5mins (#10036)Erik Johnston2021-05-216-60/+43
|
* Fix /upload 500'ing when presented a very large image (#10029)Michael Telatynski2021-05-212-0/+11
| | | | | | | | | | | | * Fix /upload 500'ing when presented a very large image Catch DecompressionBombError and re-raise as ThumbnailErrors * Set PIL's MAX_IMAGE_PIXELS to match homeserver.yaml to get it to bomb out quicker, to load less into memory in the case of super large images * Add changelog entry for 10029
* Remove unused properties from the SpaceSummaryHandler. (#10038)Patrick Cloke2021-05-211-2/+0
|
* Fixed removal of new presence stream states (#10014)Marek Matys2021-05-211-9/+9
| | | | | | | | | Fixes: https://github.com/matrix-org/synapse/issues/9962 This is a fix for above problem. I fixed it by swaping the order of insertion of new records and deletion of old ones. This ensures that we don't delete fresh database records as we do deletes before inserts. Signed-off-by: Marek Matys <themarcq@gmail.com>
* Add a batching queue implementation. (#10017)Erik Johnston2021-05-211-0/+153
|
* Add `Keyring.verify_events_for_server` and reduce memory usage (#10018)Erik Johnston2021-05-202-22/+93
| | | | | | Also add support for giving a callback to generate the JSON object to verify. This should reduce memory usage, as we no longer have the event in memory in dict form (which has a large memory footprint) for extend periods of time.
* Use ijson to parse the response to `/send_join`, reducing memory usage. (#9958)Erik Johnston2021-05-205-58/+223
| | | Instead of parsing the full response to `/send_join` into Python objects (which can be huge for large rooms) and *then* parsing that into events, we instead use ijson to stream parse the response directly into `EventBase` objects.
* Allow a user who could join a restricted room to see it in spaces summary. ↵Patrick Cloke2021-05-203-54/+253
| | | | | | (#9922) This finishes up the experimental implementation of MSC3083 by showing the restricted rooms in the spaces summary (from MSC2946).
* Refactor checking restricted join rules (#10007)Patrick Cloke2021-05-183-51/+49
| | | | | To be more consistent with similar code. The check now automatically raises an AuthError instead of passing back a boolean. It also absorbs some shared logic between callers.
* Use a database table to hold the users that should have full presence sent ↵Andrew Morgan2021-05-186-65/+245
| | | | to them, instead of something in-memory (#9823)
* Fix the allowed range of valid ordering characters for spaces. (#10002)Patrick Cloke2021-05-171-2/+2
| | | | \x7F was meant to be \0x7E (~) this was originally incorrect in MSC1772.
* Clarify comments in the space summary handler. (#9974)Patrick Cloke2021-05-171-5/+46
|
* Merge branch 'master' into developErik Johnston2021-05-171-1/+1
|\
| * 1.34.0Erik Johnston2021-05-171-1/+1
| |
* | Split multiplart email sending into a dedicated handler (#9977)Brendan Abolivier2021-05-174-90/+121
| | | | | | Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* | Minor `@cachedList` enhancements (#9975)Richard van der Hoff2021-05-144-17/+16
| | | | | | | | | | | | - use a tuple rather than a list for the iterable that is passed into the wrapped function, for performance - test that we can pass an iterable and that keys are correctly deduped.
* | Remove unnecessary SystemRandom from SQLBaseStore (#9987)Dan Callahan2021-05-142-3/+2
| | | | | | | | | | | | | | | | It's not obvious that instances of SQLBaseStore each need their own instances of random.SystemRandom(); let's just use random directly. Introduced by 52839886d664576831462e033b88e5aba4c019e3 Signed-off-by: Dan Callahan <danc@element.io>
* | Remove superfluous call to bool() (#9986)Dan Callahan2021-05-141-1/+1
| | | | | | | | | | Our strtobool already returns a bool, so no need to re-cast here Signed-off-by: Dan Callahan <danc@element.io>
* | Simplify exception handling in is_ascii. (#9985)Dan Callahan2021-05-141-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We can get away with just catching UnicodeError here. ⋮ +-- ValueError | +-- UnicodeError | +-- UnicodeDecodeError | +-- UnicodeEncodeError | +-- UnicodeTranslateError ⋮ https://docs.python.org/3/library/exceptions.html#exception-hierarchy Signed-off-by: Dan Callahan <danc@element.io>
* | Use Python's secrets module instead of random (#9984)Dan Callahan2021-05-141-8/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Functionally identical, but more obviously cryptographically secure. ...Explicit is better than implicit? Avoids needing to know that SystemRandom() implies a CSPRNG, and complies with the big scary red box on the documentation for random: > Warning: > The pseudo-random generators of this module should not be used for > security purposes. For security or cryptographic uses, see the > secrets module. https://docs.python.org/3/library/random.html Signed-off-by: Dan Callahan <danc@element.io>
* | Support enabling opentracing by user (#9978)Richard van der Hoff2021-05-142-6/+36
|/ | | | | Add a config option which allows enabling opentracing by user id, eg for debugging requests made by a test user.
* 1.34.0rc1Brendan Abolivier2021-05-121-1/+1
|
* Correctly ratelimit invites when creating a room (#9968)Brendan Abolivier2021-05-123-12/+62
| | | | | * Correctly ratelimit invites when creating a room Also allow ratelimiting for more than one action at a time.
* Change the format of access tokens away from macaroons (#5588)Richard van der Hoff2021-05-123-10/+42
|
* Run cache_joined_hosts_for_event in background (#9951)Erik Johnston2021-05-121-5/+40
|
* Sort child events according to MSC1772 for the spaces summary API. (#9954)Patrick Cloke2021-05-111-2/+69
| | | | | | | | | This should help ensure that equivalent results are achieved between homeservers querying for the summary of a space. This implements modified MSC1772 rules, according to MSC2946. The different is that the origin_server_ts of the m.room.create event is not used as a tie-breaker since this might not be known if the homeserver is not part of the room.
* Support fetching the spaces summary via GET over federation. (#9947)Patrick Cloke2021-05-113-0/+28
| | | | | | | | | | | Per changes in MSC2946, the C-S and S-S APIs for spaces summary should use GET requests. Until this is stable, the POST endpoints still exist. This does not switch federation requests to use the GET version yet since it is newly added and already deployed servers might not support it. When switching to the stable endpoint we should switch to GET requests.
* Send the `m.room.create` stripped event with invites (support MSC1772). (#9966)Patrick Cloke2021-05-111-4/+2
| | | | | MSC1772 specifies the m.room.create event should be sent as part of the invite_state. This was done optionally behind an experimental flag, but is now done by default due to MSC1772 being approved.
* Merge branch 'master' into developBrendan Abolivier2021-05-114-69/+53
|\
| * 1.33.2Brendan Abolivier2021-05-111-1/+1
| |
| * Merge pull request from GHSA-x345-32rc-8h85Richard van der Hoff2021-05-113-68/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * tests for push rule pattern matching * tests for acl pattern matching * factor out common `re.escape` * Factor out common re.compile * Factor out common anchoring code * add word_boundary support to `glob_to_regex` * Use `glob_to_regex` in push rule evaluator NB that this drops support for character classes. I don't think anyone ever used them. * Improve efficiency of globs with multiple wildcards The idea here is that we compress multiple `*` globs into a single `.*`. We also need to consider `?`, since `*?*` is as hard to implement efficiently as `**`. * add assertion on regex pattern * Fix mypy * Simplify glob_to_regex * Inline the glob_to_regex helper function Signed-off-by: Dan Callahan <danc@element.io> * Moar comments Signed-off-by: Dan Callahan <danc@element.io> Co-authored-by: Dan Callahan <danc@element.io>
* | Add config option to hide device names over federation (#9945)Aaron Raimist2021-05-112-1/+13
| | | | | | | | | | Now that cross signing exists there is much less of a need for other people to look at devices and verify them individually. This PR adds a config option to allow you to prevent device display names from being shared with other servers. Signed-off-by: Aaron Raimist <aaron@raim.ist>
* | Add debug logging for issue #9533 (#9959)Richard van der Hoff2021-05-115-2/+41
| | | | | | | | | | Hopefully this will help us track down where to-device messages are getting lost/delayed.
* | Fix `m.room_key_request` to-device messages (#9961)Richard van der Hoff2021-05-113-26/+31
| | | | | | fixes #9960
* | Improve performance of backfilling in large rooms. (#9935)Erik Johnston2021-05-101-69/+54
| | | | | | | | | | | | We were pulling the full auth chain for the room out of the DB each time we backfilled, which can be *huge* for large rooms and is totally unnecessary.
* | Always cache 'event_to_prev_state_group' (#9950)Erik Johnston2021-05-071-6/+7
| | | | | | Fixes regression in send PDU times introduced in #9905.
* | Merge remote-tracking branch 'origin/release-v1.33.2' into developErik Johnston2021-05-071-1/+1
|\|
| * Unpin attrs dep after new version has been released (#9946)Erik Johnston2021-05-071-1/+1
| | | | | | c.f. #9936
* | Reorganise the database schema directories (#9932)Richard van der Hoff2021-05-07282-44/+79
| | | | | | | | | | The hope here is that by moving all the schema files into synapse/storage/schema, it gets a bit easier for newcomers to navigate. It certainly got easier for me to write a helpful README. There's more to do on that front, but I'll follow up with other PRs for that.
* | Export jemalloc stats to prometheus when used (#9882)Erik Johnston2021-05-063-0/+199
| |
* | Revert "Leave out optional keys from /sync (#9919)" (#9940)Erik Johnston2021-05-061-44/+18
| | | | | | This reverts commit e9eb3549d32a6f93d07de8dbd5e1ebe54c8d8278.
* | Merge remote-tracking branch 'origin/master' into developErik Johnston2021-05-062-2/+3
|\|
| * 1.33.1 v1.33.1 github/release-v1.33.1 release-v1.33.1Erik Johnston2021-05-061-1/+1
| |
| * Pin attrs to <21.1.0 (#9937)Erik Johnston2021-05-061-1/+2
| | | | | | Fixes #9936
* | Follow-up to #9915 to correct the identifier for room types.Patrick Cloke2021-05-051-1/+1
| |
* | Include the time of the create event in Spaces Summary. (#9928)Patrick Cloke2021-05-051-0/+1
| | | | | | | | | | This is an update based on changes to MSC2946. The origin_server_ts of the m.room.create event is copied into the creation_ts field for each room returned from the spaces summary.
* | Increase perf of handling presence when joining large rooms. (#9916)Erik Johnston2021-05-051-72/+82
| |
* | Support stable MSC1772 spaces identifiers. (#9915)Patrick Cloke2021-05-052-2/+9
| | | | | | | | Support both the unstable and stable identifiers. A future release will disable the unstable identifiers.
* | Optionally track memory usage of each LruCache (#9881)Erik Johnston2021-05-056-1/+93
| | | | | | | | | | This will double count slightly in the presence of interned strings. It's off by default as it can consume a lot of resources.
* | Limit how often GC happens by time. (#9902)Erik Johnston2021-05-054-3/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse can be quite memory intensive, and unless care is taken to tune the GC thresholds it can end up thrashing, causing noticable performance problems for large servers. We fix this by limiting how often we GC a given generation, regardless of current counts/thresholds. This does not help with the reverse problem where the thresholds are set too high, but that should only happen in situations where they've been manually configured. Adds a `gc_min_seconds_between` config option to override the defaults. Fixes #9890.
* | Don't set the external cache if its been done recently (#9905)Erik Johnston2021-05-052-5/+33
| |
* | Use get_current_users_in_room from store and not StateHandler (#9910)Erik Johnston2021-05-0510-17/+24
| |
* | Leave out optional keys from /sync (#9919)DeepBlueV7.X2021-05-051-18/+44
| | | | | | | | | | | | This leaves out all optional keys from /sync. This should be fine for all clients tested against conduit already, but it may break some clients, as such we should check, that at least most of them don't break horribly and maybe back out some of the individual changes. (We can probably always leave out groups for example, while the others may cause more issues.) Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
* | Merge branch 'master' into developBrendan Abolivier2021-05-051-1/+1
|\|
| * 1.33.0 v1.33.0 github/release-v1.33.0 release-v1.33.0Brendan Abolivier2021-05-051-1/+1
| |
* | Time external cache response time (#9904)Erik Johnston2021-05-041-10/+26
| |
* | Add port parameter to the sample config for psycopg2 args (#9911)Andrew Morgan2021-05-041-0/+1
| | | | | | Adds the `port` option with the default value to the sample config file.
* | Merge tag 'v1.33.0rc2' into developAndrew Morgan2021-04-291-1/+1
|\| | | | | | | | | | | | | | | | | | | Synapse 1.33.0rc2 (2021-04-29) ============================== Bugfixes -------- - Fix tight loop when handling presence replication when using workers. Introduced in v1.33.0rc1. ([\#9900](https://github.com/matrix-org/synapse/issues/9900))
| * 1.33.0rc2Andrew Morgan2021-04-291-1/+1
| |
* | Add missing type hints to handlers and fix a Spam Checker type hint. (#9896)Patrick Cloke2021-04-296-54/+80
| | | | | | | | | | The user_may_create_room_alias method on spam checkers declared the room_alias parameter as a str when in reality it is passed a RoomAlias object.
* | Delete room endpoint (#9889)ThibF2021-04-291-44/+90
| | | | | | | | | | | | Support the delete of a room through DELETE request and mark previous request as deprecated through documentation. Signed-off-by: Thibault Ferrante <thibault.ferrante@pm.me>
* | Merge remote-tracking branch 'origin/release-v1.33.0' into developErik Johnston2021-04-281-1/+23
|\|
| * Fix tight loop handling presence replication. (#9900)Erik Johnston2021-04-281-1/+23
| | | | | | | | | | Only affects workers. Introduced in #9819. Fixes #9899.
* | Use the parent's logging context name for runWithConnection. (#9895)Patrick Cloke2021-04-281-1/+3
| | | | | | | | | | This fixes a regression where the logging context for runWithConnection was reported as runWithConnection instead of the connection name, e.g. "POST-XYZ".
* | Merge tag 'v1.33.0rc1' into developAndrew Morgan2021-04-284-115/+75
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.33.0rc1 (2021-04-28) ============================== Features -------- - Update experimental support for [MSC3083](https://github.com/matrix-org/matrix-doc/pull/3083): restricting room access via group membership. ([\#9800](https://github.com/matrix-org/synapse/issues/9800), [\#9814](https://github.com/matrix-org/synapse/issues/9814)) - Add experimental support for handling presence on a worker. ([\#9819](https://github.com/matrix-org/synapse/issues/9819), [\#9820](https://github.com/matrix-org/synapse/issues/9820), [\#9828](https://github.com/matrix-org/synapse/issues/9828), [\#9850](https://github.com/matrix-org/synapse/issues/9850)) - Return a new template when an user attempts to renew their account multiple times with the same token, stating that their account is set to expire. This replaces the invalid token template that would previously be shown in this case. This change concerns the optional account validity feature. ([\#9832](https://github.com/matrix-org/synapse/issues/9832)) Bugfixes -------- - Fixes the OIDC SSO flow when using a `public_baseurl` value including a non-root URL path. ([\#9726](https://github.com/matrix-org/synapse/issues/9726)) - Fix thumbnail generation for some sites with non-standard content types. Contributed by @rkfg. ([\#9788](https://github.com/matrix-org/synapse/issues/9788)) - Add some sanity checks to identity server passed to 3PID bind/unbind endpoints. ([\#9802](https://github.com/matrix-org/synapse/issues/9802)) - Limit the size of HTTP responses read over federation. ([\#9833](https://github.com/matrix-org/synapse/issues/9833)) - Fix a bug which could cause Synapse to get stuck in a loop of resyncing device lists. ([\#9867](https://github.com/matrix-org/synapse/issues/9867)) - Fix a long-standing bug where errors from federation did not propagate to the client. ([\#9868](https://github.com/matrix-org/synapse/issues/9868)) Improved Documentation ---------------------- - Add a note to the docker docs mentioning that we mirror upstream's supported Docker platforms. ([\#9801](https://github.com/matrix-org/synapse/issues/9801)) Internal Changes ---------------- - Add a dockerfile for running Synapse in worker-mode under Complement. ([\#9162](https://github.com/matrix-org/synapse/issues/9162)) - Apply `pyupgrade` across the codebase. ([\#9786](https://github.com/matrix-org/synapse/issues/9786)) - Move some replication processing out of `generic_worker`. ([\#9796](https://github.com/matrix-org/synapse/issues/9796)) - Replace `HomeServer.get_config()` with inline references. ([\#9815](https://github.com/matrix-org/synapse/issues/9815)) - Rename some handlers and config modules to not duplicate the top-level module. ([\#9816](https://github.com/matrix-org/synapse/issues/9816)) - Fix a long-standing bug which caused `max_upload_size` to not be correctly enforced. ([\#9817](https://github.com/matrix-org/synapse/issues/9817)) - Reduce CPU usage of the user directory by reusing existing calculated room membership. ([\#9821](https://github.com/matrix-org/synapse/issues/9821)) - Small speed up for joining large remote rooms. ([\#9825](https://github.com/matrix-org/synapse/issues/9825)) - Introduce flake8-bugbear to the test suite and fix some of its lint violations. ([\#9838](https://github.com/matrix-org/synapse/issues/9838)) - Only store the raw data in the in-memory caches, rather than objects that include references to e.g. the data stores. ([\#9845](https://github.com/matrix-org/synapse/issues/9845)) - Limit length of accepted email addresses. ([\#9855](https://github.com/matrix-org/synapse/issues/9855)) - Remove redundant `synapse.types.Collection` type definition. ([\#9856](https://github.com/matrix-org/synapse/issues/9856)) - Handle recently added rate limits correctly when using `--no-rate-limit` with the demo scripts. ([\#9858](https://github.com/matrix-org/synapse/issues/9858)) - Disable invite rate-limiting by default when running the unit tests. ([\#9871](https://github.com/matrix-org/synapse/issues/9871)) - Pass a reactor into `SynapseSite` to make testing easier. ([\#9874](https://github.com/matrix-org/synapse/issues/9874)) - Make `DomainSpecificString` an `attrs` class. ([\#9875](https://github.com/matrix-org/synapse/issues/9875)) - Add type hints to `synapse.api.auth` and `synapse.api.auth_blocking` modules. ([\#9876](https://github.com/matrix-org/synapse/issues/9876)) - Remove redundant `_PushHTTPChannel` test class. ([\#9878](https://github.com/matrix-org/synapse/issues/9878)) - Remove backwards-compatibility code for Python versions < 3.6. ([\#9879](https://github.com/matrix-org/synapse/issues/9879)) - Small performance improvement around handling new local presence updates. ([\#9887](https://github.com/matrix-org/synapse/issues/9887))
| * 1.33.0rc1Andrew Morgan2021-04-281-1/+1
| |
| * Revert "Experimental Federation Speedup (#9702)"Andrew Morgan2021-04-283-114/+74
| | | | | | | | This reverts commit 05e8c70c059f8ebb066e029bc3aa3e0cefef1019.
* | Reduce memory footprint of caches (#9886)Erik Johnston2021-04-281-18/+59
| |
* | Add type hints to presence handler (#9885)Erik Johnston2021-04-281-70/+89
|/
* Remove various bits of compatibility code for Python <3.6 (#9879)Andrew Morgan2021-04-2710-80/+16
| | | I went through and removed a bunch of cruft that was lying around for compatibility with old Python versions. This PR also will now prevent Synapse from starting unless you're running Python 3.6+.
* Pass errors back to the client when trying multiple federation destinations. ↵Patrick Cloke2021-04-271-58/+60
| | | | | | | | (#9868) This ensures that something like an auth error (403) will be returned to the requester instead of attempting to try more servers, which will likely result in the same error, and then passing back a generic 400 error.
* Use current state table for `presence.get_interested_remotes` (#9887)Erik Johnston2021-04-271-7/+2
| | | This should be a lot quicker than asking the state handler.
* Improved validation for received requests (#9817)Richard van der Hoff2021-04-2310-31/+87
| | | | | | * Simplify `start_listening` callpath * Correctly check the size of uploaded files
* Allow OIDC cookies to work on non-root public baseurls (#9726)Andrew Morgan2021-04-232-9/+21
| | | | | Applied a (slightly modified) patch from https://github.com/matrix-org/synapse/issues/9574. As far as I understand this would allow the cookie set during the OIDC flow to work on deployments using public baseurls that do not sit at the URL path root.
* pass a reactor into SynapseSite (#9874)Richard van der Hoff2021-04-233-24/+39
|
* Add type hints to auth and auth_blocking. (#9876)Patrick Cloke2021-04-233-44/+47
|
* Make DomainSpecificString an attrs class (#9875)Erik Johnston2021-04-233-8/+23
|
* Split presence out of master (#9820)Erik Johnston2021-04-2313-158/+236
|
* Check for space membership during a remote join of a restricted room (#9814)Patrick Cloke2021-04-235-68/+130
| | | | | | When receiving a /send_join request for a room with join rules set to 'restricted', check if the user is a member of the spaces defined in the 'allow' key of the join rules. This only applies to an experimental room version, as defined in MSC3083.
* Only store data in caches, not "smart" objects (#9845)Erik Johnston2021-04-232-141/+181
|
* Limit the size of HTTP responses read over federation. (#9833)Richard van der Hoff2021-04-232-8/+50
|
* Limit length of accepted email addresses (#9855)Erik Johnston2021-04-224-7/+48
|
* Clear the resync bit after resyncing device lists (#9867)Richard van der Hoff2021-04-222-10/+16
| | | Fixes #9866.
* Remove `synapse.types.Collection` (#9856)Richard van der Hoff2021-04-2225-62/+76
| | | This is no longer required, since we have dropped support for Python 3.5.
* Merge branch 'master' into developAndrew Morgan2021-04-222-4/+13
|\
| * 1.32.2Andrew Morgan2021-04-211-1/+1
| |
| * Make LoggingContext's name optional (#9857)Richard van der Hoff2021-04-211-3/+12
| | | | | | | | Fixes https://github.com/matrix-org/synapse-s3-storage-provider/issues/55
* | Merge branch 'master' into developAndrew Morgan2021-04-213-6/+18
|\|
| * 1.32.1Andrew Morgan2021-04-211-1/+1
| |
| * Stop BackgroundProcessLoggingContext making new prometheus timeseries (#9854)Richard van der Hoff2021-04-212-5/+17
| | | | | | | | This undoes part of b076bc276e881b262048307b6a226061d96c4a8d.
* | Rename handler and config modules which end in handler/config. (#9816)Patrick Cloke2021-04-2012-27/+34
| |
* | Merge branch 'master' into developAndrew Morgan2021-04-205-28/+19
|\|
| * 1.32.0Andrew Morgan2021-04-201-1/+1
| |
| * Always use the name as the log ID. (#9829)Patrick Cloke2021-04-204-27/+18
| | | | | | | | | | As far as I can tell our logging contexts are meant to log the request ID, or sometimes the request ID followed by a suffix (this is generally stored in the name field of LoggingContext). There's also code to log the name@memory location, but I'm not sure this is ever used. This simplifies the code paths to require every logging context to have a name and use that in logging. For sub-contexts (created via nested_logging_contexts, defer_to_threadpool, Measure) we use the current context's str (which becomes their name or the string "sentinel") and then potentially modify that (e.g. add a suffix).
* | Add presence federation stream (#9819)Erik Johnston2021-04-204-23/+254
| |
* | Fix bug where we sent remote presence states to remote servers (#9850)Erik Johnston2021-04-202-3/+12
| |
* | Fix (final) Bugbear violations (#9838)Jonathan de Jong2021-04-208-22/+19
| |
* | Port "Allow users to click account renewal links multiple times without ↵Andrew Morgan2021-04-1914-185/+350
| | | | | | | | | | hitting an 'Invalid Token' page #74" from synapse-dinsic (#9832) This attempts to be a direct port of https://github.com/matrix-org/synapse-dinsic/pull/74 to mainline. There was some fiddling required to deal with the changes that have been made to mainline since (mainly dealing with the split of `RegistrationWorkerStore` from `RegistrationStore`, and the changes made to `self.make_request` in test code).
* | Sanity check identity server passed to bind/unbind. (#9802)Denis Kasak2021-04-192-3/+58
| | | | | | | | Signed-off-by: Denis Kasak <dkasak@termina.org.uk>
* | Don't send normal presence updates over federation replication stream (#9828)Erik Johnston2021-04-194-183/+74
| |
* | User directory: use calculated room membership state instead (#9821)Andrew Morgan2021-04-162-7/+35
| | | | | | | | | | Fixes: #9797. Should help reduce CPU usage on the user directory, especially when memberships change in rooms with lots of state history.
* | Small speed up joining large remote rooms (#9825)Erik Johnston2021-04-161-21/+33
| | | | | | | | | | There are a couple of points in `persist_events` where we are doing a query per event in series, which we can replace.
* | remove `HomeServer.get_config` (#9815)Richard van der Hoff2021-04-147-17/+14
| | | | | | | | Every single time I want to access the config object, I have to remember whether or not we use `get_config`. Let's just get rid of it.
* | Separate creating an event context from persisting it in the federation ↵Patrick Cloke2021-04-141-65/+113
| | | | | | | | | | | | handler (#9800) This refactoring allows adding logic that uses the event context before persisting it.
* | Revert "Check for space membership during a remote join of a restricted ↵Patrick Cloke2021-04-144-232/+129
| | | | | | | | | | | | | | | | room. (#9763)" This reverts commit cc51aaaa7adb0ec2235e027b5184ebda9b660ec4. The PR was prematurely merged and not yet approved.
* | Check for space membership during a remote join of a restricted room. (#9763)Patrick Cloke2021-04-144-129/+232
| | | | | | | | | | | | | | When receiving a /send_join request for a room with join rules set to 'restricted', check if the user is a member of the spaces defined in the 'allow' key of the join rules. This only applies to an experimental room version, as defined in MSC3083.
* | Experimental Federation Speedup (#9702)Jonathan de Jong2021-04-143-78/+105
| | | | | | | | | | This basically speeds up federation by "squeezing" each individual dual database call (to destinations and destination_rooms), which previously happened per every event, into one call for an entire batch (100 max). Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>
* | Move some replication processing out of generic_worker (#9796)Erik Johnston2021-04-144-478/+482
| | | | | | Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | More robust handling of the Content-Type header for thumbnail generation (#9788)rkfg2021-04-142-0/+4
| | | | | | | | Signed-off-by: Sergey Shpikin <rkfg@rkfg.me>
* | Remove redundant "coding: utf-8" lines (#9786)Jonathan de Jong2021-04-14430-431/+0
|/ | | | | | | Part of #9744 Removes all redundant `# -*- coding: utf-8 -*-` lines from files, as python 3 automatically reads source code as utf-8 now. `Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>`
* 1.32.0rc1Andrew Morgan2021-04-131-1/+1
|
* Bump black configuration to target py36 (#9781)Dan Callahan2021-04-135-8/+8
| | | Signed-off-by: Dan Callahan <danc@element.io>
* Add an admin API to manage ratelimit for a specific user (#9648)Dirk Klimpel2021-04-133-5/+172
|
* Require AppserviceRegistrationType (#9548)Will Hunt2021-04-122-7/+21
| | | This change ensures that the appservice registration behaviour follows the spec. We decided to do this for Dendrite, so it made sense to also make a PR for synapse to correct the behaviour.
* Fix duplicate logging of exceptions in transaction processing (#9780)Richard van der Hoff2021-04-091-7/+3
| | | There's no point logging this twice.
* Remove old admin API `GET /_synapse/admin/v1/users/<user_id>` (#9401)Dirk Klimpel2021-04-092-25/+0
| | | | | | | | | | | | | Related: #8334 Deprecated in: #9429 - Synapse 1.28.0 (2021-02-25) `GET /_synapse/admin/v1/users/<user_id>` has no - unit tests - documentation API in v2 is available (#5925 - 12/2019, v1.7.0). API is misleading. It expects `user_id` and returns a list of all users. Signed-off-by: Dirk Klimpel dirk@klimpel.org
* Bugbear: Add Mutable Parameter fixes (#9682)Jonathan de Jong2021-04-0823-72/+130
| | | | | | | Part of #9366 Adds in fixes for B006 and B008, both relating to mutable parameter lint errors. Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>
* Merge remote-tracking branch 'origin/develop' into rav/drop_py35Richard van der Hoff2021-04-0826-250/+904
|\
| * Merge branch 'erikj/fix_stalled_catchup' into developErik Johnston2021-04-081-2/+4
| |\
| | * Fix sharded federation sender sometimes using 100% CPU.Erik Johnston2021-04-081-2/+4
| | | | | | | | | | | | | | | | | | | | | We pull all destinations requiring catchup from the DB in batches. However, if all those destinations get filtered out (due to the federation sender being sharded), then the `last_processed` destination doesn't get updated, and we keep requesting the same set repeatedly.
| * | MSC3083: Check for space membership during a local join of restricted rooms. ↵Patrick Cloke2021-04-081-1/+74
| |/ | | | | | | | | | | | | | | (#9735) When joining a room with join rules set to 'restricted', check if the user is a member of the spaces defined in the 'allow' key of the join rules. This only applies to an experimental room version, as defined in MSC3083.
| * Record more information into structured logs. (#9654)Patrick Cloke2021-04-084-43/+162
| | | | | | | | Records additional request information into the structured logs, e.g. the requester, IP address, etc.
| * Don't report anything from GaugeBucketCollector metrics until data is ↵Andrew Morgan2021-04-061-3/+13
| | | | | | | | | | present (#8926) This PR modifies `GaugeBucketCollector` to only report data once it has been updated, rather than initially reporting a value of 0. Fixes zero values being reported for some metrics on startup until a background job to update the metric's value runs later.
| * Add a Synapse Module for configuring presence update routing (#9491)Andrew Morgan2021-04-067-48/+450
| | | | | | | | | | | | | | | | | | | | | | | | At the moment, if you'd like to share presence between local or remote users, those users must be sharing a room together. This isn't always the most convenient or useful situation though. This PR adds a module to Synapse that will allow deployments to set up extra logic on where presence updates should be routed. The module must implement two methods, `get_users_for_states` and `get_interested_users`. These methods are given presence updates or user IDs and must return information that Synapse will use to grant passing presence updates around. A method is additionally added to `ModuleApi` which allows triggering a set of users to receive the current, online presence information for all users they are considered interested in. This is the equivalent of that user receiving presence information during an initial sync. The goal of this module is to be fairly generic and useful for a variety of applications, with hard requirements being: * Sending state for a specific set or all known users to a defined set of local and remote users. * The ability to trigger an initial sync for specific users, so they receive all current state.
| * Add type hints to expiring cache. (#9730)Patrick Cloke2021-04-067-54/+64
| |
| * Remove outdated constraint on remote_media_cache_thumbnails (#9725)Richard van der Hoff2021-04-062-3/+40
| | | | | | | | | | | | | | | | | | | | | | The `remote_media_cache_thumbnails_media_origin_media_id_thumbna_key` constraint is superceded by `remote_media_repository_thumbn_media_origin_id_width_height_met` (which adds `thumbnail_method` to the unique key). PR #7124 made an attempt to remove the old constraint, but got the name wrong, so it didn't work. Here we update the bg update and rerun it. Fixes #8649.
| * Merge branch 'master' into developErik Johnston2021-04-061-1/+1
| |\
| | * 1.31.0 v1.31.0 github/release-v1.31.0 release-v1.31.0Erik Johnston2021-04-061-1/+1
| | |
| * | Add type hints to the federation handler and server. (#9743)Patrick Cloke2021-04-063-95/+96
| | |
* | | remove unused param on `make_tuple_comparison_clause`Richard van der Hoff2021-04-084-7/+2
| | |
* | | Drop support for sqlite<3.22 as wellRichard van der Hoff2021-04-084-80/+12
| | |
* | | Require py36 and Postgres 9.6Richard van der Hoff2021-04-081-2/+2
|/ /
* | Update mypy configuration: `no_implicit_optional = True` (#9742)Jonathan de Jong2021-04-057-9/+14
| |
* | Improve tracing for to device messages (#9686)Erik Johnston2021-04-016-19/+101
| |
* | Add `order_by` to list user admin API (#9691)Dirk Klimpel2021-04-013-8/+64
| |
* | Add an experimental room version to support restricted join rules. (#9717)Patrick Cloke2021-03-314-8/+53
| | | | | | Per MSC3083.
* | Make sample config allowed_local_3pids regex stricter. (#9719)Denis Kasak2021-03-311-2/+2
| | | | | | | | | | | | | | The regex should be terminated so that subdomain matches of another domain are not accepted. Just ensuring that someone doesn't shoot themselves in the foot by copying our example. Signed-off-by: Denis Kasak <dkasak@termina.org.uk>
* | Deprecate imp (#9718)Cristina2021-03-311-3/+8
| | | | | | | | | | Fixes #9642. Signed-off-by: Cristina Muñoz <hi@xmunoz.com>
* | Include m.room.create in invite_room_state for Spaces (#9710)Richard van der Hoff2021-03-301-0/+4
| |
* | Replace `room_invite_state_types` with `room_prejoin_state` (#9700)Richard van der Hoff2021-03-303-26/+115
| | | | | | | | | | | | | | `room_invite_state_types` was inconvenient as a configuration setting, because anyone that ever set it would not receive any new types that were added to the defaults. Here, we deprecate the old setting, and replace it with a couple of new settings under `room_prejoin_state`.
* | Make RateLimiter class check for ratelimit overrides (#9711)Erik Johnston2021-03-3014-94/+132
|/ | | | | | | This should fix a class of bug where we forget to check if e.g. the appservice shouldn't be ratelimited. We also check the `ratelimit_override` table to check if the user has ratelimiting disabled. That table is really only meant to override the event sender ratelimiting, so we don't use any values from it (as they might not make sense for different rate limits), but we do infer that if ratelimiting is disabled for the user we should disabled all ratelimits. Fixes #9663
* 1.31.0rc1Erik Johnston2021-03-301-1/+1
|
* Add type hints to DictionaryCache and TTLCache. (#9442)Patrick Cloke2021-03-294-52/+84
|
* Add type hints for the federation sender. (#9681)Patrick Cloke2021-03-296-59/+176
| | | | Includes an abstract base class which both the FederationSender and the FederationRemoteSendQueue must implement.
* Update the OIDC sample config (#9695)Richard van der Hoff2021-03-291-31/+3
| | | | | | | I've reiterated the advice about using `oidc` to migrate, since I've seen a few people caught by this. I've also removed a couple of the examples as they are duplicating the OIDC documentation, and I think they might be leading people astray.
* Fix `re.Pattern` mypy error on 3.6 (#9703)Jonathan de Jong2021-03-291-2/+2
|
* Fix the suggested pip incantation for cryptography (#9699)Richard van der Hoff2021-03-291-2/+15
| | | | | | | | | | | If you have the wrong version of `cryptography` installed, synapse suggests: ``` To install run: pip install --upgrade --force 'cryptography>=3.4.7;python_version>='3.6'' ``` However, the use of ' inside '...' doesn't work, so when you run this, you get an error.
* Suppress CryptographyDeprecationWarning (#9698)Richard van der Hoff2021-03-263-14/+25
| | | This warning is somewhat confusing to users, so let's suppress it
* Make it possible to use dmypy (#9692)Erik Johnston2021-03-2611-6/+30
| | | | | | | | | Running `dmypy run` will do a `mypy` check while spinning up a daemon that makes rerunning `dmypy run` a lot faster. `dmypy` doesn't support `follow_imports = silent` and has `local_partial_types` enabled, so this PR enables those options and fixes the issues that were newly raised. Note that `local_partial_types` will be enabled by default in upcoming mypy releases.
* Merge branch 'master' into developErik Johnston2021-03-262-1/+4
|\
| * 1.30.1Erik Johnston2021-03-261-1/+1
| |
| * Explicitly upgrade openssl in docker file and enforce new version of ↵Erik Johnston2021-03-261-0/+3
| | | | | | | | cryptography (#9697)
* | Add a storage method for returning all current presence from all users (#9650)Andrew Morgan2021-03-252-3/+68
| | | | | | | | | | | | | | Split off from https://github.com/matrix-org/synapse/pull/9491 Adds a storage method for getting the current presence of all local users, optionally excluding those that are offline. This will be used by the code in #9491 when a PresenceRouter module informs Synapse that a given user should have `"ALL"` user presence updates routed to them. Specifically, it is used here: https://github.com/matrix-org/synapse/blob/b588f16e391d664b11f43257eabf70663f0c6d59/synapse/handlers/presence.py#L1131-L1133 Note that there is a `get_all_presence_updates` function just above. That function is intended to walk up the table through stream IDs, and is primarily used by the presence replication stream. I could possibly make use of it in the PresenceRouter-related code, but it would be a bit of a bodge.
* | Fixed undefined variable error in catchup (#9664)Erik Johnston2021-03-241-0/+2
| | | | | | | | | | Broke in #9640 Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Enable addtional flake8-bugbear linting checks. (#9659)Jonathan de Jong2021-03-245-5/+5
| |
* | Spaces summary: call out to other servers (#9653)Richard van der Hoff2021-03-243-27/+323
| | | | | | | | | | When we hit an unknown room in the space tree, see if there are other servers that we might be able to poll to get the data. Fixes: #9447
* | Add type hints to misc. files. (#9676)Patrick Cloke2021-03-244-53/+52
| |
* | Add a type hints for service notices to the HomeServer object. (#9675)Patrick Cloke2021-03-2410-40/+51
| |
* | Increase default join burst ratelimiting (#9674)Erik Johnston2021-03-231-4/+4
| | | | | | It's legitimate behaviour to try and join a bunch of rooms at once.
* | Fix federation stall on concurrent access errors (#9639)Jonathan de Jong2021-03-231-36/+9
| |
* | Federation API for Space summary (#9652)Richard van der Hoff2021-03-232-54/+196
| | | | | | | | | | Builds on the work done in #9643 to add a federation API for space summaries. There's a bit of refactoring of the existing client-server code first, to avoid too much duplication.
* | Import HomeServer from the proper module. (#9665)Patrick Cloke2021-03-2358-58/+58
| |
* | Allow providing credentials to HTTPS_PROXY (#9657)Andrew Morgan2021-03-222-34/+143
| | | | | | | | | | | | | | Addresses https://github.com/matrix-org/synapse-dinsic/issues/70 This PR causes `ProxyAgent` to attempt to extract credentials from an `HTTPS_PROXY` env var. If credentials are found, a `Proxy-Authorization` header ([details](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Proxy-Authorization)) is sent to the proxy server to authenticate against it. The headers are *not* passed to the remote server. Also added some type hints.
* | Fixed code misc. quality issues (#9649)Ankit Dobhal2021-03-222-2/+2
| | | | | | | | | | - Merge 'isinstance' calls. - Remove unnecessary dict call outside of comprehension. - Use 'sys.exit()' calls.
* | Merge branch 'master' into developErik Johnston2021-03-221-1/+1
|\|
| * 1.30.0 v1.30.0 github/release-v1.30.0 release-v1.30.0Erik Johnston2021-03-221-1/+1
| |
* | Incorporate reviewBrendan Abolivier2021-03-192-2/+2
| |
* | Merge branch 'develop' into babolivier/msc3026Brendan Abolivier2021-03-1910-43/+372
|\ \
| * | fix mypyRichard van der Hoff2021-03-191-4/+7
| | |
| * | Fix type-hints from bad merge.Patrick Cloke2021-03-181-2/+2
| | |
| * | Initial spaces summary API (#9643)Richard van der Hoff2021-03-185-3/+276
| | | | | | | | | This is very bare-bones for now: federation will come soon, while pagination is descoped for now but will come later.
| * | Consistently check whether a password may be set for a user. (#9636)Dirk Klimpel2021-03-183-2/+3
| | |
| * | Make federation catchup send last event from any server. (#9640)Erik Johnston2021-03-182-38/+91
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently federation catchup will send the last *local* event that we failed to send to the remote. This can cause issues for large rooms where lots of servers have sent events while the remote server was down, as when it comes back up again it'll be flooded with events from various points in the DAG. Instead, let's make it so that all the servers send the most recent events, even if its not theirs. The remote should deduplicate the events, so there shouldn't be much overhead in doing this. Alternatively, the servers could only send local events if they were also extremities and hope that the other server will send the event over, but that is a bit risky.
* | | Fix lintBrendan Abolivier2021-03-192-11/+10
| | |
* | | Move support for MSC3026 behind an experimental flagBrendan Abolivier2021-03-183-3/+18
| | |
* | | Implement MSC3026: busy presence stateBrendan Abolivier2021-03-184-1/+6
|/ /
* | Ensure we use a copy of the event content dict before modifying it in ↵Andrew Morgan2021-03-171-2/+12
| | | | | | | | | | | | | | | | | | serialize_event (#9585) This bug was discovered by DINUM. We were modifying `serialized_event["content"]`, which - if you've got `USE_FROZEN_DICTS` turned on or are [using a third party rules module](https://github.com/matrix-org/synapse/blob/17cd48fe5171d50da4cb59db647b993168e7dfab/synapse/events/third_party_rules.py#L73-L76) - will raise a 500 if you try to a edit a reply to a message. `serialized_event["content"]` could be set to the edit event's content, instead of a copy of it, which is bad as we attempt to modify it. Instead, we also end up modifying the original event's content. DINUM uses a third party rules module, which meant the event's content got frozen and thus an exception was raised. To be clear, the problem is not that the event's content was frozen. In fact doing so helped us uncover the fact we weren't copying event content correctly.
* | Fix up types for the typing handler. (#9638)Patrick Cloke2021-03-173-14/+29
| | | | | | | | By splitting this to two separate methods the callers know what methods they can expect on the handler.
* | only save remote cross-signing keys if they're different from the current ↵Hubert Chathi2021-03-171-4/+18
| | | | | | | | | | ones (#9634) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Fix bad naming of storage function (#9637)Erik Johnston2021-03-173-4/+6
| | | | | | | | | | | | We had two functions named `get_forward_extremities_for_room` and `get_forward_extremeties_for_room` that took different paramters. We rename one of them to avoid confusion.
* | Prep work for removing `outlier` from `internal_metadata` (#9411)Richard van der Hoff2021-03-176-7/+35
| | | | | | | | | | | | | | | | | | | | | | | | * Populate `internal_metadata.outlier` based on `events` table Rather than relying on `outlier` being in the `internal_metadata` column, populate it based on the `events.outlier` column. * Move `outlier` out of InternalMetadata._dict Ultimately, this will allow us to stop writing it to the database. For now, we have to grandfather it back in so as to maintain compatibility with older versions of Synapse.
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-11-26 04:17:01 +0000