summary refs log tree commit diff
path: root/synapse (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Fix join ratelimiter breaking profile updates and idempotency (#8153)Brendan Abolivier2020-08-241-21/+25
|
* Do not apply ratelimiting on joins to appservices (#8139)Will Hunt2020-08-242-6/+45
| | | | | | Add new method ratelimiter.can_requester_do_action and ensure that appservices are exempt from being ratelimited. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Erik Johnston <erik@matrix.org>
* 1.19.0Olivier Wilkinson (reivilibre)2020-08-171-1/+1
|
* 1.19.0rc1Olivier Wilkinson (reivilibre)2020-08-131-1/+1
|
* Convert the roommember database to async/await. (#8070)Patrick Cloke2020-08-123-241/+98
|
* Convert devices database to async/await. (#8069)Patrick Cloke2020-08-121-153/+180
|
* Add type hints to handlers.message and events.builder (#8067)Erik Johnston2020-08-123-40/+52
|
* Convert account data, device inbox, and censor events databases to ↵Patrick Cloke2020-08-123-86/+96
| | | | async/await (#8063)
* Convert appservice, group server, profile and more databases to async (#8066)Patrick Cloke2020-08-127-104/+78
|
* Fix typing for notifier (#8064)Erik Johnston2020-08-124-16/+35
|
* Merge pull request #8060 from matrix-org/erikj/type_serverErik Johnston2020-08-116-403/+267
|\ | | | | Change HomeServer definition to work with typing.
| * Merge remote-tracking branch 'origin/develop' into erikj/type_serverErik Johnston2020-08-1110-100/+354
| |\
| * | Add comment explaining castErik Johnston2020-08-111-0/+2
| | |
| * | Handle optional dependencies for Oidc and SamlErik Johnston2020-08-111-5/+9
| | |
| * | Change HomeServer definition to work with typing.Erik Johnston2020-08-116-399/+263
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Duplicating function signatures between server.py and server.pyi is silly. This commit changes that by changing all `build_*` methods to `get_*` methods and changing the `_make_dependency_method` to work work as a descriptor that caches the produced value. There are some changes in other files that were made to fix the typing in server.py.
* | | Convert tags and metrics databases to async/await (#8062)Patrick Cloke2020-08-112-64/+59
| | |
* | | Converts event_federation and registration databases to async/await (#8061)Patrick Cloke2020-08-113-164/+125
| |/ |/|
* | Auto set logging filter (#8051)Erik Johnston2020-08-111-8/+16
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We do this to prevent foot guns. The default config uses a MemoryFilter, but users are free to change to logging to files directly. If they do then they have to ensure to set the `filters: [context]` on the right handler, otherwise records get written with the wrong context. Instead we move the logic to happen when we generate a record, which is when we *log* rather than *handle*. (It's possible to add filters to loggers in the config, however they don't apply to descendant loggers and so they have to be manually set on *every* logger used in the code base)
| * | Move setting of Filter into code.Erik Johnston2020-08-111-8/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We do this to prevent foot guns. The default config uses a MemoryFilter, but users are free to change to logging to files directly. If they do then they have to ensure to set the `filters: [context]` on the right handler, otherwise records get written with the wrong context. Instead we move the logic to happen when we generate a record, which is when we *log* rather than *handle*. (It's possible to add filters to loggers in the config, however they don't apply to descendant loggers and so they have to be manually set on *every* logger used in the code base)
* | | Add typing info to Notifier (#8058)Erik Johnston2020-08-113-52/+89
|/ /
* | Reduce INFO logging (#8050)Erik Johnston2020-08-113-25/+73
| | | | | | | | | | | | | | | | | | | | c.f. #8021 A lot of the code here is to change the `Completed 200 OK` logging to include the request URI so that we can drop the `Sending request...` log line. Some notes: 1. We won't log retries, which may be confusing considering the time taken log line includes retries and sleeps. 2. The `_send_request_with_optional_trailing_slash` will always be logged *without* the forward slash, even if it succeeded only with the forward slash.
* | Change the default log config to reduce disk I/O and storage (#8040)Erik Johnston2020-08-111-5/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Change default log config to buffer by default. This batches up writes to the filesystem, which is more efficient for disk I/O. This means that it can take some time for logs to get written to disk. Note that ERROR logs (and above) immediately flush the buffer. This only effects new installs, as we only write the log config if started with `--generate-config` (in the same way we do for generating signing keys). * Default to keeping last 4 days of logs. This hopefully reduces the amount of logs kept for new servers. Keeping the last 1GB of logs is likely overkill for new servers, but equally may not be enough for busy ones. Instead, we keep the last four days worth of logs, enough so that admins can investigate any problems that happened over e.g. a long weekend.
* | Implement login blocking based on SAML attributes (#8052)Richard van der Hoff2020-08-114-11/+147
|/ | | | | | | Hopefully this mostly speaks for itself. I also did a bit of cleaning up of the error handling. Fixes #8047
* Add an assertion on prev_events in create_new_client_event (#8041)Richard van der Hoff2020-08-101-0/+9
| | | | | | I think this would have caught all the cases in https://github.com/matrix-org/synapse/issues/7642 - and I think a 500 makes more sense here than a 403
* Implement new experimental push rules (#7997)Brendan Abolivier2020-08-104-14/+244
|\ | | | | With an undocumented configuration setting to enable them for specific users.
| * TypoBrendan Abolivier2020-08-101-1/+1
| |
| * LintBrendan Abolivier2020-08-101-2/+2
| |
| * why mypy whyBrendan Abolivier2020-08-101-1/+3
| |
| * LintBrendan Abolivier2020-08-061-1/+1
| |
| * Incorporate reviewBrendan Abolivier2020-08-061-2/+2
| |
| * Merge branch 'develop' of github.com:matrix-org/synapse into ↵Brendan Abolivier2020-08-06350-1509/+1754
| |\ | | | | | | | | | babolivier/new_push_rules
| * | Incorporate reviewBrendan Abolivier2020-08-064-21/+12
| | |
| * | Fix PUT /pushrules to use the right rule IDsBrendan Abolivier2020-08-031-2/+9
| | |
| * | Back out the database hack and replace it with a temporary config settingBrendan Abolivier2020-08-034-48/+20
| | |
| * | Fix cache nameBrendan Abolivier2020-07-311-1/+1
| | |
| * | Fix cache invalidation callsBrendan Abolivier2020-07-312-2/+2
| | |
| * | LintBrendan Abolivier2020-07-301-19/+32
| | |
| * | Merge branch 'develop' of github.com:matrix-org/synapse into ↵Brendan Abolivier2020-07-3096-1714/+2102
| |\ \ | | | | | | | | | | | | babolivier/new_push_rules
| * | | Implement new experimental push rules with a database hack to enable themBrendan Abolivier2020-07-283-14/+259
| | | |
* | | | Convert directory, e2e_room_keys, end_to_end_keys, monthly_active_users ↵Patrick Cloke2020-08-075-102/+95
| | | | | | | | | | | | | | | | database to async (#8042)
* | | | Convert additional database stores to async/await (#8045)Patrick Cloke2020-08-074-150/+104
| | | |
* | | | Add a comment about SSLv23_METHOD (#8043)Richard van der Hoff2020-08-071-0/+8
| | | |
* | | | Don't log OPTIONS request at INFO (#8049)Erik Johnston2020-08-071-1/+7
| | | |
* | | | Remove unnecessary maybeDeferred calls (#8044)Patrick Cloke2020-08-074-7/+4
| | | |
* | | | Add health check endpoint (#8048)Erik Johnston2020-08-074-3/+48
| | | |
* | | | Reduce unnecessary whitespace in JSON. (#7372)David Vo2020-08-0714-53/+55
| | | |
* | | | Revert #7736 (#8039)Brendan Abolivier2020-08-067-162/+15
| | | |
* | | | Convert some util functions to async (#8035)Patrick Cloke2020-08-062-28/+27
| | | |
* | | | Convert synapse.api to async/await (#8031)Patrick Cloke2020-08-0612-92/+78
| | | |
* | | | Convert run_as_background_process inner function to async. (#8032)Patrick Cloke2020-08-063-26/+15
| | | |
* | | | Improve performance of the register endpoint (#8009)Patrick Cloke2020-08-064-73/+144
| |_|/ |/| |
* | | Rename database classes to make some sense (#8033)Erik Johnston2020-08-05314-1152/+1232
| | |
* | | Stop the parent process flushing the logs on exit (#8012)Richard van der Hoff2020-08-051-2/+8
| | | | | | | | | This solves the problem that the first few lines are logged twice on matrix.org. Hopefully the comments explain it.
* | | Fix async/await calls for broken media providers. (#8027)Patrick Cloke2020-08-042-22/+20
| | |
* | | Convert the SimpleHttpClient to async. (#8016)Patrick Cloke2020-08-042-32/+25
| | |
* | | Convert streams to async. (#8014)Patrick Cloke2020-08-048-29/+25
| | |
* | | re-implement daemonize (#8011)Richard van der Hoff2020-08-043-14/+134
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This has long been something I've wanted to do. Basically the `Daemonize` code is both too flexible and not flexible enough, in that it offers a bunch of features that we don't use (changing UID, closing FDs in the child, logging to syslog) and doesn't offer a bunch that we could do with (redirecting stdout/err to a file instead of /dev/null; having the parent not exit until the child is running). As a first step, I've lifted the Daemonize code and removed the bits we don't use. This should be a non-functional change. Fixing everything else will come later.
* | | Remove signature check on v1 identity server lookups (#8001)Andrew Morgan2020-08-031-31/+3
| | | | | | | | | | | | | | | | | | | | | We've [decided](https://github.com/matrix-org/synapse/issues/5253#issuecomment-665976308) to remove the signature check for v1 lookups. The signature check has been removed in v2 lookups. v1 lookups are currently deprecated. As mentioned in the above linked issue, this verification was causing deployments for the vector.im and matrix.org IS deployments, and this change is the simplest solution, without being unjustified. Implementations are encouraged to use the v2 lookup API as it has [increased privacy benefits](https://github.com/matrix-org/matrix-doc/pull/2134).
* | | Prevent join->join membership transitions changing member count (#7977)Andrew Morgan2020-08-033-6/+62
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `StatsHandler` handles updates to the `current_state_delta_stream`, and updates room stats such as the amount of state events, joined users, etc. However, it counts every new join membership as a new user entering a room (and that user being in another room), whereas it's possible for a user's membership status to go from join -> join, for instance when they change their per-room profile information. This PR adds a check for join->join membership transitions, and bails out early, as none of the further checks are necessary at that point. Due to this bug, membership stats in many rooms have ended up being wildly larger than their true values. I am not sure if we also want to include a migration step which recalculates these statistics (possibly using the `_populate_stats_process_rooms` bg update). Bug introduced in the initial implementation https://github.com/matrix-org/synapse/pull/4338.
* | | Implement handling of HTTP HEAD requests. (#7999)Patrick Cloke2020-08-031-5/+11
| | |
* | | Convert the crypto module to async/await. (#8003)Patrick Cloke2020-08-031-109/+92
| | |
* | | Allow guests to operate in encrypted rooms (#7314)Michael Albert2020-08-031-1/+1
| | | | | | | | | Signed-off-by: Michael Albert <michael.albert@awesome-technologies.de>
* | | Convert replication code to async/await. (#7987)Patrick Cloke2020-08-0310-38/+28
| | |
* | | Convert ACME code to async/await. (#7989)Patrick Cloke2020-08-032-14/+10
| | |
* | | Fix some comments and types in service notices (#7996)Patrick Cloke2020-07-315-59/+54
| | |
* | | Merge branch 'develop' of github.com:matrix-org/synapse into ↵Erik Johnston2020-07-3156-964/+1051
|\ \ \ | | |/ | |/| | | | erikj/add_rate_limiting_to_joins
| * | Fix invite rejection when we have no forward-extremeties (#7980)Richard van der Hoff2020-07-301-8/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Thanks to some slightly overzealous cleanup in the `delete_old_current_state_events`, it's possible to end up with no `event_forward_extremities` in a room where we have outstanding local invites. The user would then get a "no create event in auth events" when trying to reject the invite. We can hack around it by using the dangling invite as the prev event.
| * | Merge branch 'master' into developOlivier Wilkinson (reivilibre)2020-07-3011-23/+81
| |\ \
| * | | Convert federation client to async/await. (#7975)Patrick Cloke2020-07-306-162/+128
| | | |
| * | | Convert appservice to async. (#7973)Patrick Cloke2020-07-304-65/+46
| | | |
| * | | Convert some of the data store to async. (#7976)Patrick Cloke2020-07-306-188/+160
| | | |
| * | | Ensure that remove_pusher is always async (#7981)Patrick Cloke2020-07-301-1/+1
| | | |
| * | | Ensure the msg property of HttpResponseException is a string. (#7979)Patrick Cloke2020-07-292-7/+16
| | | |
| * | | Remove from the event_relations table when purging historical events. (#7978)Patrick Cloke2020-07-291-0/+2
| | | |
| * | | Add additional logging for SAML sessions. (#7971)Patrick Cloke2020-07-291-0/+3
| | | |
| * | | Re-implement unread counts (#7736)Brendan Abolivier2020-07-297-15/+162
| | | |
| * | | Various improvements to the docs (#7899)Aaron Raimist2020-07-291-18/+0
| | | |
| * | | Convert storage layer to async/await. (#7963)Patrick Cloke2020-07-283-140/+145
| | | |
| * | | Add an option to disable purge in delete room admin API (#7964)Dirk Klimpel2020-07-281-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | Add option ```purge``` to ```POST /_synapse/admin/v1/rooms/<room_id>/delete``` Fixes: #3761 Signed-off-by: Dirk Klimpel dirk@klimpel.org
| * | | Move some log lines from default logger to sql/transaction loggers (#7952)Andrew Morgan2020-07-281-8/+10
| | | | | | | | | | | | Idea from matrix-org/synapse-dinsic#49
| * | | Use the JSON module from the std library instead of simplejson. (#7936)Patrick Cloke2020-07-282-1/+13
| | | |
| * | | Option to allow server admins to join complex rooms (#7902)lugino-emeritus2020-07-282-2/+13
| | | | | | | | | | | | | | | | | | | | Fixes #7901. Signed-off-by: Niklas Tittjung <nik_t.01@web.de>
| * | | Merge tag 'v1.18.0rc2' into developRichard van der Hoff2020-07-285-88/+113
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.18.0rc2 (2020-07-28) ============================== Bugfixes -------- - Fix an `AssertionError` exception introduced in v1.18.0rc1. ([\#7876](https://github.com/matrix-org/synapse/issues/7876)) - Fix experimental support for moving typing off master when worker is restarted, which is broken in v1.18.0rc1. ([\#7967](https://github.com/matrix-org/synapse/issues/7967)) Internal Changes ---------------- - Further optimise queueing of inbound replication commands. ([\#7876](https://github.com/matrix-org/synapse/issues/7876))
| * | | | Convert the remaining media repo code to async / await. (#7947)Patrick Cloke2020-07-275-107/+130
| | | | |
| * | | | Convert a synapse.events to async/await. (#7949)Patrick Cloke2020-07-278-72/+73
| | | | |
| * | | | Convert groups and visibility code to async / await. (#7951)Patrick Cloke2020-07-272-31/+24
| | | | |
| * | | | Convert push to async/await. (#7948)Patrick Cloke2020-07-277-141/+97
| | | | |
* | | | | Add ratelimiting on joinsErik Johnston2020-07-312-2/+56
| |_|/ / |/| | |
* | | | 1.18.0Olivier Wilkinson (reivilibre)2020-07-301-1/+1
| | | |
* | | | Update worker docs with recent enhancements (#7969)Erik Johnston2020-07-2910-22/+80
| |/ / |/| |
* | | 1.18.0rc2 v1.18.0rc2Richard van der Hoff2020-07-281-1/+1
| | |
* | | Typing worker needs to handle stream update requests (#7967)Erik Johnston2020-07-281-1/+1
| | | | | | | | | | | | | | | IIRC this doesn't break tests because its only hit on reconnection, or something. Basically, when a process needs to fetch missing updates for the `typing` stream it needs to query the writer instance via HTTP (as we don't write typing notifications to the DB), the problem was that the endpoint (`streams`) was only registered on master and specifically not on the typing writer worker.
* | | Handle replication commands synchronously where possible (#7876)Richard van der Hoff2020-07-273-86/+111
|/ / | | | | Most of the stuff we do for replication commands can be done synchronously. There's no point spinning up background processes if we're not going to need them.
* | 1.18.0rc1Richard van der Hoff2020-07-271-1/+1
| |
* | Fix error reporting when using `opentracing.trace` (#7961)Erik Johnston2020-07-272-12/+3
| |
* | Fix typing replication not being handled on master (#7959)Erik Johnston2020-07-273-7/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Handling of incoming typing stream updates from replication was not hooked up on master, effecting set ups where typing was handled on a different worker. This is really only a problem if the master process is also handling sync requests, which is unlikely for those that are at the stage of moving typing off. The other observable effect is that if a worker restarts or a replication connect drops then the typing worker will issue a `POSITION typing`, triggering master process to try and stream *all* typing updates from position 0. Fixes #7907
* | Remove hacky error handling for inlineDeferreds. (#7950)Patrick Cloke2020-07-272-21/+12
| |
* | Support oEmbed for media previews. (#7920)Patrick Cloke2020-07-271-45/+220
| | | | | | Fixes previews of Twitter URLs by using their oEmbed endpoint to grab content.
* | Convert state resolution to async/await (#7942)Patrick Cloke2020-07-2412-134/+124
| |
* | Fix up types and comments that refer to Deferreds. (#7945)Patrick Cloke2020-07-247-157/+172
| |
* | Do not convert async functions to Deferreds in the interactive_auth_handler ↵Patrick Cloke2020-07-241-26/+21
| | | | | | | | (#7944)
* | Convert more of the media code to async/await (#7873)Patrick Cloke2020-07-242-33/+42
| |
* | Return an empty body for OPTIONS requests. (#7886)Patrick Cloke2020-07-241-19/+5
| |
* | Downgrade warning on client disconnect to INFO (#7928)Richard van der Hoff2020-07-241-3/+1
| | | | | | | | Clients disconnecting before we finish processing the request happens from time to time. We don't need to yell about it
* | Convert presence handler helpers to async/await. (#7939)Patrick Cloke2020-07-232-24/+23
| |
* | Update the auth providers to be async. (#7935)Patrick Cloke2020-07-232-19/+23
| |
* | Put a cache on `/state_ids` (#7931)Richard van der Hoff2020-07-231-2/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If we send out an event which refers to `prev_events` which other servers in the federation are missing, then (after a round or two of backfill attempts), they will end up asking us for `/state_ids` at a particular point in the DAG. As per https://github.com/matrix-org/synapse/issues/7893, this is quite expensive, and we tend to see lots of very similar requests around the same time. We can therefore handle this much more efficiently by using a cache, which (a) ensures that if we see the same request from multiple servers (or even the same server, multiple times), then they share the result, and (b) any other servers that miss the initial excitement can also benefit from the work. [It's interesting to note that `/state` has a cache for exactly this reason. `/state` is now essentially unused and replaced with `/state_ids`, but evidently when we replaced it we forgot to add a cache to the new endpoint.]
* | Abort federation requests if the client disconnects early (#7930)Richard van der Hoff2020-07-231-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For inbound federation requests, if a given remote server makes too many requests at once, we start stacking them up rather than processing them immediatedly. However, that means that there is a fair chance that the requesting server will disconnect before we start processing the request. In that case, if it was a read-only request (ie, a GET request), there is absolutely no point in building a response (and some requests are quite expensive to handle). Even in the case of a POST request, one of two things will happen: * Most likely, the requesting server will retry the request and we'll get the information anyway. * Even if it doesn't, the requesting server has to assume that we didn't get the memo, and act accordingly. In short, we're better off aborting the request at this point rather than ploughing on with what might be a quite expensive request.
* | Convert the federation agent and related code to async/await. (#7874)Patrick Cloke2020-07-232-16/+10
| |
* | Follow-up to admin API to re-activate accounts (#7908)Patrick Cloke2020-07-222-6/+42
| |
* | Convert the message handler to async/await. (#7884)Patrick Cloke2020-07-221-136/+152
|/
* Skip serializing /sync response if client has disconnected (#7927)Richard van der Hoff2020-07-221-0/+6
| | | ... it's a load of work which may be entirely redundant.
* Add debugging to sync response generation (#7929)Richard van der Hoff2020-07-222-2/+18
|
* Remove an unused prometheus metric (#7878)Richard van der Hoff2020-07-221-3/+1
|
* Track command processing as a background process (#7879)Richard van der Hoff2020-07-222-3/+38
| | | | I'm going to be doing more stuff synchronously, and I don't want to lose the CPU metrics down the sofa.
* Clean up PreserveLoggingContext (#7877)Richard van der Hoff2020-07-221-16/+13
| | | This had some dead code and some just plain wrong docstrings.
* fix an incorrect commentRichard van der Hoff2020-07-221-2/+2
|
* Convert room list handler to async/await. (#7912)Patrick Cloke2020-07-212-41/+31
|
* Element CSS and logo in email templates (#7919)Jason Robinson2020-07-213-0/+11
| | | | | Use Element CSS and logo in notification emails when app name is Element. Signed-off-by: Jason Robinson <jasonr@matrix.org>
* Remove unused code from synapse.logging.utils. (#7897)Karthikeyan Singaravelan2020-07-201-126/+0
|
* Fix a typo in the sample config. (#7890)Adrian2020-07-201-1/+1
|
* Fix deprecation warning: import ABC from collections.abc (#7892)Karthikeyan Singaravelan2020-07-204-6/+6
|
* Change sample config's postgres user to synapse_user (#7889)Andrew Morgan2020-07-201-1/+1
| | | | | | | The [postgres setup docs](https://github.com/matrix-org/synapse/blob/develop/docs/postgres.md#set-up-database) recommend setting up your database with user `synapse_user`. However, uncommenting the postgres defaults in the sample config leave you with user `synapse`. This PR switches the sample config to recommend `synapse_user`. Took a me a second to figure this out, so assume this will beneficial to others.
* Fix the trace function for async functions. (#7872)Patrick Cloke2020-07-171-23/+40
| | | Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* Stop using 'device_max_stream_id' (#7882)Erik Johnston2020-07-173-5/+2
| | | | | It serves no purpose and updating everytime we write to the device inbox stream means all such transactions will conflict, causing lots of transaction failures and retries.
* Fix TypeError in synapse.notifier (#7880)Erik Johnston2020-07-171-0/+8
| | | Fixes #7774
* Add a default limit (of 100) to get/sync operations. (#7858)Patrick Cloke2020-07-172-3/+14
|
* Change "unknown room ver" logging to warning. (#7881)Erik Johnston2020-07-171-1/+1
| | | | It's somewhat expected for us to have unknown room versions in the database due to room version experiments.
* Convert device handler to async/await (#7871)Patrick Cloke2020-07-172-138/+131
|
* Convert synapse.app to async/await. (#7868)Patrick Cloke2020-07-173-41/+36
|
* Convert _base, profile, and _receipts handlers to async/await (#7860)Patrick Cloke2020-07-174-53/+41
|
* Add admin endpoint to get members in a room. (#7842)Michael Albert2020-07-162-0/+27
|
* Consistently use `db_to_json` to convert from database values to JSON ↵Patrick Cloke2020-07-1621-82/+79
| | | | objects. (#7849)
* Optimise queueing of inbound replication commands (#7861)Richard van der Hoff2020-07-161-116/+215
| | | | | | | | | | | When we get behind on replication, we tend to stack up background processes behind a linearizer. Bg processes are heavy (particularly with respect to prometheus metrics) and linearizers aren't terribly efficient once the queue gets long either. A better approach is to maintain a queue of requests to be processed, and nominate a single process to work its way through the queue. Fixes: #7444
* Reject attempts to join empty rooms over federation (#7859)Richard van der Hoff2020-07-161-2/+13
| | | | | | We shouldn't allow others to make_join through us if we've left the room; reject such attempts with a 404. Fixes #7835. Fixes #6958.
* Allow moving typing off master (#7869)Erik Johnston2020-07-169-178/+283
|
* Add ability to run multiple pusher instances (#7855)Erik Johnston2020-07-167-82/+99
| | | This reuses the same scheme as federation sender sharding
* Merge pull request #7866 from matrix-org/rav/fix_guest_user_idRichard van der Hoff2020-07-169-80/+184
|\ | | | | Fix guest user registration with lots of client readers
| * Use a postgres sequence to generate guest user IDsRichard van der Hoff2020-07-163-50/+71
| |
| * Use SequenceGenerator for state group ID allocationRichard van der Hoff2020-07-164-26/+11
| |
| * Use `PostgresSequenceGenerator` from `MultiWriterIdGenerator`Richard van der Hoff2020-07-161-4/+4
| | | | | | | | partly just to show it works, but alwo to remove a bit of code duplication.
| * Add some helper classes for generating ID sequencesRichard van der Hoff2020-07-161-0/+98
| |
* | Add some tiny type annotations (#7870)Richard van der Hoff2020-07-162-8/+6
| | | | | | I found these made pycharm have more of a clue as to what was going on in other places.
* | Remove obsolete comment.Olivier Wilkinson (reivilibre)2020-07-161-2/+0
| | | | | | | | | | | | | | | | It was correct at the time of our friend Jorik writing it (checking git blame), but the world has moved now and it is no longer a generator. Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
* | Ensure that calls to `json.dumps` are compatible with the standard library ↵Patrick Cloke2020-07-157-13/+21
| | | | | | | | json. (#7836)
* | Avoid brand new rooms in `delete_old_current_state_events` (#7854)Richard van der Hoff2020-07-151-10/+55
| | | | | | | | | | | | | | | | When considering rooms to clean up in `delete_old_current_state_events`, skip rooms which we are creating, which otherwise look a bit like rooms we have left. Fixes #7834.
* | Merge branch 'erikj/faster_typing' of github.com:matrix-org/synapse into developErik Johnston2020-07-151-2/+2
|\ \ | |/ |/|
| * Fix typoErik Johnston2020-07-151-1/+1
| |
| * Use get_users_in_room rather than state handler in typing for speedErik Johnston2020-07-151-2/+2
| |
* | Allow accounts to be re-activated from the admin APIs. (#7847)Patrick Cloke2020-07-152-21/+37
| |
* | Fix client reader sharding tests (#7853)Erik Johnston2020-07-152-1/+28
|/ | | | | | | | | | | | | | | * Fix client reader sharding tests * Newsfile * Fix typing * Update changelog.d/7853.misc Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Move mocking of http_client to tests Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Convert E2E key and room key handlers to async/await. (#7851)Patrick Cloke2020-07-152-124/+98
|
* Return the proper 403 Forbidden error during errors with JWT logins. (#7844)Patrick Cloke2020-07-151-5/+3
|
* remove `retry_on_integrity_error` wrapper for persist_events (#7848)Richard van der Hoff2020-07-151-67/+0
| | | | | | | | | As far as I can tell from the sentry logs, the only time this has actually done anything in the last two years is when we had two master workers running at once, and even then, it made a bit of a mess of it (see https://github.com/matrix-org/synapse/issues/7845#issuecomment-658238739). Generally I feel like this code is doing more harm than good.
* Fix bug in per-room message retention policies. (#7850)Patrick Cloke2020-07-141-1/+1
|
* Allow email subjects to be customised through Synapse's configuration (#7846)Brendan Abolivier2020-07-142-37/+132
|
* Add delete room admin endpoint (#7613)Dirk Klimpel2020-07-146-113/+273
| | | | | | | | | | | | | | | | | | The Delete Room admin API allows server admins to remove rooms from server and block these rooms. `DELETE /_synapse/admin/v1/rooms/<room_id>` It is a combination and improvement of "[Shutdown room](https://github.com/matrix-org/synapse/blob/develop/docs/admin_api/shutdown_room.md)" and "[Purge room](https://github.com/matrix-org/synapse/blob/develop/docs/admin_api/purge_room.md)" API. Fixes: #6425 It also fixes a bug in [synapse/storage/data_stores/main/room.py](synapse/storage/data_stores/main/room.py) in ` get_room_with_stats`. It should return `None` if the room is unknown. But it returns an `IndexError`. https://github.com/matrix-org/synapse/blob/901b1fa561e3cc661d78aa96d59802cf2078cb0d/synapse/storage/data_stores/main/room.py#L99-L105 Related to: - #5575 - https://github.com/Awesome-Technologies/synapse-admin/issues/17 Signed-off-by: Dirk Klimpel dirk@klimpel.org
* Add the option to validate the `iss` and `aud` claims for JWT logins. (#7827)Patrick Cloke2020-07-142-6/+47
|
* Improve the type hints of synapse.api.errors. (#7820)Patrick Cloke2020-07-141-55/+73
|
* Correctly pass app_name to all email templates. (#7829)Erik Johnston2020-07-141-2/+8
| | | We didn't do this for e.g. registration emails.
* Support handling registration requests across multiple client readers. (#7830)Patrick Cloke2020-07-131-1/+2
|
* Fix handling of "off" in encryption_enabled_by_default_for_room_type (#7822)Brendan Abolivier2020-07-131-1/+6
| | | | | | | | | | | | | | | | | Fixes https://github.com/matrix-org/synapse/issues/7821, introduced in https://github.com/matrix-org/synapse/pull/7639 Turns out PyYAML translates `off` into a `False` boolean if it's unquoted (see https://stackoverflow.com/questions/36463531/pyyaml-automatically-converting-certain-keys-to-boolean-values), which seems to be a liberal interpretation of this bit of the YAML spec: https://yaml.org/spec/1.1/current.html#id864510 An alternative fix would be to implement the solution mentioned in the SO post linked above, but I'm aware it might break existing setups (which might use these values in the configuration file) so it's probably better just to add an extra check for this one. We should be aware that this is a thing for the next times we do that though. I didn't find any other occurrence of this bug elsewhere in the codebase.
* Merge branch 'master' into developRichard van der Hoff2020-07-131-1/+1
|\
| * 1.17.0 v1.17.0 github/release-v1.17.0 release-v1.17.0Richard van der Hoff2020-07-131-1/+1
| |
* | Do not use canonicaljson to magically handle decoding bytes from JSON. (#7802)Patrick Cloke2020-07-105-27/+15
| |
* | Add types to the server code and remove unused parameter (#7813)Patrick Cloke2020-07-101-30/+41
| |
* | Include room states on invite events sent to ASes (#6455)Sorunome2020-07-101-4/+16
| |
* | Merge branch 'release-v1.17.0' into developRichard van der Hoff2020-07-101-0/+22
|\|
| * Merge branch 'master' into release-v1.17.0Richard van der Hoff2020-07-101-0/+22
| |\
| | * fix migration, againRichard van der Hoff2020-07-101-1/+1
| | |
| | * 1.16.1Richard van der Hoff2020-07-101-1/+1
| | |
| | * Drop incorrectly-added table `local_rejections_stream`. (#7816)Richard van der Hoff2020-07-101-0/+22
| | |
* | | Add ability to shard the federation sender (#7798)Erik Johnston2020-07-1011-125/+349
| | |
* | | Fix resync remote devices on receive PDU in worker mode. (#7815)Erik Johnston2020-07-101-8/+19
| | | | | | | | | | | | | | | | | | The replication client requires that arguments are given as keyword arguments, which was not done in this case. We also pull out the logic so that we can catch and handle any exceptions raised, rather than leaving them unhandled.
* | | Fix recursion error when fetching auth chain over federation (#7817)Erik Johnston2020-07-102-16/+43
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | When fetching the state of a room over federation we receive the event IDs of the state and auth chain. We then fetch those events that we don't already have. However, we used a function that recursively fetched any missing auth events for the fetched events, which can lead to a lot of recursion if the server is missing most of the auth chain. This work is entirely pointless because would have queued up the missing events in the auth chain to be fetched already. Let's just diable the recursion, since it only gets called from one place anyway.
* | 1.17.0rc1 v1.17.0rc1Richard van der Hoff2020-07-091-1/+1
| |
* | Fix some spelling mistakes / typos. (#7811)Patrick Cloke2020-07-0924-33/+33
| |
* | `update_membership` declaration: now always returns an event id. (#7809)Richard van der Hoff2020-07-093-9/+7
| |
* | Improve stacktraces from exceptions in background processes (#7808)Richard van der Hoff2020-07-091-1/+9
| | | | | | use `Failure()` to fish out the real exception.
* | Fix `can only concatenate list (not "tuple") to list` exception (#7810)Richard van der Hoff2020-07-091-1/+1
| | | | | | It seems auth_events can be either a list or a tuple, depending on Things.
* | Pass original request headers from workers to the main process. (#7797)Patrick Cloke2020-07-091-5/+25
| |
* | Generate real events when we reject invites (#7804)Richard van der Hoff2020-07-096-169/+183
| | | | | | | | | | | | | | | | Fixes #2181. The basic premise is that, when we fail to reject an invite via the remote server, we can generate our own out-of-band leave event and persist it as an outlier, so that we have something to send to the client.
* | Add `HomeServer.signing_key` property (#7805)Richard van der Hoff2020-07-088-7/+9
| | | | | | ... instead of duplicating `config.signing_key[0]` everywhere
* | Do not use simplejson in Synapse. (#7800)Patrick Cloke2020-07-085-25/+10
| |
* | Stop passing bytes when dumping JSON (#7799)Patrick Cloke2020-07-083-6/+10
| |
* | Merge branch 'master' into developRichard van der Hoff2020-07-081-1/+1
|\|
| * 1.16.0Richard van der Hoff2020-07-081-1/+1
| |
* | Stop populating unused table `local_invites`. (#7793)Richard van der Hoff2020-07-073-80/+24
| | | | | | | | | | This table is no longer used, so we may as well stop populating it. Removing it would prevent people rolling back to older releases of Synapse, so that can happen in a future release.
* | Refactor getting replication updates from database v2. (#7740)Erik Johnston2020-07-0710-195/+335
| |
* | Add documentation for JWT login type and improve sample config. (#7776)Patrick Cloke2020-07-062-25/+58
| |
* | Convert the appservice handler to async/await. (#7775)Patrick Cloke2020-07-062-43/+32
| |
* | Don't ignore `set_tweak` actions with no explicit `value`. (#7766)reivilibre2020-07-061-4/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix spec compliance; tweaks without values are valid (default to True, which is only concretely specified for `highlight`, but it seems only reasonable to generalise) * Changelog for 7766. * Add documentation to `tweaks_for_actions` May as well tidy up when I'm here. * Add a test for `tweaks_for_actions`
* | Allow to use higher versions of prometheus_client (#7780)Oliver Kurz2020-07-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes https://github.com/matrix-org/synapse/issues/7641 The package was pinned to <0.8.0 without an obvious reasoning with 7ad1d7635 in https://github.com/matrix-org/synapse/pull/5636 while the version selection looks to just try to exclude an arbitrary next minor version number that might introduce API breaking changes. Selecting the next minor number might be a good conservative selection. Downstream distributions already reported success patching out the version requirements. This also fixes the integration of upgraded packages into openSUSE packages, e.g. for openSUSE Tumbleweed which already ships prometheus_client >= 0.8 . Signed-off-by: Oliver Kurz <okurz@suse.de> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | isort 5 compatibility (#7786)Will Hunt2020-07-0515-25/+15
| | | | | | The CI appears to use the latest version of isort, which is a problem when isort gets a major version bump. Rather than try to pin the version, I've done the necessary to make isort5 happy with synapse.
* | Merge different Resource implementation classes (#7732)Erik Johnston2020-07-0315-309/+256
| |
* | Fix inconsistent handling of upper and lower cases of email addresses. (#7021)Dirk Klimpel2020-07-035-18/+84
| | | | | | fixes #7016
* | Merge tag 'v1.16.0rc2' into developPatrick Cloke2020-07-023-3/+3
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.16.0rc2 (2020-07-02) ============================== Synapse 1.16.0rc2 includes the security fixes released with Synapse 1.15.2. Please see [below](https://github.com/matrix-org/synapse/blob/master/CHANGES.md#synapse-1152-2020-07-02) for more details. Improved Documentation ---------------------- - Update postgres image in example `docker-compose.yaml` to tag `12-alpine`. ([\#7696](https://github.com/matrix-org/synapse/issues/7696)) Internal Changes ---------------- - Add some metrics for inbound and outbound federation latencies: `synapse_federation_server_pdu_process_time` and `synapse_event_processing_lag_by_event`. ([\#7771](https://github.com/matrix-org/synapse/issues/7771))
| * 1.16.0rc2Patrick Cloke2020-07-021-1/+1
| |
| * Merge branch 'master' into release-v1.16.0Patrick Cloke2020-07-0211-97/+106
| |\
| * | Fix new metric where we used ms instead of seconds (#7771)Erik Johnston2020-07-012-2/+2
| | | | | | | | | | | | Introduced in #7755, not yet released.
* | | Merge branch 'master' into developPatrick Cloke2020-07-0211-97/+106
|\ \ \ | | |/ | |/|
| * | 1.15.2Patrick Cloke2020-07-021-1/+1
| | |
| * | Correctly handle outliers as prev events over federationErik Johnston2020-07-021-3/+3
| | |
| * | Ensure that HTML pages served from Synapse include headers to avoid embedding.Patrick Cloke2020-07-0210-94/+103
| | |
* | | Hack to add push priority to push notifications (#7765)reivilibre2020-07-011-3/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Remove obsolete comment about ancient temporary code Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> * Implement hack to set push priority based on whether the tweaks indicate the event might cause effects. * Changelog for 7765 Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> * Antilint * Add tests for push priority Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> * Update synapse/push/httppusher.py Co-authored-by: Brendan Abolivier <babolivier@matrix.org> * Antilint * Remove needless invites from tests. Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* | | Add early returns to `_check_for_soft_fail` (#7769)Richard van der Hoff2020-07-011-64/+55
| | | | | | | | | | | | my editor was complaining about unset variables, so let's add some early returns to fix that and reduce indentation/cognitive load.
* | | Use symbolic names for replication stream names (#7768)Richard van der Hoff2020-07-0110-22/+26
| | | | | | | | | This makes it much easier to find where streams are referenced.
* | | Type checking for `FederationHandler` (#7770)Richard van der Hoff2020-07-011-17/+30
| | | | | | | | | fix a few things to make this pass mypy.
* | | Fix incorrect error message when database CTYPE was set incorrectly. (#7760)Richard van der Hoff2020-07-011-1/+1
| |/ |/|
* | 1.16.0rc1Andrew Morgan2020-07-011-1/+1
| |
* | Back out MSC2625 implementation (#7761)Brendan Abolivier2020-07-016-142/+33
| |
* | Additional configuration options for auto-join rooms (#7763)Patrick Cloke2020-06-303-67/+273
| |
* | Add some metrics for inbound and outbound federation processing times (#7755)Erik Johnston2020-06-304-17/+42
| |
* | Explain the purpose of the "tests" conditional dependency requirement (#7751)Andrew Morgan2020-06-301-0/+4
| |
* | Add another yield point to state res v2 (#7746)Erik Johnston2020-06-261-2/+10
| |
* | Yield during large v2 state res. (#7735)Erik Johnston2020-06-243-11/+52
| | | | | | | | | | | | | | | | | | | | | | State res v2 across large data sets can be very CPU intensive, and if all the relevant events are in the cache the algorithm will run from start to finish within a single reactor tick. This can result in blocking the reactor tick for several seconds, which can have major repercussions on other requests. To fix this we simply add the occaisonal `sleep(0)` during iterations to yield execution until the next reactor tick. The aim is to only do this for large data sets so that we don't impact otherwise quick resolutions.=
* | add org.matrix.login.jwt so that m.login.jwt can be deprecated (#7675)Sorunome2020-06-241-1/+4
| |
* | Set Content-Length for Metrics requests (#7730)Christian Svensson2020-06-231-1/+4
| | | | | | | | | | | | HTTP requires the response to contain a Content-Length header unless chunked encoding is being used. Prometheus metrics endpoint did not set this, causing software such as prometheus-proxy to not be able to scrape synapse for metrics. Signed-off-by: Christian Svensson <blue@cmd.nu>
* | Allow local media to be marked as safe from being quarantined. (#7718)Patrick Cloke2020-06-224-35/+52
| |
* | Convert directory handler to async/await (#7727)Patrick Cloke2020-06-222-40/+32
| |
* | Speed up state res v2 across large state differences. (#7725)Erik Johnston2020-06-191-1/+2
| |
* | add a commentRichard van der Hoff2020-06-181-0/+2
| |
* | Merge pull request #7716 from matrix-org/babolivier/unread_fixBrendan Abolivier2020-06-172-2/+2
|\ \ | | | | | | Fix unread counts in sync
| * | Fix unread counts in syncBrendan Abolivier2020-06-172-2/+2
| | | | | | | | | | | | | | | * Always return an unread_count in get_unread_event_push_actions_by_room_for_user * Don't always expect unread_count to be there so we don't take out sync entirely if something goes wrong
* | | Convert the typing handler to async/await. (#7679)Patrick Cloke2020-06-171-18/+11
| | |
* | | Require parameterized package version to be at least 0.7.0. (#7680)Oleg Girko2020-06-171-1/+2
|/ / | | | | | | | | Older versions of `parameterized` package have no `parameterized_class` decorator. This decorator is used in tests. Signed-off-by: Oleg Girko <ol@infoserver.lv>
* | Add support for using rust-python-jaeger-reporter (#7697)Erik Johnston2020-06-171-3/+36
| |
* | Support running multiple media repos. (#7706)Erik Johnston2020-06-172-3/+21
| | | | | | | | | | This requires a new config option to specify which media repo should be responsible for running background jobs to e.g. clear out expired URL preview caches.
* | Fetch from the r0 media path instead of the unspecced v1. (#7714)Patrick Cloke2020-06-171-4/+4
| |
* | Implement unread counter (MSC2625) (#7673)Brendan Abolivier2020-06-176-32/+141
|\ \ | | | | | | Implementation of https://github.com/matrix-org/matrix-doc/pull/2625
| * \ Merge branch 'develop' into babolivier/mark_unreadBrendan Abolivier2020-06-1551-271/+218
| |\ \
| * \ \ Merge branch 'develop' into babolivier/mark_unreadBrendan Abolivier2020-06-1513-103/+295
| |\ \ \
| * | | | Incorporate reviewBrendan Abolivier2020-06-151-15/+11
| | | | |
| * | | | LintBrendan Abolivier2020-06-121-3/+8
| | | | |
| * | | | Incorporate review bitsBrendan Abolivier2020-06-122-21/+19
| | | | |
| * | | | Pre-populate the unread_count columnBrendan Abolivier2020-06-121-0/+5
| | | | |
| * | | | Don't update the schema versionBrendan Abolivier2020-06-122-1/+1
| | | | |
| * | | | Use attr instead of a dictBrendan Abolivier2020-06-121-21/+31
| | | | |
| * | | | Fix summary rotationBrendan Abolivier2020-06-121-12/+35
| | | | |
| * | | | Log for invalid values of notifBrendan Abolivier2020-06-111-0/+6
| | | | |
| * | | | Fix SQLBrendan Abolivier2020-06-111-3/+3
| | | | |
| * | | | Fix schema updateBrendan Abolivier2020-06-111-1/+1
| | | | |
| * | | | LintBrendan Abolivier2020-06-111-1/+2
| | | | |
| * | | | Save the count of unread messages to event_push_summaryBrendan Abolivier2020-06-113-20/+53
| | | | |
| * | | | Actually act on mark_unreadBrendan Abolivier2020-06-111-3/+7
| | | | |
| * | | | Appease mypyBrendan Abolivier2020-06-101-1/+1
| | | | |
| * | | | LintBrendan Abolivier2020-06-101-3/+3
| | | | |
| * | | | Use temporary prefixes as per the MSCBrendan Abolivier2020-06-103-3/+5
| | | | |
| * | | | Use a more efficient way of calculating countersBrendan Abolivier2020-06-101-23/+20
| | | | |
| * | | | Add a new unread_counter to sync responsesBrendan Abolivier2020-06-103-3/+28
| | | | |