summary refs log tree commit diff
path: root/synapse (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'master' into developBrendan Abolivier2020-01-231-1/+1
|\
| * 1.9.0Brendan Abolivier2020-01-231-1/+1
| |
* | a bit of debugging for media storage providers (#6757)Richard van der Hoff2020-01-232-0/+7
| | | | | | | | | | | | * a bit of debugging for media storage providers * changelog
* | Minor fixes to user admin api (#6761)Richard van der Hoff2020-01-231-9/+5
| | | | | | | | * don't insist on a password (this is valid if you have an SSO login) * fix reference to undefined `requester`
* | Remove unnecessary abstractions in admin handler (#6751)Andrew Morgan2020-01-223-73/+10
|/
* 1.9.0rc1Brendan Abolivier2020-01-221-1/+1
|
* Admin API to list, filter and sort rooms (#6720)Andrew Morgan2020-01-225-3/+224
|
* Fix typo in _select_thumbnailBrendan Abolivier2020-01-221-1/+1
|
* Fix and add test to deprecated quarantine media admin api (#6756)Andrew Morgan2020-01-221-1/+1
|
* Allow monthly active user limiting support for worker mode, fixes #4639. (#6742)Neil Johnson2020-01-225-82/+99
|
* Allow streaming cache invalidate all to workers. (#6749)Erik Johnston2020-01-224-15/+63
|
* Add a DeltaState to track changes to be made to current state (#6716)Erik Johnston2020-01-202-99/+111
|
* Fixup synapse.rest to pass mypy (#6732)Erik Johnston2020-01-209-33/+45
|
* Fix `/events/:event_id` deprecated API. (#6731)Erik Johnston2020-01-201-1/+1
|
* Fixup synapse.api to pass mypy (#6733)Erik Johnston2020-01-203-4/+9
|
* Fix changing password via user admin API. (#6730)Erik Johnston2020-01-201-2/+2
|
* Fix empty account_validity config blockAndrew Morgan2020-01-201-1/+2
|
* Add more logging around message retention policies support (#6717)Brendan Abolivier2020-01-172-0/+21
| | | So we can debug issues like #6683 more easily
* bump version to v1.9.0.dev2 v1.9.0.dev2Richard van der Hoff2020-01-171-1/+1
|
* Fix syntax error in run_upgrade for schema 57 (#6728)Satsuki Yanagi2020-01-171-3/+4
| | | | | | | Fix #6727 Related #6655 Co-authored-by: Erik Johnston <erikj@jki.re>
* Merge pull request #6714 from matrix-org/babolivier/retention_select_eventBrendan Abolivier2020-01-173-7/+7
|\ | | | | Fix instantiation of message retention purge jobs
| * Fixup diffBrendan Abolivier2020-01-161-6/+7
| |
| * Remove get_room_event_after_stream_ordering entirelyBrendan Abolivier2020-01-162-58/+13
| |
| * LintBrendan Abolivier2020-01-161-6/+12
| |
| * Correctly order when selecting before stream orderingBrendan Abolivier2020-01-151-2/+5
| |
| * Fix typoBrendan Abolivier2020-01-151-1/+1
| |
| * Fix instantiation of message retention purge jobsBrendan Abolivier2020-01-152-13/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When figuring out which topological token to start a purge job at, we need to do the following: 1. Figure out a timestamp before which events will be purged 2. Select the first stream ordering after that timestamp 3. Select info about the first event after that stream ordering 4. Build a topological token from that info In some situations (e.g. quiet rooms with a short max_lifetime), there might not be an event after the stream ordering at step 3, therefore we abort the purge with the error `No event found`. To mitigate that, this patch fetches the first event _before_ the stream ordering, instead of after.
* | bump version to v1.9.0.dev1 v1.9.0.dev1Richard van der Hoff2020-01-171-1/+1
| |
* | Merge pull request #6724 from matrix-org/rav/log_saml_attributesRichard van der Hoff2020-01-179-24/+66
|\ \ | | | | | | Log saml assertions rather than the whole response
| * | Log saml assertions rather than the whole responseRichard van der Hoff2020-01-162-1/+25
| | | | | | | | | | | | | | | | | | ... since the whole response is huge. We even need to break up the assertions, since kibana otherwise truncates them.
| * | move batch_iter to a separate moduleRichard van der Hoff2020-01-168-23/+41
| | |
* | | Delegate remote_user_id mapping to the saml mapping provider (#6723)Richard van der Hoff2020-01-172-6/+22
| | | | | | | | | Turns out that figuring out a remote user id for the SAML user isn't quite as obvious as it seems. Factor it out to the SamlMappingProvider so that it's easy to control.
* | | Wake up transaction queue when remote server comes back online (#6706)Erik Johnston2020-01-179-7/+129
| | | | | | | | | | | | | | | This will be used to retry outbound transactions to a remote server if we think it might have come back up.
* | | Clarify the `account_validity` and `email` sections of the sample ↵Richard van der Hoff2020-01-173-140/+167
|/ / | | | | | | | | | | | | | | | | | | | | configuration. (#6685) Generally try to make this more comprehensible, and make it match the conventions. I've removed the documentation for all the settings which allow you to change the names of the template files, because I can't really see why they are useful.
* | Add StateMap type alias (#6715)Erik Johnston2020-01-1613-93/+114
| |
* | Add org.matrix.e2e_cross_signing to unstable_features in /versions as per ↵Neil Johnson2020-01-161-0/+2
| | | | | | | | MSC1756 (#6712)
* | Port synapse.replication.tcp to async/await (#6666)Erik Johnston2020-01-1613-104/+78
| | | | | | | | | | | | | | | | | | | | * Port synapse.replication.tcp to async/await * Newsfile * Correctly document type of on_<FOO> functions as async * Don't be overenthusiastic with the asyncing....
* | Fix purge_room admin API (#6711)Erik Johnston2020-01-151-1/+1
| |
* | Remove duplicate session check in web fallback servlet (#6702)Andrew Morgan2020-01-151-4/+0
| |
* | Merge branch 'develop' into rav/module_api_extensionsRichard van der Hoff2020-01-1536-240/+682
|\ \
| * | Implement RedirectException (#6687)Richard van der Hoff2020-01-152-5/+35
| | | | | | | | | | | | | | | Allow REST endpoint implemnentations to raise a RedirectException, which will redirect the user's browser to a given location.
| * | Add `local_current_membership` table (#6655)Erik Johnston2020-01-1513-89/+247
| |/ | | | | | | | | | | | | Currently we rely on `current_state_events` to figure out what rooms a user was in and their last membership event in there. However, if the server leaves the room then the table may be cleaned up and that information is lost. So lets add a table that separately holds that information.
| * Process EDUs in parallel with PDUs. (#6697)Erik Johnston2020-01-141-12/+58
| | | | | | | | This means that things like to device messages don't get blocked behind processing PDUs, which can potentially take *ages*.
| * Fixup synapse.replication to pass mypy checks (#6667)Erik Johnston2020-01-1410-86/+103
| |
| * Quarantine media by ID or user ID (#6681)Andrew Morgan2020-01-132-3/+181
| |
| * Kill off RegistrationError (#6691)Richard van der Hoff2020-01-132-15/+3
| | | | | | This is pretty pointless. Let's just use SynapseError.
| * Don't assign numeric IDs for empty usernames (#6690)Richard van der Hoff2020-01-131-1/+1
| | | | | | | | Fix a bug where we would assign a numeric userid if somebody tried registering with an empty username
| * Merge pull request #6689 from matrix-org/rav/saml_mapping_provider_updatesRichard van der Hoff2020-01-131-6/+16
| |\ | | | | | | Updates to the SAML mapping provider API
| | * Pass client redirect URL into SAML mapping providersRichard van der Hoff2020-01-121-4/+11
| | |
| | * Pass the module_api into the SamlMappingProviderRichard van der Hoff2020-01-121-2/+5
| | | | | | | | | | | | | | | ... for consistency with other modules, and because we'll need it sooner or later and it will be a pain to introduce later.
| * | Allow additional_resources to implement Resource directly (#6686)Richard van der Hoff2020-01-131-2/+11
| | | | | | | | | | | | | | | | | | AdditionalResource really doesn't add any value, and it gets in the way for resources which want to support child resources or the like. So, if the resource object already implements the IResource interface, don't bother wrapping it.
| * | Fix exceptions on requests for non-ascii urls (#6682)Richard van der Hoff2020-01-131-1/+1
| | | | | | | | | Fixes #6402
| * | comment for run_in_backgroundRichard van der Hoff2020-01-121-0/+3
| | |
| * | Refuse to start if sqlite is older than 3.11.0Richard van der Hoff2020-01-092-4/+7
| | |
| * | Check postgres version in check_databaseRichard van der Hoff2020-01-091-13/+12
| | | | | | | | | | | | | | | this saves doing it on each connection, and will allow us to pass extra options in.
| * | Modify check_database to take a connection rather than a cursorRichard van der Hoff2020-01-093-10/+11
| |/ | | | | | | We might not need the cursor at all.
* | Handle `config` not being set for synapse plugin modulesRichard van der Hoff2020-01-121-1/+1
| | | | | | | | | | Some modules don't need any config, so having to define a `config` property just to keep the loader happy is a bit annoying.
* | Cleanups and additions to the module APIRichard van der Hoff2020-01-122-6/+59
|/ | | | | | | | | | | Add some useful things, such as error types and logcontext handling, to the API. Make `hs` a private member to dissuade people from using it (hopefully they aren't already). Add a couple of new methods (`record_user_external_id` and `generate_short_term_login_token`).
* Allow admin users to create or modify users without a shared secret (#6495)Manuel Stahl2020-01-094-0/+155
| | | Signed-off-by: Manuel Stahl <manuel.stahl@awesome-technologies.de>
* Merge branch 'master' into developErik Johnston2020-01-091-1/+1
|\
| * 1.8.0Erik Johnston2020-01-091-1/+1
| |
* | Merge pull request #6664 from matrix-org/erikj/media_admin_apisErik Johnston2020-01-082-120/+130
|\ \ | | | | | | Fix media repo admin APIs when using a media worker.
| * | Shuffle the codeErik Johnston2020-01-081-25/+16
| | |
| * | CommentsErik Johnston2020-01-081-0/+3
| | |
| * | Do not rely on streaming events, as media repo doesn'tErik Johnston2020-01-081-12/+26
| | |
| * | Import RoomStore in media worker to fix admin APIsErik Johnston2020-01-081-0/+2
| | |
| * | Move media admin store functions to worker storeErik Johnston2020-01-081-120/+120
| | |
* | | Merge remote-tracking branch 'origin/release-v1.8.0' into developRichard van der Hoff2020-01-082-24/+10
|\ \ \ | | |/ | |/|
| * | Fix GET request on /_synapse/admin/v2/users endpoint (#6563)Manuel Stahl2020-01-081-2/+2
| | | | | | | | | | | | Fixes #6552
| * | Back out ill-advised notary server hackery (#6657)Richard van der Hoff2020-01-081-22/+8
| |/ | | | | | | | | | | | | | | | | | | | | This was ill-advised. We can't modify verify_keys here, because the response object has already been signed by the requested key. Furthermore, it's somewhat unnecessary because existing versions of Synapse (which get upset that the notary key isn't present in verify_keys) will fall back to a direct fetch via `/key/v2/server`. Also: more tests for fetching keys via perspectives: it would be nice if we actually tested when our fetcher can't talk to our notary impl.
* | Correctly proxy remote group HTTP errors. (#6654)Erik Johnston2020-01-071-0/+16
| | | | | | | | | | e.g. if remote returns a 404 then that shouldn't be treated as an error but should be proxied through.
* | Merge pull request #6621 from matrix-org/babolivier/purge_job_config_typoBrendan Abolivier2020-01-071-5/+5
|\ \ | |/ |/| Fix a typo in the purge jobs configuration example
| * RewordBrendan Abolivier2020-01-071-3/+3
| |
| * Change the example from 5min to 12hBrendan Abolivier2020-01-071-4/+4
| | | | | | | | Have a purge job running every 5min is probably not something we want to advise admins to do as a sort-of default.
| * Fix a typo in the purge jobs configuration exampleBrendan Abolivier2020-01-031-1/+1
| |
* | 1.8.0rc1Erik Johnston2020-01-071-1/+1
| |
* | Merge pull request #6652 from matrix-org/babolivier/depth_missing_eventsBrendan Abolivier2020-01-072-3/+3
|\ \ | | | | | | Fix conditions failing if min_depth = 0
| * | Fix conditions failing if min_depth = 0Brendan Abolivier2020-01-072-3/+3
| |/ | | | | | | This could result in Synapse not fetching prev_events for new events in the room if it has missed some events.
* | Add a background update to clear tombstoned rooms from the directory (#6648)Richard van der Hoff2020-01-074-1/+100
| | | | | | | | | | | | * Add a background update to clear tombstoned rooms from the directory * use the ABC metaclass
* | Async/await for background updates (#6647)Richard van der Hoff2020-01-071-16/+20
| | | | | | | | so that bg update routines can be async
* | Merge pull request #6645 from matrix-org/rav/fix_synchrotron_errorRichard van der Hoff2020-01-072-15/+47
|\ \ | | | | | | Fix exceptions in the synchrotron worker log when events are rejected.
| * | Fix exceptions in log when rejected event is replicatedRichard van der Hoff2020-01-061-2/+9
| | |
| * | async/await for SyncReplicationHandler.process_and_notifyRichard van der Hoff2020-01-061-5/+4
| | |
| * | Clarify documentation on get_event* methodsRichard van der Hoff2020-01-061-9/+35
| | | | | | | | | | | | Make it clearer how they behave in the face of rejected and/or missing events.
* | | Merge pull request #6629 from matrix-org/rav/kill_event_reference_hashesRichard van der Hoff2020-01-064-87/+49
|\ \ \ | |/ / |/| | Remove a bunch of unused code from event creation
| * | Remove unused get_latest_event_ids_and_hashes_in_roomRichard van der Hoff2020-01-061-42/+0
| | |
| * | Remove unused get_prev_events_and_hashes_for_roomRichard van der Hoff2020-01-061-30/+0
| | |
| * | Remove unused hashes and depths from _update_membership paramsRichard van der Hoff2020-01-061-13/+4
| | |
| * | Remove unused hashes and depths from create_event paramsRichard van der Hoff2020-01-062-17/+12
| | |
| * | Remove unused hashes and depths from create_new_client_event paramsRichard van der Hoff2020-01-062-12/+26
| | |
| * | replace get_prev_events_and_hashes_for_room with get_prev_events_for_room in ↵Richard van der Hoff2020-01-062-9/+38
| | | | | | | | | | | | create_new_client_event
| * | rename get_prev_events_for_room to get_prev_events_and_hashes_for_roomRichard van der Hoff2020-01-063-5/+10
| | | | | | | | | | | | ... to make way for a new method which just returns the event ids
* | | Fix some test failures when frozen_dicts are enabled (#6642)Richard van der Hoff2020-01-064-11/+19
| | | | | | | | | | | | Fixes #4026
* | | Add experimental 'databases' config (#6580)Erik Johnston2020-01-062-13/+63
| | |
* | | Fix an error which was thrown by the PresenceHandler _on_shutdown handler. ↵Richard van der Hoff2020-01-061-7/+2
| | | | | | | | | | | | (#6640)
* | | Fix exception when fetching notary server's old keys (#6625)Richard van der Hoff2020-01-061-6/+7
| | | | | | | | | | | | | | | | | | Lift the restriction that *all* the keys used for signing v2 key responses be present in verify_keys. Fixes #6596.
* | | Workaround for error when fetching notary's own key (#6620)Richard van der Hoff2020-01-061-8/+22
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | * Kill off redundant SynapseRequestFactory We already get the Site via the Channel, so there's no need for a dedicated RequestFactory: we can just use the right constructor. * Workaround for error when fetching notary's own key As a notary server, when we return our own keys, include all of our signing keys in verify_keys. This is a workaround for #6596.
* | Fix power levels being incorrectly set in old and new rooms after a room ↵Andrew Morgan2020-01-061-7/+10
| | | | | | | | | | | | upgrade (#6633) Modify a copy of an upgraded room's PL before sending to the new room
* | Automate generation of the sample and debian log configs (#6627)Richard van der Hoff2020-01-031-1/+8
| |
* | Raise an error if someone tries to use the log_file config option (#6626)Richard van der Hoff2020-01-032-3/+16
| | | | | | | | This has caused some confusion for people who didn't notice it going away.
* | Remove unused, undocumented "content repo" resource (#6628)Richard van der Hoff2020-01-036-123/+2
| | | | | | | | | | | | This looks like it got half-killed back in #888. Fixes #6567.
* | Kill off redundant SynapseRequestFactory (#6619)Richard van der Hoff2020-01-031-15/+3
| | | | | | | | We already get the Site via the Channel, so there's no need for a dedicated RequestFactory: we can just use the right constructor.
* | Reduce the reconnect time when replication fails. (#6617)Richard van der Hoff2020-01-031-1/+2
|/
* Merge branch 'master' into developRichard van der Hoff2019-12-312-16/+38
|\
| * 1.7.3 v1.7.3 github/release-v1.7.3 release-v1.7.3Richard van der Hoff2019-12-311-1/+1
| |
| * Hacks to work around #6605 (#6608)Richard van der Hoff2019-12-311-15/+37
| | | | | | | | | | When we have an event which refers to non-existent auth_events, ignore said events rather than exploding in a ball of fire. Fixes #6605.
* | Merge branch 'master' into developRichard van der Hoff2019-12-202-2/+5
|\|
| * 1.7.2 v1.7.2 github/release-v1.7.2 release-v1.7.2Richard van der Hoff2019-12-201-1/+1
| |
| * Backport fixes to sqlite upgrade from develop (#6578)Richard van der Hoff2019-12-201-1/+9
| | | | | | | | | | Only run prepare_database on connection for in-memory databases. Fixes #6569.
| * Fix exceptions when attempting to backfill (#6576)Richard van der Hoff2019-12-201-1/+4
| | | | | | Fixes #6575
* | Split state groups into a separate data store (#6296)Erik Johnston2019-12-2024-1162/+1152
| |
* | Change EventContext to use the Storage class (#6564)Erik Johnston2019-12-2013-39/+49
| |
* | Explode on duplicate delta file names. (#6565)Erik Johnston2019-12-191-0/+18
| |
* | Port some admin handlers to async/await (#6559)Erik Johnston2019-12-193-56/+45
| |
* | Improve diagnostics on database upgrade failure (#6570)Richard van der Hoff2019-12-192-8/+6
| | | | | | | | `Failed to upgrade database` is not helpful, and it's unlikely that UPGRADE.rst has anything useful.
* | Fix sdnotify with acme enabled (#6571)Richard van der Hoff2019-12-191-3/+7
| | | | | | | | | | | | | | If acme was enabled, the sdnotify startup hook would never be run because we would try to add it to a hook which had already fired. There's no need to delay it: we can sdnotify as soon as we've started the listeners.
* | Add an export_signing_key script (#6546)Richard van der Hoff2019-12-191-8/+15
| | | | | | | | | | I want to do some key rotation, and it is silly that we don't have a way to do this.
* | Clean up startup for the pusher (#6558)Richard van der Hoff2019-12-184-43/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Remove redundant python2 support code `str.decode()` doesn't exist on python3, so presumably this code was doing nothing * Filter out pushers with corrupt data When we get a row with unparsable json, drop the row, rather than returning a row with null `data`, which will then cause an explosion later on. * Improve logging when we can't start a pusher Log the ID to help us understand the problem * Make email pusher setup more robust We know we'll have a `data` member, since that comes from the database. What we *don't* know is if that is a dict, and if that has a `brand` member, and if that member is a string.
* | Add delta file to fix missing default table data (#6555)Andrew Morgan2019-12-183-15/+23
| |
* | Add database config class (#6513)Erik Johnston2019-12-189-73/+160
| | | | | | | | | | This encapsulates config for a given database and is the way to get new connections.
* | Merge branch 'master' into developRichard van der Hoff2019-12-181-1/+1
|\|
| * 1.7.1Richard van der Hoff2019-12-181-1/+1
| |
* | Merge release-v1.7.1 into developRichard van der Hoff2019-12-184-10/+16
|\|
| * Fix bug where we added duplicate event IDs as auth_events (#6560)Erik Johnston2019-12-171-7/+8
| |
| * Add auth events as per spec. (#6556)Erik Johnston2019-12-161-67/+34
| | | | | | | | | | Previously we tried to be clever and filter out some unnecessary event IDs to keep the auth chain small, but that had some annoying interactions with state res v2 so we stop doing that for now.
| * Merge pull request #6553 from matrix-org/babolivier/fix-context-filterBrendan Abolivier2019-12-162-3/+7
| |\ | | | | | | Use the filtered version of an event when responding to /context requests for that event
| | * Incorporate reviewBrendan Abolivier2019-12-161-1/+1
| | |
| | * Update the documentation of the filtering functionBrendan Abolivier2019-12-161-1/+2
| | |
| | * Use the filtered version of an event when responding to /context requests ↵Brendan Abolivier2019-12-161-1/+4
| | | | | | | | | | | | | | | | | | for that event Sometimes the filtering function can return a pruned version of an event (on top of either the event itself or an empty list), if it thinks the user should be able to see that there's an event there but not the content of that event. Therefore, the previous logic of 'if filtered is empty then we can use the event we retrieved from the database' is flawed, and we should use the event returned by the filtering function.
| * | Exclude rejected state events when calculating state at backwards extrems ↵Richard van der Hoff2019-12-161-1/+1
| | | | | | | | | | | | | | | (#6527) This fixes a weird bug where, if you were determined enough, you could end up with a rejected event forming part of the state at a backwards-extremity. Authing that backwards extrem would then lead to us trying to pull the rejected event from the db (with allow_rejected=False), which would fail with a 404.
| * | Persist auth/state events at backwards extremities when we fetch them (#6526)Richard van der Hoff2019-12-162-165/+82
| | | | | | | | | | | | The main point here is to make sure that the state returned by _get_state_in_room has been authed before we try to use it as state in the room.
| * | sanity-checking for events used in state res (#6531)Richard van der Hoff2019-12-164-43/+124
| | | | | | | | | | | | | | | When we perform state resolution, check that all of the events involved are in the right room.
| * | Sanity-check room ids in event auth (#6530)Richard van der Hoff2019-12-161-0/+12
| | | | | | | | | | | | When we do an event auth operation, check that all of the events involved are in the right room.
| * | Check the room_id of events when fetching room state/auth (#6524)Richard van der Hoff2019-12-161-24/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we request the state/auth_events to populate a backwards extremity (on backfill or in the case of missing events in a transaction push), we should check that the returned events are in the right room rather than blindly using them in the room state or auth chain. Given that _get_events_from_store_or_dest takes a room_id, it seems clear that it should be sanity-checking the room_id of the requested events, so let's do it there.
| * | Add `include_event_in_state` to _get_state_for_room (#6521)Richard van der Hoff2019-12-161-18/+21
| | | | | | | | | | | | | | | | | | Make it return the state *after* the requested event, rather than the one before it. This is a bit easier and requires fewer calls to get_events_from_store_or_dest.
| * | Move get_state methods into FederationHandler (#6503)Richard van der Hoff2019-12-162-86/+106
| | | | | | | | | | | | | | | This is a non-functional refactor as a precursor to some other work.
| * | Refactor get_events_from_store_or_dest to return a dict (#6501)Richard van der Hoff2019-12-161-29/+15
| |/ | | | | | | | | There was a bunch of unnecessary conversion back and forth between dict and list going on here. We can simplify a bunch of the code.
* | Remove unused `get_pagination_rows` methods. (#6557)Erik Johnston2019-12-173-18/+0
| | | | | | Remove unused get_pagination_rows methods
* | Add auth events as per spec. (#6556)Erik Johnston2019-12-161-67/+34
| | | | | | | | | | Previously we tried to be clever and filter out some unnecessary event IDs to keep the auth chain small, but that had some annoying interactions with state res v2 so we stop doing that for now.
* | Add option to allow profile queries without sharing a room (#6523)Will Hunt2019-12-162-1/+18
| |
* | Exclude rejected state events when calculating state at backwards extrems ↵Richard van der Hoff2019-12-161-1/+1
| | | | | | | | | | (#6527) This fixes a weird bug where, if you were determined enough, you could end up with a rejected event forming part of the state at a backwards-extremity. Authing that backwards extrem would then lead to us trying to pull the rejected event from the db (with allow_rejected=False), which would fail with a 404.
* | Persist auth/state events at backwards extremities when we fetch them (#6526)Richard van der Hoff2019-12-162-169/+82
| | | | | | The main point here is to make sure that the state returned by _get_state_in_room has been authed before we try to use it as state in the room.
* | Automatically delete empty groups/communities (#6453)Werner Sembach2019-12-162-0/+34
| | | | | | Signed-off-by: Werner Sembach <werner.sembach@fau.de>
* | sanity-checking for events used in state res (#6531)Richard van der Hoff2019-12-134-43/+124
| | | | | | | | | | | | | | When we perform state resolution, check that all of the events involved are in the right room.
* | Sanity-check room ids in event auth (#6530)Richard van der Hoff2019-12-131-0/+12
| | | | | | | | When we do an event auth operation, check that all of the events involved are in the right room.
* | Merge pull request #6537 from matrix-org/erikj/bump_mypy_versionErik Johnston2019-12-136-6/+11
|\ \ | | | | | | Bump mypy version
| * | Bump version of mypyErik Johnston2019-12-126-6/+11
| | |
* | | Merge branch 'master' into developErik Johnston2019-12-131-1/+1
|\ \ \ | | |/ | |/|
| * | 1.7.0Erik Johnston2019-12-131-1/+1
| | |
* | | Merge pull request #6496 from matrix-org/erikj/initial_sync_asnycErik Johnston2019-12-131-52/+44
|\ \ \ | | | | | | | | Port synapse.handlers.initial_sync to async/await
| * \ \ Merge branch 'develop' of github.com:matrix-org/synapse into ↵Erik Johnston2019-12-1170-693/+1121
| |\ \ \ | | | | | | | | | | | | | | | erikj/initial_sync_asnyc
| * | | | Port synapse.handlers.initial_sync to async/awaitErik Johnston2019-12-091-52/+44
| | | | |
* | | | | look up cross-signing keys from the DB in bulk (#6486)Hubert Chathi2019-12-123-13/+241
| | | | |
* | | | | Fix redacted events being returned in search results ordered by "recent" (#6522)Andrew Morgan2019-12-121-3/+8
| |_|_|/ |/| | |
* | | | Check the room_id of events when fetching room state/auth (#6524)Richard van der Hoff2019-12-121-23/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we request the state/auth_events to populate a backwards extremity (on backfill or in the case of missing events in a transaction push), we should check that the returned events are in the right room rather than blindly using them in the room state or auth chain. Given that _get_events_from_store_or_dest takes a room_id, it seems clear that it should be sanity-checking the room_id of the requested events, so let's do it there.
* | | | Merge pull request #6511 from matrix-org/erikj/remove_db_config_from_appsErik Johnston2019-12-1213-62/+12
|\ \ \ \ | |_|/ / |/| | | Move database config from apps into HomeServer object
| * | | Add new config param to docstring and add typesErik Johnston2019-12-111-1/+3
| | | |
| * | | Remove database config parsing from apps.Erik Johnston2019-12-1013-62/+10
| | | |
* | | | Add `include_event_in_state` to _get_state_for_room (#6521)Richard van der Hoff2019-12-111-22/+28
| | | | | | | | | | | | | | | | | | | | Make it return the state *after* the requested event, rather than the one before it. This is a bit easier and requires fewer calls to get_events_from_store_or_dest.
* | | | Merge pull request #6517 from matrix-org/rav/event_auth/13Richard van der Hoff2019-12-112-98/+88
|\ \ \ \ | | | | | | | | | | Port some of FederationHandler to async/await
| * | | | convert to async: FederationHandler._process_received_pduRichard van der Hoff2019-12-111-11/+10
| | | | | | | | | | | | | | | | | | | | also fix user_joined_room to consistently return deferreds
| * | | | convert to async: FederationHandler._get_state_for_roomRichard van der Hoff2019-12-111-21/+21
| | | | | | | | | | | | | | | | | | | | ... and _get_events_from_store_or_dest
| * | | | convert to async: FederationHandler.on_receive_pduRichard van der Hoff2019-12-111-27/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | and associated functions: * on_receive_pdu * handle_queued_pdus * get_missing_events_for_pdu
| * | | | Convert federation backfill to asyncRichard van der Hoff2019-12-112-39/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PaginationHandler.get_messages is only called by RoomMessageListRestServlet, which is async. Chase the code path down from there: - FederationHandler.maybe_backfill (and nested try_backfill) - FederationHandler.backfill
* | | | | Merge pull request #6504 from matrix-org/erikj/account_validity_async_awaitErik Johnston2019-12-112-55/+45
|\ \ \ \ \ | |/ / / / |/| | | | Port handlers.account_validity to async/await.
| * | | | Port handlers.account_validity to async/await.Erik Johnston2019-12-102-47/+41
| | | | |
| * | | | Port handlers.account_data to async/await.Erik Johnston2019-12-101-9/+5
| |/ / /
* | | | Clean up some logging (#6515)Richard van der Hoff2019-12-111-18/+19
| | | | | | | | | | | | | | | | This just makes some of the logging easier to follow when things start going wrong.
* | | | Merge tag 'v1.7.0rc2' into developErik Johnston2019-12-114-8/+18
|\ \ \ \ | | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.7.0rc2 (2019-12-11) ============================= Bugfixes -------- - Fix incorrect error message for invalid requests when setting user's avatar URL. ([\#6497](https://github.com/matrix-org/synapse/issues/6497)) - Fix support for SQLite 3.7. ([\#6499](https://github.com/matrix-org/synapse/issues/6499)) - Fix regression where sending email push would not work when using a pusher worker. ([\#6507](https://github.com/matrix-org/synapse/issues/6507), [\#6509](https://github.com/matrix-org/synapse/issues/6509))
| * | | 1.7.0rc2 v1.7.0rc2Erik Johnston2019-12-111-1/+1
| | | |
| * | | Back out change preventing setting null avatar URLsErik Johnston2019-12-111-6/+6
| | | |
| * | | Merge branch 'erikj/fix_sqlite_7' of github.com:matrix-org/synapse into ↵Erik Johnston2019-12-116-14/+49
| |\ \ \ | | | | | | | | | | | | | | | release-v1.7.0
| * | | | Give the server config to the RoomWorkerStoreBrendan Abolivier2019-12-101-0/+5
| | | | |
| * | | | Make the PusherSlaveStore inherit from the slave RoomStoreBrendan Abolivier2019-12-101-1/+6
| | | | | | | | | | | | | | | | | | | | So that it has access to the get_retention_policy_for_room function which is required by filter_events_for_client.
* | | | | Prevent redacted events from appearing in message search (#6377)Andrew Morgan2019-12-115-43/+77
| | | | |
* | | | | Add dev script to generate full SQL schema files (#6394)Andrew Morgan2019-12-112-19/+13
| | | | |
* | | | | Prevent message search in upgraded rooms we're not in (#6385)Andrew Morgan2019-12-113-16/+40
| | | | |
* | | | | Merge pull request #6349 from matrix-org/babolivier/msc1802Brendan Abolivier2019-12-114-28/+140
|\ \ \ \ \ | | | | | | | | | | | | Implement v2 APIs for send_join and send_leave
| * \ \ \ \ Merge branch 'develop' into babolivier/msc1802Brendan Abolivier2019-12-05147-2521/+3950
| |\ \ \ \ \
| * | | | | | LintBrendan Abolivier2019-11-111-3/+2
| | | | | | |
| * | | | | | LintBrendan Abolivier2019-11-111-3/+1
| | | | | | |
| * | | | | | Fix prefix for v2/send_leaveBrendan Abolivier2019-11-111-0/+2
| | | | | | |
| * | | | | | Add server-side support to the v2 APIBrendan Abolivier2019-11-112-14/+33
| | | | | | |
| * | | | | | Implement v2 API for send_leaveBrendan Abolivier2019-11-112-5/+56
| | | | | | |
| * | | | | | Add missing yieldBrendan Abolivier2019-11-111-1/+1
| | | | | | |
| * | | | | | Implement v2 API for send_joinBrendan Abolivier2019-11-112-8/+51
| | | | | | |
* | | | | | | Move get_state methods into FederationHandler (#6503)Richard van der Hoff2019-12-102-86/+106
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a non-functional refactor as a precursor to some other work.
* | | | | | | Allow SAML username provider plugins (#6411)Andrew Morgan2019-12-102-88/+296
| | | | | | |
* | | | | | | Merge pull request #6510 from matrix-org/erikj/phone_home_stats_dbErik Johnston2019-12-101-2/+4
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Phone home stats DB reporting should not assume a single DB.
| * | | | | | | Phone home stats DB reporting should not assume a single DB.Erik Johnston2019-12-101-2/+4
| | |_|_|_|/ / | |/| | | | |
* | | | | | | Fix race which caused deleted devices to reappear (#6514)Richard van der Hoff2019-12-101-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Stop the `update_client_ips` background job from recreating deleted devices.
* | | | | | | Refactor get_events_from_store_or_dest to return a dict (#6501)Richard van der Hoff2019-12-101-29/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There was a bunch of unnecessary conversion back and forth between dict and list going on here. We can simplify a bunch of the code.
* | | | | | | Remove redundant code from event authorisation implementation. (#6502)Richard van der Hoff2019-12-101-6/+2
| | | | | | |
* | | | | | | Merge pull request #6505 from matrix-org/erikj/make_deferred_yiedableErik Johnston2019-12-101-1/+10
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Fix `make_deferred_yieldable` to work with coroutines
| * | | | | | | Update commentErik Johnston2019-12-101-2/+4
| | | | | | | |
| * | | | | | | Fix make_deferred_yieldable to work with coroutinesErik Johnston2019-12-101-1/+8
| |/ / / / / /
* | | | | | | Merge pull request #6499 from matrix-org/erikj/fix_sqlite_7Erik Johnston2019-12-105-11/+41
|\ \ \ \ \ \ \ | | |_|_|_|/ / | |/| | | | | Fix support for SQLite 3.7.
| * | | | | | Drop unused indexErik Johnston2019-12-104-13/+18
| | | | | | |
| * | | | | | Convert _censor_redactions to async since it awaits on coroutinesErik Johnston2019-12-101-11/+9
| | | | | | |
| * | | | | | Only start censor background job after indices are createdErik Johnston2019-12-102-2/+9
| | | | | | |
| * | | | | | Fix support for SQLite 3.7.Erik Johnston2019-12-093-2/+22
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | Partial indices support was added in 3.8.0, so we need to use the background updates that handles this correctly.
* | | | | | Merge pull request #6506 from matrix-org/erikj/remove_snapshot_cacheErik Johnston2019-12-102-105/+8
|\ \ \ \ \ \ | |/ / / / / |/| | | | / | | |_|_|/ | |/| | | Remove SnapshotCache in favour of ResponseCache
| * | | | Remove SnapshotCache in favour of ResponseCacheErik Johnston2019-12-092-105/+8
| | | | |
* | | | | Merge tag 'v1.7.0rc1' into developNeil Johnson2019-12-091-1/+1
|\ \ \ \ \ | | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.7.0rc1 (2019-12-09) ============================= Features -------- - Implement per-room message retention policies. ([\#5815](https://github.com/matrix-org/synapse/issues/5815), [\#6436](https://github.com/matrix-org/synapse/issues/6436)) - Add etag and count fields to key backup endpoints to help clients guess if there are new keys. ([\#5858](https://github.com/matrix-org/synapse/issues/5858)) - Add `/admin/v2/users` endpoint with pagination. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#5925](https://github.com/matrix-org/synapse/issues/5925)) - Require User-Interactive Authentication for `/account/3pid/add`, meaning the user's password will be required to add a third-party ID to their account. ([\#6119](https://github.com/matrix-org/synapse/issues/6119)) - Implement the `/_matrix/federation/unstable/net.atleastfornow/state/<context>` API as drafted in MSC2314. ([\#6176](https://github.com/matrix-org/synapse/issues/6176)) - Configure privacy-preserving settings by default for the room directory. ([\#6354](https://github.com/matrix-org/synapse/issues/6354)) - Add ephemeral messages support by partially implementing [MSC2228](https://github.com/matrix-org/matrix-doc/pull/2228). ([\#6409](https://github.com/matrix-org/synapse/issues/6409)) - Add support for [MSC 2367](https://github.com/matrix-org/matrix-doc/pull/2367), which allows specifying a reason on all membership events. ([\#6434](https://github.com/matrix-org/synapse/issues/6434)) Bugfixes -------- - Transfer non-standard power levels on room upgrade. ([\#6237](https://github.com/matrix-org/synapse/issues/6237)) - Fix error from the Pillow library when uploading RGBA images. ([\#6241](https://github.com/matrix-org/synapse/issues/6241)) - Correctly apply the event filter to the `state`, `events_before` and `events_after` fields in the response to `/context` requests. ([\#6329](https://github.com/matrix-org/synapse/issues/6329)) - Fix caching devices for remote users when using workers, so that we don't attempt to refetch (and potentially fail) each time a user requests devices. ([\#6332](https://github.com/matrix-org/synapse/issues/6332)) - Prevent account data syncs getting lost across TCP replication. ([\#6333](https://github.com/matrix-org/synapse/issues/6333)) - Fix bug: TypeError in `register_user()` while using LDAP auth module. ([\#6406](https://github.com/matrix-org/synapse/issues/6406)) - Fix an intermittent exception when handling read-receipts. ([\#6408](https://github.com/matrix-org/synapse/issues/6408)) - Fix broken guest registration when there are existing blocks of numeric user IDs. ([\#6420](https://github.com/matrix-org/synapse/issues/6420)) - Fix startup error when http proxy is defined. ([\#6421](https://github.com/matrix-org/synapse/issues/6421)) - Fix error when using synapse_port_db on a vanilla synapse db. ([\#6449](https://github.com/matrix-org/synapse/issues/6449)) - Fix uploading multiple cross signing signatures for the same user. ([\#6451](https://github.com/matrix-org/synapse/issues/6451)) - Fix bug which lead to exceptions being thrown in a loop when a cross-signed device is deleted. ([\#6462](https://github.com/matrix-org/synapse/issues/6462)) - Fix `synapse_port_db` not exiting with a 0 code if something went wrong during the port process. ([\#6470](https://github.com/matrix-org/synapse/issues/6470)) - Improve sanity-checking when receiving events over federation. ([\#6472](https://github.com/matrix-org/synapse/issues/6472)) - Fix inaccurate per-block Prometheus metrics. ([\#6491](https://github.com/matrix-org/synapse/issues/6491)) - Fix small performance regression for sending invites. ([\#6493](https://github.com/matrix-org/synapse/issues/6493)) - Back out cross-signing code added in Synapse 1.5.0, which caused a performance regression. ([\#6494](https://github.com/matrix-org/synapse/issues/6494)) Improved Documentation ---------------------- - Update documentation and variables in user contributed systemd reference file. ([\#6369](https://github.com/matrix-org/synapse/issues/6369), [\#6490](https://github.com/matrix-org/synapse/issues/6490)) - Fix link in the user directory documentation. ([\#6388](https://github.com/matrix-org/synapse/issues/6388)) - Add build instructions to the docker readme. ([\#6390](https://github.com/matrix-org/synapse/issues/6390)) - Switch Ubuntu package install recommendation to use python3 packages in INSTALL.md. ([\#6443](https://github.com/matrix-org/synapse/issues/6443)) - Write some docs for the quarantine_media api. ([\#6458](https://github.com/matrix-org/synapse/issues/6458)) - Convert CONTRIBUTING.rst to markdown (among other small fixes). ([\#6461](https://github.com/matrix-org/synapse/issues/6461)) Deprecations and Removals ------------------------- - Remove admin/v1/users_paginate endpoint. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#5925](https://github.com/matrix-org/synapse/issues/5925)) - Remove fallback for federation with old servers which lack the /federation/v1/state_ids API. ([\#6488](https://github.com/matrix-org/synapse/issues/6488)) Internal Changes ---------------- - Add benchmarks for structured logging and improve output performance. ([\#6266](https://github.com/matrix-org/synapse/issues/6266)) - Improve the performance of outputting structured logging. ([\#6322](https://github.com/matrix-org/synapse/issues/6322)) - Refactor some code in the event authentication path for clarity. ([\#6343](https://github.com/matrix-org/synapse/issues/6343), [\#6468](https://github.com/matrix-org/synapse/issues/6468), [\#6480](https://github.com/matrix-org/synapse/issues/6480)) - Clean up some unnecessary quotation marks around the codebase. ([\#6362](https://github.com/matrix-org/synapse/issues/6362)) - Complain on startup instead of 500'ing during runtime when `public_baseurl` isn't set when necessary. ([\#6379](https://github.com/matrix-org/synapse/issues/6379)) - Add a test scenario to make sure room history purges don't break `/messages` in the future. ([\#6392](https://github.com/matrix-org/synapse/issues/6392)) - Clarifications for the email configuration settings. ([\#6423](https://github.com/matrix-org/synapse/issues/6423)) - Add more tests to the blacklist when running in worker mode. ([\#6429](https://github.com/matrix-org/synapse/issues/6429)) - Refactor data store layer to support multiple databases in the future. ([\#6454](https://github.com/matrix-org/synapse/issues/6454), [\#6464](https://github.com/matrix-org/synapse/issues/6464), [\#6469](https://github.com/matrix-org/synapse/issues/6469), [\#6487](https://github.com/matrix-org/synapse/issues/6487)) - Port synapse.rest.client.v1 to async/await. ([\#6482](https://github.com/matrix-org/synapse/issues/6482)) - Port synapse.rest.client.v2_alpha to async/await. ([\#6483](https://github.com/matrix-org/synapse/issues/6483)) - Port SyncHandler to async/await. ([\#6484](https://github.com/matrix-org/synapse/issues/6484))
| * | | | 1.7.0rc1 v1.7.0rc1Neil Johnson2019-12-091-1/+1
| | | | |
* | | | | Better errors regarding changing avatar_url (#6497)Andrew Morgan2019-12-091-3/+8
|/ / / /
* | | | Back out perf regression from get_cross_signing_keys_from_cache. (#6494)Neil Johnson2019-12-091-30/+8
| | | | | | | | | | | | Back out cross-signing code added in Synapse 1.5.0, which caused a performance regression.
* | | | Merge pull request #6487 from matrix-org/erikj/pass_in_dbErik Johnston2019-12-0946-183/+214
|\ \ \ \ | |/ / / |/| | | Pass in Database object to data stores.
| * | | Fix commentErik Johnston2019-12-091-1/+1
| | | | | | | | | | | | | | | | Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
| * | | Fix port db scriptErik Johnston2019-12-061-1/+1
| | | |
| * | | Move start up DB checks to main data store.Erik Johnston2019-12-062-18/+12
| | | |
| * | | Pass Database into the data storeErik Johnston2019-12-065-28/+24
| | | |
| * | | Move are_all_users_on_domain checks to main data store.Erik Johnston2019-12-063-24/+24
| | | |
| * | | Change DataStores to accept 'database' param.Erik Johnston2019-12-0640-112/+153
| | | |
* | | | Merge pull request #6493 from matrix-org/erikj/invite_state_configErik Johnston2019-12-091-1/+3
|\ \ \ \ | | | | | | | | | | Pull out room_invite_state_types config option once.
| * | | | Pull out room_invite_state_types config option once.Erik Johnston2019-12-091-1/+3
| |/ / / | | | | | | | | | | | | Pulling things out of config is currently surprisingly expensive.
* | | | Fix inaccurate per-block metrics (#6491)Richard van der Hoff2019-12-091-42/+18
| | | | | | | | | | | | | | | | | | | | `Measure` incorrectly assumed that it was the only thing being done by the parent `LoggingContext`. For instance, during a "renew group attestations" operation, hundreds of `outbound_request` calls could take place in parallel, all using the same `LoggingContext`. This would mean that any resources used during *any* of those calls would be reported against *all* of them, producing wildly inaccurate results. Instead, we now give each `Measure` block its own `LoggingContext` (using the parent `LoggingContext` mechanism to ensure that the log lines look correct and that the metrics are ultimately propogated to the top level for reporting against requests/backgrond tasks).
* | | | Remove fallback for missing /federation/v1/state_ids API (#6488)Richard van der Hoff2019-12-092-96/+17
| | | | | | | | | | | | | | | | This API was added way back in 0.17.0; the code here is annoying to maintain and entirely redundant.
* | | | Merge pull request #6484 from matrix-org/erikj/port_sync_handlerErik Johnston2019-12-097-177/+164
|\ \ \ \ | |/ / / |/| | | Port SyncHandler to async/await
| * | | Fixup functions to consistently return deferredsErik Johnston2019-12-064-7/+7
| | | |
| * | | Port SyncHandler to async/awaitErik Johnston2019-12-054-173/+160
| | | |
* | | | Merge branch 'develop' of github.com:matrix-org/synapse into ↵Erik Johnston2019-12-0641-817/+675
|\ \ \ \ | | |_|/ | |/| | | | | | erikj/make_database_class
| * | | Replace /admin/v1/users_paginate endpoint with /admin/v2/users (#5925)Manuel Stahl2019-12-056-109/+114
| |/ /
| * | Port rest.client.v2Erik Johnston2019-12-0523-505/+361
| | |
| * | Port rest/v1 to async/awaitErik Johnston2019-12-0511-167/+118
| | |
| * | Stronger typing in the federation handler (#6480)Richard van der Hoff2019-12-051-24/+57
| | | | | | | | | | | | | | | replace the event_info dict with an attrs thing
| * | Sanity-check the rooms of auth events before pulling them in. (#6472)Richard van der Hoff2019-12-051-9/+25
| | |
* | | Remove unused varErik Johnston2019-12-061-2/+0
| | |
* | | Move background update handling out of storeErik Johnston2019-12-0519-148/+165
| | |
* | | CommentsErik Johnston2019-12-053-5/+16
| | |
* | | Move DB pool and helper functions into dedicated Database classErik Johnston2019-12-0547-2195/+2274
|/ /
* | Merge pull request #6464 from matrix-org/erikj/make_public_sql_baseErik Johnston2019-12-0546-519/+512
|\ \ | | | | | | Clean up SQLBaseStore private function usage
| * | Remove underscore from SQLBaseStore functionsErik Johnston2019-12-0444-501/+493
| | |
| * | Don't call SQLBaseStore methods from outside storesErik Johnston2019-12-044-19/+20
| | |
* | | Merge pull request #6470 from matrix-org/babolivier/port_db_ci_failureBrendan Abolivier2019-12-041-2/+10
|\ \ \ | | | | | | | | Make synapse_port_db exit with a non-0 code if something failed
| * | | Fix background updates for synapse_port_dbBrendan Abolivier2019-12-041-2/+10
| |/ /
* / / get rid of (most of) have_events from ↵Richard van der Hoff2019-12-042-72/+24
|/ / | | | | | | | | | | | | | | | | | | | | | | | | _update_auth_events_and_context_for_auth (#6468) have_events was a map from event_id to rejection reason (or None) for events which are in our local database. It was used as filter on the list of event_ids being passed into get_events_as_list. However, since get_events_as_list will ignore any event_ids that are unknown or rejected, we can equivalently just leave it to get_events_as_list to do the filtering. That means that we don't have to keep `have_events` up-to-date, and can use `have_seen_events` instead of `get_seen_events_with_rejection` in the one place we do need it.
* | Merge pull request #6454 from matrix-org/erikj/clean_base_StoreErik Johnston2019-12-048-192/+221
|\ \ | | | | | | Move things out of SQLBaseStore
| * | Revert "Move get_user_count_txn out of base store"Erik Johnston2019-12-042-12/+12
| | | | | | | | | | | | | | | | | | This reverts commit 00f0d67566cdfe8eae44aeae1c982c42a255cfcd. Its going to get removed soon, so lets not make merge conflicts.
| * | _CURRENT_STATE_CACHE_NAME is publicErik Johnston2019-12-042-5/+5
| | |
| * | Move get_user_count_txn out of base storeErik Johnston2019-12-042-12/+12
| | |
| * | Move cache invalidation to main data storeErik Johnston2019-12-046-113/+143
| | |
| * | Move event fetch vars to EventWorkStoreErik Johnston2019-12-044-14/+15
| | |
| * | Move account validity bg updates to registration storeErik Johnston2019-12-042-66/+64
| | |
* | | Merge pull request #6441 from syamgk/fix-parameter-mismatchErik Johnston2019-12-041-1/+1
|\ \ \ | | | | | | | | Fix issue #6406 parameter mismatch
| * | | Issue #6406 Fix parameter mismatchSyam G Krishnan2019-12-041-1/+1
| | | | | | | | | | | | | | | | Signed-off-by: Syam G Krishnan <syamgk01@gmail.com>
* | | | Merge pull request #6329 from matrix-org/babolivier/context_filtersBrendan Abolivier2019-12-045-3/+23
|\ \ \ \ | |_|/ / |/| | | Filter state, events_before and events_after in /context requests
| * | | Merge branch 'develop' into babolivier/context_filtersBrendan Abolivier2019-12-0487-1315/+3016
| |\ \ \
| * | | | Incorporate reviewBrendan Abolivier2019-12-041-2/+1
| | | | |
| * | | | Also filter state eventsBrendan Abolivier2019-11-061-1/+7
| | | | |