summary refs log tree commit diff
path: root/synapse (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Set Content-Length for Metrics requests (#7730)Christian Svensson2020-06-231-1/+4
| | | | | | HTTP requires the response to contain a Content-Length header unless chunked encoding is being used. Prometheus metrics endpoint did not set this, causing software such as prometheus-proxy to not be able to scrape synapse for metrics. Signed-off-by: Christian Svensson <blue@cmd.nu>
* Allow local media to be marked as safe from being quarantined. (#7718)Patrick Cloke2020-06-224-35/+52
|
* Convert directory handler to async/await (#7727)Patrick Cloke2020-06-222-40/+32
|
* Speed up state res v2 across large state differences. (#7725)Erik Johnston2020-06-191-1/+2
|
* add a commentRichard van der Hoff2020-06-181-0/+2
|
* Merge pull request #7716 from matrix-org/babolivier/unread_fixBrendan Abolivier2020-06-172-2/+2
|\ | | | | Fix unread counts in sync
| * Fix unread counts in syncBrendan Abolivier2020-06-172-2/+2
| | | | | | | | | | * Always return an unread_count in get_unread_event_push_actions_by_room_for_user * Don't always expect unread_count to be there so we don't take out sync entirely if something goes wrong
* | Convert the typing handler to async/await. (#7679)Patrick Cloke2020-06-171-18/+11
| |
* | Require parameterized package version to be at least 0.7.0. (#7680)Oleg Girko2020-06-171-1/+2
|/ | | | | Older versions of `parameterized` package have no `parameterized_class` decorator. This decorator is used in tests. Signed-off-by: Oleg Girko <ol@infoserver.lv>
* Add support for using rust-python-jaeger-reporter (#7697)Erik Johnston2020-06-171-3/+36
|
* Support running multiple media repos. (#7706)Erik Johnston2020-06-172-3/+21
| | | | | This requires a new config option to specify which media repo should be responsible for running background jobs to e.g. clear out expired URL preview caches.
* Fetch from the r0 media path instead of the unspecced v1. (#7714)Patrick Cloke2020-06-171-4/+4
|
* Implement unread counter (MSC2625) (#7673)Brendan Abolivier2020-06-176-32/+141
|\ | | | | Implementation of https://github.com/matrix-org/matrix-doc/pull/2625
| * Merge branch 'develop' into babolivier/mark_unreadBrendan Abolivier2020-06-1551-271/+218
| |\
| * \ Merge branch 'develop' into babolivier/mark_unreadBrendan Abolivier2020-06-1513-103/+295
| |\ \
| * | | Incorporate reviewBrendan Abolivier2020-06-151-15/+11
| | | |
| * | | LintBrendan Abolivier2020-06-121-3/+8
| | | |
| * | | Incorporate review bitsBrendan Abolivier2020-06-122-21/+19
| | | |
| * | | Pre-populate the unread_count columnBrendan Abolivier2020-06-121-0/+5
| | | |
| * | | Don't update the schema versionBrendan Abolivier2020-06-122-1/+1
| | | |
| * | | Use attr instead of a dictBrendan Abolivier2020-06-121-21/+31
| | | |
| * | | Fix summary rotationBrendan Abolivier2020-06-121-12/+35
| | | |
| * | | Log for invalid values of notifBrendan Abolivier2020-06-111-0/+6
| | | |
| * | | Fix SQLBrendan Abolivier2020-06-111-3/+3
| | | |
| * | | Fix schema updateBrendan Abolivier2020-06-111-1/+1
| | | |
| * | | LintBrendan Abolivier2020-06-111-1/+2
| | | |
| * | | Save the count of unread messages to event_push_summaryBrendan Abolivier2020-06-113-20/+53
| | | |
| * | | Actually act on mark_unreadBrendan Abolivier2020-06-111-3/+7
| | | |
| * | | Appease mypyBrendan Abolivier2020-06-101-1/+1
| | | |
| * | | LintBrendan Abolivier2020-06-101-3/+3
| | | |
| * | | Use temporary prefixes as per the MSCBrendan Abolivier2020-06-103-3/+5
| | | |
| * | | Use a more efficient way of calculating countersBrendan Abolivier2020-06-101-23/+20
| | | |
| * | | Add a new unread_counter to sync responsesBrendan Abolivier2020-06-103-3/+28
| | | |
| * | | Rename dont_push into mark_unreadBrendan Abolivier2020-06-102-5/+4
| | | |
| * | | Merge branch 'develop' into babolivier/mark_unreadBrendan Abolivier2020-06-10616-26200/+42607
| |\ \ \
| * | | | Add experimental "dont_push" push action to suppress push for notificationsMatthew Hodgson2019-09-191-5/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a potential solution to https://github.com/vector-im/riot-web/issues/3374 and https://github.com/vector-im/riot-web/issues/5953 as raised by Mozilla at https://github.com/vector-im/riot-web/issues/10868. This lets you define a push rule action which increases the badge count (unread notification) count on a given room, but doesn't actually send a push for that notification via email or HTTP. We might want to define this as the default behaviour for group chats in future to solve https://github.com/vector-im/riot-web/issues/3268 at last. This is implemented as a string action rather than a tweak because: * Other pushers don't care about the tweak, given they won't ever get pushed * The DB can store the tweak more efficiently using the existing `notify` table. * It avoids breaking the default_notif/highlight_action optimisations. Clients which generate their own notifs (e.g. desktop notifs from Riot/Web would need to be aware of the new push action) to uphold it. An alternative way to do this would be to maintain a `msg_count` alongside `highlight_count` and `notification_count` in `unread_notifications` in sync responses. However, doing this by counting the rows in `events` since the `stream_position` of the user's last read receipt turns out to be painfully slow (~200ms), perhaps due to the size of the events table. So instead, we use the highly optimised existing event_push_actions (and event_push_actions_staging) table to maintain the counts - using the code paths which already exist for tracking unread notification counts efficiently. These queries are typically ~3ms or so. The biggest issues I see here are: * We're slightly repurposing the `notif` field on `event_push_actions` to track whether a given action actually sent a `push` or not. This doesn't seem unreasonable, but it's slightly naughty given that previously the field explicitly tracked whether `notify` was true for the action (and as a result, it was uselessly always set to 1 in the DB). * We're going to put more load on the `event_push_actions` table for all the random group chats which people had previously muted. In practice i don't think there are many of these though. * There isn't an MSC for this yet (although this comment could become one).
* | | | | fix broken link in sample config (#7712)Richard van der Hoff2020-06-161-1/+1
| | | | |
* | | | | Refactor getting replication updates from database. (#7636)Erik Johnston2020-06-168-72/+250
| | | | | | | | | | | | | | | The aim here is to make it easier to reason about when streams are limited and when they're not, by moving the logic into the database functions themselves. This should mean we can kill of `db_query_to_update_function` function.
* | | | | Fix "argument of type 'ObservableDeferred' is not iterable" error (#7708)Patrick Cloke2020-06-162-5/+6
| | | | |
* | | | | Include a user agent in federation requests. (#7677)Patrick Cloke2020-06-163-4/+32
| | | | |
* | | | | Replace all remaining six usage with native Python 3 equivalents (#7704)Dagfinn Ilmari Mannsåker2020-06-1657-201/+90
| | | | |
* | | | | Convert the device message and pagination handlers to async/await. (#7678)Patrick Cloke2020-06-162-31/+18
| | | | |
* | | | | Create a ListenerConfig object (#7681)Richard van der Hoff2020-06-167-148/+216
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This ended up being a bit more invasive than I'd hoped for (not helped by generic_worker duplicating some of the code from homeserver), but hopefully it's an improvement. The idea is that, rather than storing unstructured `dict`s in the config for the listener configurations, we instead parse it into a structured `ListenerConfig` object.
* | | | | Merge branch 'master' into developBrendan Abolivier2020-06-163-9/+11
|\ \ \ \ \
| * | | | | 1.15.1Brendan Abolivier2020-06-161-1/+1
| | | | | |
| * | | | | Wrap register_device coroutine in an ensureDeferred (#7684)Andrew Morgan2020-06-161-5/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes https://github.com/matrix-org/synapse/issues/7683 Broke in: #7649 We had a `yield` acting on a coroutine. To be fair this one is a bit difficult to notice as there's a function in the middle that just passes the coroutine along.
| * | | | | Enable 3PID add/bind/unbind endpoints on r0 routesBrendan Abolivier2020-06-151-3/+3
| | | | | |
* | | | | | Ensure the body is a string before comparing push rules. (#7701)Patrick Cloke2020-06-151-2/+2
| | | | | |
* | | | | | Ensure etag is a string for GET room_keys/version response (#7691)Hubert Chathi2020-06-151-0/+1
| | | | | |
* | | | | | Update m.id.phone to use 'phone' instead of 'number' (#7687)Andrew Morgan2020-06-151-2/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The spec [states](https://matrix.org/docs/spec/client_server/r0.6.1#phone-number) that `m.id.phone` requires the field `country` and `phone`. In Synapse, we've been enforcing `country` and `number`. I am not currently sure whether this affects any client implementations. This issue was introduced in #1994.
* | | | | | Fix "There was no active span when trying to log." error (#7698)Erik Johnston2020-06-151-0/+1
| |_|_|_|/ |/| | | |
* | | | | Discard RDATA from already seen positions. (#7648)Patrick Cloke2020-06-153-6/+33
| | | | |
* | | | | Replace iteritems/itervalues/iterkeys with native versions. (#7692)Patrick Cloke2020-06-1546-263/+183
| | | | |
* | | | | Fix warnings about losing log context during UI auth. (#7688)Patrick Cloke2020-06-121-1/+1
| | | | |
* | | | | Fix a typo when comparing the URI & method during UI Auth. (#7689)Patrick Cloke2020-06-121-1/+1
| |_|_|/ |/| | |
* | | | Remove "user_id" from GET /presence. (#7606)Will Hunt2020-06-111-1/+3
| | | |
* | | | Merge branch 'master' into developBrendan Abolivier2020-06-111-1/+1
|\| | |
| * | | 1.15.0 v1.15.0 github/release-v1.15.0 release-v1.15.0Brendan Abolivier2020-06-111-1/+1
| | |/ | |/|
* | | Increase the default SAML session expirary time to 15 minutes. (#7664)Patrick Cloke2020-06-111-2/+2
| | |
* | | fix typo in sample_config.yaml (#7652)wondratsch2020-06-111-1/+1
| | | | | | | | | | | | | | | Just a simple typo fix. Signed-off-by: wondratsch 28294257+wondratsch@users.noreply.github.com
* | | Take out a lock before modifying _CACHES (#7663)Richard van der Hoff2020-06-101-5/+15
| | | | | | | | | | | | This should fix #7610.
* | | Add option to enable encryption by default for new rooms (#7639)Andrew Morgan2020-06-105-29/+144
| | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes https://github.com/matrix-org/synapse/issues/2431 Adds config option `encryption_enabled_by_default_for_room_type`, which determines whether encryption should be enabled with the default encryption algorithm in private or public rooms upon creation. Whether the room is private or public is decided based upon the room creation preset that is used. Part of this PR is also pulling out all of the individual instances of `m.megolm.v1.aes-sha2` into a constant variable to eliminate typos ala https://github.com/matrix-org/synapse/pull/7637 Based on #7637
* | | Clean-up the fallback login code. (#7657)Patrick Cloke2020-06-103-64/+129
|/ /
* | 1.15.0rc1 v1.15.0rc1Brendan Abolivier2020-06-091-1/+1
| |
* | Revert "1.15.0rc1"Brendan Abolivier2020-06-091-1/+1
| | | | | | | | This reverts commit 8587b0426fa4e65992aaa47158e991fa1797d3fb.
* | 1.15.0rc1Brendan Abolivier2020-06-091-1/+1
| |
* | Fix bug in account data replication stream. (#7656)Erik Johnston2020-06-095-4/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Ensure account data stream IDs are unique. The account data stream is shared between three tables, and the maximum allocated ID was tracked in a dedicated table. Updating the max ID happened outside the transaction that allocated the ID, leading to a race where if the server was restarted then the same ID could be allocated but the max ID failed to be updated, leading it to be reused. The ID generators have support for tracking across multiple tables, so we may as well use that instead of a dedicated table. * Fix bug in account data replication stream. If the same stream ID was used in both global and room account data then the getting updates for the replication stream would fail due to `heapq.merge(..)` trying to compare a `str` with a `None`. (This is because you'd have two rows like `(534, '!room')` and `(534, None)` from the room and global account data tables). Fix is just to order by stream ID, since we don't rely on the ordering beyond that. The bug where stream IDs can be reused should be fixed now, so this case shouldn't happen going forward. Fixes #7617
* | Convert the registration handler to async/await. (#7649)Patrick Cloke2020-06-082-68/+47
| |
* | Accept device information at the login fallback endpoint. (#7629)Patrick Cloke2020-06-081-35/+120
| |
* | Convert user directory handler and related classes to async/await. (#7640)Patrick Cloke2020-06-054-107/+73
| |
* | Add an option to disable autojoin for guest accounts (#6637)Travis Ralston2020-06-052-1/+15
| | | | | | | | Fixes https://github.com/matrix-org/synapse/issues/3177
* | Update to the stable SSO prefix for UI Auth. (#7630)Patrick Cloke2020-06-051-1/+1
| |
* | Fix type information on `assert_*_is_admin` methods (#7645)Richard van der Hoff2020-06-052-23/+18
| | | | | | These things don't return Deferreds.
* | Remove some unused constants. (#7644)Richard van der Hoff2020-06-051-4/+0
| |
* | Typo fixes.Patrick Cloke2020-06-052-2/+2
| |
* | Allow new users to be registered via the admin API even if the monthly ↵Dirk Klimpel2020-06-052-1/+8
| | | | | | | | active user limit has been reached (#7263)
* | Add device management to admin API (#7481)Dirk Klimpel2020-06-052-0/+169
| | | | | | | | | | | | | | | | | | | | - Admin is able to - change displaynames - delete devices - list devices - get device informations Fixes #7330
* | Attempt to fix PhoneHomeStatsTestCase.test_performance_100 being flaky. (#7634)Patrick Cloke2020-06-051-19/+23
| |
* | Support CS API v0.6.0 (#6585)Andrew Morgan2020-06-051-15/+1
| |
* | Add support for webp thumbnailing (#7586)WGH2020-06-051-0/+1
| | | | | | | | | | Closes #4382 Signed-off-by: Maxim Plotnikov <wgh@torlan.ru>
* | Performance improvements and refactor of Ratelimiter (#7595)Andrew Morgan2020-06-0510-162/+193
| | | | | | | | | | | | | | | | | | | | While working on https://github.com/matrix-org/synapse/issues/5665 I found myself digging into the `Ratelimiter` class and seeing that it was both: * Rather undocumented, and * causing a *lot* of config checks This PR attempts to refactor and comment the `Ratelimiter` class, as well as encourage config file accesses to only be done at instantiation. Best to be reviewed commit-by-commit.
* | Fix encryption algorithm typos in tests/comments (#7637)Andrew Morgan2020-06-041-4/+4
| | | | | | | | | | | | | | | | @uhoreg has confirmed these were both typos. They are only in comments and tests though, rather than anything critical. Introduced in: * https://github.com/matrix-org/synapse/pull/7157 * https://github.com/matrix-org/synapse/pull/5726
* | Advertise the token login type when OpenID Connect is enabled. (#7631)Patrick Cloke2020-06-041-8/+3
| |
* | Cleanups to the OpenID Connect integration (#7628)Richard van der Hoff2020-06-034-83/+125
| | | | | | | | docs, default configs, comments. Nothing very significant.
* | async/await get_user_id_by_threepid (#7620)Andrew Morgan2020-06-033-28/+28
| | | | | | | | | | Based on #7619 async's `get_user_id_by_threepid` and its call stack.
* | Check if the localpart is reserved for guests earlier in the registration ↵Brendan Abolivier2020-06-031-9/+9
| | | | | | | | | | flow (#7625) This is so the user is warned about the username not being valid as soon as possible, rather than only once they've finished UIA.
* | Fix exceptions when fetching events from a down host. (#7622)Erik Johnston2020-06-031-1/+1
| | | | | | We already caught some exceptions, but not all.
* | Clean up exception handling in SAML2ResponseResource (#7614)Richard van der Hoff2020-06-034-60/+68
| | | | | | | | | | | | | | | | | | | | | | | | | | * Expose `return_html_error`, and allow it to take a Jinja2 template instead of a raw string * Clean up exception handling in SAML2ResponseResource * use the existing code in `return_html_error` instead of re-implementing it (giving it a jinja2 template rather than inventing a new form of template) * do the exception-catching in the REST layer rather than in the handler layer, to make sure we catch all exceptions.
* | Fix a bug in automatic user creation with m.login.jwt. (#7585)Olof Johansson2020-06-011-7/+8
| |
* | Process cross-signing keys when resyncing device lists (#7594)Brendan Abolivier2020-06-012-18/+62
| | | | | | It looks like `user_device_resync` was ignoring cross-signing keys from the results received from the remote server. This patch fixes this, by processing these keys using the same process `_handle_signing_key_updates` does (and effectively factor that part out of that function).
* | Email notifications for new users when creating via the Admin API. (#7267)Dirk Klimpel2020-06-011-0/+16
| |
* | Improve performance of _get_state_groups_from_groups_txn (#7567)Dagfinn Ilmari Mannsåker2020-06-011-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The query keeps showing up in my slow query log. This changes the plan under the top-level Sort node from ``` WindowAgg (cost=280335.88..292963.15 rows=561212 width=80) (actual time=138.651..160.562 rows=27112 loops=1) -> Sort (cost=280335.88..281738.91 rows=561212 width=84) (actual time=138.597..140.622 rows=27112 loops=1) Sort Key: state_groups_state.type, state_groups_state.state_key, state_groups_state.state_group Sort Method: quicksort Memory: 4581kB -> Nested Loop (cost=2.83..226745.22 rows=561212 width=84) (actual time=21.548..47.657 rows=27112 loops=1) -> HashAggregate (cost=2.27..3.28 rows=101 width=8) (actual time=21.526..21.535 rows=20 loops=1) Group Key: state.state_group -> CTE Scan on state (cost=0.00..2.02 rows=101 width=8) (actual time=21.280..21.493 rows=20 loops=1) -> Index Scan using state_groups_state_type_idx on state_groups_state (cost=0.56..2189.40 rows=5557 width=84) (actual time=0.005..0.991 rows=1356 loops=20) Index Cond: (state_group = state.state_group) ``` to ``` Nested Loop (cost=2.83..226745.22 rows=561212 width=84) (actual time=24.194..52.834 rows=27112 loops=1) -> HashAggregate (cost=2.27..3.28 rows=101 width=8) (actual time=24.130..24.138 rows=20 loops=1) Group Key: state.state_group -> CTE Scan on state (cost=0.00..2.02 rows=101 width=8) (actual time=23.887..24.113 rows=20 loops=1) -> Index Scan using state_groups_state_type_idx on state_groups_state (cost=0.56..2189.40 rows=5557 width=84) (actual time=0.016..1.159 rows=1356 loops=20) Index Cond: (state_group = state.state_group) ``` This cuts the execution time from ~190ms to ~130ms, i.e. a reduction of ~30%. The full plans are visualised at https://explain.depesz.com/s/WpbT and https://explain.depesz.com/s/KlEk Signed-off-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
* | Convert groups local and server to async/await. (#7600)Patrick Cloke2020-06-012-190/+149
| |
* | Don't fail all of an iteration of the device list retry loop on error (#7609)Brendan Abolivier2020-06-011-15/+21
| | | | | | Without this patch, if an error happens which isn't caught by `user_device_resync`, then `_maybe_retry_device_resync` would fail, without retrying the next users in the iteration. This patch fixes this so that it now only logs an error in this case.
* | Use upsert when inserting read receipts (#7607)Dagfinn Ilmari Mannsåker2020-06-011-9/+4
| | | | | | | | | | Fixes #7469 Signed-off-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
* | Fix 'FederationGroupsRoomsServlet' API when group has room server is not in. ↵Erik Johnston2020-05-291-8/+12
| | | | | | | | (#7599)
* | Make inflight background metrics more efficient. (#7597)Erik Johnston2020-05-291-34/+70
| | | | | | Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* | Merge branch 'master' into developBrendan Abolivier2020-05-281-1/+1
|\ \
| * | 1.14.0Brendan Abolivier2020-05-281-1/+1
| | |
* | | Merge pull request #7584 from matrix-org/erikj/save_and_send_fed_token_in_bgErik Johnston2020-05-272-7/+36
|\ \ \ | | | | | | | | Speed up processing of federation stream RDATA rows.
| * | | Ensure we persist and ack the same tokenErik Johnston2020-05-271-5/+7
| | | |
| * | | Remove spurious changeErik Johnston2020-05-271-2/+0
| | | |
| * | | Speed up processing of federation stream RDATA rows.Erik Johnston2020-05-273-2/+31
| |/ / | | | | | | | | | | | | | | | Instead of storing and sending an ACK for every single row we send synchronously, we instead do it asynchronously while batching up updates.
* | | allow emails to be passed through SAML (#7385)Christopher Cooper2020-05-271-2/+10
| | | | | | | | | Signed-off-by: Christopher Cooper <cooperc@ocf.berkeley.edu>
* | | Merge tag 'v1.14.0rc2' into developBrendan Abolivier2020-05-275-7/+48
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.14.0rc2 (2020-05-27) ============================== Bugfixes -------- - Fix cache config to not apply cache factor to event cache. Regression in v1.14.0rc1. ([\#7578](https://github.com/matrix-org/synapse/issues/7578)) - Fix bug where `ReplicationStreamer` was not always started when replication was enabled. Bug introduced in v1.14.0rc1. ([\#7579](https://github.com/matrix-org/synapse/issues/7579)) - Fix specifying individual cache factors for caches with special characters in their name. Regression in v1.14.0rc1. ([\#7580](https://github.com/matrix-org/synapse/issues/7580)) Improved Documentation ---------------------- - Fix the OIDC `client_auth_method` value in the sample config. ([\#7581](https://github.com/matrix-org/synapse/issues/7581))
| * | 1.14.0rc2Brendan Abolivier2020-05-271-1/+1
| | |
| * | Fix sample config docs error (#7581)Jason Robinson2020-05-271-1/+1
| | | | | | | | | | | | | | | | | | 'client_auth_method' commented out value was erronously 'client_auth_basic', when code and docstring says it should be 'client_secret_basic'. Signed-off-by: Jason Robinson <jasonr@matrix.org>
| * | Fix up commentsErik Johnston2020-05-271-2/+2
| | |
| * | Fix specifying cache factors via env vars with * in name. (#7580)Erik Johnston2020-05-271-5/+39
| | | | | | | | | | | | | | | This mostly applise to `*stateGroupCache*` and co. Broke in #6391.
| * | Don't apply cache factor to event cache. (#7578)Erik Johnston2020-05-271-0/+4
| | | | | | | | | | | | This is already correctly done when we instansiate the cache, but wasn't when it got reloaded (which always happens at least once on startup).
| * | Ensure ReplicationStreamer is always started when replication enabled. (#7579)Erik Johnston2020-05-271-0/+3
| | | | | | | | | Fixes #7566.
* | | Fix incorrect placeholder syntax in database prepartion code (#7575)Andrew Morgan2020-05-271-3/+2
| | | | | | | | | We were using `logger` syntax which isn't supported by `Exception`s.
* | | Merge branch 'develop' of github.com:matrix-org/synapse into developBrendan Abolivier2020-05-262-63/+46
|\ \ \ | |/ / |/| |
| * | Convert identity handler to async/await. (#7561)Patrick Cloke2020-05-262-63/+46
| | |
* | | Not full release yet, this is rc1Brendan Abolivier2020-05-261-1/+1
| | |
* | | 1.14.0Brendan Abolivier2020-05-261-1/+1
|/ /
* | Replace device_27_unique_idx bg update with a fg one (#7562)Richard van der Hoff2020-05-265-62/+94
| | | | | | | | | | | | The bg update never managed to complete, because it kept being interrupted by transactions which want to take a lock. Just doing it in the foreground isn't that bad, and is a good deal simpler.
* | Fix incorrect exception handling in KeyUploadServlet.on_POST (#7563)Richard van der Hoff2020-05-261-1/+1
| | | | | | Introduced in #7556
* | Fix recording of federation stream token (#7564)Richard van der Hoff2020-05-261-24/+44
| | | | | | | | | | | | | | | | A couple of changes of significance: * remove the `_last_ack < federation_position` condition, so that updates will still be correctly processed after restart * Correctly wire up send_federation_ack to the right class.
* | Simplify reap_monthly_active_users (#7558)Richard van der Hoff2020-05-231-59/+41
| | | | | | | | | | | | we can use `make_in_list_sql_clause` rather than doing our own half-baked equivalent, which has the benefit of working just fine with empty lists. (This has quite a lot of tests, so I think it's pretty safe)
* | Optimise some references to hs.config (#7546)Richard van der Hoff2020-05-223-19/+32
| | | | | | These are surprisingly expensive, and we only really need to do them at startup.
* | Fix missing CORS headers on OPTION responses (#7560)Erik Johnston2020-05-221-1/+1
| | | | | | Broke in #7534.
* | Add option to move event persistence off master (#7517)Erik Johnston2020-05-2220-73/+378
| |
* | Return 200 OK for all OPTIONS requests (#7534)Patrick Cloke2020-05-223-11/+31
| |
* | Add ability to wait for replication streams (#7542)Erik Johnston2020-05-2218-104/+288
| | | | | | | | | | | | | | The idea here is that if an instance persists an event via the replication HTTP API it can return before we receive that event over replication, which can lead to races where code assumes that persisting an event immediately updates various caches (e.g. current state of the room). Most of Synapse doesn't hit such races, so we don't do the waiting automagically, instead we do so where necessary to avoid unnecessary delays. We may decide to change our minds here if it turns out there are a lot of subtle races going on. People probably want to look at this commit by commit.
* | Convert sending mail to async/await. (#7557)Erik Johnston2020-05-223-74/+57
| | | | | | | | Mainly because sometimes the email push code raises exceptions where the stack traces have gotten lost, which is hopefully fixed by this.
* | Use a non-empty RelayState for user interactive auth with SAML. (#7552)Patrick Cloke2020-05-221-1/+4
| |
* | On upgrade room only send canonical alias once. (#7547)Erik Johnston2020-05-221-55/+60
| | | | | | | | | | | | | | | | Instead of doing a complicated dance of deleting and moving aliases one by one, which sends a canonical alias update into the old room for each one, lets do it all in one go. This also changes the function to move *all* local alias events to the new room, however that happens later on anyway.
* | Fix exception reporting due to HTTP request errors. (#7556)Erik Johnston2020-05-223-4/+23
| | | | | | | | These are business as usual errors, rather than stuff we want to log at error.
* | synapse.metrics: implement detailed memory usage reporting on PyPy (#7536)Ivan Shapovalov2020-05-221-1/+78
| | | | | | | | | | | | PyPy's gc.get_stats() returns an object containing detailed allocator statistics which could be beneficial to collect as metrics. Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
* | Fix stacktrace mangling in `patch_inline_callbacks` (#7554)Richard van der Hoff2020-05-221-2/+7
| | | | | | `Failure()` is more cunning than `Failure(e)`.
* | mypy for synapse.http.site (#7553)Richard van der Hoff2020-05-221-3/+6
| |
* | Fix some DETECTED VIOLATIONS in the config file (#7550)Richard van der Hoff2020-05-226-29/+36
| | | | | | consistency ftw
* | Retry to sync out of sync device lists (#7453)Brendan Abolivier2020-05-212-19/+95
| | | | | | | | | | | | | | | | | | | | | | When a call to `user_device_resync` fails, we don't currently mark the remote user's device list as out of sync, nor do we retry to sync it. https://github.com/matrix-org/synapse/pull/6776 introduced some code infrastructure to mark device lists as stale/out of sync. This commit uses that code infrastructure to mark device lists as out of sync if processing an incoming device list update makes the device handler realise that the device list is out of sync, but we can't resync right now. It also adds a looping call to retry all failed resync every 30s. This shouldn't cause too much spam in the logs as this commit also removes the "Failed to handle device list update for..." warning logs when catching `NotRetryingDestination`. Fixes #7418
* | Stub out GET presence requests in the frontend proxy (#7545)Richard van der Hoff2020-05-211-17/+4
| | | | | | | | | | We don't really make any promises about returning accurate presence data when presence is disabled, so we may as well just return a static response, rather than making the master handle a request.
* | add a commentRichard van der Hoff2020-05-211-0/+3
| |
* | Fix bug in persist events when dealing with non member types. (#7548)Erik Johnston2020-05-211-2/+2
| | | | | | | | | | `_is_server_still_joined` will throw if it is given state updates with non-user ID state keys with local user leaves. This is actually rarely a problem since local leaves almost always get persisted by themselves. (I discovered this on a branch that was otherwise broken, so I haven't seen this in the wild)
* | Hash passwords earlier in the password reset process (#7538)Patrick Cloke2020-05-204-11/+32
| | | | | | | | This now matches the logic of the registration process as modified in 56db0b1365965c02ff539193e26c333b7f70d101 / #7523.
* | Merge branch 'master' into developPatrick Cloke2020-05-191-1/+1
|\ \
| * | 1.13.0Patrick Cloke2020-05-191-1/+1
| | |
* | | Omit displayname or avatar_url if they aren't set instead of returning null ↵Aaron Raimist2020-05-191-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | (#7497) Per https://github.com/matrix-org/matrix-doc/issues/1436#issuecomment-410089470 they should be omitted instead of returning null or "". They aren't marked as required in the spec. Fixes https://github.com/matrix-org/synapse/issues/7333 Signed-off-by: Aaron Raimist <aaron@raim.ist>
* | | Merge tag 'v1.13.0rc3' into developPatrick Cloke2020-05-184-32/+31
|\| | | | | | | | | | | | | | | | | | | | | | | Synapse 1.13.0rc3 (2020-05-18) Bugfixes: - Hash passwords as early as possible during registration. #7523
| * | 1.13.0rc3 v1.13.0rc3Patrick Cloke2020-05-181-1/+1
| | |
| * | Hash passwords earlier in the registration process (#7523)Patrick Cloke2020-05-183-31/+30
| | |
* | | Allow ReplicationRestResource to be added to workers (#7515)Erik Johnston2020-05-182-5/+12
| | | | | | | | | This allows workers to talk to each other over HTTP replication.
* | | Merge pull request #7519 from matrix-org/rav/kill_py2_codeRichard van der Hoff2020-05-1814-189/+45
|\ \ \ | | | | | | | | Kill off some old python 2 code
| * | | remove miscellaneous PY2 codeRichard van der Hoff2020-05-156-67/+24
| | | |
| * | | remove `builtins.buffer` code from storage codeRichard van der Hoff2020-05-153-24/+3
| | | | | | | | | | | | | | | | this is no longer needed on python 3
| * | | remove redundant `__func__`Richard van der Hoff2020-05-152-13/+4
| | | | | | | | | | | | | | | | this is a no-op under python 3
| * | | remove to_asciiRichard van der Hoff2020-05-153-38/+12
| | | | | | | | | | | | | | | | this is a no-op on python 3.
| * | | Remove `exception_to_unicode`Richard van der Hoff2020-05-152-48/+3
| | | | | | | | | | | | | | | | this is a no-op on python 3.
* | | | Add type hints to room member handlers (#7513)Patrick Cloke2020-05-152-139/+173
| | | |
* | | | Fix limit logic for AccountDataStream (#7384)Richard van der Hoff2020-05-152-31/+99
| | | | | | | | | | | | | | | | | | | | | | | | Make sure that the AccountDataStream presents complete updates, in the right order. This is much the same fix as #7337 and #7358, but applied to a different stream.
* | | | Fix a couple of small typosAndrew Morgan2020-05-152-3/+3
| | | |
* | | | Support UI Authentication for OpenID Connect accounts (#7457)Patrick Cloke2020-05-154-36/+94
| | | |
* | | | Add a worker store for search insertion. (#7516)Erik Johnston2020-05-152-47/+51
| | | | | | | | | | | | | | | | | | | | This is required as both event persistence and the background update needs access to this function. It should be perfectly safe for two workers to write to that table at the same time.
* | | | Prevent 0-member/null room_version rooms from appearing in group room ↵Andrew Morgan2020-05-151-14/+78
| | | | | | | | | | | | | | | | queries (#7465)
* | | | Move event stream handling out of slave store. (#7491)Erik Johnston2020-05-157-116/+160
| | | | | | | | | | | | | | | | | | | | This allows us to have the logic on both master and workers, which is necessary to move event persistence off master. We also combine the instantiation of ID generators from DataStore and slave stores to the base worker stores. This allows us to select which process writes events independently of the master/worker splits.
* | | | Add type hints to event_auth code. (#7505)Patrick Cloke2020-05-151-32/+46
| | | |
* | | | Fix a small typo in the arguments of simple_update in ↵Andrew Morgan2020-05-151-1/+1
|/ / / | | | | | | | | | update_remote_profile_cache (#7511)
* | | Update the room member handler to use async/await. (#7507)Patrick Cloke2020-05-152-74/+58
| | |
* | | Implement room version 6 (MSC2240). (#7506)Patrick Cloke2020-05-151-26/+4
| | |
* | | Ignore incoming presence updates when presence is disabled (#7508)Andrew Morgan2020-05-151-2/+4
| | |
* | | Strictly enforce canonicaljson requirements in a new room version (#7381)Patrick Cloke2020-05-145-4/+70
| | |
* | | Enforce MSC2209: auth rules for notifications in power level event (#7502)Patrick Cloke2020-05-142-3/+31
| | | | | | | | | | | | In a new room version, the "notifications" key of power level events are subject to restricted auth rules.
* | | Workaround for failure to wrap reason in Failure (#7473)Andrew Morgan2020-05-141-0/+7
| | |
* | | Fix b'GET' in prometheus metrics (#7503)Richard van der Hoff2020-05-141-2/+4
| | |
* | | Allow expired accounts to logout (#7443)Andrew Morgan2020-05-142-20/+36
| | |
* | | Move EventStream handling into default ReplicationDataHandler (#7493)Erik Johnston2020-05-144-36/+39
| | | | | | | | | This is so that the logic can happen on both master and workers when we move event persistence out.
* | | Add `instance_map` config and route replication calls (#7495)Erik Johnston2020-05-142-6/+32
| | |
* | | Merge tag 'v1.13.0rc2' into developRichard van der Hoff2020-05-144-22/+21
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.13.0rc2 (2020-05-14) ============================== Bugfixes -------- - Fix a long-standing bug which could cause messages not to be sent over federation, when state events with state keys matching user IDs (such as custom user statuses) were received. ([\#7376](https://github.com/matrix-org/synapse/issues/7376)) - Restore compatibility with non-compliant clients during the user interactive authentication process, fixing a problem introduced in v1.13.0rc1. ([\#7483](https://github.com/matrix-org/synapse/issues/7483)) Internal Changes ---------------- - Fix linting errors in new version of Flake8. ([\#7470](https://github.com/matrix-org/synapse/issues/7470))
| * | 1.13.0rc2Richard van der Hoff2020-05-141-1/+1
| | |
| * | Stop `get_joined_users` corruption from custom statuses (#7376)Richard van der Hoff2020-05-141-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | Fix a bug where the `get_joined_users` cache could be corrupted by custom status events (or other state events with a state_key matching the user ID). The bug was introduced by #2229, but has largely gone unnoticed since then. Fixes #7099, #7373.
| * | Do not validate that the client dict is stable during UI Auth. (#7483)Patrick Cloke2020-05-132-20/+18
| | | | | | | | | | | | This backs out some of the validation for the client dictionary and logs if this changes during a user interactive authentication session instead.
| * | Fix new flake8 errors (#7489)Patrick Cloke2020-05-135-11/+17
| | | | | | | | | | | | This is a cherry-pick of 1a1da60ad2c9172fe487cd38a164b39df60f4cb5 (#7470) to the release-v1.13.0 branch.
* | | Allow censoring of events to happen on workers. (#7492)Erik Johnston2020-05-133-8/+3
| | | | | | | | | This is safe as we can now write to cache invalidation stream on workers, and is required for when we move event persistence off master.
* | | Fix copypasted comment (#7477)Paul Tötterman2020-05-131-1/+1
| | | | | | | | | Signed-off-by: Paul Tötterman <paul.totterman@iki.fi>
* | | SpellingErik Johnston2020-05-132-2/+2
| | |
* | | Shuffle persist event data store functions. (#7440)Erik Johnston2020-05-1317-1234/+1373
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The aim here is to get to a stage where we have a `PersistEventStore` that holds all the write methods used during event persistence, so that we can take that class out of the `DataStore` mixin and instansiate it separately. This will allow us to instansiate it on processes other than master, while also ensuring it is only available on processes that are configured to write to events stream. This is a bit of an architectural change, where we end up with multiple classes per data store (rather than one per data store we have now). We end up having: 1. Storage classes that provide high level APIs that can talk to multiple data stores. 2. Data store modules that consist of classes that must point at the same database instance. 3. Classes in a data store that can be instantiated on processes depending on config.
* | | Have all instances correctly respond to REPLICATE command. (#7475)Erik Johnston2020-05-133-48/+50
| | | | | | | | | | | | | | | Before all streams were only written to from master, so only master needed to respond to `REPLICATE` commands. Before all instances wrote to the cache invalidation stream, but didn't respond to `REPLICATE`. This was a bug, which could lead to missed rows from cache invalidation stream if an instance is restarted, however all the caches would be empty in that case so it wasn't a problem.
* | | Fix Redis reconnection logic (#7482)Erik Johnston2020-05-132-2/+14
| | | | | | | | | Proactively send out `POSITION` commands (as if we had just received a `REPLICATE`) when we connect to Redis. This is important as other instances won't notice we've connected to issue a `REPLICATE` command (unlike for direct TCP connections). This is only currently an issue if master process reconnects without restarting (if it restarts then it won't have written anything and so other instances probably won't have missed anything).
* | | Fix new flake8 errors (#7470)Erik Johnston2020-05-125-11/+17
| | |
* | | Convert federation handler to async/await. (#7459)Patrick Cloke2020-05-112-21/+16
| | |
* | | Convert search code to async/await. (#7460)Patrick Cloke2020-05-111-24/+20
| | |
* | | Allow configuration of Synapse's cache without using synctl or environment ↵Amber Brown2020-05-1121-124/+402
| | | | | | | | | | | | variables (#6391)
* | | Remove unused store method get_hosts_in_room (#7448)Andrew Morgan2020-05-111-10/+0
| | |
* | | Merge branch 'release-v1.13.0' into developAndrew Morgan2020-05-117-20/+65
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * release-v1.13.0: Don't UPGRADE database rows RST indenting Put rollback instructions in upgrade notes Fix changelog typo Oh yeah, RST Absolute URL it is then Fix upgrade notes link Provide summary of upgrade issues in changelog. Fix ) Move next version notes from changelog to upgrade notes Changelog fixes 1.13.0rc1 Documentation on setting up redis (#7446) Rework UI Auth session validation for registration (#7455) Fix errors from malformed log line (#7454) Drop support for redis.dbid (#7450)
| * | 1.13.0rc1Andrew Morgan2020-05-111-1/+1
| | |
| * | Rework UI Auth session validation for registration (#7455)Patrick Cloke2020-05-083-14/+62
| | | | | | | | | | | | Be less strict about validation of UI authentication sessions during registration to match client expecations.
| * | Fix errors from malformed log line (#7454)Richard van der Hoff2020-05-071-1/+1
| | |
| * | Drop support for redis.dbid (#7450)Richard van der Hoff2020-05-072-4/+1
| | | | | | | | | Since we only use pubsub, the dbid is irrelevant.
* | | Extend spam checker to allow for multiple modules (#7435)Andrew Morgan2020-05-082-47/+69
| | |
* | | Implement OpenID Connect-based login (#7256)Quentin Gliech2020-05-0815-12/+1323
| | |
* | | Add room details admin endpoint (#7317)Manuel Stahl2020-05-073-1/+58
| | |
* | | Merge branch 'release-v1.13.0' into developBrendan Abolivier2020-05-075-18/+49
|\| |
| * | Add a configuration setting for the dummy event threshold (#7422)Brendan Abolivier2020-05-072-1/+18
| | | | | | | | | Add dummy_events_threshold which allows configuring the number of forward extremities a room needs for Synapse to send forward extremities in it.
| * | Improve per-block CPU and DB usage metrics (#7426)Patrick Cloke2020-05-061-12/+26
| | |
| * | Port group attestation renewal slow down from matrix-org-hotfixes (#7442)Andrew Morgan2020-05-061-4/+2
| | |
| * | Make redis go faster with hiredis (#7439)Richard van der Hoff2020-05-061-1/+3
| | | | | | | | | | | | | | | For the record, the reason we need this is as follows: each RDATA command comes down the redis pipe as a subscription message. txredisapi as written needs at least three reactor ticks to read each subscription message from the tcp buffer. Hence, once the process gets loaded, it starts getting behind, and eventually redis knifes the connection. it then takes ages for the master to work its way through the backlog, before it reconnects again, during which any commands from any workers are dropped.
* | | Fixes typo (bellow -> below) (#7449)Patrick Cloke2020-05-072-2/+2
| | |
* | | Add more type hints to SAML handler. (#7445)Patrick Cloke2020-05-071-12/+16
| | |
* | | Support any process writing to cache invalidation stream. (#7436)Erik Johnston2020-05-0723-225/+223
| | |
* | | Merge branch 'release-v1.13.0' into developRichard van der Hoff2020-05-067-117/+208
|\| |
| * | Stop Auth methods from polling the config on every req. (#7420)Andrew Morgan2020-05-062-73/+114
| | |
| * | Merge pull request #7423 from matrix-org/erikj/faster_device_lists_fetchErik Johnston2020-05-063-10/+25
| |\ \ | | | | | | | | Speed up fetching device lists changes in sync.
| | * \ Merge branch 'release-v1.13.0' into erikj/faster_device_lists_fetchRichard van der Hoff2020-05-0542-577/+562
| | |\ \
| | * | | Speed up fetching device lists changes in sync.Erik Johnston2020-05-053-10/+25
| | | | | | | | | | | | | | | | | | | | | | | | | Currently we copy `users_who_share_room` needlessly about three times, which is expensive when the set is large (which it can easily be).
| * | | | Merge branch 'release-v1.13.0' into rav/fix_dropped_messagesRichard van der Hoff2020-05-051-1/+1
| |\ \ \ \
| * \ \ \ \ Merge branch 'release-v1.13.0' into rav/fix_dropped_messagesRichard van der Hoff2020-05-0542-576/+562
| |\ \ \ \ \ | | | |_|/ / | | |/| | |
| * | | | | Wait for a POSITION on the right connection before accepting RDATARichard van der Hoff2020-05-052-19/+38
| | | | | | | | | | | | | | | | | | | | | | | | ... otherwise we can believe we're up to date when we're not.
| * | | | | Wait to subscribe before sending REPLICATERichard van der Hoff2020-05-052-20/+35
| | |_|/ / | |/| | |
* | | | | Merge pull request #7428 from matrix-org/rav/cross_signing_keys_cacheRichard van der Hoff2020-05-061-77/+21
|\ \ \ \ \ | | | | | | | | | | | | Make get_e2e_cross_signing_key delegate to get_e2e_cross_signing_keys_bulk
| * | | | | Make get_e2e_cross_signing_key delegate to get_e2e_cross_signing_keys_bulkRichard van der Hoff2020-05-061-54/+6
| | | | | | | | | | | | | | | | | | | | | | | | ... mostly because the latter has a cache.
| * | | | | Fix batching for fetching cross-signing keysRichard van der Hoff2020-05-061-23/+15
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | There's no point carefully dividing a list into batches, and then completely ignoring the batches.
* | | | | Merge branch 'release-v1.13.0' into developRichard van der Hoff2020-05-063-3/+47
|\| | | |
| * | | | Move logs about discarded RDATA to debug (#7421)Brendan Abolivier2020-05-051-1/+1
| | |/ / | |/| |
| * | | Add backwards compatibility codepath to LoggingContext. (#7408)Patrick Cloke2020-05-051-0/+41
| | | |
| * | | Fix bug in EventContext.deserialize. (#7393)Erik Johnston2020-05-051-2/+5
| | | | | | | | | | | | | | | | This caused `prev_state_ids` to be incorrect if the state event was not replacing an existing state entry.
* | | | Merge branch 'develop' into rav/upsert_for_device_listRichard van der Hoff2020-05-0646-651/+794
|\ \ \ \
| * | | | Fix typing annotations in synapse/federation (#7382)Richard van der Hoff2020-05-051-15/+31
| | | | | | | | | | | | | | | | | | | | We're pretty close to having mypy working for `synapse.federation`, so let's finish the job.
| * | | | Fix catchup-on-reconnect for the Federation Stream (#7374)Richard van der Hoff2020-05-057-36/+63
| | | | | | | | | | | | | | | | | | | | looks like we managed to break this during the refactorathon.
| * | | | Add MultiWriterIdGenerator. (#7281)Erik Johnston2020-05-041-2/+167
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will be used to coordinate stream IDs across multiple writers. Functions as the equivalent of both `StreamIdGenerator` and `SlavedIdTracker`.
| * | | | Merge branch 'release-v1.13.0' into developBrendan Abolivier2020-05-041-0/+3
| |\| | |
| | * | | Fix redis password support. (#7401)Erik Johnston2020-05-041-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | We forgot to set the password on the subscriber connection, as well as not calling super methods for overridden connectionMade/connectionLost functions.
| * | | | Convert the room handler to async/await. (#7396)Patrick Cloke2020-05-041-24/+18
| |/ / /
| * | | Convert synapse.server_notices to async/await. (#7394)Patrick Cloke2020-05-011-10/+6
| | | |
| * | | Convert the synapse.notifier module to async/await. (#7395)Patrick Cloke2020-05-011-10/+7
| | | |
| * | | Wait for current_state_events_membership before populate_stats_process_rooms ↵Richard van der Hoff2020-05-011-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (#7387) populate_stats_process_rooms was added in #5971 / v1.4.0; current_state_events_membership was added in #5706 / v1.3.0. Fixes #7380.
| * | | Thread through instance name to replication client. (#7369)Erik Johnston2020-05-018-35/+94
| | | | | | | | | | | | For in memory streams when fetching updates on workers we need to query the source of the stream, which currently is hard coded to be master. This PR threads through the source instance we received via `POSITION` through to the update function in each stream, which can then be passed to the replication client for in memory streams.
| * | | Use `stream.current_token()` and remove `stream_positions()` (#7172)Erik Johnston2020-05-0114-120/+3
| | | | | | | | | | | | | | | | We move the processing of typing and federation replication traffic into their handlers so that `Stream.current_token()` points to a valid token. This allows us to remove `get_streams_to_replicate()` and `stream_positions()`.
| * | | async/await is_server_admin (#7363)Andrew Morgan2020-05-0117-376/+328
| | | |
| * | | Further improvements to requesting the public rooms list on a homeserver ↵Andrew Morgan2020-05-012-23/+70
| |/ / | | | | | | | | | which has it set to private (#7368)
* | | use an upsert to update device_lists_outbound_last_successRichard van der Hoff2020-05-063-18/+71
| | |
* | | Better type annotations for simple_upsert_txnRichard van der Hoff2020-05-061-30/+43
|/ / | | | | | | most of these params don't really need to be lists.
* | Workaround for assertion errors from db_query_to_update_function (#7378)Richard van der Hoff2020-05-011-2/+1
| | | | | | Hopefully this is no worse than what we have on master...
* | Persist user interactive authentication sessions (#7302)Patrick Cloke2020-04-3010-120/+387
| | | | | | | | | | By persisting the user interactive authentication sessions to the database, this fixes situations where a user hits different works throughout their auth session and also allows sessions to persist through restarts of Synapse.
* | Apply federation check for /publicRooms with filter list (#7367)Andrew Morgan2020-04-301-1/+5
| |
* | Add instance name to RDATA/POSITION commands (#7364)Erik Johnston2020-04-296-31/+65
| | | | | | | | | | This is primarily for allowing us to send those commands from workers, but for now simply allows us to ignore echoed RDATA/POSITION commands that we sent (we get echoes of sent commands when using redis). Currently we log a WARNING on the master process every time we receive an echoed RDATA.
* | Don't relay REMOTE_SERVER_UP cmds to same conn. (#7352)Erik Johnston2020-04-294-25/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | For direct TCP connections we need the master to relay REMOTE_SERVER_UP commands to the other connections so that all instances get notified about it. The old implementation just relayed to all connections, assuming that sending back to the original sender of the command was safe. This is not true for redis, where commands sent get echoed back to the sender, which was causing master to effectively infinite loop sending and then re-receiving REMOTE_SERVER_UP commands that it sent. The fix is to ensure that we only relay to *other* connections and not to the connection we received the notification from. Fixes #7334.
* | Fix limit logic for EventsStream (#7358)Richard van der Hoff2020-04-294-19/+76
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Factor out functions for injecting events into database I want to add some more flexibility to the tools for injecting events into the database, and I don't want to clutter up HomeserverTestCase with them, so let's factor them out to a new file. * Rework TestReplicationDataHandler This wasn't very easy to work with: the mock wrapping was largely superfluous, and it's useful to be able to inspect the received rows, and clear out the received list. * Fix AssertionErrors being thrown by EventsStream Part of the problem was that there was an off-by-one error in the assertion, but also the limit logic was too simple. Fix it all up and add some tests.
* | Fix fallback value for account_threepid_delegates.email (#7316)Andrew Morgan2020-04-291-3/+8
| |
* | Return total number of users and profile attributes in admin users endpoint ↵Manuel Stahl2020-04-282-33/+43
| | | | | | | | | | (#6881) Signed-off-by: Manuel Stahl <manuel.stahl@awesome-technologies.de>
* | Fix typo 'datbases' in ConfigErrorAndrew Morgan2020-04-281-1/+1
| |
* | Run replication streamers on workers (#7146)Erik Johnston2020-04-282-22/+24
| | | | | | Currently we never write to streams from workers, but that will change soon
* | Fix incorrect metrics reporting for renew_attestations (#7344)Richard van der Hoff2020-04-271-10/+9
| | | | | | | | We need to wait for the renewals to finish, so that the metrics are correctly reported.
* | Don't crash when one of the configuration files is empty (#7341)Brendan Abolivier2020-04-271-0/+6
| | | | | | | | | | If the admin adds a `.yaml` file that's either empty or doesn't parse into a dict to a config directory (e.g. `conf.d` for debs installs), stuff like https://github.com/matrix-org/synapse/issues/7322 would happen. This PR checks that the file is correctly parsed into a dict, or ignores it with a warning if it parses into any other type (including `None` for empty files). Fixes https://github.com/matrix-org/synapse/issues/7322
* | Add documentation to the sample config about the templates for SSO. (#7343)Patrick Cloke2020-04-241-0/+24
| |
* | Convert some of the federation handler methods to async/await. (#7338)Patrick Cloke2020-04-241-25/+24
| |
* | Merge pull request #7337 from matrix-org/rav/fix_update_limit_assertionRichard van der Hoff2020-04-244-44/+146
|\ \ | | | | | | Fix assertions being thrown by the EventsStream update function
| * | Fix EventsStream raising assertions when it falls behindRichard van der Hoff2020-04-242-30/+129
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Figuring out how to correctly limit updates from this stream without dropping entries is far more complicated than just counting the number of rows being returned. We need to consider each query separately and, if any one query hits the limit, truncate the results from the others. I think this also fixes some potentially long-standing bugs where events or state changes could get missed if we hit the limit on either query.
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-12-21 09:02:52 +0000