summary refs log tree commit diff
path: root/synapse/visibility.py (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Bump black from 23.10.1 to 24.2.0 (#16936)dependabot[bot]2024-03-131-3/+3
|
* Correctly mention previous copyright (#16820)Erik Johnston2024-01-231-0/+2
| | | | | During the migration the automated script to update the copyright headers accidentally got rid of some of the existing copyright lines. Reinstate them.
* Update license headersPatrick Cloke2023-11-211-11/+16
|
* Use StrCollection in additional places. (#16301)Patrick Cloke2023-09-131-3/+3
|
* Run pyupgrade for python 3.7 & 3.8. (#16110)Patrick Cloke2023-08-151-1/+1
|
* Log when events are (unexpectedly) filtered out of responses in tests (#14213)Eric Eastwood2023-06-011-7/+7
| | | | | See https://github.com/matrix-org/synapse/pull/14095#discussion_r990335492 This is useful because when see that a relevant event is an `outlier` or `soft-failed`, then that's a good unexpected indicator explaining why it's not showing up. `filter_events_for_client` is used in `/sync`, `/messages`, `/context` which are all common end-to-end assertion touch points (also notifications, relations).
* Refactor `filter_events_for_server` (#15240)David Robertson2023-03-101-20/+47
| | | | | | | | | | | | | | | | | * Tweak docstring and type hint * Flip logic and provide better name * Separate decision from action * Track a set of strings, not EventBases * Require explicit boolean options from callers * Add explicit option for partial state rooms * Changelog * Rename param
* Move `StateFilter` to `synapse.types` (#14668)David Robertson2022-12-121-1/+1
| | | | | * Move `StateFilter` to `synapse.types` * Changelog
* Faster joins: filter out non local events when a room doesn't have its full ↵Mathieu Velten2022-11-211-3/+26
| | | | | | state (#14404) Signed-off-by: Mathieu Velten <mathieuv@matrix.org>
* Add debug logs to figure out why an event was filtered (#14095)Eric Eastwood2022-10-171-1/+31
| | | | | | | | | | | | | | | | Spawned while investigating https://github.com/matrix-org/synapse/issues/13944 This way we might get some more context whenever an `403 Forbidden - body: {"errcode":"M_FORBIDDEN","error":"You don't have permission to access that event."}` error is produced. `log_config.yaml` ```yaml loggers: synapse: level: INFO synapse.visibility: level: DEBUG ```
* Skip filtering during push if there are no push actions (#13992)Erik Johnston2022-09-301-0/+4
|
* Add some miscellaneous comments around sync (#13474)Sean Quah2022-08-101-2/+2
| | | | | | | | Add some miscellaneous comments to document sync, especially around `compute_state_delta`. Signed-off-by: Sean Quah <seanq@matrix.org> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* Instrument `/messages` for understandable traces in Jaeger (#13368)Eric Eastwood2022-08-031-0/+2
| | | | | | In Jaeger: - Before: huge list of uncategorized database calls - After: nice and collapsible into units of work
* Add a `filter_event_for_clients_with_state` function (#13222)Erik Johnston2022-07-111-137/+387
|
* Fix 404 on `/sync` when the last event is a redaction of an unknown/purged ↵Richard van der Hoff2022-06-011-10/+18
| | | | | | | | | | | event (#12905) Currently, we try to pull the event corresponding to a sync token from the database. However, when we fetch redaction events, we check the target of that redaction (because we aren't allowed to send redactions to clients without validating them). So, if the sync token points to a redaction of an event that we don't have, we have a problem. It turns out we don't really need that event, and can just work with its ID and metadata, which sidesteps the whole problem.
* Rename storage classes (#12913)Erik Johnston2022-05-311-5/+5
|
* Prevent expired events from being filtered out when retention is disabled ↵Brendan Abolivier2022-05-231-3/+3
| | | | | | (#12611) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Optimise backfill calculation (#12522)Richard van der Hoff2022-04-261-0/+7
| | | | | | Try to avoid an OOM by checking fewer extremities. Generally this is a big rewrite of _maybe_backfill, to try and fix some of the TODOs and other problems in it. It's best reviewed commit-by-commit.
* Handle outliers in `/federation/v1/event` (#12332)Richard van der Hoff2022-03-311-106/+128
| | | | | | | The intention here is to avoid doing state lookups for outliers in `/_matrix/federation/v1/event`. Unfortunately that's expanded into something of a rewrite of `filter_events_for_server`, which ended up trying to do that operation in a couple of places.
* Use the ignored_users table to test event visibility & sync. (#12225)Patrick Cloke2022-03-151-15/+3
| | | | | Instead of fetching the raw account data and re-parsing it. The ignored_users table is a denormalised version of the account data for quick searching.
* Update client-visibility filtering for outlier events (#12155)Richard van der Hoff2022-03-041-1/+16
| | | Avoid trying to get the state for outliers, which isn't a sensible thing to do.
* Make the `get_global_account_data_by_type_for_user` cache be a tree-cache ↵reivilibre2022-01-211-1/+1
| | | | whose key is prefixed with the user ID (#11788)
* [pyupgrade] `synapse/` (#10348)Jonathan de Jong2021-07-191-2/+2
| | | | | | | | | This PR is tantamount to running ``` pyupgrade --py36-plus --keep-percent-format `find synapse/ -type f -name "*.py"` ``` Part of #9744
* Use inline type hints in various other places (in `synapse/`) (#10380)Jonathan de Jong2021-07-151-1/+1
|
* Remove redundant "coding: utf-8" lines (#9786)Jonathan de Jong2021-04-141-1/+0
| | | | | | | Part of #9744 Removes all redundant `# -*- coding: utf-8 -*-` lines from files, as python 3 automatically reads source code as utf-8 now. `Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>`
* Add type hints to misc. files. (#9676)Patrick Cloke2021-03-241-40/+38
|
* Merge pull request #9150 from Yoric/develop-contextDavid Teller2021-02-081-0/+1
|\ | | | | New API /_synapse/admin/rooms/{roomId}/context/{eventId}
| * FIXUP: Don't filter events at all for admin/v1/rooms/.../context/...David Teller2021-01-281-19/+6
| |
| * New API /_synapse/admin/rooms/{roomId}/context/{eventId}David Teller2021-01-281-6/+20
| | | | | | | | Signed-off-by: David Teller <davidt@element.io>
* | Typo fix in a comment: subequently -> subsequently. (#8988)Tim Gates2021-02-031-1/+1
|/
* Try and drop stale extremities. (#8929)Erik Johnston2020-12-181-1/+1
| | | | If we see stale extremities while persisting events, and notice that they don't change the result of state resolution, we drop them.
* Do not assume that the contents dictionary includes history_visibility. (#8945)Patrick Cloke2020-12-161-14/+28
|
* Do not assume that account data is of the correct form. (#8454)Patrick Cloke2020-10-051-8/+7
| | | | This fixes a bug where `m.ignored_user_list` was assumed to be a dict, leading to odd behavior for users who set it to something else.
* Convert groups and visibility code to async / await. (#7951)Patrick Cloke2020-07-271-17/+13
|
* Fix some spelling mistakes / typos. (#7811)Patrick Cloke2020-07-091-2/+2
|
* Replace all remaining six usage with native Python 3 equivalents (#7704)Dagfinn Ilmari Mannsåker2020-06-161-2/+0
|
* Replace iteritems/itervalues/iterkeys with native versions. (#7692)Patrick Cloke2020-06-151-13/+8
|
* Refactor a bitBrendan Abolivier2020-03-111-28/+30
|
* Also don't fail on aliases events in this caseBrendan Abolivier2020-03-111-1/+1
|
* LintBrendan Abolivier2020-03-111-1/+5
|
* Also don't filter out events sent by ignored users when checking state ↵Brendan Abolivier2020-03-111-1/+1
| | | | visibility
* Fix conditionBrendan Abolivier2020-03-111-1/+1
|
* Don't filter out dummy events when we're checking the visibility of stateBrendan Abolivier2020-03-111-8/+7
|
* Hide extremities dummy events from clientsBrendan Abolivier2020-03-041-0/+3
|
* Clarify list/set/dict/tuple comprehensions and enforce via flake8 (#6957)Patrick Cloke2020-02-211-2/+2
| | | | Ensure good comprehension hygiene using flake8-comprehensions.
* filter out m.room.aliases from the CS API until a better solution is specced ↵Matthew Hodgson2020-02-101-0/+7
| | | | | (#6878) We're in the middle of properly mitigating spam caused by malicious aliases being added to a room. However, until this work fully lands, we temporarily filter out all m.room.aliases events from /sync and /messages on the CS API, to remove abusive aliases. This is considered acceptable as m.room.aliases events were never a reliable record of the given alias->id mapping and were purely informational, and in their current state do more harm than good.
* Update the documentation of the filtering functionBrendan Abolivier2019-12-161-1/+2
|
* LintBrendan Abolivier2019-11-281-4/+8
|
* Discard retention policies when retrieving stateBrendan Abolivier2019-11-281-8/+14
| | | | | | | | Purge jobs don't delete the latest event in a room in order to keep the forward extremity and not break the room. On the other hand, get_state_events, when given an at_token argument calls filter_events_for_client to know if the user can see the event that matches that (sync) token. That function uses the retention policies of the events it's given to filter out those that are too old from a client's view. Some clients, such as Riot, when loading a room, request the list of members for the latest sync token it knows about, and get confused to the point of refusing to send any message if the server tells it that it can't get that information. This can happen very easily with the message retention feature turned on and a room with low activity so that the last event sent becomes too old according to the room's retention policy. An easy and clean fix for that issue is to discard the room's retention policies when retrieving state.
* Don't apply retention policy based filtering on state eventsBrendan Abolivier2019-11-061-6/+9
| | | | As per MSC1763, 'Retention is only considered for non-state events.', so don't filter out state events based on the room's retention policy.
* Implement per-room message retention policiesBrendan Abolivier2019-11-041-0/+17
|
* Port to use state storageErik Johnston2019-10-301-13/+17
|
* Replace returnValue with return (#5736)Amber Brown2019-07-231-4/+4
|
* Run Black. (#5482)Amber Brown2019-06-201-41/+28
|
* Implement soft failErik Johnston2019-03-061-0/+4
|
* clarify commentsErik Johnston2019-03-051-1/+1
|
* Fix missing null guardErik Johnston2019-03-041-1/+1
|
* Only check history visibility when filteringErik Johnston2019-03-041-34/+43
| | | | | | When filtering events to send to server we check more than just history visibility. However when deciding whether to backfill or not we only care about the history visibility.
* Stop backpaginating when events not visibleErik Johnston2019-02-201-5/+25
|
* Refactor state group lookup to reduce DB hits (#4011)Erik Johnston2018-10-251-6/+9
| | | | | | | | Currently when fetching state groups from the data store we make two hits two the database: once for members and once for non-members (unless request is filtered to one or the other). This adds needless load to the datbase, so this PR refactors the lookup to make only a single database hit.
* synapse/visibility.py: fix SyntaxError on py3.7Ivan Shapovalov2018-10-141-1/+1
|
* Optimisation for filter_events_for_serverRichard van der Hoff2018-10-081-7/+6
| | | | | | | We're better off hashing just the event_id than the whole ((type, state_key), event_id) tuple - so use a dict instead of a set. Also, iteritems > items.
* Merge remote-tracking branch 'origin/develop' into rav/remove_who_forgot_in_roomRichard van der Hoff2018-07-231-9/+10
|\
| * Make the rest of the .iterwhatever go away (#3562)Amber Brown2018-07-211-9/+10
| |
* | Remove redundant checks on room forgottennessRichard van der Hoff2018-07-231-18/+1
|/ | | | Fixes #3550
* add a commentRichard van der Hoff2018-07-171-0/+2
|
* Fix visibility of events from erased users over federationRichard van der Hoff2018-07-171-56/+67
|
* fix importsRichard van der Hoff2018-07-171-0/+1
|
* add a commentRichard van der Hoff2018-07-171-0/+2
|
* Attempt to make _filter_events_for_server more efficientRichard van der Hoff2018-07-161-17/+23
|
* Move filter_events_for_server out of FederationHandlerRichard van der Hoff2018-07-161-0/+132
| | | | for easier unit testing.
* run isortAmber Brown2018-07-091-3/+1
|
* Revert "Revert "Merge pull request #3431 from ↵Erik Johnston2018-06-251-22/+55
| | | | | | matrix-org/rav/erasure_visibility"" This reverts commit 1d009013b3c3e814177afc59f066e02a202b21cd.
* Revert "Merge pull request #3431 from matrix-org/rav/erasure_visibility"Richard van der Hoff2018-06-221-55/+22
| | | | | This reverts commit ce0d911156b355c5bf452120bfb08653dad96497, reversing changes made to b4a5d767a94f1680d07edfd583aae54ce422573e.
* Filter out erased messagesRichard van der Hoff2018-06-121-22/+55
| | | | Redact any messges sent by erased users.
* remove dead filter_events_for_clientsRichard van der Hoff2018-06-121-64/+34
| | | | | | This is only used by filter_events_for_client, so we can simplify the whole thing by just doing one user at a time, and removing a dead storage function to boot.
* Remove preserve_context_over_{fn, deferred}Richard van der Hoff2017-11-141-2/+2
| | | | | Both of these functions ae known to leak logcontexts. Replace the remaining calls to them and kill them off.
* Don't filter out current state events from timelineErik Johnston2017-09-181-3/+11
|
* Perf: Don't filter events for pushErik Johnston2017-07-071-19/+0
| | | | | We know the users are joined and we can explicitly check for if they are ignoring the user, so lets do that.
* Revert "Speed up filtering of a single event in push"Erik Johnston2017-05-081-0/+19
| | | | This reverts commit 421fdf74609439edaaffce117436e6a6df147841.
* Speed up filtering of a single event in pushErik Johnston2017-04-281-19/+0
|
* Don't convert to deferreds when not necessaryErik Johnston2017-03-301-1/+2
|
* Fix rejection of invites not reaching syncDavid Baker2017-03-231-0/+7
| | | | | | | Always allow the user to see their own leave events, otherwise they won't see the event if they reject an invite for a room whose history visibility is set such that they cannot see events before joining.
* Replace context.current_state with context.current_state_idsErik Johnston2016-08-251-0/+19
|
* Preserve some logcontextsErik Johnston2016-08-241-3/+3
|
* move filter_events_for_client out of base handlerMark Haines2016-05-111-0/+210
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-11-26 10:32:25 +0000