summary refs log tree commit diff
path: root/synapse/storage (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Add missing `ordering` to background updates (#8850)Richard van der Hoff2020-12-014-12/+12
| | | | | | | It's important that we make sure our background updates happen in a defined order, to avoid disasters like #6923. Add an ordering to all of the background updates that have landed since #7190.
* Drop (almost) unused index on event_json (#8845)Richard van der Hoff2020-11-302-1/+20
|
* Speed up remote invite rejection database call (#8815)Andrew Morgan2020-11-251-1/+33
| | | | | | | | | | | | | This is another PR that grew out of #6739. The existing code for checking whether a user is currently invited to a room when they want to leave the room looks like the following: https://github.com/matrix-org/synapse/blob/f737368a26bb9eea401fcc3a5bdd7e0b59e91f09/synapse/handlers/room_member.py#L518-L540 It calls `get_invite_for_local_user_in_room`, which will actually query *all* rooms the user has been invited to, before iterating over them and matching via the room ID. It will then return a tuple of a lot of information which we pull the event ID out of. I need to do a similar check for knocking, but this code wasn't very efficient. I then tried to write a different implementation using `StateHandler.get_current_state` but this actually didn't work as we haven't *joined* the room yet - we've only been invited to it. That means that only certain tables in Synapse have our desired `invite` membership state. One of those tables is `local_current_membership`. So I wrote a store method that just queries that table instead
* Improve appservice handler to send only the most recent read receipts when ↵Will Hunt2020-11-181-1/+6
| | | | | | | | | | | | | | | | | | | no stream_id is stored. (#8744) * Make this line debug (it's noisy) * Don't include from_key for presence if we are at 0 * Limit read receipts for all rooms to 100 * changelog.d/8744.bugfix * Allow from_key to be None * Update 8744.bugfix * The from_key is superflous * Update comment
* Add admin API for logging in as a user (#8617)Erik Johnston2020-11-171-0/+2
|
* Generalise _maybe_store_room_on_invite (#8754)Andrew Morgan2020-11-131-4/+6
| | | | | | | | | There's a handy function called maybe_store_room_on_invite which allows us to create an entry in the rooms table for a room and its version for which we aren't joined to yet, but we can reference when ingesting events about. This is currently used for invites where we receive some stripped state about the room and pass it down via /sync to the client, without us being in the room yet. There is a similar requirement for knocking, where we will eventually do the same thing, and need an entry in the rooms table as well. Thus, reusing this function works, however its name needs to be generalised a bit. Separated out from #6739.
* Cache event ID to auth event IDs lookups (#8752)Erik Johnston2020-11-131-12/+70
| | | | | This should hopefully speed up `get_auth_chain_difference` a bit in the case of repeated state res on the same rooms. `get_auth_chain_difference` does a breadth first walk of the auth graphs by repeatedly looking up events' auth events. Different state resolutions on the same room will end up doing a lot of the same event to auth events lookups, so by caching them we should speed things up in cases of repeated state resolutions on the same room.
* Enable reconnection in DB pool (#8726)Erik Johnston2020-11-121-1/+6
| | | | | | `adbapi.ConnectionPool` let's you turn on auto reconnect of DB connections. This is off by default. As far as I can tell if its not enabled dead connections never get removed from the pool. Maybe helps #8574
* Add an admin API for users' media statistics (#8700)Dirk Klimpel2020-11-051-0/+127
| | | | | | | | Add `GET /_synapse/admin/v1/statistics/users/media` to get statisics about local media usage by users. Related to #6094 It is the first API for statistics. Goal is to avoid/reduce usage of sql queries like [Wiki analyzing Synapse](https://github.com/matrix-org/synapse/wiki/SQL-for-analyzing-Synapse-PostgreSQL-database-stats) Signed-off-by: Dirk Klimpel dirk@klimpel.org
* Improve start time by adding index to e2e_cross_signing_keys (#8694)Erik Johnston2020-11-022-2/+33
| | | We do a `SELECT MAX(stream_id) FROM e2e_cross_signing_keys` on startup.
* Fix error handling around when completing an AS transaction (#8693)Brendan Abolivier2020-10-301-1/+1
|
* Fix race for concurrent downloads of remote media. (#8682)Erik Johnston2020-10-301-0/+27
| | | Fixes #6755
* Fix optional parameter in stripped state storage method (#8688)Andrew Morgan2020-10-301-1/+1
| | | Missed in #8671.
* Add ability for access tokens to belong to one user but grant access to ↵Erik Johnston2020-10-292-9/+56
| | | | | | | | | | another user. (#8616) We do it this way round so that only the "owner" can delete the access token (i.e. `/logout/all` by the "owner" also deletes that token, but `/logout/all` by the "target user" doesn't). A future PR will add an API for creating such a token. When the target user and authenticated entity are different the `Processed request` log line will be logged with a: `{@admin:server as @bob:server} ...`. I'm not convinced by that format (especially since it adds spaces in there, making it harder to use `cut -d ' '` to chop off the start of log lines). Suggestions welcome.
* Merge pull request #8678 from matrix-org/rav/fix_frozen_eventsRichard van der Hoff2020-10-282-9/+7
|\ | | | | Fix serialisation errors when using third-party event rules.
| * Remove frozendict_json_encoder and support frozendicts everywhereRichard van der Hoff2020-10-282-9/+7
| | | | | | | | | | | | Not being able to serialise `frozendicts` is fragile, and it's annoying to have to think about which serialiser you want. There's no real downside to supporting frozendicts, so let's just have one json encoder.
* | Add type hints to application services. (#8655)Patrick Cloke2020-10-281-38/+60
| |
* | Don't pull event from DB when handling replication traffic. (#8669)Erik Johnston2020-10-281-2/+6
| | | | | | | | | | I was trying to make it so that we didn't have to start a background task when handling RDATA, but that is a bigger job (due to all the code in `generic_worker`). However I still think not pulling the event from the DB may help reduce some DB usage due to replication, even if most workers will simply go and pull that event from the DB later anyway. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Tell Black to format code for Python 3.5 (#8664)Dan Callahan2020-10-271-2/+2
| | | | | | | | | | | | | | | | This allows trailing commas in multi-line arg lists. Minor, but we might as well keep our formatting current with regard to our minimum supported Python version. Signed-off-by: Dan Callahan <danc@element.io>
* | Abstract code for stripping room state into a separate method (#8671)Andrew Morgan2020-10-271-1/+53
| | | | | | | | | | | | | | | | | | | | | | This is a requirement for [knocking](https://github.com/matrix-org/synapse/pull/6739), and is abstracting some code that was originally used by the invite flow. I'm separating it out into this PR as it's a fairly contained change. For a bit of context: when you invite a user to a room, you send them [stripped state events](https://matrix.org/docs/spec/server_server/unstable#put-matrix-federation-v2-invite-roomid-eventid) as part of `invite_room_state`. This is so that their client can display useful information such as the room name and avatar. The same requirement applies to knocking, as it would be nice for clients to be able to display a list of rooms you've knocked on - room name and avatar included. The reason we're sending membership events down as well is in the case that you are invited to a room that does not have an avatar or name set. In that case, the client should use the displayname/avatar of the inviter. That information is located in the inviter's membership event. This is optional as knocks don't really have any user in the room to link up to. When you knock on a room, your knock is sent by you and inserted into the room. It wouldn't *really* make sense to show the avatar of a random user - plus it'd be a data leak. So I've opted not to send membership events to the client here. The UX on the client for when you knock on a room without a name/avatar is a separate problem. In essence this is just moving some inline code to a reusable store method.
* | Add admin API to list users' local media (#8647)Dirk Klimpel2020-10-273-0/+60
| | | | | | Add admin API `GET /_synapse/admin/v1/users/<user_id>/media` to get information of users' uploaded files.
* | Add type hints for account validity handler (#8620)Patrick Cloke2020-10-262-4/+4
| | | | | | This also fixes a bug by fixing handling of an account which doesn't expire.
* | Split admin API for reported events into a detail and a list view (#8539)Dirk Klimpel2020-10-261-17/+87
| | | | | | | | | | | | | | | | | | | | | | | | Split admin API for reported events in detail und list view. API was introduced with #8217 in synapse v.1.21.0. It makes the list (`GET /_synapse/admin/v1/event_reports`) less complex and provides a better overview. The details can be queried with: `GET /_synapse/admin/v1/event_reports/<report_id>`. It is similar to room and users API. It is a kind of regression in `GET /_synapse/admin/v1/event_reports`. `event_json` was removed. But the api was introduced one version before and it is an admin API (not under spec). Signed-off-by: Dirk Klimpel dirk@klimpel.org
* | Add an admin api to delete local media. (#8519)Dirk Klimpel2020-10-261-0/+53
| | | | | | | | | | | | Related to: #6459, #3479 Add `DELETE /_synapse/admin/v1/media/<server_name>/<media_id>` to delete a single file from server.
* | Merge branch 'release-v1.22.0' into developErik Johnston2020-10-261-4/+5
|\|
| * Fix get|set_type_stream_id_for_appservice store functions (#8648)Will Hunt2020-10-261-7/+22
| |
| * Fix user_daily_visits to not have duplicate rows for UA. (#8654)Erik Johnston2020-10-261-4/+5
| | | | | | | | | | | | | | | | | | | | | | * Fix user_daily_visits to not have duplicate rows for UA. Fixes #8641. * Newsfile * Fix typo. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Fix get|set_type_stream_id_for_appservice store functions (#8648)Will Hunt2020-10-261-7/+22
| |
* | Type hints for RegistrationStore (#8615)Erik Johnston2020-10-222-74/+83
|/
* Add type hints to profile and base handlers. (#8609)Patrick Cloke2020-10-211-3/+3
|
* Consistently use wrap_as_background_task in more places (#8599)Patrick Cloke2020-10-202-14/+13
|
* Move schema file for as_device_stream (#8590)Will Hunt2020-10-201-3/+2
| | | | | | | | | * Move schema file * Add a . * Add matching changelog entry * Fix sqlite
* Drop unused `device_max_stream_id` table (#8589)Vasilis Gerakaris2020-10-191-0/+1
| | | Signed-off-by: Vasilis Gerakaris <vasilis.gerakaris@navarino.gr>
* Add `DeferredCache.get_immediate` method (#8568)Richard van der Hoff2020-10-193-12/+3
| | | | | | | | | | | * Add `DeferredCache.get_immediate` method A bunch of things that are currently calling `DeferredCache.get` are only really interested in the result if it's completed. We can optimise and simplify this case. * Remove unused 'default' parameter to DeferredCache.get() * another get_immediate instance
* Replace DeferredCache with LruCache where possible (#8563)Richard van der Hoff2020-10-195-22/+21
| | | Most of these uses don't need a full-blown DeferredCache; LruCache is lighter and more appropriate.
* Pre-emptively fix synapse.storage.types.Connection for future mypy release ↵Jonathan de Jong2020-10-172-3/+3
| | | | | (#8577) Fix the Connection protocol according to typeshed's assertions about sqlite3.Connection
* Clean-up old transaction IDs on the background worker. (#8544)Patrick Cloke2020-10-161-1/+1
|
* Send some ephemeral events to appservices (#8437)Will Hunt2020-10-153-9/+130
| | | Optionally sends typing, presence, and read receipt information to appservices.
* Merge pull request #8548 from matrix-org/rav/deferred_cacheRichard van der Hoff2020-10-153-6/+8
|\ | | | | Rename Cache to DeferredCache, and related changes
| * move DeferredCache into its own moduleRichard van der Hoff2020-10-143-3/+5
| |
| * Rename Cache->DeferredCacheRichard van der Hoff2020-10-143-6/+6
| |
* | Include user agent in user daily visits table (#8503)Neil Johnson2020-10-152-3/+26
| | | | | | Include user agent in user daily visits table.
* | Use autocommit mode for single statement DB functions. (#8542)Erik Johnston2020-10-144-70/+155
| | | | | | | | | | | | | | | | | | | | | | | | | | Autocommit means that we don't wrap the functions in transactions, and instead get executed directly. Introduced in #8456. This will help: 1. reduce the number of `could not serialize access due to concurrent delete` errors that we see (though there are a few functions that often cause serialization errors that we don't fix here); 2. improve the DB performance, as it no longer needs to deal with the overhead of `REPEATABLE READ` isolation levels; and 3. improve wall clock speed of these functions, as we no longer need to send `BEGIN` and `COMMIT` to the DB. Some notes about the differences between autocommit mode and our default `REPEATABLE READ` transactions: 1. Currently `autocommit` only applies when using PostgreSQL, and is ignored when using SQLite (due to silliness with [Twisted DB classes](https://twistedmatrix.com/trac/ticket/9998)). 2. Autocommit functions may get retried on error, which means they can get applied *twice* (or more) to the DB (since they are not in a transaction the previous call would not get rolled back). This means that the functions need to be idempotent (or otherwise not care about being called multiple times). Read queries, simple deletes, and updates/upserts that replace rows (rather than generating new values from existing rows) are all idempotent. 3. Autocommit functions no longer get executed in [`REPEATABLE READ`](https://www.postgresql.org/docs/current/transaction-iso.html) isolation level, and so data can change queries, which is fine for single statement queries.
* | Remove racey assertion in MultiWriterIDGenerator (#8530)Erik Johnston2020-10-141-7/+0
| | | | | | | | | | | | | | | | We asserted that the IDs returned by postgres sequence was greater than any we had seen, however this is technically racey as we may update the current positions out of order. We now assert that the sequences are correct on startup, so the assertion is no longer really required, so we remove them.
* | Make sure a retention policy is a state event (#8527)Brendan Abolivier2020-10-141-0/+4
|/ | | | | * Make sure a retention policy is a state event * Changelog
* Move additional tasks to the background worker, part 4 (#8513)Patrick Cloke2020-10-133-152/+150
|
* Fix message duplication if something goes wrong after persisting the event ↵Erik Johnston2020-10-135-15/+241
| | | | | (#8476) Should fix #3365.
* Make event persisters periodically announce position over replication. (#8499)Erik Johnston2020-10-122-0/+12
| | | | | Currently background proccesses stream the events stream use the "minimum persisted position" (i.e. `get_current_token()`) rather than the vector clock style tokens. This is broadly fine as it doesn't matter if the background processes lag a small amount. However, in extreme cases (i.e. SyTests) where we only write to one event persister the background processes will never make progress. This PR changes it so that the `MultiWriterIDGenerator` keeps the current position of a given instance as up to date as possible (i.e using the latest token it sees if its not in the process of persisting anything), and then periodically announces that over replication. This then allows the "minimum persisted position" to advance, albeit with a small lag.
* Only send RDATA for instance local events. (#8496)Erik Johnston2020-10-093-19/+42
| | | | | When pulling events out of the DB to send over replication we were not filtering by instance name, and so we were sending events for other instances.
* Move additional tasks to the background worker, part 3 (#8489)Patrick Cloke2020-10-096-271/+272
|
* Add type hints to some handlers (#8505)Patrick Cloke2020-10-091-1/+3
|
* Invalidate the cache when an olm fallback key is uploaded (#8501)Hubert Chathi2020-10-081-0/+4
|
* Move additional tasks to the background worker (#8458)Patrick Cloke2020-10-075-175/+179
|
* Reduce serialization errors in MultiWriterIdGen (#8456)Erik Johnston2020-10-075-8/+110
| | | | | | We call `_update_stream_positions_table_txn` a lot, which is an UPSERT that can conflict in `REPEATABLE READ` isolation level. Instead of doing a transaction consisting of a single query we may as well run it outside of a transaction.
* Use vector clocks for room stream tokens. (#8439)Erik Johnston2020-10-072-37/+268
| | | | | | | | | | Currently when using multiple event persisters we (in the worst case) don't tell clients about events until all event persisters have persisted new events after the original event. This is a suboptimal, especially if one of the event persisters goes down. To handle this, we encode the position of each event persister in the room tokens so that we can send events to clients immediately. To reduce the size of the token we do two things: 1. We create a unique immutable persistent mapping between instance names and a generated small integer ID, which we can encode in the tokens instead of the instance name; and 2. We encode the "persisted upto position" of the room token and then only explicitly include instances that have positions strictly greater than that. The new tokens look something like: `m3478~1.3488~2.3489`, where the first number is the min position, and the subsequent `-` separated pairs are the instance ID to positions map. (We use `.` and `~` as separators as they're URL safe and not already used by `StreamToken`).
* Add typing information to the device handler. (#8407)Patrick Cloke2020-10-071-3/+3
|
* Add support for MSC2697: Dehydrated devices (#8380)Hubert Chathi2020-10-074-4/+133
| | | | This allows a user to store an offline device on the server and then restore it at a subsequent login.
* Add support for MSC2732: olm fallback keys (#8312)Hubert Chathi2020-10-062-1/+123
|
* Remove stream ordering from Metadata dict (#8452)Richard van der Hoff2020-10-054-23/+22
| | | | | | | | There's no need for it to be in the dict as well as the events table. Instead, we store it in a separate attribute in the EventInternalMetadata object, and populate that on load. This means that we can rely on it being correctly populated for any event which has been persited to the database.
* Do not assume that account data is of the correct form. (#8454)Patrick Cloke2020-10-051-2/+7
| | | | This fixes a bug where `m.ignored_user_list` was assumed to be a dict, leading to odd behavior for users who set it to something else.
* Add logging on startup/shutdown (#8448)Erik Johnston2020-10-0220-107/+134
| | | | | This is so we can tell what is going on when things are taking a while to start up. The main change here is to ensure that transactions that are created during startup get correctly logged like normal transactions.
* Speed up unit tests when using PostgreSQL (#8450)Erik Johnston2020-10-021-1/+12
|
* Allow background tasks to be run on a separate worker. (#8369)Patrick Cloke2020-10-025-259/+266
|
* Merge tag 'v1.21.0rc2' into developRichard van der Hoff2020-10-021-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.21.0rc2 (2020-10-02) ============================== Features -------- - Convert additional templates from inline HTML to Jinja2 templates. ([\#8444](https://github.com/matrix-org/synapse/issues/8444)) Bugfixes -------- - Fix a regression in v1.21.0rc1 which broke thumbnails of remote media. ([\#8438](https://github.com/matrix-org/synapse/issues/8438)) - Do not expose the experimental `uk.half-shot.msc2778.login.application_service` flow in the login API, which caused a compatibility problem with Element iOS. ([\#8440](https://github.com/matrix-org/synapse/issues/8440)) - Fix malformed log line in new federation "catch up" logic. ([\#8442](https://github.com/matrix-org/synapse/issues/8442)) - Fix DB query on startup for negative streams which caused long start up times. Introduced in [\#8374](https://github.com/matrix-org/synapse/issues/8374). ([\#8447](https://github.com/matrix-org/synapse/issues/8447))
| * Fix DB query on startup for negative streams. (#8447)Erik Johnston2020-10-021-1/+1
| | | | | | | | | | | | | | | | For negative streams we have to negate the internal stream ID before querying the DB. The effect of this bug was to query far too many rows, slowing start up time, but we would correctly filter the results afterwards so there was no ill effect.
* | Enable mypy checking for unreachable code and fix instances. (#8432)Patrick Cloke2020-10-014-18/+10
|/
* Make token serializing/deserializing async (#8427)Erik Johnston2020-09-301-4/+4
| | | The idea is that in future tokens will encode a mapping of instance to position. However, we don't want to include the full instance name in the string representation, so instead we'll have a mapping between instance name and an immutable integer ID in the DB that we can use instead. We'll then do the lookup when we serialize/deserialize the token (we could alternatively pass around an `Instance` type that includes both the name and ID, but that turns out to be a lot more invasive).
* Add an improved "forward extremities" metricRichard van der Hoff2020-09-301-2/+25
| | | | | Hopefully, N(extremities) * N(state_events) is a more realistic approximation to "how big a problem is this room?".
* Rewrite BucketCollectorRichard van der Hoff2020-09-301-16/+10
| | | | | | | | | | | | This was a bit unweildy for what I wanted: in particular, I wanted to assign each measurement straight into a bucket, rather than storing an intermediate Counter which didn't do any bucketing at all. I've replaced it with something that is hopefully a bit easier to use. (I'm not entirely sure what the difference between a HistogramMetricFamily and a GaugeHistogramMetricFamily is, but given our counters can go down as well as up the latter *sounds* more accurate?)
* Various clean ups to room stream tokens. (#8423)Erik Johnston2020-09-292-20/+23
|
* Don't table scan events on worker startup (#8419)Erik Johnston2020-09-291-1/+25
| | | | | | | | | | | | | | | | | | | | * Fix table scan of events on worker startup. This happened because we assumed "new" writers had an initial stream position of 0, so the replication code tried to fetch all events written by the instance between 0 and the current position. Instead, set the initial position of new writers to the current persisted up to position, on the assumption that new writers won't have written anything before that point. * Consider old writers coming back as "new". Otherwise we'd try and fetch entries between the old stale token and the current position, even though it won't have written any rows. Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* Mypy fixes for `synapse.handlers.federation` (#8422)Richard van der Hoff2020-09-293-6/+6
| | | For some reason, an apparently unrelated PR upset mypy about this module. Here are a number of little fixes.
* Filter out appservices from mau count (#8404)Will Hunt2020-09-291-1/+8
| | | This is an attempt to fix #8403.
* Add checks for postgres sequence consistency (#8402)Erik Johnston2020-09-284-2/+99
|
* typoMatthew Hodgson2020-09-281-1/+1
|
* Allow existing users to login via OpenID Connect. (#8345)Tdxdxoz2020-09-251-2/+2
| | | | | | | Co-authored-by: Benjamin Koch <bbbsnowball@gmail.com> This adds configuration flags that will match a user to pre-existing users when logging in via OpenID Connect. This is useful when switching to an existing SSO system.
* Fix schema delta for servers that have not backfilled (#8396)Erik Johnston2020-09-252-2/+8
| | | | | Fixes #8395.
* Fix MultiWriteIdGenerator's handling of restarts. (#8374)Erik Johnston2020-09-244-22/+160
| | | | | | | | | | | | | | | | | | | On startup `MultiWriteIdGenerator` fetches the maximum stream ID for each instance from the table and uses that as its initial "current position" for each writer. This is problematic as a) it involves either a scan of events table or an index (neither of which is ideal), and b) if rows are being persisted out of order elsewhere while the process restarts then using the maximum stream ID is not correct. This could theoretically lead to race conditions where e.g. events that are persisted out of order are not sent down sync streams. We fix this by creating a new table that tracks the current positions of each writer to the stream, and update it each time we finish persisting a new entry. This is a relatively small overhead when persisting events. However for the cache invalidation stream this is a much bigger relative overhead, so instead we note that for invalidation we don't actually care about reliability over restarts (as there's no caches to invalidate) and simply don't bother reading and writing to the new table in that particular case.
* Add EventStreamPosition type (#8388)Erik Johnston2020-09-243-11/+19
| | | | | | | | | | | | | | The idea is to remove some of the places we pass around `int`, where it can represent one of two things: 1. the position of an event in the stream; or 2. a token that partitions the stream, used as part of the stream tokens. The valid operations are then: 1. did a position happen before or after a token; 2. get all events that happened before or after a token; and 3. get all events between two tokens. (Note that we don't want to allow other operations as we want to change the tokens to be vector clocks rather than simple ints)
* Fix bug which caused failure on join with malformed membership events (#8385)Richard van der Hoff2020-09-231-3/+7
|
* Use `async with` for ID gens (#8383)Erik Johnston2020-09-2313-80/+102
| | | This will allow us to hit the DB after we've finished using the generated stream ID.
* Don't push if an user account has expired (#8353)Mathieu Velten2020-09-231-0/+14
|
* Fix missing null character check on guest_access room stateAndrew Morgan2020-09-221-0/+2
| | | | | | | | | | | | | | | When updating room_stats_state, we try to check for null bytes slipping in to the content for state events. It turns out we had added guest_access as a field to room_stats_state without including it in the null byte check. Lo and behold, a null byte in a m.room.guest_access event then breaks room_stats_state updates. This PR adds the check for guest_access. A further PR will improve this function so that this hopefully does not happen again in future.
* Fixed a bug with reactivating users with the admin API (#8362)Dirk Klimpel2020-09-221-1/+1
| | | | | | | Fixes: #8359 Trying to reactivate a user with the admin API (`PUT /_synapse/admin/v2/users/<user_name>`) causes an internal server error. Seems to be a regression in #8033.
* Admin API for reported events (#8217)Dirk Klimpel2020-09-221-0/+95
| | | Add an admin API to read entries of table `event_reports`. API: `GET /_synapse/admin/v1/event_reports`
* Merge tag 'v1.20.0rc5' into developPatrick Cloke2020-09-181-8/+5
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.20.0rc5 (2020-09-18) ============================== In addition to the below, Synapse 1.20.0rc5 also includes the bug fix that was included in 1.19.3. Features -------- - Add flags to the `/versions` endpoint for whether new rooms default to using E2EE. ([\#8343](https://github.com/matrix-org/synapse/issues/8343)) Bugfixes -------- - Fix rate limiting of federation `/send` requests. ([\#8342](https://github.com/matrix-org/synapse/issues/8342)) - Fix a longstanding bug where back pagination over federation could get stuck if it failed to handle a received event. ([\#8349](https://github.com/matrix-org/synapse/issues/8349)) Internal Changes ---------------- - Blacklist [MSC2753](https://github.com/matrix-org/matrix-doc/pull/2753) SyTests until it is implemented. ([\#8285](https://github.com/matrix-org/synapse/issues/8285))
| * Intelligently select extremities used in backfill. (#8349)Erik Johnston2020-09-181-8/+5
| | | | | | | | | | | | | | | | | | Instead of just using the most recent extremities let's pick the ones that will give us results that the pagination request cares about, i.e. pick extremities only if they have a smaller depth than the pagination token. This is useful when we fail to backfill an extremity, as we no longer get stuck requesting that same extremity repeatedly.
* | Catch-up after Federation Outage (bonus): Catch-up on Synapse Startup (#8322)reivilibre2020-09-181-2/+64
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Fix _set_destination_retry_timings This came about because the code assumed that retry_interval could not be NULL — which has been challenged by catch-up.
* | Simplify super() calls to Python 3 syntax. (#8344)Patrick Cloke2020-09-1825-45/+43
| | | | | | | | | | | | | | This converts calls like super(Foo, self) -> super(). Generated with: sed -i "" -Ee 's/super\([^\(]+\)/super()/g' **/*.py
* | Remove obsolete __future__ imports (#8337)Jonathan de Jong2020-09-171-2/+0
| |
* | Switch metaclass initialization to python 3-compatible syntax (#8326)Jonathan de Jong2020-09-164-17/+10
| |
* | Catch-up after Federation Outage (split, 4): catch-up loop (#8272)reivilibre2020-09-151-1/+42
| |
* | Use slots in attrs classes where possible (#8296)Patrick Cloke2020-09-145-5/+5
| | | | | | | | | | slots use less memory (and attribute access is faster) while slightly limiting the flexibility of the class attributes. This focuses on objects which are instantiated "often" and for short periods of time.
* | Add the topic and avatar to the room details admin API (#8305)Tulir Asokan2020-09-141-1/+2
| |
* | Add experimental support for sharding event persister. Again. (#8294)Erik Johnston2020-09-147-29/+105
| | | | | | | | | | | | This is *not* ready for production yet. Caveats: 1. We should write some tests... 2. The stream token that we use for events can get stalled at the minimum position of all writers. This means that new events may not be processed and e.g. sent down sync streams if a writer isn't writing or is slow.
* | Make `StreamToken.room_key` be a `RoomStreamToken` instance. (#8281)Erik Johnston2020-09-114-56/+61
| |
* | Merge branch 'release-v1.20.0' into developRichard van der Hoff2020-09-101-2/+3
|\|
| * Fix /notifications and pushers misbehaving because of unread counts (#8280)Brendan Abolivier2020-09-081-2/+3
| |
* | Don't remember `enabled` of deleted push rules and properly return 404 for ↵reivilibre2020-09-092-11/+148
| | | | | | | | | | | | | | missing push rules in `.../actions` and `.../enabled` (#7796) Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Include method in thumbnail media name (#7124)DeepBlueV7.X2020-09-083-0/+134
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes an issue where different methods (crop/scale) overwrite each other. This first tries the new path. If that fails and we are looking for a remote thumbnail, it tries the old path. If that still isn't found, it continues as normal. This should probably be removed in the future, after some of the newer thumbnails were generated with the new path on most deployments. Then the overhead should be minimal if the other thumbnails need to be regenerated. Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
* | Add types to StreamToken and RoomStreamToken (#8279)Erik Johnston2020-09-082-14/+14
| | | | | | The intention here is to change `StreamToken.room_key` to be a `RoomStreamToken` in a future PR, but that is a big enough change without this refactoring too.
* | Fix `MultiWriterIdGenerator.current_position`. (#8257)Erik Johnston2020-09-081-6/+37
| | | | | | | | | | It did not correctly handle IDs finishing being persisted out of order, resulting in the `current_position` lagging until new IDs are persisted.
* | Rename 'populate_stats_process_rooms_2' background job back to ↵Andrew Morgan2020-09-082-30/+28
| | | | | | | | | | | | | | 'populate_stats_process_rooms' again (#8243) Fixes https://github.com/matrix-org/synapse/issues/8238 Alongside the delta file, some changes were also necessary to the codebase to remove references to the now defunct `populate_stats_process_rooms_2` background job. Thankfully the latter doesn't seem to have made it into any documentation yet :)
* | Merge remote-tracking branch 'origin/release-v1.20.0' into developRichard van der Hoff2020-09-085-35/+111
|\|
| * Avoid table-scanning users at startup (#8271)Richard van der Hoff2020-09-071-11/+14
| | | | | | This takes about 10 seconds in the best case; often more.
| * Fix unread count failing on NULL values (#8270)Brendan Abolivier2020-09-071-1/+6
| | | | | | | | Fix unread counts making sync fail if the value of the `unread_count` column in `event_push_summary` is `None`.
| * Add more logging to debug slow startup (#8264)Richard van der Hoff2020-09-074-7/+32
| | | | | | | | I'm hoping this will provide some pointers for debugging https://github.com/matrix-org/synapse/issues/7968.
| * Refuse to upgrade database on worker processes (#8266)Richard van der Hoff2020-09-071-17/+61
| |
* | Run database updates in a transaction (#8265)Richard van der Hoff2020-09-071-5/+22
| | | | | | Fixes: #6467
* | Merge branch 'release-v1.20.0' into developRichard van der Hoff2020-09-063-37/+20
|\|
| * Add cross-signing sigs to the `keys` object (#8234)Richard van der Hoff2020-09-042-34/+17
| | | | | | | | | | All the callers want this info in the same place, so let's reduce the duplication by doing it here.
| * Unread counts fixes (#8254)Brendan Abolivier2020-09-041-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fixup `ALTER TABLE` database queries Make the new columns nullable, because doing otherwise can wedge a server with a big database, as setting a default value rewrites the table. * Switch back to using the notifications count in the push badge Clients are likely to be confused if we send a push but the badge count is the unread messages one, and not the notifications one. * Changelog
* | In light of #8255, use BIGINTs for destination_rooms (#8256)reivilibre2020-09-041-1/+1
| |
* | Catch up after Federation Outage (split, 2): Track last successful stream ↵reivilibre2020-09-042-0/+59
| | | | | | | | | | ordering after transmission (#8247) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Catch-up after Federation Outage (split, 1) (#8230)reivilibre2020-09-044-5/+109
|/ | | Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
* Fix type signature in simple_select_one_onecol and friends (#8241)reivilibre2020-09-041-10/+7
| | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Stop sub-classing object (#8249)Patrick Cloke2020-09-0412-19/+19
|
* Revert "Add experimental support for sharding event persister. (#8170)" (#8242)Brendan Abolivier2020-09-047-100/+26
| | | | | | | * Revert "Add experimental support for sharding event persister. (#8170)" This reverts commit 82c1ee1c22a87b9e6e3179947014b0f11c0a1ac3. * Changelog
* Split fetching device keys and signatures into two transactions (#8233)Richard van der Hoff2020-09-031-44/+65
| | | I think this is simpler (and moves stuff out of the db threads)
* Fix typing for SyncHandler (#8237)Erik Johnston2020-09-032-5/+5
|
* wrap `_get_e2e_device_keys_and_signatures_txn` in a non-txn method (#8231)Richard van der Hoff2020-09-032-17/+39
| | | | | We have three things which all call `_get_e2e_device_keys_and_signatures_txn` with their own `runInteraction`. Factor out the common code.
* Add an overload for simple_select_one_onecol_txn. (#8235)Patrick Cloke2020-09-021-0/+24
|
* Convert runInteraction to async/await (#8156)Patrick Cloke2020-09-021-15/+14
|
* Add StreamStore to mypy (#8232)Erik Johnston2020-09-022-18/+62
|
* Re-implement unread counts (again) (#8059)Brendan Abolivier2020-09-024-70/+205
|
* Refactor `_get_e2e_device_keys_for_federation_query_txn` (#8225)Richard van der Hoff2020-09-021-11/+6
| | | | | We can use the existing `_get_e2e_device_keys_and_signatures_txn` instead of creating our own txn function
* Add experimental support for sharding event persister. (#8170)Erik Johnston2020-09-027-26/+100
| | | | | | This is *not* ready for production yet. Caveats: 1. We should write some tests... 2. The stream token that we use for events can get stalled at the minimum position of all writers. This means that new events may not be processed and e.g. sent down sync streams if a writer isn't writing or is slow.
* Add /user/{user_id}/shared_rooms/ api (#7785)Will Hunt2020-09-021-1/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add shared_rooms api * Add changelog * Add . * Wrap response in {"rooms": } * linting * Add unstable_features key * Remove options from isort that aren't part of 5.x `-y` and `-rc` are now default behaviour and no longer exist. `dont-skip` is no longer required https://timothycrosley.github.io/isort/CHANGELOG/#500-penny-july-4-2020 * Update imports to make isort happy * Add changelog * Update tox.ini file with correct invocation * fix linting again for isort * Vendor prefix unstable API * Fix to match spec * import Codes * import Codes * Use FORBIDDEN * Update changelog.d/7785.feature Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Implement get_shared_rooms_for_users * a comma * trailing whitespace * Handle the easy feedback * Switch to using runInteraction * Add tests * Feedback * Seperate unstable endpoint from v2 * Add upgrade node * a line * Fix style by adding a blank line at EOF. * Update synapse/storage/databases/main/user_directory.py Co-authored-by: Tulir Asokan <tulir@maunium.net> * Update synapse/storage/databases/main/user_directory.py Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Update UPGRADE.rst Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Fix UPGRADE/CHANGELOG unstable paths unstable unstable unstable Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Tulir Asokan <tulir@maunium.net> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Tulir Asokan <tulir@maunium.net>
* Do not try to store invalid data in the stats table (#8226)Patrick Cloke2020-09-021-8/+26
|
* Make _get_e2e_device_keys_and_signatures_txn return an attrs (#8224)Richard van der Hoff2020-09-022-20/+40
| | | | this makes it a bit clearer what's going on.
* Fix errors when updating the user directory with invalid data (#8223)Patrick Cloke2020-09-011-0/+5
|
* Convert additional databases to async/await part 3 (#8201)Patrick Cloke2020-09-016-87/+120
|
* Rename `_get_e2e_device_keys_txn` (#8222)Richard van der Hoff2020-09-012-6/+8
| | | | | ... to `_get_e2e_device_keys_and_signatures_txn`, to better reflect what it does.
* Convert additional databases to async/await (#8199)Patrick Cloke2020-09-016-137/+146
|
* Convert additional databases to async/await part 2 (#8200)Patrick Cloke2020-09-0110-50/+90
|
* Make MultiWriterIDGenerator work for streams that use negative stream IDs ↵Erik Johnston2020-09-011-11/+28
| | | | | (#8203) This is so that we can use it for the backfill events stream.
* Move and rename `get_devices_with_keys_by_user` (#8204)Richard van der Hoff2020-09-013-48/+60
| | | | | | | | | | | | | | | | | | * Move `get_devices_with_keys_by_user` to `EndToEndKeyWorkerStore` this seems a better fit for it. This commit simply moves the existing code: no other changes at all. * Rename `get_devices_with_keys_by_user` to better reflect what it does. * get_device_stream_token abstract method To avoid referencing fields which are declared in the derived classes, make `get_device_stream_token` abstract, and define that in the classes which define `_device_list_id_gen`.
* Rename `get_e2e_device_keys` to better reflect its purpose (#8205)Richard van der Hoff2020-08-291-14/+6
| | | | | | | | | | | ... and to show that it does something slightly different to `_get_e2e_device_keys_txn`. `include_all_devices` and `include_deleted_devices` were never used (and `include_deleted_devices` was broken, since that would cause `None`s in the result which were not handled in the loop below. Add some typing too.
* Fix incorrect return signatureAndrew Morgan2020-08-281-1/+1
|
* Convert `event_push_actions`, `registration`, and `roommember` datastores to ↵Patrick Cloke2020-08-283-160/+168
| | | | async (#8197)
* Only return devices with keys from `/federation/v1/user/devices/` (#8198)Richard van der Hoff2020-08-281-3/+1
| | | | | There's not much point in returning all the others, and some people have a silly number of devices.
* Convert state and stream stores and related code to async (#8194)Patrick Cloke2020-08-285-44/+49
|
* Convert additional database code to async/await. (#8195)Patrick Cloke2020-08-287-157/+221
|
* Convert stats and related calls to async/await (#8192)Patrick Cloke2020-08-272-48/+49
|
* Convert simple_delete to async/await. (#8191)Patrick Cloke2020-08-273-35/+85
|
* Convert calls of async database methods to async (#8166)Patrick Cloke2020-08-2711-74/+103
|
* simple_search_list_txn should return None, not 0. (#8187)Patrick Cloke2020-08-271-4/+3
|
* Fix missing _add_persisted_position (#8179)Erik Johnston2020-08-271-0/+2
| | | This was forgotten in #8164.
* Convert additional database methods to async (select list, search, ↵Patrick Cloke2020-08-275-79/+60
| | | | insert_many, delete_*) (#8168)
* Convert simple_update* and simple_select* to async (#8173)Patrick Cloke2020-08-2712-86/+114
|
* Make SlavedIdTracker.advance have same interface as MultiWriterIDGenerator ↵Erik Johnston2020-08-261-2/+2
| | | | (#8171)
* Convert simple_select_one and simple_select_one_onecol to async (#8162)Patrick Cloke2020-08-2616-73/+116
|
* Add functions to `MultiWriterIdGen` used by events stream (#8164)Erik Johnston2020-08-252-3/+108
|
* Make StreamIdGen `get_next` and `get_next_mult` async (#8161)Erik Johnston2020-08-2513-49/+53
| | | | This is mainly so that `StreamIdGenerator` and `MultiWriterIdGenerator` will have the same interface, allowing them to be used interchangeably.
* Wording fixes to 'name' user admin api filter (#8163)Andrew Morgan2020-08-251-1/+1
| | | Some fixes to wording I noticed after merging #7377.
* Search in columns 'name' and 'displayname' in the admin users endpoint (#7377)Manuel Stahl2020-08-251-12/+19
| | | | | * Search in columns 'name' and 'displayname' in the admin users endpoint Signed-off-by: Manuel Stahl <manuel.stahl@awesome-technologies.de>
* Don't fail /submit_token requests on incorrect session ID if ↵Brendan Abolivier2020-08-241-6/+19
| | | | | | | | | | | | | | | | | | | request_token_inhibit_3pid_errors is turned on (#7991) * Don't raise session_id errors on submit_token if request_token_inhibit_3pid_errors is set * Changelog * Also wait some time before responding to /requestToken * Incorporate review * Update synapse/storage/databases/main/registration.py Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Incorporate review Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* Micro-optimisations to get_auth_chain_ids (#8132)Richard van der Hoff2020-08-211-23/+17
|
* Allow denying or shadow banning registrations via the spam checker (#8034)Patrick Cloke2020-08-202-1/+63
|
* Be more tolerant of membership events in unknown rooms (#8110)Richard van der Hoff2020-08-201-6/+25
| | | | It turns out that not all out-of-band membership events are labelled as such, so we need to be more accepting here.
* Use the JSON encoder without whitespace in more places. (#8124)Patrick Cloke2020-08-205-19/+14
|
* Add more types to synapse.storage.database. (#8127)Patrick Cloke2020-08-202-222/+366
|
* Do not assume calls to runInteraction return Deferreds. (#8133)Patrick Cloke2020-08-203-22/+26
|
* Close the database connection we create during startup (#8131)Richard van der Hoff2020-08-191-1/+10
| | | ... otherwise it gets leaked.
* Remove `ChainedIdGenerator`. (#8123)Erik Johnston2020-08-192-86/+18
| | | | | It's just a thin wrapper around two ID gens to make `get_current_token` and `get_next` return tuples. This can easily be replaced by calling the appropriate methods on the underlying ID gens directly.
* Be stricter about JSON that is accepted by Synapse (#8106)Patrick Cloke2020-08-192-6/+17
|
* Convert runWithConnection to async. (#8121)Patrick Cloke2020-08-191-14/+13
|
* Separate `get_current_token` into two. (#8113)Erik Johnston2020-08-192-11/+29
| | | | | | | | | | | | The function is used for two purposes: 1) for subscribers of streams to get a token they can use to get further updates with, and 2) for replication to track position of the writers of the stream. For streams with a single writer the two scenarios produce the same result, however the situation becomes complicated for streams with multiple writers. The current `MultiWriterIdGenerator` does not correctly handle the first case (which is not an issue as its only used for the `caches` stream which nothing subscribes to outside of replication).
* Convert events worker database to async/await. (#8071)Patrick Cloke2020-08-183-75/+88
|
* Fix the return type of send_nonmember_events. (#8112)Patrick Cloke2020-08-181-4/+15
|
* Convert some of the general database methods to async (#8100)Patrick Cloke2020-08-175-29/+24
|
* Convert stream database to async/await. (#8074)Patrick Cloke2020-08-173-257/+201
|
* Add a shadow-banned flag to users. (#8092)Patrick Cloke2020-08-142-1/+26
|
* Convert pusher databases to async/await. (#8075)Patrick Cloke2020-08-142-91/+84
|
* Convert receipts and events databases to async/await. (#8076)Patrick Cloke2020-08-143-82/+79
|
* Remove some unused database functions. (#8085)Patrick Cloke2020-08-146-244/+18
|
* Convert misc database code to async (#8087)Patrick Cloke2020-08-1410-64/+38
|
* Convert the roommember database to async/await. (#8070)Patrick Cloke2020-08-123-241/+98
|
* Convert devices database to async/await. (#8069)Patrick Cloke2020-08-121-153/+180
|
* Convert account data, device inbox, and censor events databases to ↵Patrick Cloke2020-08-123-86/+96
| | | | async/await (#8063)
* Convert appservice, group server, profile and more databases to async (#8066)Patrick Cloke2020-08-127-104/+78
|
* Merge pull request #8060 from matrix-org/erikj/type_serverErik Johnston2020-08-111-12/+16
|\ | | | | Change HomeServer definition to work with typing.
| * Change HomeServer definition to work with typing.Erik Johnston2020-08-111-12/+16
| | | | | | | | | | | | | | | | | | | | Duplicating function signatures between server.py and server.pyi is silly. This commit changes that by changing all `build_*` methods to `get_*` methods and changing the `_make_dependency_method` to work work as a descriptor that caches the produced value. There are some changes in other files that were made to fix the typing in server.py.
* | Convert tags and metrics databases to async/await (#8062)Patrick Cloke2020-08-112-64/+59
| |
* | Converts event_federation and registration databases to async/await (#8061)Patrick Cloke2020-08-113-164/+125
|/
* Implement new experimental push rules (#7997)Brendan Abolivier2020-08-101-4/+12
|\ | | | | With an undocumented configuration setting to enable them for specific users.
| * Merge branch 'develop' of github.com:matrix-org/synapse into ↵Brendan Abolivier2020-08-06282-1079/+1212
| |\ | | | | | | | | | babolivier/new_push_rules
| * | Incorporate reviewBrendan Abolivier2020-08-061-3/+3
| | |
| * | Back out the database hack and replace it with a temporary config settingBrendan Abolivier2020-08-032-47/+9
| | |
| * | Fix cache nameBrendan Abolivier2020-07-311-1/+1
| | |
| * | Fix cache invalidation callsBrendan Abolivier2020-07-311-1/+1
| | |
| * | Merge branch 'develop' of github.com:matrix-org/synapse into ↵Brendan Abolivier2020-07-3019-346/+503
| |\ \ | | | | | | | | | | | | babolivier/new_push_rules
| * | | Implement new experimental push rules with a database hack to enable themBrendan Abolivier2020-07-282-5/+51
| | | |
* | | | Convert directory, e2e_room_keys, end_to_end_keys, monthly_active_users ↵Patrick Cloke2020-08-075-102/+95
| | | | | | | | | | | | | | | | database to async (#8042)
* | | | Convert additional database stores to async/await (#8045)Patrick Cloke2020-08-074-150/+104
| | | |
* | | | Reduce unnecessary whitespace in JSON. (#7372)David Vo2020-08-079-45/+38
| | | |
* | | | Revert #7736 (#8039)Brendan Abolivier2020-08-064-151/+2
| | | |
* | | | Convert synapse.api to async/await (#8031)Patrick Cloke2020-08-061-3/+2
| |_|/ |/| |
* | | Rename database classes to make some sense (#8033)Erik Johnston2020-08-05282-1075/+1152
| | |
* | | Convert streams to async. (#8014)Patrick Cloke2020-08-041-4/+4
| | |
* | | Prevent join->join membership transitions changing member count (#7977)Andrew Morgan2020-08-032-5/+61
| |/ |/| | | | | | | | | | | | | | | | | | | `StatsHandler` handles updates to the `current_state_delta_stream`, and updates room stats such as the amount of state events, joined users, etc. However, it counts every new join membership as a new user entering a room (and that user being in another room), whereas it's possible for a user's membership status to go from join -> join, for instance when they change their per-room profile information. This PR adds a check for join->join membership transitions, and bails out early, as none of the further checks are necessary at that point. Due to this bug, membership stats in many rooms have ended up being wildly larger than their true values. I am not sure if we also want to include a migration step which recalculates these statistics (possibly using the `_populate_stats_process_rooms` bg update). Bug introduced in the initial implementation https://github.com/matrix-org/synapse/pull/4338.
* | Merge branch 'master' into developOlivier Wilkinson (reivilibre)2020-07-301-1/+1
|\ \
| * | Update worker docs with recent enhancements (#7969)Erik Johnston2020-07-291-1/+1
| | |
* | | Convert some of the data store to async. (#7976)Patrick Cloke2020-07-306-188/+160
| | |
* | | Remove from the event_relations table when purging historical events. (#7978)Patrick Cloke2020-07-291-0/+2
| | |
* | | Re-implement unread counts (#7736)Brendan Abolivier2020-07-294-2/+151
| | |
* | | Convert storage layer to async/await. (#7963)Patrick Cloke2020-07-283-140/+145
| | |
* | | Move some log lines from default logger to sql/transaction loggers (#7952)Andrew Morgan2020-07-281-8/+10
| | | | | | | | | Idea from matrix-org/synapse-dinsic#49
* | | Convert push to async/await. (#7948)Patrick Cloke2020-07-271-2/+2
|/ /
* | Convert state resolution to async/await (#7942)Patrick Cloke2020-07-244-4/+9
| |
* | Follow-up to admin API to re-activate accounts (#7908)Patrick Cloke2020-07-221-2/+24
|/
* Stop using 'device_max_stream_id' (#7882)Erik Johnston2020-07-172-4/+1
| | | | | It serves no purpose and updating everytime we write to the device inbox stream means all such transactions will conflict, causing lots of transaction failures and retries.
* Change "unknown room ver" logging to warning. (#7881)Erik Johnston2020-07-171-1/+1
| | | | It's somewhat expected for us to have unknown room versions in the database due to room version experiments.
* Consistently use `db_to_json` to convert from database values to JSON ↵Patrick Cloke2020-07-1621-82/+79
| | | | objects. (#7849)
* Merge pull request #7866 from matrix-org/rav/fix_guest_user_idRichard van der Hoff2020-07-168-59/+183
|\ | | | | Fix guest user registration with lots of client readers
| * Use a postgres sequence to generate guest user IDsRichard van der Hoff2020-07-162-29/+70
| |
| * Use SequenceGenerator for state group ID allocationRichard van der Hoff2020-07-164-26/+11
| |
| * Use `PostgresSequenceGenerator` from `MultiWriterIdGenerator`Richard van der Hoff2020-07-161-4/+4
| | | | | | | | partly just to show it works, but alwo to remove a bit of code duplication.
| * Add some helper classes for generating ID sequencesRichard van der Hoff2020-07-161-0/+98
| |
* | Avoid brand new rooms in `delete_old_current_state_events` (#7854)Richard van der Hoff2020-07-151-10/+55
|/ | | | | | | | When considering rooms to clean up in `delete_old_current_state_events`, skip rooms which we are creating, which otherwise look a bit like rooms we have left. Fixes #7834.
* remove `retry_on_integrity_error` wrapper for persist_events (#7848)Richard van der Hoff2020-07-151-67/+0
| | | | | | | | | As far as I can tell from the sentry logs, the only time this has actually done anything in the last two years is when we had two master workers running at once, and even then, it made a bit of a mess of it (see https://github.com/matrix-org/synapse/issues/7845#issuecomment-658238739). Generally I feel like this code is doing more harm than good.
* Fix bug in per-room message retention policies. (#7850)Patrick Cloke2020-07-141-1/+1
|
* Add delete room admin endpoint (#7613)Dirk Klimpel2020-07-141-1/+6
| | | | | | | | | | | | | | | | | | The Delete Room admin API allows server admins to remove rooms from server and block these rooms. `DELETE /_synapse/admin/v1/rooms/<room_id>` It is a combination and improvement of "[Shutdown room](https://github.com/matrix-org/synapse/blob/develop/docs/admin_api/shutdown_room.md)" and "[Purge room](https://github.com/matrix-org/synapse/blob/develop/docs/admin_api/purge_room.md)" API. Fixes: #6425 It also fixes a bug in [synapse/storage/data_stores/main/room.py](synapse/storage/data_stores/main/room.py) in ` get_room_with_stats`. It should return `None` if the room is unknown. But it returns an `IndexError`. https://github.com/matrix-org/synapse/blob/901b1fa561e3cc661d78aa96d59802cf2078cb0d/synapse/storage/data_stores/main/room.py#L99-L105 Related to: - #5575 - https://github.com/Awesome-Technologies/synapse-admin/issues/17 Signed-off-by: Dirk Klimpel dirk@klimpel.org
* Merge branch 'release-v1.17.0' into developRichard van der Hoff2020-07-101-0/+22
|\
| * Merge branch 'master' into release-v1.17.0Richard van der Hoff2020-07-101-0/+22
| |\
| | * fix migration, againRichard van der Hoff2020-07-101-1/+1
| | |
| | * Drop incorrectly-added table `local_rejections_stream`. (#7816)Richard van der Hoff2020-07-101-0/+22
| | |
* | | Add ability to shard the federation sender (#7798)Erik Johnston2020-07-102-7/+112
|/ /
* | Generate real events when we reject invites (#7804)Richard van der Hoff2020-07-092-26/+0
| | | | | | | | | | | | | | | | Fixes #2181. The basic premise is that, when we fail to reject an invite via the remote server, we can generate our own out-of-band leave event and persist it as an outlier, so that we have something to send to the client.
* | Do not use simplejson in Synapse. (#7800)Patrick Cloke2020-07-084-16/+8
| |
* | Stop populating unused table `local_invites`. (#7793)Richard van der Hoff2020-07-073-80/+24
| | | | | | | | | | This table is no longer used, so we may as well stop populating it. Removing it would prevent people rolling back to older releases of Synapse, so that can happen in a future release.
* | Refactor getting replication updates from database v2. (#7740)Erik Johnston2020-07-078-149/+322
| |
* | isort 5 compatibility (#7786)Will Hunt2020-07-053-5/+2
| | | | | | The CI appears to use the latest version of isort, which is a problem when isort gets a major version bump. Rather than try to pin the version, I've done the necessary to make isort5 happy with synapse.
* | Use symbolic names for replication stream names (#7768)Richard van der Hoff2020-07-012-5/+9
| | | | | | This makes it much easier to find where streams are referenced.
* | Fix incorrect error message when database CTYPE was set incorrectly. (#7760)Richard van der Hoff2020-07-011-1/+1
|/
* Back out MSC2625 implementation (#7761)Brendan Abolivier2020-07-012-128/+28
|
* Allow local media to be marked as safe from being quarantined. (#7718)Patrick Cloke2020-06-224-35/+52
|
* Fix unread counts in syncBrendan Abolivier2020-06-171-1/+1
| | | | | * Always return an unread_count in get_unread_event_push_actions_by_room_for_user * Don't always expect unread_count to be there so we don't take out sync entirely if something goes wrong
* Implement unread counter (MSC2625) (#7673)Brendan Abolivier2020-06-172-27/+127
|\ | | | | Implementation of https://github.com/matrix-org/matrix-doc/pull/2625
| * Merge branch 'develop' into babolivier/mark_unreadBrendan Abolivier2020-06-1513-81/+62
| |\
| * | Incorporate reviewBrendan Abolivier2020-06-151-15/+11
| | |
| * | LintBrendan Abolivier2020-06-121-3/+8
| | |
| * | Incorporate review bitsBrendan Abolivier2020-06-121-14/+13
| | |
| * | Pre-populate the unread_count columnBrendan Abolivier2020-06-121-0/+5
| | |
| * | Don't update the schema versionBrendan Abolivier2020-06-122-1/+1
| | |
| * | Use attr instead of a dictBrendan Abolivier2020-06-121-21/+31
| | |
| * | Fix summary rotationBrendan Abolivier2020-06-121-12/+35
| | |
| * | Log for invalid values of notifBrendan Abolivier2020-06-111-0/+6
| | |
| * | Fix SQLBrendan Abolivier2020-06-111-3/+3
| | |
| * | Fix schema updateBrendan Abolivier2020-06-111-1/+1
| | |