summary refs log tree commit diff
path: root/synapse/storage (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Reduce serialization errors in MultiWriterIdGen (#8456)Erik Johnston2020-10-075-5/+107
| | | | | | | We call `_update_stream_positions_table_txn` a lot, which is an UPSERT that can conflict in `REPEATABLE READ` isolation level. Instead of doing a transaction consisting of a single query we may as well run it outside of a transaction.
* Fix DB query on startup for negative streams. (#8447)Erik Johnston2020-10-021-1/+1
| | | | | | | | For negative streams we have to negate the internal stream ID before querying the DB. The effect of this bug was to query far too many rows, slowing start up time, but we would correctly filter the results afterwards so there was no ill effect.
* Make token serializing/deserializing async (#8427)Erik Johnston2020-09-301-4/+4
| | | The idea is that in future tokens will encode a mapping of instance to position. However, we don't want to include the full instance name in the string representation, so instead we'll have a mapping between instance name and an immutable integer ID in the DB that we can use instead. We'll then do the lookup when we serialize/deserialize the token (we could alternatively pass around an `Instance` type that includes both the name and ID, but that turns out to be a lot more invasive).
* Add an improved "forward extremities" metricRichard van der Hoff2020-09-301-2/+25
| | | | | Hopefully, N(extremities) * N(state_events) is a more realistic approximation to "how big a problem is this room?".
* Rewrite BucketCollectorRichard van der Hoff2020-09-301-16/+10
| | | | | | | | | | | | This was a bit unweildy for what I wanted: in particular, I wanted to assign each measurement straight into a bucket, rather than storing an intermediate Counter which didn't do any bucketing at all. I've replaced it with something that is hopefully a bit easier to use. (I'm not entirely sure what the difference between a HistogramMetricFamily and a GaugeHistogramMetricFamily is, but given our counters can go down as well as up the latter *sounds* more accurate?)
* Various clean ups to room stream tokens. (#8423)Erik Johnston2020-09-292-20/+23
|
* Don't table scan events on worker startup (#8419)Erik Johnston2020-09-291-1/+25
| | | | | | | | | | | | | | | | | | | | * Fix table scan of events on worker startup. This happened because we assumed "new" writers had an initial stream position of 0, so the replication code tried to fetch all events written by the instance between 0 and the current position. Instead, set the initial position of new writers to the current persisted up to position, on the assumption that new writers won't have written anything before that point. * Consider old writers coming back as "new". Otherwise we'd try and fetch entries between the old stale token and the current position, even though it won't have written any rows. Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* Mypy fixes for `synapse.handlers.federation` (#8422)Richard van der Hoff2020-09-293-6/+6
| | | For some reason, an apparently unrelated PR upset mypy about this module. Here are a number of little fixes.
* Filter out appservices from mau count (#8404)Will Hunt2020-09-291-1/+8
| | | This is an attempt to fix #8403.
* Add checks for postgres sequence consistency (#8402)Erik Johnston2020-09-284-2/+99
|
* typoMatthew Hodgson2020-09-281-1/+1
|
* Allow existing users to login via OpenID Connect. (#8345)Tdxdxoz2020-09-251-2/+2
| | | | | | | Co-authored-by: Benjamin Koch <bbbsnowball@gmail.com> This adds configuration flags that will match a user to pre-existing users when logging in via OpenID Connect. This is useful when switching to an existing SSO system.
* Fix schema delta for servers that have not backfilled (#8396)Erik Johnston2020-09-252-2/+8
| | | | | Fixes #8395.
* Fix MultiWriteIdGenerator's handling of restarts. (#8374)Erik Johnston2020-09-244-22/+160
| | | | | | | | | | | | | | | | | | | On startup `MultiWriteIdGenerator` fetches the maximum stream ID for each instance from the table and uses that as its initial "current position" for each writer. This is problematic as a) it involves either a scan of events table or an index (neither of which is ideal), and b) if rows are being persisted out of order elsewhere while the process restarts then using the maximum stream ID is not correct. This could theoretically lead to race conditions where e.g. events that are persisted out of order are not sent down sync streams. We fix this by creating a new table that tracks the current positions of each writer to the stream, and update it each time we finish persisting a new entry. This is a relatively small overhead when persisting events. However for the cache invalidation stream this is a much bigger relative overhead, so instead we note that for invalidation we don't actually care about reliability over restarts (as there's no caches to invalidate) and simply don't bother reading and writing to the new table in that particular case.
* Add EventStreamPosition type (#8388)Erik Johnston2020-09-243-11/+19
| | | | | | | | | | | | | | The idea is to remove some of the places we pass around `int`, where it can represent one of two things: 1. the position of an event in the stream; or 2. a token that partitions the stream, used as part of the stream tokens. The valid operations are then: 1. did a position happen before or after a token; 2. get all events that happened before or after a token; and 3. get all events between two tokens. (Note that we don't want to allow other operations as we want to change the tokens to be vector clocks rather than simple ints)
* Fix bug which caused failure on join with malformed membership events (#8385)Richard van der Hoff2020-09-231-3/+7
|
* Use `async with` for ID gens (#8383)Erik Johnston2020-09-2313-80/+102
| | | This will allow us to hit the DB after we've finished using the generated stream ID.
* Don't push if an user account has expired (#8353)Mathieu Velten2020-09-231-0/+14
|
* Fix missing null character check on guest_access room stateAndrew Morgan2020-09-221-0/+2
| | | | | | | | | | | | | | | When updating room_stats_state, we try to check for null bytes slipping in to the content for state events. It turns out we had added guest_access as a field to room_stats_state without including it in the null byte check. Lo and behold, a null byte in a m.room.guest_access event then breaks room_stats_state updates. This PR adds the check for guest_access. A further PR will improve this function so that this hopefully does not happen again in future.
* Fixed a bug with reactivating users with the admin API (#8362)Dirk Klimpel2020-09-221-1/+1
| | | | | | | Fixes: #8359 Trying to reactivate a user with the admin API (`PUT /_synapse/admin/v2/users/<user_name>`) causes an internal server error. Seems to be a regression in #8033.
* Admin API for reported events (#8217)Dirk Klimpel2020-09-221-0/+95
| | | Add an admin API to read entries of table `event_reports`. API: `GET /_synapse/admin/v1/event_reports`
* Merge tag 'v1.20.0rc5' into developPatrick Cloke2020-09-181-8/+5
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.20.0rc5 (2020-09-18) ============================== In addition to the below, Synapse 1.20.0rc5 also includes the bug fix that was included in 1.19.3. Features -------- - Add flags to the `/versions` endpoint for whether new rooms default to using E2EE. ([\#8343](https://github.com/matrix-org/synapse/issues/8343)) Bugfixes -------- - Fix rate limiting of federation `/send` requests. ([\#8342](https://github.com/matrix-org/synapse/issues/8342)) - Fix a longstanding bug where back pagination over federation could get stuck if it failed to handle a received event. ([\#8349](https://github.com/matrix-org/synapse/issues/8349)) Internal Changes ---------------- - Blacklist [MSC2753](https://github.com/matrix-org/matrix-doc/pull/2753) SyTests until it is implemented. ([\#8285](https://github.com/matrix-org/synapse/issues/8285))
| * Intelligently select extremities used in backfill. (#8349)Erik Johnston2020-09-181-8/+5
| | | | | | | | | | | | | | | | | | Instead of just using the most recent extremities let's pick the ones that will give us results that the pagination request cares about, i.e. pick extremities only if they have a smaller depth than the pagination token. This is useful when we fail to backfill an extremity, as we no longer get stuck requesting that same extremity repeatedly.
* | Catch-up after Federation Outage (bonus): Catch-up on Synapse Startup (#8322)reivilibre2020-09-181-2/+64
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Fix _set_destination_retry_timings This came about because the code assumed that retry_interval could not be NULL — which has been challenged by catch-up.
* | Simplify super() calls to Python 3 syntax. (#8344)Patrick Cloke2020-09-1825-45/+43
| | | | | | | | | | | | | | This converts calls like super(Foo, self) -> super(). Generated with: sed -i "" -Ee 's/super\([^\(]+\)/super()/g' **/*.py
* | Remove obsolete __future__ imports (#8337)Jonathan de Jong2020-09-171-2/+0
| |
* | Switch metaclass initialization to python 3-compatible syntax (#8326)Jonathan de Jong2020-09-164-17/+10
| |
* | Catch-up after Federation Outage (split, 4): catch-up loop (#8272)reivilibre2020-09-151-1/+42
| |
* | Use slots in attrs classes where possible (#8296)Patrick Cloke2020-09-145-5/+5
| | | | | | | | | | slots use less memory (and attribute access is faster) while slightly limiting the flexibility of the class attributes. This focuses on objects which are instantiated "often" and for short periods of time.
* | Add the topic and avatar to the room details admin API (#8305)Tulir Asokan2020-09-141-1/+2
| |
* | Add experimental support for sharding event persister. Again. (#8294)Erik Johnston2020-09-147-29/+105
| | | | | | | | | | | | This is *not* ready for production yet. Caveats: 1. We should write some tests... 2. The stream token that we use for events can get stalled at the minimum position of all writers. This means that new events may not be processed and e.g. sent down sync streams if a writer isn't writing or is slow.
* | Make `StreamToken.room_key` be a `RoomStreamToken` instance. (#8281)Erik Johnston2020-09-114-56/+61
| |
* | Merge branch 'release-v1.20.0' into developRichard van der Hoff2020-09-101-2/+3
|\|
| * Fix /notifications and pushers misbehaving because of unread counts (#8280)Brendan Abolivier2020-09-081-2/+3
| |
* | Don't remember `enabled` of deleted push rules and properly return 404 for ↵reivilibre2020-09-092-11/+148
| | | | | | | | | | | | | | missing push rules in `.../actions` and `.../enabled` (#7796) Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Include method in thumbnail media name (#7124)DeepBlueV7.X2020-09-083-0/+134
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes an issue where different methods (crop/scale) overwrite each other. This first tries the new path. If that fails and we are looking for a remote thumbnail, it tries the old path. If that still isn't found, it continues as normal. This should probably be removed in the future, after some of the newer thumbnails were generated with the new path on most deployments. Then the overhead should be minimal if the other thumbnails need to be regenerated. Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
* | Add types to StreamToken and RoomStreamToken (#8279)Erik Johnston2020-09-082-14/+14
| | | | | | The intention here is to change `StreamToken.room_key` to be a `RoomStreamToken` in a future PR, but that is a big enough change without this refactoring too.
* | Fix `MultiWriterIdGenerator.current_position`. (#8257)Erik Johnston2020-09-081-6/+37
| | | | | | | | | | It did not correctly handle IDs finishing being persisted out of order, resulting in the `current_position` lagging until new IDs are persisted.
* | Rename 'populate_stats_process_rooms_2' background job back to ↵Andrew Morgan2020-09-082-30/+28
| | | | | | | | | | | | | | 'populate_stats_process_rooms' again (#8243) Fixes https://github.com/matrix-org/synapse/issues/8238 Alongside the delta file, some changes were also necessary to the codebase to remove references to the now defunct `populate_stats_process_rooms_2` background job. Thankfully the latter doesn't seem to have made it into any documentation yet :)
* | Merge remote-tracking branch 'origin/release-v1.20.0' into developRichard van der Hoff2020-09-085-35/+111
|\|
| * Avoid table-scanning users at startup (#8271)Richard van der Hoff2020-09-071-11/+14
| | | | | | This takes about 10 seconds in the best case; often more.
| * Fix unread count failing on NULL values (#8270)Brendan Abolivier2020-09-071-1/+6
| | | | | | | | Fix unread counts making sync fail if the value of the `unread_count` column in `event_push_summary` is `None`.
| * Add more logging to debug slow startup (#8264)Richard van der Hoff2020-09-074-7/+32
| | | | | | | | I'm hoping this will provide some pointers for debugging https://github.com/matrix-org/synapse/issues/7968.
| * Refuse to upgrade database on worker processes (#8266)Richard van der Hoff2020-09-071-17/+61
| |
* | Run database updates in a transaction (#8265)Richard van der Hoff2020-09-071-5/+22
| | | | | | Fixes: #6467
* | Merge branch 'release-v1.20.0' into developRichard van der Hoff2020-09-063-37/+20
|\|
| * Add cross-signing sigs to the `keys` object (#8234)Richard van der Hoff2020-09-042-34/+17
| | | | | | | | | | All the callers want this info in the same place, so let's reduce the duplication by doing it here.
| * Unread counts fixes (#8254)Brendan Abolivier2020-09-041-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fixup `ALTER TABLE` database queries Make the new columns nullable, because doing otherwise can wedge a server with a big database, as setting a default value rewrites the table. * Switch back to using the notifications count in the push badge Clients are likely to be confused if we send a push but the badge count is the unread messages one, and not the notifications one. * Changelog
* | In light of #8255, use BIGINTs for destination_rooms (#8256)reivilibre2020-09-041-1/+1
| |
* | Catch up after Federation Outage (split, 2): Track last successful stream ↵reivilibre2020-09-042-0/+59
| | | | | | | | | | ordering after transmission (#8247) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Catch-up after Federation Outage (split, 1) (#8230)reivilibre2020-09-044-5/+109
|/ | | Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
* Fix type signature in simple_select_one_onecol and friends (#8241)reivilibre2020-09-041-10/+7
| | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Stop sub-classing object (#8249)Patrick Cloke2020-09-0412-19/+19
|
* Revert "Add experimental support for sharding event persister. (#8170)" (#8242)Brendan Abolivier2020-09-047-100/+26
| | | | | | | * Revert "Add experimental support for sharding event persister. (#8170)" This reverts commit 82c1ee1c22a87b9e6e3179947014b0f11c0a1ac3. * Changelog
* Split fetching device keys and signatures into two transactions (#8233)Richard van der Hoff2020-09-031-44/+65
| | | I think this is simpler (and moves stuff out of the db threads)
* Fix typing for SyncHandler (#8237)Erik Johnston2020-09-032-5/+5
|
* wrap `_get_e2e_device_keys_and_signatures_txn` in a non-txn method (#8231)Richard van der Hoff2020-09-032-17/+39
| | | | | We have three things which all call `_get_e2e_device_keys_and_signatures_txn` with their own `runInteraction`. Factor out the common code.
* Add an overload for simple_select_one_onecol_txn. (#8235)Patrick Cloke2020-09-021-0/+24
|
* Convert runInteraction to async/await (#8156)Patrick Cloke2020-09-021-15/+14
|
* Add StreamStore to mypy (#8232)Erik Johnston2020-09-022-18/+62
|
* Re-implement unread counts (again) (#8059)Brendan Abolivier2020-09-024-70/+205
|
* Refactor `_get_e2e_device_keys_for_federation_query_txn` (#8225)Richard van der Hoff2020-09-021-11/+6
| | | | | We can use the existing `_get_e2e_device_keys_and_signatures_txn` instead of creating our own txn function
* Add experimental support for sharding event persister. (#8170)Erik Johnston2020-09-027-26/+100
| | | | | | This is *not* ready for production yet. Caveats: 1. We should write some tests... 2. The stream token that we use for events can get stalled at the minimum position of all writers. This means that new events may not be processed and e.g. sent down sync streams if a writer isn't writing or is slow.
* Add /user/{user_id}/shared_rooms/ api (#7785)Will Hunt2020-09-021-1/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add shared_rooms api * Add changelog * Add . * Wrap response in {"rooms": } * linting * Add unstable_features key * Remove options from isort that aren't part of 5.x `-y` and `-rc` are now default behaviour and no longer exist. `dont-skip` is no longer required https://timothycrosley.github.io/isort/CHANGELOG/#500-penny-july-4-2020 * Update imports to make isort happy * Add changelog * Update tox.ini file with correct invocation * fix linting again for isort * Vendor prefix unstable API * Fix to match spec * import Codes * import Codes * Use FORBIDDEN * Update changelog.d/7785.feature Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Implement get_shared_rooms_for_users * a comma * trailing whitespace * Handle the easy feedback * Switch to using runInteraction * Add tests * Feedback * Seperate unstable endpoint from v2 * Add upgrade node * a line * Fix style by adding a blank line at EOF. * Update synapse/storage/databases/main/user_directory.py Co-authored-by: Tulir Asokan <tulir@maunium.net> * Update synapse/storage/databases/main/user_directory.py Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Update UPGRADE.rst Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Fix UPGRADE/CHANGELOG unstable paths unstable unstable unstable Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Tulir Asokan <tulir@maunium.net> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Tulir Asokan <tulir@maunium.net>
* Do not try to store invalid data in the stats table (#8226)Patrick Cloke2020-09-021-8/+26
|
* Make _get_e2e_device_keys_and_signatures_txn return an attrs (#8224)Richard van der Hoff2020-09-022-20/+40
| | | | this makes it a bit clearer what's going on.
* Fix errors when updating the user directory with invalid data (#8223)Patrick Cloke2020-09-011-0/+5
|
* Convert additional databases to async/await part 3 (#8201)Patrick Cloke2020-09-016-87/+120
|
* Rename `_get_e2e_device_keys_txn` (#8222)Richard van der Hoff2020-09-012-6/+8
| | | | | ... to `_get_e2e_device_keys_and_signatures_txn`, to better reflect what it does.
* Convert additional databases to async/await (#8199)Patrick Cloke2020-09-016-137/+146
|
* Convert additional databases to async/await part 2 (#8200)Patrick Cloke2020-09-0110-50/+90
|
* Make MultiWriterIDGenerator work for streams that use negative stream IDs ↵Erik Johnston2020-09-011-11/+28
| | | | | (#8203) This is so that we can use it for the backfill events stream.
* Move and rename `get_devices_with_keys_by_user` (#8204)Richard van der Hoff2020-09-013-48/+60
| | | | | | | | | | | | | | | | | | * Move `get_devices_with_keys_by_user` to `EndToEndKeyWorkerStore` this seems a better fit for it. This commit simply moves the existing code: no other changes at all. * Rename `get_devices_with_keys_by_user` to better reflect what it does. * get_device_stream_token abstract method To avoid referencing fields which are declared in the derived classes, make `get_device_stream_token` abstract, and define that in the classes which define `_device_list_id_gen`.
* Rename `get_e2e_device_keys` to better reflect its purpose (#8205)Richard van der Hoff2020-08-291-14/+6
| | | | | | | | | | | ... and to show that it does something slightly different to `_get_e2e_device_keys_txn`. `include_all_devices` and `include_deleted_devices` were never used (and `include_deleted_devices` was broken, since that would cause `None`s in the result which were not handled in the loop below. Add some typing too.
* Fix incorrect return signatureAndrew Morgan2020-08-281-1/+1
|
* Convert `event_push_actions`, `registration`, and `roommember` datastores to ↵Patrick Cloke2020-08-283-160/+168
| | | | async (#8197)
* Only return devices with keys from `/federation/v1/user/devices/` (#8198)Richard van der Hoff2020-08-281-3/+1
| | | | | There's not much point in returning all the others, and some people have a silly number of devices.
* Convert state and stream stores and related code to async (#8194)Patrick Cloke2020-08-285-44/+49
|
* Convert additional database code to async/await. (#8195)Patrick Cloke2020-08-287-157/+221
|
* Convert stats and related calls to async/await (#8192)Patrick Cloke2020-08-272-48/+49
|
* Convert simple_delete to async/await. (#8191)Patrick Cloke2020-08-273-35/+85
|
* Convert calls of async database methods to async (#8166)Patrick Cloke2020-08-2711-74/+103
|
* simple_search_list_txn should return None, not 0. (#8187)Patrick Cloke2020-08-271-4/+3
|
* Fix missing _add_persisted_position (#8179)Erik Johnston2020-08-271-0/+2
| | | This was forgotten in #8164.
* Convert additional database methods to async (select list, search, ↵Patrick Cloke2020-08-275-79/+60
| | | | insert_many, delete_*) (#8168)
* Convert simple_update* and simple_select* to async (#8173)Patrick Cloke2020-08-2712-86/+114
|
* Make SlavedIdTracker.advance have same interface as MultiWriterIDGenerator ↵Erik Johnston2020-08-261-2/+2
| | | | (#8171)
* Convert simple_select_one and simple_select_one_onecol to async (#8162)Patrick Cloke2020-08-2616-73/+116
|
* Add functions to `MultiWriterIdGen` used by events stream (#8164)Erik Johnston2020-08-252-3/+108
|
* Make StreamIdGen `get_next` and `get_next_mult` async (#8161)Erik Johnston2020-08-2513-49/+53
| | | | This is mainly so that `StreamIdGenerator` and `MultiWriterIdGenerator` will have the same interface, allowing them to be used interchangeably.
* Wording fixes to 'name' user admin api filter (#8163)Andrew Morgan2020-08-251-1/+1
| | | Some fixes to wording I noticed after merging #7377.
* Search in columns 'name' and 'displayname' in the admin users endpoint (#7377)Manuel Stahl2020-08-251-12/+19
| | | | | * Search in columns 'name' and 'displayname' in the admin users endpoint Signed-off-by: Manuel Stahl <manuel.stahl@awesome-technologies.de>
* Don't fail /submit_token requests on incorrect session ID if ↵Brendan Abolivier2020-08-241-6/+19
| | | | | | | | | | | | | | | | | | | request_token_inhibit_3pid_errors is turned on (#7991) * Don't raise session_id errors on submit_token if request_token_inhibit_3pid_errors is set * Changelog * Also wait some time before responding to /requestToken * Incorporate review * Update synapse/storage/databases/main/registration.py Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Incorporate review Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* Micro-optimisations to get_auth_chain_ids (#8132)Richard van der Hoff2020-08-211-23/+17
|
* Allow denying or shadow banning registrations via the spam checker (#8034)Patrick Cloke2020-08-202-1/+63
|
* Be more tolerant of membership events in unknown rooms (#8110)Richard van der Hoff2020-08-201-6/+25
| | | | It turns out that not all out-of-band membership events are labelled as such, so we need to be more accepting here.
* Use the JSON encoder without whitespace in more places. (#8124)Patrick Cloke2020-08-205-19/+14
|
* Add more types to synapse.storage.database. (#8127)Patrick Cloke2020-08-202-222/+366
|
* Do not assume calls to runInteraction return Deferreds. (#8133)Patrick Cloke2020-08-203-22/+26
|
* Close the database connection we create during startup (#8131)Richard van der Hoff2020-08-191-1/+10
| | | ... otherwise it gets leaked.
* Remove `ChainedIdGenerator`. (#8123)Erik Johnston2020-08-192-86/+18
| | | | | It's just a thin wrapper around two ID gens to make `get_current_token` and `get_next` return tuples. This can easily be replaced by calling the appropriate methods on the underlying ID gens directly.
* Be stricter about JSON that is accepted by Synapse (#8106)Patrick Cloke2020-08-192-6/+17
|
* Convert runWithConnection to async. (#8121)Patrick Cloke2020-08-191-14/+13
|
* Separate `get_current_token` into two. (#8113)Erik Johnston2020-08-192-11/+29
| | | | | | | | | | | | The function is used for two purposes: 1) for subscribers of streams to get a token they can use to get further updates with, and 2) for replication to track position of the writers of the stream. For streams with a single writer the two scenarios produce the same result, however the situation becomes complicated for streams with multiple writers. The current `MultiWriterIdGenerator` does not correctly handle the first case (which is not an issue as its only used for the `caches` stream which nothing subscribes to outside of replication).
* Convert events worker database to async/await. (#8071)Patrick Cloke2020-08-183-75/+88
|
* Fix the return type of send_nonmember_events. (#8112)Patrick Cloke2020-08-181-4/+15
|
* Convert some of the general database methods to async (#8100)Patrick Cloke2020-08-175-29/+24
|
* Convert stream database to async/await. (#8074)Patrick Cloke2020-08-173-257/+201
|
* Add a shadow-banned flag to users. (#8092)Patrick Cloke2020-08-142-1/+26
|
* Convert pusher databases to async/await. (#8075)Patrick Cloke2020-08-142-91/+84
|
* Convert receipts and events databases to async/await. (#8076)Patrick Cloke2020-08-143-82/+79
|
* Remove some unused database functions. (#8085)Patrick Cloke2020-08-146-244/+18
|
* Convert misc database code to async (#8087)Patrick Cloke2020-08-1410-64/+38
|
* Convert the roommember database to async/await. (#8070)Patrick Cloke2020-08-123-241/+98
|
* Convert devices database to async/await. (#8069)Patrick Cloke2020-08-121-153/+180
|
* Convert account data, device inbox, and censor events databases to ↵Patrick Cloke2020-08-123-86/+96
| | | | async/await (#8063)
* Convert appservice, group server, profile and more databases to async (#8066)Patrick Cloke2020-08-127-104/+78
|
* Merge pull request #8060 from matrix-org/erikj/type_serverErik Johnston2020-08-111-12/+16
|\ | | | | Change HomeServer definition to work with typing.
| * Change HomeServer definition to work with typing.Erik Johnston2020-08-111-12/+16
| | | | | | | | | | | | | | | | | | | | Duplicating function signatures between server.py and server.pyi is silly. This commit changes that by changing all `build_*` methods to `get_*` methods and changing the `_make_dependency_method` to work work as a descriptor that caches the produced value. There are some changes in other files that were made to fix the typing in server.py.
* | Convert tags and metrics databases to async/await (#8062)Patrick Cloke2020-08-112-64/+59
| |
* | Converts event_federation and registration databases to async/await (#8061)Patrick Cloke2020-08-113-164/+125
|/
* Implement new experimental push rules (#7997)Brendan Abolivier2020-08-101-4/+12
|\ | | | | With an undocumented configuration setting to enable them for specific users.
| * Merge branch 'develop' of github.com:matrix-org/synapse into ↵Brendan Abolivier2020-08-06282-1079/+1212
| |\ | | | | | | | | | babolivier/new_push_rules
| * | Incorporate reviewBrendan Abolivier2020-08-061-3/+3
| | |
| * | Back out the database hack and replace it with a temporary config settingBrendan Abolivier2020-08-032-47/+9
| | |
| * | Fix cache nameBrendan Abolivier2020-07-311-1/+1
| | |
| * | Fix cache invalidation callsBrendan Abolivier2020-07-311-1/+1
| | |
| * | Merge branch 'develop' of github.com:matrix-org/synapse into ↵Brendan Abolivier2020-07-3019-346/+503
| |\ \ | | | | | | | | | | | | babolivier/new_push_rules
| * | | Implement new experimental push rules with a database hack to enable themBrendan Abolivier2020-07-282-5/+51
| | | |
* | | | Convert directory, e2e_room_keys, end_to_end_keys, monthly_active_users ↵Patrick Cloke2020-08-075-102/+95
| | | | | | | | | | | | | | | | database to async (#8042)
* | | | Convert additional database stores to async/await (#8045)Patrick Cloke2020-08-074-150/+104
| | | |
* | | | Reduce unnecessary whitespace in JSON. (#7372)David Vo2020-08-079-45/+38
| | | |
* | | | Revert #7736 (#8039)Brendan Abolivier2020-08-064-151/+2
| | | |
* | | | Convert synapse.api to async/await (#8031)Patrick Cloke2020-08-061-3/+2
| |_|/ |/| |
* | | Rename database classes to make some sense (#8033)Erik Johnston2020-08-05282-1075/+1152
| | |
* | | Convert streams to async. (#8014)Patrick Cloke2020-08-041-4/+4
| | |
* | | Prevent join->join membership transitions changing member count (#7977)Andrew Morgan2020-08-032-5/+61
| |/ |/| | | | | | | | | | | | | | | | | | | `StatsHandler` handles updates to the `current_state_delta_stream`, and updates room stats such as the amount of state events, joined users, etc. However, it counts every new join membership as a new user entering a room (and that user being in another room), whereas it's possible for a user's membership status to go from join -> join, for instance when they change their per-room profile information. This PR adds a check for join->join membership transitions, and bails out early, as none of the further checks are necessary at that point. Due to this bug, membership stats in many rooms have ended up being wildly larger than their true values. I am not sure if we also want to include a migration step which recalculates these statistics (possibly using the `_populate_stats_process_rooms` bg update). Bug introduced in the initial implementation https://github.com/matrix-org/synapse/pull/4338.
* | Merge branch 'master' into developOlivier Wilkinson (reivilibre)2020-07-301-1/+1
|\ \
| * | Update worker docs with recent enhancements (#7969)Erik Johnston2020-07-291-1/+1
| | |
* | | Convert some of the data store to async. (#7976)Patrick Cloke2020-07-306-188/+160
| | |
* | | Remove from the event_relations table when purging historical events. (#7978)Patrick Cloke2020-07-291-0/+2
| | |
* | | Re-implement unread counts (#7736)Brendan Abolivier2020-07-294-2/+151
| | |
* | | Convert storage layer to async/await. (#7963)Patrick Cloke2020-07-283-140/+145
| | |
* | | Move some log lines from default logger to sql/transaction loggers (#7952)Andrew Morgan2020-07-281-8/+10
| | | | | | | | | Idea from matrix-org/synapse-dinsic#49
* | | Convert push to async/await. (#7948)Patrick Cloke2020-07-271-2/+2
|/ /
* | Convert state resolution to async/await (#7942)Patrick Cloke2020-07-244-4/+9
| |
* | Follow-up to admin API to re-activate accounts (#7908)Patrick Cloke2020-07-221-2/+24
|/
* Stop using 'device_max_stream_id' (#7882)Erik Johnston2020-07-172-4/+1
| | | | | It serves no purpose and updating everytime we write to the device inbox stream means all such transactions will conflict, causing lots of transaction failures and retries.
* Change "unknown room ver" logging to warning. (#7881)Erik Johnston2020-07-171-1/+1
| | | | It's somewhat expected for us to have unknown room versions in the database due to room version experiments.
* Consistently use `db_to_json` to convert from database values to JSON ↵Patrick Cloke2020-07-1621-82/+79
| | | | objects. (#7849)
* Merge pull request #7866 from matrix-org/rav/fix_guest_user_idRichard van der Hoff2020-07-168-59/+183
|\ | | | | Fix guest user registration with lots of client readers
| * Use a postgres sequence to generate guest user IDsRichard van der Hoff2020-07-162-29/+70
| |
| * Use SequenceGenerator for state group ID allocationRichard van der Hoff2020-07-164-26/+11
| |
| * Use `PostgresSequenceGenerator` from `MultiWriterIdGenerator`Richard van der Hoff2020-07-161-4/+4
| | | | | | | | partly just to show it works, but alwo to remove a bit of code duplication.
| * Add some helper classes for generating ID sequencesRichard van der Hoff2020-07-161-0/+98
| |
* | Avoid brand new rooms in `delete_old_current_state_events` (#7854)Richard van der Hoff2020-07-151-10/+55
|/ | | | | | | | When considering rooms to clean up in `delete_old_current_state_events`, skip rooms which we are creating, which otherwise look a bit like rooms we have left. Fixes #7834.
* remove `retry_on_integrity_error` wrapper for persist_events (#7848)Richard van der Hoff2020-07-151-67/+0
| | | | | | | | | As far as I can tell from the sentry logs, the only time this has actually done anything in the last two years is when we had two master workers running at once, and even then, it made a bit of a mess of it (see https://github.com/matrix-org/synapse/issues/7845#issuecomment-658238739). Generally I feel like this code is doing more harm than good.
* Fix bug in per-room message retention policies. (#7850)Patrick Cloke2020-07-141-1/+1
|
* Add delete room admin endpoint (#7613)Dirk Klimpel2020-07-141-1/+6
| | | | | | | | | | | | | | | | | | The Delete Room admin API allows server admins to remove rooms from server and block these rooms. `DELETE /_synapse/admin/v1/rooms/<room_id>` It is a combination and improvement of "[Shutdown room](https://github.com/matrix-org/synapse/blob/develop/docs/admin_api/shutdown_room.md)" and "[Purge room](https://github.com/matrix-org/synapse/blob/develop/docs/admin_api/purge_room.md)" API. Fixes: #6425 It also fixes a bug in [synapse/storage/data_stores/main/room.py](synapse/storage/data_stores/main/room.py) in ` get_room_with_stats`. It should return `None` if the room is unknown. But it returns an `IndexError`. https://github.com/matrix-org/synapse/blob/901b1fa561e3cc661d78aa96d59802cf2078cb0d/synapse/storage/data_stores/main/room.py#L99-L105 Related to: - #5575 - https://github.com/Awesome-Technologies/synapse-admin/issues/17 Signed-off-by: Dirk Klimpel dirk@klimpel.org
* Merge branch 'release-v1.17.0' into developRichard van der Hoff2020-07-101-0/+22
|\
| * Merge branch 'master' into release-v1.17.0Richard van der Hoff2020-07-101-0/+22
| |\
| | * fix migration, againRichard van der Hoff2020-07-101-1/+1
| | |
| | * Drop incorrectly-added table `local_rejections_stream`. (#7816)Richard van der Hoff2020-07-101-0/+22
| | |
* | | Add ability to shard the federation sender (#7798)Erik Johnston2020-07-102-7/+112
|/ /
* | Generate real events when we reject invites (#7804)Richard van der Hoff2020-07-092-26/+0
| | | | | | | | | | | | | | | | Fixes #2181. The basic premise is that, when we fail to reject an invite via the remote server, we can generate our own out-of-band leave event and persist it as an outlier, so that we have something to send to the client.
* | Do not use simplejson in Synapse. (#7800)Patrick Cloke2020-07-084-16/+8
| |
* | Stop populating unused table `local_invites`. (#7793)Richard van der Hoff2020-07-073-80/+24
| | | | | | | | | | This table is no longer used, so we may as well stop populating it. Removing it would prevent people rolling back to older releases of Synapse, so that can happen in a future release.
* | Refactor getting replication updates from database v2. (#7740)Erik Johnston2020-07-078-149/+322
| |
* | isort 5 compatibility (#7786)Will Hunt2020-07-053-5/+2
| | | | | | The CI appears to use the latest version of isort, which is a problem when isort gets a major version bump. Rather than try to pin the version, I've done the necessary to make isort5 happy with synapse.
* | Use symbolic names for replication stream names (#7768)Richard van der Hoff2020-07-012-5/+9
| | | | | | This makes it much easier to find where streams are referenced.
* | Fix incorrect error message when database CTYPE was set incorrectly. (#7760)Richard van der Hoff2020-07-011-1/+1
|/
* Back out MSC2625 implementation (#7761)Brendan Abolivier2020-07-012-128/+28
|
* Allow local media to be marked as safe from being quarantined. (#7718)Patrick Cloke2020-06-224-35/+52
|
* Fix unread counts in syncBrendan Abolivier2020-06-171-1/+1
| | | | | * Always return an unread_count in get_unread_event_push_actions_by_room_for_user * Don't always expect unread_count to be there so we don't take out sync entirely if something goes wrong
* Implement unread counter (MSC2625) (#7673)Brendan Abolivier2020-06-172-27/+127
|\ | | | | Implementation of https://github.com/matrix-org/matrix-doc/pull/2625
| * Merge branch 'develop' into babolivier/mark_unreadBrendan Abolivier2020-06-1513-81/+62
| |\
| * | Incorporate reviewBrendan Abolivier2020-06-151-15/+11
| | |
| * | LintBrendan Abolivier2020-06-121-3/+8
| | |
| * | Incorporate review bitsBrendan Abolivier2020-06-121-14/+13
| | |
| * | Pre-populate the unread_count columnBrendan Abolivier2020-06-121-0/+5
| | |
| * | Don't update the schema versionBrendan Abolivier2020-06-122-1/+1
| | |
| * | Use attr instead of a dictBrendan Abolivier2020-06-121-21/+31
| | |
| * | Fix summary rotationBrendan Abolivier2020-06-121-12/+35
| | |
| * | Log for invalid values of notifBrendan Abolivier2020-06-111-0/+6
| | |
| * | Fix SQLBrendan Abolivier2020-06-111-3/+3
| | |
| * | Fix schema updateBrendan Abolivier2020-06-111-1/+1
| | |
| * | LintBrendan Abolivier2020-06-111-1/+2
| | |
| * | Save the count of unread messages to event_push_summaryBrendan Abolivier2020-06-113-20/+53
| | |
| * | Use temporary prefixes as per the MSCBrendan Abolivier2020-06-101-1/+1
| | |
| * | Use a more efficient way of calculating countersBrendan Abolivier2020-06-101-23/+20
| | |
| * | Add a new unread_counter to sync responsesBrendan Abolivier2020-06-101-2/+23
| | |
| * | Rename dont_push into mark_unreadBrendan Abolivier2020-06-101-3/+2
| | |
| * | Merge branch 'develop' into babolivier/mark_unreadBrendan Abolivier2020-06-10294-11621/+18475
| |\ \
| * | | Add experimental "dont_push" push action to suppress push for notificationsMatthew Hodgson2019-09-191-5/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a potential solution to https://github.com/vector-im/riot-web/issues/3374 and https://github.com/vector-im/riot-web/issues/5953 as raised by Mozilla at https://github.com/vector-im/riot-web/issues/10868. This lets you define a push rule action which increases the badge count (unread notification) count on a given room, but doesn't actually send a push for that notification via email or HTTP. We might want to define this as the default behaviour for group chats in future to solve https://github.com/vector-im/riot-web/issues/3268 at last. This is implemented as a string action rather than a tweak because: * Other pushers don't care about the tweak, given they won't ever get pushed * The DB can store the tweak more efficiently using the existing `notify` table. * It avoids breaking the default_notif/highlight_action optimisations. Clients which generate their own notifs (e.g. desktop notifs from Riot/Web would need to be aware of the new push action) to uphold it. An alternative way to do this would be to maintain a `msg_count` alongside `highlight_count` and `notification_count` in `unread_notifications` in sync responses. However, doing this by counting the rows in `events` since the `stream_position` of the user's last read receipt turns out to be painfully slow (~200ms), perhaps due to the size of the events table. So instead, we use the highly optimised existing event_push_actions (and event_push_actions_staging) table to maintain the counts - using the code paths which already exist for tracking unread notification counts efficiently. These queries are typically ~3ms or so. The biggest issues I see here are: * We're slightly repurposing the `notif` field on `event_push_actions` to track whether a given action actually sent a `push` or not. This doesn't seem unreasonable, but it's slightly naughty given that previously the field explicitly tracked whether `notify` was true for the action (and as a result, it was uselessly always set to 1 in the DB). * We're going to put more load on the `event_push_actions` table for all the random group chats which people had previously muted. In practice i don't think there are many of these though. * There isn't an MSC for this yet (although this comment could become one).
* | | | Refactor getting replication updates from database. (#7636)Erik Johnston2020-06-164-37/+183
| | | | | | | | | | | | The aim here is to make it easier to reason about when streams are limited and when they're not, by moving the logic into the database functions themselves. This should mean we can kill of `db_query_to_update_function` function.
* | | | Fix "argument of type 'ObservableDeferred' is not iterable" error (#7708)Patrick Cloke2020-06-161-4/+5
| | | |
* | | | Replace all remaining six usage with native Python 3 equivalents (#7704)Dagfinn Ilmari Mannsåker2020-06-1610-27/+7
| |_|/ |/| |
* | | Replace iteritems/itervalues/iterkeys with native versions. (#7692)Patrick Cloke2020-06-1512-80/+61
| | |
* | | Fix warnings about losing log context during UI auth. (#7688)Patrick Cloke2020-06-121-1/+1
| |/ |/|
* | Fix bug in account data replication stream. (#7656)Erik Johnston2020-06-093-1/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Ensure account data stream IDs are unique. The account data stream is shared between three tables, and the maximum allocated ID was tracked in a dedicated table. Updating the max ID happened outside the transaction that allocated the ID, leading to a race where if the server was restarted then the same ID could be allocated but the max ID failed to be updated, leading it to be reused. The ID generators have support for tracking across multiple tables, so we may as well use that instead of a dedicated table. * Fix bug in account data replication stream. If the same stream ID was used in both global and room account data then the getting updates for the replication stream would fail due to `heapq.merge(..)` trying to compare a `str` with a `None`. (This is because you'd have two rows like `(534, '!room')` and `(534, None)` from the room and global account data tables). Fix is just to order by stream ID, since we don't rely on the ordering beyond that. The bug where stream IDs can be reused should be fixed now, so this case shouldn't happen going forward. Fixes #7617
* | async/await get_user_id_by_threepid (#7620)Andrew Morgan2020-06-032-23/+24
| | | | | | | | | | Based on #7619 async's `get_user_id_by_threepid` and its call stack.
* | Improve performance of _get_state_groups_from_groups_txn (#7567)Dagfinn Ilmari Mannsåker2020-06-011-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The query keeps showing up in my slow query log. This changes the plan under the top-level Sort node from ``` WindowAgg (cost=280335.88..292963.15 rows=561212 width=80) (actual time=138.651..160.562 rows=27112 loops=1) -> Sort (cost=280335.88..281738.91 rows=561212 width=84) (actual time=138.597..140.622 rows=27112 loops=1) Sort Key: state_groups_state.type, state_groups_state.state_key, state_groups_state.state_group Sort Method: quicksort Memory: 4581kB -> Nested Loop (cost=2.83..226745.22 rows=561212 width=84) (actual time=21.548..47.657 rows=27112 loops=1) -> HashAggregate (cost=2.27..3.28 rows=101 width=8) (actual time=21.526..21.535 rows=20 loops=1) Group Key: state.state_group -> CTE Scan on state (cost=0.00..2.02 rows=101 width=8) (actual time=21.280..21.493 rows=20 loops=1) -> Index Scan using state_groups_state_type_idx on state_groups_state (cost=0.56..2189.40 rows=5557 width=84) (actual time=0.005..0.991 rows=1356 loops=20) Index Cond: (state_group = state.state_group) ``` to ``` Nested Loop (cost=2.83..226745.22 rows=561212 width=84) (actual time=24.194..52.834 rows=27112 loops=1) -> HashAggregate (cost=2.27..3.28 rows=101 width=8) (actual time=24.130..24.138 rows=20 loops=1) Group Key: state.state_group -> CTE Scan on state (cost=0.00..2.02 rows=101 width=8) (actual time=23.887..24.113 rows=20 loops=1) -> Index Scan using state_groups_state_type_idx on state_groups_state (cost=0.56..2189.40 rows=5557 width=84) (actual time=0.016..1.159 rows=1356 loops=20) Index Cond: (state_group = state.state_group) ``` This cuts the execution time from ~190ms to ~130ms, i.e. a reduction of ~30%. The full plans are visualised at https://explain.depesz.com/s/WpbT and https://explain.depesz.com/s/KlEk Signed-off-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
* | Use upsert when inserting read receipts (#7607)Dagfinn Ilmari Mannsåker2020-06-011-9/+4
| | | | | | | | | | Fixes #7469 Signed-off-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
* | Fix incorrect placeholder syntax in database prepartion code (#7575)Andrew Morgan2020-05-271-3/+2
| | | | | | We were using `logger` syntax which isn't supported by `Exception`s.
* | Replace device_27_unique_idx bg update with a fg one (#7562)Richard van der Hoff2020-05-265-62/+94
| | | | | | | | | | | | The bg update never managed to complete, because it kept being interrupted by transactions which want to take a lock. Just doing it in the foreground isn't that bad, and is a good deal simpler.
* | Simplify reap_monthly_active_users (#7558)Richard van der Hoff2020-05-231-59/+41
| | | | | | | | | | | | we can use `make_in_list_sql_clause` rather than doing our own half-baked equivalent, which has the benefit of working just fine with empty lists. (This has quite a lot of tests, so I think it's pretty safe)
* | Optimise some references to hs.config (#7546)Richard van der Hoff2020-05-221-8/+20
| | | | | | These are surprisingly expensive, and we only really need to do them at startup.
* | Add option to move event persistence off master (#7517)Erik Johnston2020-05-226-43/+60
| |
* | Add ability to wait for replication streams (#7542)Erik Johnston2020-05-222-3/+5
| | | | | | | | | | | | | | The idea here is that if an instance persists an event via the replication HTTP API it can return before we receive that event over replication, which can lead to races where code assumes that persisting an event immediately updates various caches (e.g. current state of the room). Most of Synapse doesn't hit such races, so we don't do the waiting automagically, instead we do so where necessary to avoid unnecessary delays. We may decide to change our minds here if it turns out there are a lot of subtle races going on. People probably want to look at this commit by commit.
* | Retry to sync out of sync device lists (#7453)Brendan Abolivier2020-05-211-12/+22
| | | | | | | | | | | | | | | | | | | | | | When a call to `user_device_resync` fails, we don't currently mark the remote user's device list as out of sync, nor do we retry to sync it. https://github.com/matrix-org/synapse/pull/6776 introduced some code infrastructure to mark device lists as stale/out of sync. This commit uses that code infrastructure to mark device lists as out of sync if processing an incoming device list update makes the device handler realise that the device list is out of sync, but we can't resync right now. It also adds a looping call to retry all failed resync every 30s. This shouldn't cause too much spam in the logs as this commit also removes the "Failed to handle device list update for..." warning logs when catching `NotRetryingDestination`. Fixes #7418
* | Fix bug in persist events when dealing with non member types. (#7548)Erik Johnston2020-05-211-2/+2
| | | | | | | | | | `_is_server_still_joined` will throw if it is given state updates with non-user ID state keys with local user leaves. This is actually rarely a problem since local leaves almost always get persisted by themselves. (I discovered this on a branch that was otherwise broken, so I haven't seen this in the wild)
* | Merge pull request #7519 from matrix-org/rav/kill_py2_codeRichard van der Hoff2020-05-186-55/+17
|\ \ | | | | | | Kill off some old python 2 code
| * | remove `builtins.buffer` code from storage codeRichard van der Hoff2020-05-153-24/+3
| | | | | | | | | | | | this is no longer needed on python 3
| * | remove to_asciiRichard van der Hoff2020-05-152-19/+11
| | | | | | | | | | | | this is a no-op on python 3.
| * | Remove `exception_to_unicode`Richard van der Hoff2020-05-151-12/+3
| | | | | | | | | | | | this is a no-op on python 3.
* | | Fix limit logic for AccountDataStream (#7384)Richard van der Hoff2020-05-151-19/+43
| | | | | | | | | | | | | | | | | | Make sure that the AccountDataStream presents complete updates, in the right order. This is much the same fix as #7337 and #7358, but applied to a different stream.
* | | Fix a couple of small typosAndrew Morgan2020-05-151-2/+2
| | |
* | | Add a worker store for search insertion. (#7516)Erik Johnston2020-05-151-47/+49
| | | | | | | | | | | | | | | This is required as both event persistence and the background update needs access to this function. It should be perfectly safe for two workers to write to that table at the same time.
* | | Prevent 0-member/null room_version rooms from appearing in group room ↵Andrew Morgan2020-05-151-14/+78
| | | | | | | | | | | | queries (#7465)
* | | Move event stream handling out of slave store. (#7491)Erik Johnston2020-05-155-19/+160
| | | | | | | | | | | | | | | This allows us to have the logic on both master and workers, which is necessary to move event persistence off master. We also combine the instantiation of ID generators from DataStore and slave stores to the base worker stores. This allows us to select which process writes events independently of the master/worker splits.
* | | Fix a small typo in the arguments of simple_update in ↵Andrew Morgan2020-05-151-1/+1
|/ / | | | | | | update_remote_profile_cache (#7511)
* | Merge tag 'v1.13.0rc2' into developRichard van der Hoff2020-05-141-1/+2
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.13.0rc2 (2020-05-14) ============================== Bugfixes -------- - Fix a long-standing bug which could cause messages not to be sent over federation, when state events with state keys matching user IDs (such as custom user statuses) were received. ([\#7376](https://github.com/matrix-org/synapse/issues/7376)) - Restore compatibility with non-compliant clients during the user interactive authentication process, fixing a problem introduced in v1.13.0rc1. ([\#7483](https://github.com/matrix-org/synapse/issues/7483)) Internal Changes ---------------- - Fix linting errors in new version of Flake8. ([\#7470](https://github.com/matrix-org/synapse/issues/7470))
| * | Stop `get_joined_users` corruption from custom statuses (#7376)Richard van der Hoff2020-05-141-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | Fix a bug where the `get_joined_users` cache could be corrupted by custom status events (or other state events with a state_key matching the user ID). The bug was introduced by #2229, but has largely gone unnoticed since then. Fixes #7099, #7373.
| * | Fix new flake8 errors (#7489)Patrick Cloke2020-05-131-2/+2
| | | | | | | | | | | | This is a cherry-pick of 1a1da60ad2c9172fe487cd38a164b39df60f4cb5 (#7470) to the release-v1.13.0 branch.
* | | Allow censoring of events to happen on workers. (#7492)Erik Johnston2020-05-131-6/+1
| | | | | | | | | This is safe as we can now write to cache invalidation stream on workers, and is required for when we move event persistence off master.
* | | SpellingErik Johnston2020-05-132-2/+2
| | |
* | | Shuffle persist event data store functions. (#7440)Erik Johnston2020-05-1317-1234/+1373
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The aim here is to get to a stage where we have a `PersistEventStore` that holds all the write methods used during event persistence, so that we can take that class out of the `DataStore` mixin and instansiate it separately. This will allow us to instansiate it on processes other than master, while also ensuring it is only available on processes that are configured to write to events stream. This is a bit of an architectural change, where we end up with multiple classes per data store (rather than one per data store we have now). We end up having: 1. Storage classes that provide high level APIs that can talk to multiple data stores. 2. Data store modules that consist of classes that must point at the same database instance. 3. Classes in a data store that can be instantiated on processes depending on config.
* | | Fix new flake8 errors (#7470)Erik Johnston2020-05-121-2/+2
| | |
* | | Allow configuration of Synapse's cache without using synctl or environment ↵Amber Brown2020-05-113-7/+7
| | | | | | | | | | | | variables (#6391)
* | | Remove unused store method get_hosts_in_room (#7448)Andrew Morgan2020-05-111-10/+0
| | |
* | | Merge branch 'release-v1.13.0' into developAndrew Morgan2020-05-111-0/+21
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * release-v1.13.0: Don't UPGRADE database rows RST indenting Put rollback instructions in upgrade notes Fix changelog typo Oh yeah, RST Absolute URL it is then Fix upgrade notes link Provide summary of upgrade issues in changelog. Fix ) Move next version notes from changelog to upgrade notes Changelog fixes 1.13.0rc1 Documentation on setting up redis (#7446) Rework UI Auth session validation for registration (#7455) Fix errors from malformed log line (#7454) Drop support for redis.dbid (#7450)
| * | Rework UI Auth session validation for registration (#7455)Patrick Cloke2020-05-081-0/+21
| | | | | | | | | | | | Be less strict about validation of UI authentication sessions during registration to match client expecations.
* | | Add room details admin endpoint (#7317)Manuel Stahl2020-05-071-0/+31
| | |
* | | Support any process writing to cache invalidation stream. (#7436)Erik Johnston2020-05-075-42/+92
| | |
* | | Merge branch 'release-v1.13.0' into developRichard van der Hoff2020-05-061-2/+2
|\| |
| * | Merge branch 'release-v1.13.0' into erikj/faster_device_lists_fetchRichard van der Hoff2020-05-052-4/+7
| |\ \
| * | | Speed up fetching device lists changes in sync.Erik Johnston2020-05-051-2/+2
| | | | | | | | | | | | | | | | | | | | Currently we copy `users_who_share_room` needlessly about three times, which is expensive when the set is large (which it can easily be).
* | | | Merge pull request #7428 from matrix-org/rav/cross_signing_keys_cacheRichard van der Hoff2020-05-061-77/+21
|\ \ \ \ | | | | | | | | | | Make get_e2e_cross_signing_key delegate to get_e2e_cross_signing_keys_bulk
| * | | | Make get_e2e_cross_signing_key delegate to get_e2e_cross_signing_keys_bulkRichard van der Hoff2020-05-061-54/+6
| | | | | | | | | | | | | | | | | | | | ... mostly because the latter has a cache.
| * | | | Fix batching for fetching cross-signing keysRichard van der Hoff2020-05-061-23/+15
| | |/ / | |/| | | | | | | | | | | | | | There's no point carefully dividing a list into batches, and then completely ignoring the batches.
* | | | Merge branch 'develop' into rav/upsert_for_device_listRichard van der Hoff2020-05-063-6/+174
|\ \ \ \
| * | | | Add MultiWriterIdGenerator. (#7281)Erik Johnston2020-05-041-2/+167
| |/ / / | | | | | | | | | | | | | | | | | | | | This will be used to coordinate stream IDs across multiple writers. Functions as the equivalent of both `StreamIdGenerator` and `SlavedIdTracker`.
| * | | Wait for current_state_events_membership before populate_stats_process_rooms ↵Richard van der Hoff2020-05-011-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (#7387) populate_stats_process_rooms was added in #5971 / v1.4.0; current_state_events_membership was added in #5706 / v1.3.0. Fixes #7380.
| * | | async/await is_server_admin (#7363)Andrew Morgan2020-05-011-3/+2
| |/ /
* | | use an upsert to update device_lists_outbound_last_successRichard van der Hoff2020-05-063-18/+71
| | |
* | | Better type annotations for simple_upsert_txnRichard van der Hoff2020-05-061-30/+43
|/ / | | | | | | most of these params don't really need to be lists.
* | Persist user interactive authentication sessions (#7302)Patrick Cloke2020-04-304-0/+318
| | | | | | | | | | By persisting the user interactive authentication sessions to the database, this fixes situations where a user hits different works throughout their auth session and also allows sessions to persist through restarts of Synapse.
* | Fix limit logic for EventsStream (#7358)Richard van der Hoff2020-04-291-4/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Factor out functions for injecting events into database I want to add some more flexibility to the tools for injecting events into the database, and I don't want to clutter up HomeserverTestCase with them, so let's factor them out to a new file. * Rework TestReplicationDataHandler This wasn't very easy to work with: the mock wrapping was largely superfluous, and it's useful to be able to inspect the received rows, and clear out the received list. * Fix AssertionErrors being thrown by EventsStream Part of the problem was that there was an off-by-one error in the assertion, but also the limit logic was too simple. Fix it all up and add some tests.
* | Return total number of users and profile attributes in admin users endpoint ↵Manuel Stahl2020-04-281-29/+39
| | | | | | | | | | (#6881) Signed-off-by: Manuel Stahl <manuel.stahl@awesome-technologies.de>
* | Fix EventsStream raising assertions when it falls behindRichard van der Hoff2020-04-241-12/+34
| | | | | | | | | | | | | | | | | | | | Figuring out how to correctly limit updates from this stream without dropping entries is far more complicated than just counting the number of rows being returned. We need to consider each query separately and, if any one query hits the limit, truncate the results from the others. I think this also fixes some potentially long-standing bugs where events or state changes could get missed if we hit the limit on either query.