Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Handle pusher being deleted during processing. | Erik Johnston | 2019-08-01 | 1 | -7/+20 |
| | | | | | Instead of throwing a StoreError lets break out of processing loop and mark the pusher as stopped. | ||||
* | Replace returnValue with return (#5736) | Amber Brown | 2019-07-23 | 1 | -9/+9 |
| | |||||
* | Run Black. (#5482) | Amber Brown | 2019-06-20 | 1 | -116/+110 |
| | |||||
* | Make starting pushers faster during start up | Erik Johnston | 2019-04-02 | 1 | -2/+10 |
| | | | | | | | | | | | We start all pushers on start up and immediately start a background process to fetch push to send. This makes start up incredibly painful when dealing with many pushers. Instead, let's do a quick fast DB check to see if there *may* be push to send and only start the background processes for those pushers. We also stagger starting up and doing those checks so that we don't try and handle all pushers at once. | ||||
* | Correctly handle null data in HttpPusher | Erik Johnston | 2019-02-22 | 1 | -0/+5 |
| | |||||
* | Add prometheus metrics for number of badge update pushes. (#4709) | Richard van der Hoff | 2019-02-22 | 1 | -8/+25 |
| | | | | | | We're counting the number of push notifications, but not the number of badges; I'd like to see if they are significant. | ||||
* | Logging improvements for the pusher (#4691) | Richard van der Hoff | 2019-02-20 | 1 | -8/+8 |
| | |||||
* | Clean up event accesses and tests | Erik Johnston | 2018-11-02 | 1 | -2/+2 |
| | | | | | This is in preparation to refactor FrozenEvent to support different event formats for different room versions | ||||
* | sanity-check the is_processing flag | Richard van der Hoff | 2018-10-24 | 1 | -4/+7 |
| | | | | ... and rename it, for even more sanity | ||||
* | Make on_started synchronous too | Richard van der Hoff | 2018-10-22 | 1 | -1/+0 |
| | | | | | | This brings it into line with on_new_notifications and on_new_receipts. It requires a little bit of hoop-jumping in EmailPusher to load the throttle params before the first loop. | ||||
* | Remove redundant run_as_background_process() from pusherpool | Richard van der Hoff | 2018-10-22 | 1 | -2/+0 |
| | | | | | | | `on_new_notifications` and `on_new_receipts` in `HttpPusher` and `EmailPusher` now always return synchronously, so we can remove the `defer.gatherResults` on their results, and the `run_as_background_process` wrappers can be removed too because the PusherPool methods will now complete quickly enough. | ||||
* | Give pushers their own background logcontext | Richard van der Hoff | 2018-10-22 | 1 | -34/+30 |
| | | | | | | | | Each pusher has its own loop which runs for as long as it has work to do. This should run in its own background thread with its own logcontext, as other similar loops elsewhere in the system do - which means that CPU usage is consistently attributed to that loop, rather than to whatever request happened to start the loop. | ||||
* | merge (#3576) | Amber Brown | 2018-09-14 | 1 | -1/+6 |
| | |||||
* | run isort | Amber Brown | 2018-07-09 | 1 | -3/+3 |
| | |||||
* | Remove all global reactor imports & pass it around explicitly (#3424) | Amber Brown | 2018-06-25 | 1 | -2/+4 |
| | |||||
* | fixes | Amber Brown | 2018-05-22 | 1 | -2/+2 |
| | |||||
* | replacing portions | Amber Brown | 2018-05-21 | 1 | -9/+4 |
| | |||||
* | make imports local | Adrian Tschira | 2018-04-28 | 1 | -2/+2 |
| | | | | Signed-off-by: Adrian Tschira <nota@notafile.com> | ||||
* | Improve exception handling for background processes | Richard van der Hoff | 2018-04-27 | 1 | -1/+4 |
| | | | | | | | | | | | | | | | | | | There were a bunch of places where we fire off a process to happen in the background, but don't have any exception handling on it - instead relying on the unhandled error being logged when the relevent deferred gets garbage-collected. This is unsatisfactory for a number of reasons: - logging on garbage collection is best-effort and may happen some time after the error, if at all - it can be hard to figure out where the error actually happened. - it is logged as a scary CRITICAL error which (a) I always forget to grep for and (b) it's not really CRITICAL if a background process we don't care about fails. So this is an attempt to add exception handling to everything we fire off into the background. | ||||
* | Better logging when pushes fail | Richard van der Hoff | 2018-01-29 | 1 | -2/+8 |
| | |||||
* | add appid/device_display_name to to pusher logging | Richard van der Hoff | 2018-01-29 | 1 | -2/+2 |
| | |||||
* | Fix logging and add user_id | Richard van der Hoff | 2018-01-22 | 1 | -2/+3 |
| | |||||
* | logging and debug for http pusher | Richard van der Hoff | 2018-01-22 | 1 | -4/+20 |
| | |||||
* | Rename redact_content option to include_content | David Baker | 2017-11-08 | 1 | -1/+2 |
| | | | | | | | | | | | | | | | | | | The redact_content option never worked because it read the wrong config section. The PR introducing it (https://github.com/matrix-org/synapse/pull/2301) had feedback suggesting the name be changed to not re-use the term 'redact' but this wasn't incorporated. This reanmes the option to give it a less confusing name, and also means that people who've set the redact_content option won't suddenly see a behaviour change when upgrading synapse, but instead can set include_content if they want to. This PR also updates the wording of the config comment to clarify that this has no effect on event_id_only push. Includes https://github.com/matrix-org/synapse/pull/2422 | ||||
* | replace 'except:' with 'except Exception:' | Richard van der Hoff | 2017-10-23 | 1 | -3/+3 |
| | | | | what could possibly go wrong | ||||
* | Also include the room_id | David Baker | 2017-09-18 | 1 | -0/+1 |
| | | | | as really it's part of the event ID | ||||
* | Use .get - it's much shorter | David Baker | 2017-09-18 | 1 | -1/+1 |
| | |||||
* | Add support for event_id_only push format | David Baker | 2017-09-18 | 1 | -0/+19 |
| | | | | | | | Param in the data dict of a pusher that tells an HTTP pusher to send just the event_id of the event it's notifying about and the notification counts. For clients that want to go & fetch the body of the event themselves anyway. | ||||
* | Fix TravisCI tests for PR #2301 | Caleb James DeLisle | 2017-06-23 | 1 | -1/+1 |
| | |||||
* | Add configuration parameter to allow redaction of content from push messages ↵ | Caleb James DeLisle | 2017-06-23 | 1 | -1/+1 |
| | | | | for google/apple devices | ||||
* | Fix up push to use get_current_state_ids | Erik Johnston | 2016-08-25 | 1 | -1/+1 |
| | |||||
* | Ignore AlreadyCalled errors on timer cancel | Erik Johnston | 2016-07-31 | 1 | -1/+6 |
| | |||||
* | Create separate methods for getting messages to push | Mark Haines | 2016-07-28 | 1 | -1/+2 |
| | | | | | | | | | | | for the email and http pushers rather than trying to make a single method that will work with their conflicting requirements. The http pusher needs to get the messages in ascending stream order, and doesn't want to miss a message. The email pusher needs to get the messages in descending timestamp order, and doesn't mind if it misses messages. | ||||
* | Use similar naming we use in email notifs for push | David Baker | 2016-06-24 | 1 | -3/+6 |
| | | | | Fixes https://github.com/vector-im/vector-web/issues/1654 | ||||
* | Optionally split out the pushers into a separate process | Mark Haines | 2016-04-21 | 1 | -1/+1 |
| | |||||
* | Add missing yield | Erik Johnston | 2016-04-14 | 1 | -1/+1 |
| | |||||
* | Rename log context | Erik Johnston | 2016-04-14 | 1 | -1/+1 |
| | |||||
* | Make send_badge private | Erik Johnston | 2016-04-14 | 1 | -2/+2 |
| | |||||
* | Add necessary logging contexts | Erik Johnston | 2016-04-14 | 1 | -24/+25 |
| | |||||
* | Add extra Measure | Erik Johnston | 2016-04-14 | 1 | -14/+16 |
| | |||||
* | Run unsafe proces in a loop until we've caught up | David Baker | 2016-04-11 | 1 | -4/+11 |
| | | | | and wrap unsafe process in a try block | ||||
* | Actually check if we;re processing | David Baker | 2016-04-08 | 1 | -0/+2 |
| | |||||
* | Make sure max stream ordering only increases | David Baker | 2016-04-08 | 1 | -1/+1 |
| | |||||
* | Unsafe process should call itself if the max has changed | David Baker | 2016-04-08 | 1 | -0/+3 |
| | |||||
* | Comment why unsafe process is unsafe | David Baker | 2016-04-08 | 1 | -0/+5 |
| | |||||
* | Only pass in what we need | David Baker | 2016-04-07 | 1 | -3/+5 |
| | |||||
* | Wrap process in a flag so we don't process whist already processing. | David Baker | 2016-04-07 | 1 | -0/+9 |
| | |||||
* | Add measure blocks | David Baker | 2016-04-07 | 1 | -5/+10 |
| | |||||
* | Add comments on min_stream_id | David Baker | 2016-04-07 | 1 | -0/+2 |
| | | | | saying that the min stream id won't be completely accurate all the time | ||||
* | Remove code that's now been obsoleted or moved elsewhere | David Baker | 2016-04-07 | 1 | -1/+1 |
| | |||||
* | Send badge count pushes. | David Baker | 2016-04-07 | 1 | -16/+29 |
| | | | | Also fix bugs with retrying. | ||||
* | Make pushers use the event_push_actions table instead of listening on an ↵ | David Baker | 2016-04-06 | 1 | -38/+166 |
| | | | | | | | event stream & running the rules again. Sytest passes, but remaining to do: * Make badges work again * Remove old, unused code | ||||
* | Remove dead code for setting device specific rules. | Mark Haines | 2016-02-18 | 1 | -2/+1 |
| | | | | | | It wasn't possible to hit the code from the API because of a typo in parsing the request path. Since no-one was using the feature we might as well remove the dead code. | ||||
* | Merge branch 'develop' into push_badge_counts | David Baker | 2016-01-19 | 1 | -4/+4 |
|\ | |||||
| * | Rename 'user_name' to 'user_id' in push to make it consistent with the rest ↵ | Mark Haines | 2016-01-13 | 1 | -3/+3 |
| | | | | | | | | of the code | ||||
* | | Use the unread notification count to send accurate badge counts in push ↵ | David Baker | 2016-01-13 | 1 | -7/+7 |
|/ | | | | notifications. | ||||
* | copyrights | Matthew Hodgson | 2016-01-07 | 1 | -1/+1 |
| | |||||
* | Reuse a single http client, rather than creating new ones | Mark Haines | 2015-12-02 | 1 | -4/+3 |
| | |||||
* | Dial down logging for failed pushers | David Baker | 2015-03-06 | 1 | -1/+1 |
| | |||||
* | Add attribute so push gateways can tell if a member event is about the user ↵ | David Baker | 2015-03-06 | 1 | -0/+1 |
| | | | | in question | ||||
* | Send room ID in http notifications so clients know which room to go to if ↵ | David Baker | 2015-02-19 | 1 | -0/+1 |
| | | | | the user responds to the notification. | ||||
* | s/instance_handle/profile_tag/ | David Baker | 2015-02-03 | 1 | -2/+2 |
| | |||||
* | Ignore empty strings for display names & room names in notifications | David Baker | 2015-01-31 | 1 | -2/+2 |
| | |||||
* | Include content in notification pokes | David Baker | 2015-01-29 | 1 | -0/+2 |
| | |||||
* | Change 'from' in notification pokes to 'sender' to match client API v2. Send ↵ | David Baker | 2015-01-29 | 1 | -5/+4 |
| | | | | sender display names where they exist. | ||||
* | Code style fixes. | Mark Haines | 2015-01-29 | 1 | -4/+4 |
| | |||||
* | It is 2015 | David Baker | 2015-01-28 | 1 | -1/+1 |
| | |||||
* | Reset badge count to zero when last active time is bumped | David Baker | 2015-01-28 | 1 | -3/+35 |
| | |||||
* | Support membership events and more camelcase/underscores | David Baker | 2015-01-26 | 1 | -4/+4 |
| | |||||
* | Use push settings! | David Baker | 2015-01-23 | 1 | -4/+5 |
| | |||||
* | use underscores everywhere, not camelcase. | David Baker | 2015-01-20 | 1 | -3/+3 |
| | |||||
* | add instance_handles to pushers so we have a way to refer to them even if ↵ | David Baker | 2015-01-20 | 1 | -1/+2 |
| | | | | the push token changes. | ||||
* | Send room name and first alias in notification poke. | David Baker | 2015-01-15 | 1 | -3/+13 |
| | |||||
* | Honour the 'rejected' return from push gateways | David Baker | 2015-01-13 | 1 | -5/+10 |
| | | | | | | | Add a timestamp to push tokens so we know the last time they we got them from the device. Send it to the push gateways so it can determine whether its failure is more recent than the token. Stop and remove pushers that have been rejected. | ||||
* | after a few rethinks, a working implementation of pushers. | David Baker | 2014-12-18 | 1 | -12/+13 |
| | |||||
* | Update to app_id / app_instance_id (partially) and mangle to be PEP8 compliant. | David Baker | 2014-12-03 | 1 | -33/+42 |
| | |||||
* | More work on pushers. Attempt to do HTTP pokes. Not sure if the actual HTTP ↵ | David Baker | 2014-11-21 | 1 | -4/+51 |
| | | | | pokes work or not yet but the retry semantics are pretty good. | ||||
* | remove random half-line | David Baker | 2014-11-19 | 1 | -1/+0 |
| | |||||
* | Start creating a module to do generic notifications (just prints them to ↵ | David Baker | 2014-11-19 | 1 | -0/+40 |
stdout currently!) |