summary refs log tree commit diff
path: root/synapse/notifier.py (unfollow)
Commit message (Collapse)AuthorFilesLines
2023-04-27Add a nix flake that sets up a development environment (via devenv) (#15495)Andrew Morgan4-1/+484
2023-04-27Disable push rule evaluation for rooms excluded from sync (#15361)mcalinghee2-0/+2
* no push for excluded room from sync * add changelog Signed-off-by: Maghen Calinghee <maghen.calinghee@beta.gouv.fr> * correct changelog
2023-04-27Docs: Add Nginx loadbalancing example with sticky mxid for workers (#15411)Tatu Wikman2-2/+65
* Docs: Add Nginx loadbalancing example with sticky mxid for workers Add example nginx configuration snippet that * does load balancing for workers * respects mxid part of the token * from both url parameter and auth header * and handles since parameter Thanks to @olmari for pushing me to write this and testing the configs Signed-off-by: Tatu Wikman <tatu.wikman@gmail.com> * Add changelog entry Signed-off-by: Tatu Wikman <tatu.wikman@gmail.com> * Update codeblock formatter Co-authored-by: Dirk Klimpel <5740567+dklimpel@users.noreply.github.com> * Remove indirectly related nginx-config Signed-off-by: Sami Olmari <sami@olmari.fi> * Proper definition of action how to target username for worker Signed-off-by: Sami Olmari <sami@olmari.fi> * Change "nginx" to general "reverse proxy" as it's concept now. Signed-off-by: Sami Olmari <sami@olmari.fi> * Wording in better English Co-authored-by: Tatu Wikman <tatu.wikman@gmail.com> * rename changelog entry to have correct extension --------- Signed-off-by: Tatu Wikman <tatu.wikman@gmail.com> Signed-off-by: Sami Olmari <sami@olmari.fi> Co-authored-by: Dirk Klimpel <5740567+dklimpel@users.noreply.github.com> Co-authored-by: Sami Olmari <sami@olmari.fi> Co-authored-by: Sami Olmari <sami+github@olmari.fi>
2023-04-26Add column `full_user_id` to tables `profiles` and `user_filters`. (#15458)Shay17-74/+186
2023-04-26Add a module API to send an HTTP push notification (#15387)Mathieu Velten3-77/+160
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
2023-04-26Do not return extensible events experimental push rules by default. (#15494)Patrick Cloke2-1/+5
2023-04-26Add admin endpoint to query room sizes (#15482)Erik Johnston6-1/+195
2023-04-25Update the `check_schema_delta` script to account for when the schema ↵Shay2-2/+25
version has been bumped locally (#15466)
2023-04-25Add unstable /keys/claim endpoint which always returns fallback keys. (#15462)Patrick Cloke9-29/+371
It can be useful to always return the fallback key when attempting to claim keys. This adds an unstable endpoint for `/keys/claim` which always returns fallback keys in addition to one-time-keys. The fallback key(s) are not marked as "used" unless there are no corresponding OTKs. This is currently defined in MSC3983 (although likely to be split out to a separate MSC). The endpoint shape may change or be requested differently (i.e. a keyword parameter on the current endpoint), but the core logic should be reasonable.
2023-04-251.82.0 v1.82.0David Robertson3-1/+13
2023-04-25Re re introduce membership tables event stream ordering (#15356)Nick Mills-Barrett7-12/+163
2023-04-25Experimental support for MSC3970: per-device transaction IDs (#15318)Quentin Gliech11-48/+265
2023-04-24Finish type hints for federation client HTTP code. (#15465)Patrick Cloke7-42/+82
2023-04-24Ask bug reporters to provide logs as text (#15479)David Robertson2-1/+2
2023-04-24Bump types-jsonschema from 4.17.0.6 to 4.17.0.7 (#15476)dependabot[bot]2-3/+4
* Bump types-jsonschema from 4.17.0.6 to 4.17.0.7 Bumps [types-jsonschema](https://github.com/python/typeshed) from 4.17.0.6 to 4.17.0.7. - [Release notes](https://github.com/python/typeshed/releases) - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-jsonschema dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-04-24Bump types-netaddr from 0.8.0.7 to 0.8.0.8 (#15475)dependabot[bot]2-3/+4
* Bump types-netaddr from 0.8.0.7 to 0.8.0.8 Bumps [types-netaddr](https://github.com/python/typeshed) from 0.8.0.7 to 0.8.0.8. - [Release notes](https://github.com/python/typeshed/releases) - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-netaddr dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-04-24Bump cryptography from 40.0.1 to 40.0.2 (#15474)dependabot[bot]2-20/+21
* Bump cryptography from 40.0.1 to 40.0.2 Bumps [cryptography](https://github.com/pyca/cryptography) from 40.0.1 to 40.0.2. - [Release notes](https://github.com/pyca/cryptography/releases) - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pyca/cryptography/compare/40.0.1...40.0.2) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-04-24Bump pyasn1-modules from 0.2.8 to 0.3.0 (#15473)dependabot[bot]2-6/+7
* Bump pyasn1-modules from 0.2.8 to 0.3.0 Bumps [pyasn1-modules](https://github.com/pyasn1/pyasn1-modules) from 0.2.8 to 0.3.0. - [Release notes](https://github.com/pyasn1/pyasn1-modules/releases) - [Changelog](https://github.com/pyasn1/pyasn1-modules/blob/main/CHANGES.txt) - [Commits](https://github.com/pyasn1/pyasn1-modules/compare/v0.2.8...v0.3.0) --- updated-dependencies: - dependency-name: pyasn1-modules dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-04-24Bump types-pyyaml from 6.0.12.8 to 6.0.12.9 (#15471)dependabot[bot]2-3/+4
* Bump types-pyyaml from 6.0.12.8 to 6.0.12.9 Bumps [types-pyyaml](https://github.com/python/typeshed) from 6.0.12.8 to 6.0.12.9. - [Release notes](https://github.com/python/typeshed/releases) - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-pyyaml dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-04-21Remove legacy code of single user device resync api (#15418)Alok Kumar Singh6-122/+26
* Removed single-user resync usage and updated it to use multi-user counterpart Signed-off-by: Alok Kumar Singh alokaks601@gmail.com
2023-04-20Modify StoreKeyFetcher to read from server_keys_json. (#15417)Patrick Cloke8-76/+162
Before this change: * `PerspectivesKeyFetcher` and `ServerKeyFetcher` write to `server_keys_json`. * `PerspectivesKeyFetcher` also writes to `server_signature_keys`. * `StoreKeyFetcher` reads from `server_signature_keys`. After this change: * `PerspectivesKeyFetcher` and `ServerKeyFetcher` write to `server_keys_json`. * `PerspectivesKeyFetcher` also writes to `server_signature_keys`. * `StoreKeyFetcher` reads from `server_keys_json`. This results in `StoreKeyFetcher` now using the results from `ServerKeyFetcher` in addition to those from `PerspectivesKeyFetcher`, i.e. keys which are directly fetched from a server will now be pulled from the database instead of refetched. An additional minor change is included to avoid creating a `PerspectivesKeyFetcher` (and checking it) if no `trusted_key_servers` are configured. The overall impact of this should be better usage of cached results: * If a server has no trusted key servers configured then it should reduce how often keys are fetched. * if a server's trusted key server does not have a requested server's keys cached then it should reduce how often keys are directly fetched.
2023-04-18Speedup tests by caching HomeServerConfig instances (#15284)Val Lorentz2-2/+61
These two lines: ``` config_obj = HomeServerConfig() config_obj.parse_config_dict(config, "", "") ``` are called many times with the exact same value for `config`. As the test suite is CPU-bound and non-negligeably time is spent in `parse_config_dict`, this saves ~5% on the overall runtime of the Trial test suite (tested with both `-j2` and `-j12` on a 12t CPU). This is sadly rather limited, as the cache cannot be shared between processes (it contains at least jinja2.Template and RLock objects which aren't pickleable), and Trial tends to run close tests in different processes.
2023-04-18Revert "Bump pillow from 9.4.0 to 9.5.0 (#15444)" v1.82.0rc1Olivier Wilkinson (reivilibre)1-71/+82
This reverts commit efab11825184a4251554f1e412549a4c23329d8b.
2023-04-181.82.0rc1Olivier Wilkinson (reivilibre)45-43/+76
2023-04-18Move Spam Checker callbacks to a dedicated file (#15453)Andrew Morgan20-73/+107
2023-04-17Add a note to the config documentation that the 'delete_stale_devices_after' ↵Andrew Morgan2-0/+5
job always runs on the main process (#15452)
2023-04-17Switch `InstanceLocationConfig` to a pydantic `BaseModel` (#15431)Jason Little3-10/+71
* Switch InstanceLocationConfig to a pydantic BaseModel, apply Strict* types and add a few helper methods(that will make more sense in follow up work). Co-authored-by: David Robertson <davidr@element.io>
2023-04-17Bump mypy from 1.0.0 to 1.0.1 (#15447)dependabot[bot]2-27/+28
* Bump mypy from 1.0.0 to 1.0.1 Bumps [mypy](https://github.com/python/mypy) from 1.0.0 to 1.0.1. - [Release notes](https://github.com/python/mypy/releases) - [Commits](https://github.com/python/mypy/compare/v1.0.0...v1.0.1) --- updated-dependencies: - dependency-name: mypy dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-04-17Bump psycopg2 from 2.9.5 to 2.9.6 (#15448)dependabot[bot]2-14/+15
* Bump psycopg2 from 2.9.5 to 2.9.6 Bumps [psycopg2](https://github.com/psycopg/psycopg2) from 2.9.5 to 2.9.6. - [Release notes](https://github.com/psycopg/psycopg2/releases) - [Changelog](https://github.com/psycopg/psycopg2/blob/master/NEWS) - [Commits](https://github.com/psycopg/psycopg2/commits/2.9.6) --- updated-dependencies: - dependency-name: psycopg2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-04-17Bump types-pyopenssl from 23.1.0.0 to 23.1.0.2 (#15446)dependabot[bot]2-3/+4
* Bump types-pyopenssl from 23.1.0.0 to 23.1.0.2 Bumps [types-pyopenssl](https://github.com/python/typeshed) from 23.1.0.0 to 23.1.0.2. - [Release notes](https://github.com/python/typeshed/releases) - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-pyopenssl dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-04-17Bump furo from 2023.3.23 to 2023.3.27 (#15445)dependabot[bot]2-3/+4
* Bump furo from 2023.3.23 to 2023.3.27 Bumps [furo](https://github.com/pradyunsg/furo) from 2023.3.23 to 2023.3.27. - [Release notes](https://github.com/pradyunsg/furo/releases) - [Changelog](https://github.com/pradyunsg/furo/blob/main/docs/changelog.md) - [Commits](https://github.com/pradyunsg/furo/compare/2023.03.23...2023.03.27) --- updated-dependencies: - dependency-name: furo dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-04-17Bump pillow from 9.4.0 to 9.5.0 (#15444)dependabot[bot]2-82/+72
* Bump pillow from 9.4.0 to 9.5.0 Bumps [pillow](https://github.com/python-pillow/Pillow) from 9.4.0 to 9.5.0. - [Release notes](https://github.com/python-pillow/Pillow/releases) - [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst) - [Commits](https://github.com/python-pillow/Pillow/compare/9.4.0...9.5.0) --- updated-dependencies: - dependency-name: pillow dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-04-17Bump serde from 1.0.159 to 1.0.160 (#15443)dependabot[bot]2-4/+5
* Bump serde from 1.0.159 to 1.0.160 Bumps [serde](https://github.com/serde-rs/serde) from 1.0.159 to 1.0.160. - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](https://github.com/serde-rs/serde/compare/v1.0.159...v1.0.160) --- updated-dependencies: - dependency-name: serde dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-04-17Bump dawidd6/action-download-artifact from 2.26.1 to 2.27.0 (#15441)dependabot[bot]2-1/+2
* Bump dawidd6/action-download-artifact from 2.26.1 to 2.27.0 Bumps [dawidd6/action-download-artifact](https://github.com/dawidd6/action-download-artifact) from 2.26.1 to 2.27.0. - [Release notes](https://github.com/dawidd6/action-download-artifact/releases) - [Commits](https://github.com/dawidd6/action-download-artifact/compare/7132ab516fba5f602fafae6fdd4822afa10db76f...246dbf436b23d7c49e21a7ab8204ca9ecd1fe615) --- updated-dependencies: - dependency-name: dawidd6/action-download-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-04-17Bump serde_json from 1.0.95 to 1.0.96 (#15442)dependabot[bot]2-2/+3
* Bump serde_json from 1.0.95 to 1.0.96 Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.95 to 1.0.96. - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](https://github.com/serde-rs/json/compare/v1.0.95...v1.0.96) --- updated-dependencies: - dependency-name: serde_json dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-04-14Refactor `SimpleHttpClient` to pull out reusable methods (#15427)Jason Little2-56/+77
Pulls out some methods to `BaseHttpClient` to eventually be reused in other contexts.
2023-04-14More precise type for LoggingTransaction.execute (#15432)David Robertson4-14/+32
* More precise type for LoggingTransaction.execute * Add an annotation for stream_ordering_month_ago This would have spotted the error that was fixed in "Add comma missing from #15382. (#15429)"
2023-04-14Disable directory listing for `StaticResource` (#15438)Dirk Klimpel2-0/+11
2023-04-14Load `/capabilities` endpoint on workers (#15436)Dirk Klimpel5-1/+5
2023-04-14User directory background update speedup (#15435)Erik Johnston2-45/+45
c.f. #15264 The two changes are: 1. Add indexes so that the select / deletes don't do sequential scans 2. Don't repeatedly call `SELECT count(*)` each iteration, as that's slow
2023-04-14Delete pushers after calling on_logged_out module hook on device delete (#15410)Mathieu Velten4-3/+58
2023-04-14Convert async to normal tests in `TestSSOHandler` (#15433)Dirk Klimpel2-4/+5
* Convert async to normal tests in `TestSSOHandler` * newsfile
2023-04-14Load `/directory/room/{roomAlias}` endpoint on workers (#15333)Dirk Klimpel6-6/+12
* Enable `directory` * move to worker store * newsfile * disable `ClientDirectoryListServer` and `ClientAppserviceDirectoryListServer` for workers
2023-04-13Remove registration fallback code. (#15405)Patrick Cloke10-227/+17
The registration fallback is broken and unspecced. This removes it since there is no plan to spec it. Note that this does not modify the login fallback code.
2023-04-13Improve robustness when handling a perspective key response by deduplicating ↵reivilibre6-28/+43
received server keys. (#15423) * Change `store_server_verify_keys` to take a `Mapping[(str, str), FKR]` This is because we already can't handle duplicate keys — leads to cardinality violation * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-04-13Add comma missing from #15382. (#15429)reivilibre2-1/+2
* Add missing comma * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-04-13Implement MSC2174: move redacts to a content property. (#15395)Patrick Cloke8-17/+87
This moves `redacts` from being a top-level property to a `content` property in a new room version. MSC2176 (which was previously implemented) states to not `redact` this property.
2023-04-13Only load the SSO redirect servlet if SSO is enabled. (#15421)Dirk Klimpel2-1/+7
2023-04-13Disable loading `RefreshTokenServlet` on workers (#15428)Dirk Klimpel2-1/+5
2023-04-12Throw if the appservice config list is the wrong type (#15425)Will Hunt3-4/+51
* raise a ConfigError on an invalid app_service_config_files * changelog * Move config check to read_config * Add test * Ensure list also contains strings
2023-04-111.81.0 v1.81.0Erik Johnston3-3/+15
2023-04-10Bump immutabledict from 2.2.3 to 2.2.4 (#15415)dependabot[bot]2-3/+4
2023-04-10Bump sentry-sdk from 1.17.0 to 1.19.1 (#15414)dependabot[bot]2-3/+5
2023-04-10Bump parameterized from 0.8.1 to 0.9.0 (#15412)dependabot[bot]2-4/+5
2023-04-10Bump types-pillow from 9.4.0.17 to 9.4.0.19 (#15413)dependabot[bot]2-3/+4
2023-04-10Bump black from 23.1.0 to 23.3.0 (#15372)dependabot[bot]2-26/+27
2023-04-10Attempt to fix weird mypy failures on ignored files. (#15409)David Robertson2-3/+55
By inlining the typechecking job from backend-meta. This seems to resolve odd errors (maybe due to caching?) to have been seen on Dependabot PRs.
2023-04-06Implement MSC2175: remove the creator field from create events. (#15394)Patrick Cloke8-24/+72
2023-04-06Bump pyopenssl from 23.1.0 to 23.1.1 (#15373)dependabot[bot]2-3/+4
* Bump pyopenssl from 23.1.0 to 23.1.1 Bumps [pyopenssl](https://github.com/pyca/pyopenssl) from 23.1.0 to 23.1.1. - [Release notes](https://github.com/pyca/pyopenssl/releases) - [Changelog](https://github.com/pyca/pyopenssl/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pyca/pyopenssl/compare/23.1.0...23.1.1) --- updated-dependencies: - dependency-name: pyopenssl dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com> Co-authored-by: Mathieu Velten <mathieuv@matrix.org> Co-authored-by: David Robertson <davidr@element.io>
2023-04-06Trust dtolnay/rust-toolchain (#15406)David Robertson4-77/+18
* Trust dtolnay/rust-toolchain The author is a big deal in the Rust world and I'm happy to trust them. I'm also bored of the dependabot updates tbh. * Changelog
2023-04-06Bump types-psycopg2 from 2.9.21.8 to 2.9.21.9 (#15374)dependabot[bot]2-3/+4
* Bump types-psycopg2 from 2.9.21.8 to 2.9.21.9 Bumps [types-psycopg2](https://github.com/python/typeshed) from 2.9.21.8 to 2.9.21.9. - [Release notes](https://github.com/python/typeshed/releases) - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-psycopg2 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com> Co-authored-by: Mathieu Velten <mathieuv@matrix.org> Co-authored-by: David Robertson <davidr@element.io>
2023-04-06Bump types-netaddr from 0.8.0.6 to 0.8.0.7 (#15375)dependabot[bot]2-3/+4
* Bump types-netaddr from 0.8.0.6 to 0.8.0.7 Bumps [types-netaddr](https://github.com/python/typeshed) from 0.8.0.6 to 0.8.0.7. - [Release notes](https://github.com/python/typeshed/releases) - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-netaddr dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com> Co-authored-by: David Robertson <davidr@element.io>
2023-04-06Bump types-opentracing from 2.4.10.3 to 2.4.10.4 (#15376)dependabot[bot]2-3/+4
* Bump types-opentracing from 2.4.10.3 to 2.4.10.4 Bumps [types-opentracing](https://github.com/python/typeshed) from 2.4.10.3 to 2.4.10.4. - [Release notes](https://github.com/python/typeshed/releases) - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-opentracing dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-04-06Bump dawidd6/action-download-artifact from 2.26.0 to 2.26.1 (#15404)dependabot[bot]2-1/+2
* Bump dawidd6/action-download-artifact from 2.26.0 to 2.26.1 Bumps [dawidd6/action-download-artifact](https://github.com/dawidd6/action-download-artifact) from 2.26.0 to 2.26.1. - [Release notes](https://github.com/dawidd6/action-download-artifact/releases) - [Commits](https://github.com/dawidd6/action-download-artifact/compare/5e780fc7bbd0cac69fc73271ed86edf5dcb72d67...7132ab516fba5f602fafae6fdd4822afa10db76f) --- updated-dependencies: - dependency-name: dawidd6/action-download-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-04-06Don't keep old stream_ordering_to_exterm around (#15382)Erik Johnston3-10/+53
2023-04-061.81.0rc2 v1.81.0rc2David Robertson5-4/+23
2023-04-06Use setup-go instead of relying on go 1.17 to exist (#15403)David Robertson5-10/+7
* Use setup-go instead of relying on 1.17 to exist See https://github.com/actions/runner-images/issues/7276 * Changelog
2023-04-05Implement MSC3989 to redact the origin field. (#15393)Patrick Cloke4-1/+49
This will be done in a future room version, for now an unstable room version is added which redacts the origin field.
2023-04-05Fix the 'set_device_id_for_pushers_txn' background update. (#15391)Quentin Gliech2-1/+2
Refer to the correct field from the response when updating the background update progress.
2023-04-04Delete server-side backup keys when deactivating an account. (#15181)Shay6-3/+291
2023-04-04Update changelog v1.81.0rc1Erik Johnston1-5/+18
2023-04-041.81.0rc1Erik Johnston50-49/+76
2023-04-04Speed up membership queries for users with forgotten rooms (#15385)Erik Johnston3-1/+31
2023-04-04Fix a rare bug where initial /syncs would fail (#15383)Sean Quah2-5/+20
This change fixes a rare bug where initial /syncs would fail with a `KeyError` under the following circumstances: 1. A user fast joins a remote room. 2. The user is kicked from the room before the room's full state has been synced. 3. A second local user fast joins the room. 4. Events are backfilled into the room with a higher topological ordering than the original user's leave. They are assigned a negative stream ordering. It's not clear how backfill happened here, since it is expected to be equivalent to syncing the full state. 5. The second local user leaves the room before the room's full state has been synced. The homeserver does not complete the sync. 6. The original user performs an initial /sync with lazy_load_members enabled. * Because they were kicked from the room, the room is included in the /sync response even though the include_leave option is not specified. * To populate the room's timeline, `_load_filtered_recents` / `get_recent_events_for_room` fetches events with a lower stream ordering than the leave event and picks the ones with the highest topological orderings (which are most recent). This captures the backfilled events after the leave, since they have a negative stream ordering. These events are filtered out of the timeline, since the user was not in the room at the time and cannot view them. The sync code ends up with an empty timeline for the room that notably does not include the user's leave event. This seems buggy, but at least we don't disclose events the user isn't allowed to see. * Normally, `compute_state_delta` would fetch the state at the start and end of the room's timeline to generate the sync response. Since the timeline is empty, it fetches the state at `min(now, last event in the room)`, which corresponds with the second user's leave. The state during the entirety of the second user's membership does not include the membership for the first user because of partial state. This part is also questionable, since we are fetching state from outside the bounds of the user's membership. * `compute_state_delta` then tries and fails to find the user's membership in the auth events of timeline events. Because there is no timeline event whose auth events are expected to contain the user's membership, a `KeyError` is raised. Also contains a drive-by fix for a separate unlikely race condition. Signed-off-by: Sean Quah <seanq@matrix.org>
2023-04-04Note that Synapse 1.74 queued a user dir rebuild (#15386)David Robertson2-0/+12
* Note that Synapse 1.74 queued a user dir rebuild * Changelog
2023-04-03Build Debian packages for Ubuntu 23.04 Lunar Lobster (#15381)Sean Quah2-0/+2
Signed-off-by: Sean Quah <seanq@matrix.org>
2023-04-03Call appservices on modern paths, falling back to legacy paths. (#15317)Patrick Cloke5-48/+172
This uses the specced /_matrix/app/v1/... paths instead of the "legacy" paths. If the homeserver receives an error it will retry using the legacy path.
2023-04-03Experimental Unix socket support (#15353)Jason Little8-90/+239
* Add IReactorUNIX to ISynapseReactor type hint. * Create listen_unix(). Two options, 'path' to the file and 'mode' of permissions(not umask, recommend 666 as default as nginx/other reverse proxies write to it and it's setup as user www-data) For the moment, leave the option to always create a PID lockfile turned on by default * Create UnixListenerConfig and wire it up. Rename ListenerConfig to TCPListenerConfig, then Union them together into ListenerConfig. This spidered around a bit, but I think I got it all. Metrics and manhole have been placed behind a conditional in case of accidental putting them onto a unix socket. Use new helpers to get if a listener is configured for TLS, and to help create a site tag for logging. There are 2 TODO things in parse_listener_def() to finish up at a later point. * Refactor SynapseRequest to handle logging correctly when using a unix socket. This prevents an exception when an IP address can not be retrieved for a request. * Make the 'Synapse now listening on Unix socket' log line a little prettier. * No silent failures on generic workers when trying to use a unix socket with metrics or manhole. * Inline variables in app/_base.py * Update docstring for listen_unix() to remove reference to a hardcoded permission of 0o666 and add a few comments saying where the default IS declared. * Disallow both a unix socket and a ip/port combo on the same listener resource * Linting * Changelog * review: simplify how listen_unix returns(and get rid of a type: ignore) * review: fix typo from ConfigError in app/homeserver.py * review: roll conditional for http_options.tag into get_site_tag() helper(and add docstring) * review: enhance the conditionals for checking if a port or path is valid, remove a TODO line * review: Try updating comment in get_client_ip_if_available to clarify what is being retrieved and why * Pretty up how 'Synapse now listening on Unix Socket' looks by decoding the byte string. * review: In parse_listener_def(), raise ConfigError if neither socket_path nor port is declared(and fix a typo)
2023-04-03Bump serde_json from 1.0.94 to 1.0.95 (#15371)dependabot[bot]2-2/+3
* Bump serde_json from 1.0.94 to 1.0.95 Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.94 to 1.0.95. - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](https://github.com/serde-rs/json/compare/v1.0.94...v1.0.95) --- updated-dependencies: - dependency-name: serde_json dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-04-03Bump serde from 1.0.158 to 1.0.159 (#15370)dependabot[bot]2-4/+5
* Bump serde from 1.0.158 to 1.0.159 Bumps [serde](https://github.com/serde-rs/serde) from 1.0.158 to 1.0.159. - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](https://github.com/serde-rs/serde/compare/v1.0.158...v1.0.159) --- updated-dependencies: - dependency-name: serde dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-04-03Bump peaceiris/actions-gh-pages from 3.9.2 to 3.9.3 (#15369)dependabot[bot]2-2/+3
* Bump peaceiris/actions-gh-pages from 3.9.2 to 3.9.3 Bumps [peaceiris/actions-gh-pages](https://github.com/peaceiris/actions-gh-pages) from 3.9.2 to 3.9.3. - [Release notes](https://github.com/peaceiris/actions-gh-pages/releases) - [Changelog](https://github.com/peaceiris/actions-gh-pages/blob/main/CHANGELOG.md) - [Commits](https://github.com/peaceiris/actions-gh-pages/compare/bd8c6b06eba6b3d25d72b7a1767993c0aeee42e7...373f7f263a76c20808c831209c920827a82a2847) --- updated-dependencies: - dependency-name: peaceiris/actions-gh-pages dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-03-31Fix copyright year in SSO footer template (#15358)Jason Robinson2-2/+3
2023-03-31Revert pruning of old devices (#15360)Erik Johnston9-187/+7
* Revert "Fix registering a device on an account with lots of devices (#15348)" This reverts commit f0d8f66eaaacfa75bed65bc5d0c602fbc5339c85. * Revert "Delete stale non-e2e devices for users, take 3 (#15183)" This reverts commit 78cdb72cd6b0e007c314d9fed9f629dfc5b937a6.
2023-03-31Revert "Set thread_id column to non-null for ↵Olivier Wilkinson (reivilibre)6-154/+243
event_push_{actions,actions_staging,summary} (#15350)" This reverts commit 2a234b788e2b5706ee83cf8eb86dfd004bc7c166. See #15359 for context.
2023-03-30Set thread_id column to non-null for ↵Patrick Cloke6-243/+154
event_push_{actions,actions_staging,summary} (#15350) Clean-up from adding the thread_id column, which was initially null but backfilled with values. It is desirable to require it to now be non-null. In addition to altering this column to be non-null, we clean up obsolete background jobs, indexes, and just-in-time updating code.
2023-03-30to_device updates could be dropped when consuming the replication stream ↵Mathieu Velten5-15/+98
(#15349) Co-authored-by: reivilibre <oliverw@matrix.org>
2023-03-30Speed up SQLite unit test CI (#15334)Erik Johnston4-4/+53
Tests now take 40% of the time.
2023-03-30Implement MSC3984 to proxy /keys/query requests to appservices. (#15321)Patrick Cloke9-48/+298
If enabled, for users which are exclusively owned by an application service then the appservice will be queried for devices in addition to any information stored in the Synapse database.
2023-03-30Fix spinloop during partial state sync when a prev event is in backoff (#15351)Sean Quah6-47/+79
Previously, we would spin in a tight loop until `update_state_for_partial_state_event` stopped raising `FederationPullAttemptBackoffError`s. Replace the spinloop with a wait until the backoff period has expired. Signed-off-by: Sean Quah <seanq@matrix.org>
2023-03-30Add the ability to enable/disable registrations when in the OIDC flow (#14978)Warren Bailey6-3/+44
Signed-off-by: Warren Bailey <warren@warrenbailey.net>
2023-03-30Add some clarification to the doc/comments regarding TCP replication (#15354)Mathieu Velten4-36/+9
2023-03-30Fix missing app variable in mail subject for password resets (#15352)Cyberes2-1/+2
* Update mailer.py Fix `KeyError: 'app'` * Create 15352.bugfix Signed-off-by: Cyberes <cyberes@evulid.cc> --------- Signed-off-by: Cyberes <cyberes@evulid.cc>
2023-03-29Fix registering a device on an account with lots of devices (#15348)Erik Johnston4-3/+56
Fixes up #15183
2023-03-29Revert "Reintroduce membership tables event stream ordering (#15128)" (#15347)Erik Johnston6-131/+12
This reverts commit e6af49fbea939d9e69ed05e0a0ced5948c722ea4.
2023-03-29Delete stale non-e2e devices for users, take 3 (#15183)Erik Johnston7-7/+134
This should help reduce the number of devices e.g. simple bots the repeatedly login rack up. We only delete non-e2e devices as they should be safe to delete, whereas if we delete e2e devices for a user we may accidentally break their ability to receive e2e keys for a message.
2023-03-29doc: fix account login requests ratelimit defaults typo (#15341)Jayesh Nirve2-1/+2
* doc: fix account login requests ratelimit defaults typo Signed-off-by: td <nirvejayesh@gmail.com> * chore: changelog.d file --------- Signed-off-by: td <nirvejayesh@gmail.com>
2023-03-29Fix joining rooms you have been unbanned from (#15323)DeepBlueV7.X3-53/+59
* Fix joining rooms you have been unbanned from Since forever synapse did not allow you to join a room after you have been unbanned from it over federation. This was not actually because of the unban event not federating. Synapse simply used outdated state to validate the join transition. This skips the validation if we are not in the room and for that reason won't have the current room state. Fixes #1563 Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de> * Add changelog Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de> * Update changelog.d/15323.bugfix --------- Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
2023-03-28Implement MSC3983 to proxy /keys/claim queries to appservices. (#15314)Patrick Cloke9-29/+355
Experimental support for MSC3983 is behind a configuration flag. If enabled, for users which are exclusively owned by an application service then the appservice will be queried for one-time keys *if* there are none uploaded to Synapse.
2023-03-28Speed up generate sample config CI lint (#15340)Erik Johnston2-0/+9
2023-03-28Speed up pydantic CI lint (#15339)Erik Johnston2-0/+9
2023-03-28Fix typo in developer docs GitHub workflow (#15336)Sean Quah2-1/+2
Signed-off-by: Sean Quah <seanq@matrix.org>
2023-03-281.80.0 v1.80.0Sean Quah3-1/+13
2023-03-28Bump ruff from 0.0.252 to 0.0.259 (#15328)dependabot[bot]12-35/+54
* Bump ruff from 0.0.252 to 0.0.259 Bumps [ruff](https://github.com/charliermarsh/ruff) from 0.0.252 to 0.0.259. - [Release notes](https://github.com/charliermarsh/ruff/releases) - [Changelog](https://github.com/charliermarsh/ruff/blob/main/BREAKING_CHANGES.md) - [Commits](https://github.com/charliermarsh/ruff/compare/v0.0.252...v0.0.259) --- updated-dependencies: - dependency-name: ruff dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Fix new warnings * Mypy * Newsfile --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Erik Johnston <erik@matrix.org>
2023-03-27Prune old typing notifications (#15332)Erik Johnston2-0/+26
Rather than keeping them around forever in memory, slowing things down. Fixes #11750.
2023-03-27Load `/password_policy` endpoint on workers. (#15331)Dirk Klimpel5-2/+5
2023-03-27Bump cryptography from 40.0.0 to 40.0.1 (#15329)dependabot[bot]2-20/+21
* Bump cryptography from 40.0.0 to 40.0.1 Bumps [cryptography](https://github.com/pyca/cryptography) from 40.0.0 to 40.0.1. - [Release notes](https://github.com/pyca/cryptography/releases) - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pyca/cryptography/compare/40.0.0...40.0.1) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-03-27Bump mypy-zope from 0.9.0 to 0.9.1 (#15330)dependabot[bot]2-4/+5
* Bump mypy-zope from 0.9.0 to 0.9.1 Bumps [mypy-zope](https://github.com/Shoobx/mypy-zope) from 0.9.0 to 0.9.1. - [Release notes](https://github.com/Shoobx/mypy-zope/releases) - [Changelog](https://github.com/Shoobx/mypy-zope/blob/master/CHANGELOG.md) - [Commits](https://github.com/Shoobx/mypy-zope/compare/0.9.0...0.9.1) --- updated-dependencies: - dependency-name: mypy-zope dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-03-27Bump furo from 2022.12.7 to 2023.3.23 (#15327)dependabot[bot]3-5/+6
* Bump furo from 2022.12.7 to 2023.3.23 Bumps [furo](https://github.com/pradyunsg/furo) from 2022.12.7 to 2023.3.23. - [Release notes](https://github.com/pradyunsg/furo/releases) - [Changelog](https://github.com/pradyunsg/furo/blob/main/docs/changelog.md) - [Commits](https://github.com/pradyunsg/furo/compare/2022.12.07...2023.03.23) --- updated-dependencies: - dependency-name: furo dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-03-27Bump types-pyopenssl from 23.0.0.4 to 23.1.0.0 (#15326)dependabot[bot]2-3/+4
* Bump types-pyopenssl from 23.0.0.4 to 23.1.0.0 Bumps [types-pyopenssl](https://github.com/python/typeshed) from 23.0.0.4 to 23.1.0.0. - [Release notes](https://github.com/python/typeshed/releases) - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-pyopenssl dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-03-27Bump regex from 1.7.1 to 1.7.3 (#15325)dependabot[bot]2-4/+5
* Bump regex from 1.7.1 to 1.7.3 Bumps [regex](https://github.com/rust-lang/regex) from 1.7.1 to 1.7.3. - [Release notes](https://github.com/rust-lang/regex/releases) - [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md) - [Commits](https://github.com/rust-lang/regex/compare/1.7.1...1.7.3) --- updated-dependencies: - dependency-name: regex dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-03-27Bump serde from 1.0.157 to 1.0.158 (#15324)dependabot[bot]2-7/+8
* Bump serde from 1.0.157 to 1.0.158 Bumps [serde](https://github.com/serde-rs/serde) from 1.0.157 to 1.0.158. - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](https://github.com/serde-rs/serde/compare/v1.0.157...v1.0.158) --- updated-dependencies: - dependency-name: serde dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-03-24Fix `.gitignore` rule for the Complement source tarball downloaded ↵reivilibre2-1/+2
automatically by `complement.sh`. (#15319)
2023-03-24Add developer documentation for the Federation Sender and add a ↵reivilibre12-509/+1280
documentation mechanism using Sphinx. (#15265) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
2023-03-24As an optimisation, use `TRUNCATE` on Postgres when clearing the user ↵reivilibre2-4/+12
directory tables. (#15316)
2023-03-24Make cleaning up pushers depend on the device_id instead of the token_id ↵Quentin Gliech15-65/+142
(#15280) This makes it so that we rely on the `device_id` to delete pushers on logout, instead of relying on the `access_token_id`. This ensures we're not removing pushers on token refresh, and prepares for a world without access token IDs (also known as the OIDC). This actually runs the `set_device_id_for_pushers` background update, which was forgotten in #13831. Note that for backwards compatibility it still deletes pushers based on the `access_token` until the background update finishes.
2023-03-24Reject mentions on the C-S API which are invalid. (#15311)Patrick Cloke4-54/+105
Invalid mentions data received over the Client-Server API should be rejected with a 400 error. This will hopefully stop clients from sending invalid data, although does not help with data received over federation.
2023-03-24Reintroduce membership tables event stream ordering (#15128)Nick Mills-Barrett6-12/+131
* Add `event_stream_ordering` column to membership state tables Specifically this adds the column to `current_state_events`, `local_current_membership` and `room_memberships`. Each of these tables is regularly joined with the `events` table to get the stream ordering and denormalising this into each table will yield significant query performance improvements once used. * Make denormalised `event_stream_ordering` columns foreign keys * Add comment in schema file explaining new denormalised columns * Add triggers to enforce consistency of `event_stream_ordering` columns * Re-order purge room tables to account for foreign keys * Bump schema version to 75 Co-authored-by: David Robertson <david.m.robertson1@gmail.com> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
2023-03-23Add a primitive helper script for listing worker endpoints. (#15243)reivilibre31-12/+424
Co-authored-by: Patrick Cloke <patrickc@matrix.org>
2023-03-22Use immutabledict instead of frozendict (#15113)David Robertson20-244/+124
Additionally: * Consistently use `freeze()` in test --------- Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: 6543 <6543@obermui.de>
2023-03-22Add a check to SQLite port DB script to ensure that the sqlite database ↵Shay2-0/+10
passed to the script exists before trying to port from it (#15306)
2023-03-221.80.0rc2 v1.80.0rc2H. Shay6-6/+18
2023-03-22Bump dtolnay/rust-toolchain from e12eda571dc9a5ee5d58eecf4738ec291c66f295 to ↵dependabot[bot]4-15/+16
fc3253060d0c959bea12a59f10f8391454a0b02d (#15304) * Bump dtolnay/rust-toolchain Bumps [dtolnay/rust-toolchain](https://github.com/dtolnay/rust-toolchain) from e12eda571dc9a5ee5d58eecf4738ec291c66f295 to fc3253060d0c959bea12a59f10f8391454a0b02d. - [Release notes](https://github.com/dtolnay/rust-toolchain/releases) - [Commits](https://github.com/dtolnay/rust-toolchain/compare/e12eda571dc9a5ee5d58eecf4738ec291c66f295...fc3253060d0c959bea12a59f10f8391454a0b02d) --- updated-dependencies: - dependency-name: dtolnay/rust-toolchain dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-03-22Have replication clients remove _INT_STREAM_POS (#15309)David Robertson2-1/+2
* Have replication clients remove _INT_STREAM_POS Suppose worker A makes an internal http request from worker B. B may make changes that A later learns about over replication. We want A's request to block until it has seen those changes—mainly to ensure A's caches are invalidated promptly. This helps provide read-after-write consistency, eliminating entire categories of races and test flakes. To implement this, B includes a top-level field `_INT_STREAM_POS` in its response JSON. Roughly speaking, the field's value tells A what to wait for. But we weren't removing that internal field before A's request completed! Introduced in https://github.com/matrix-org/synapse/pull/14820. Fixes #15308. * Changelog
2023-03-21Change the parameter `immediate` of `send_device_messages` to default to ↵Shay3-2/+3
`True` (#15297)
2023-03-21Bump sentry-sdk from 1.15.0 to 1.17.0 (#15285)dependabot[bot]2-3/+5
* Bump sentry-sdk from 1.15.0 to 1.17.0 Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 1.15.0 to 1.17.0. - [Release notes](https://github.com/getsentry/sentry-python/releases) - [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-python/compare/1.15.0...1.17.0) --- updated-dependencies: - dependency-name: sentry-sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com> Co-authored-by: Mathieu Velten <mathieuv@matrix.org>
2023-03-21Update 15295.bugfixPatrick Cloke1-1/+1
2023-03-21Allow running twisted trunk against other branches (#15302)David Robertson2-1/+9
* Allow running twisted trunk against other branches I would like to do this so we can try Synapse's typechecking against a specific branch that the project solicited tests for, see https://mail.python.org/archives/list/twisted@python.org/message/GGO5JHA5S475AK6JZ3GCC3GIHGKQYM6Y/ * Changelog
2023-03-21Remind maintainer to ask #synapse-dev for changelog (#15303)David Robertson2-1/+2
* Remind maintainer to ask #synapse-dev for changelog * Changelog
2023-03-21Apply & bundle edits for non-message events. (#15295)Patrick Cloke2-7/+5
2023-03-21update changelogH. Shay1-8/+9
2023-03-21Update CHANGES.mdShay1-1/+1
2023-03-211.80.0rc1H. Shay46-44/+73
2023-03-21Revert "check sqlite database file exists before porting/#14692" (#15301)Shay2-1/+4
2023-03-21Make `POST /_matrix/client/v3/rooms/{roomId}/report/{eventId}` endpoint ↵Andrew Morgan5-6/+61
return 404 if event exists, but the user lacks access (#15300)
2023-03-21Make `EventHandler.get_event` return `None` when the requested event is not ↵Andrew Morgan3-4/+11
found (#15298)
2023-03-21Document that our Docker images are mirrored to GHCR. (#15282)reivilibre2-2/+3
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-03-21Fix error when sending message into deleted room. (#15235)Erik Johnston3-2/+31
When a room is deleted in Synapse we remove the event forward extremities in the room, so if (say a bot) tries to send a message into the room we error out due to not being able to calculate prev events for the new event *before* we check if the sender is in the room. Fixes #8094
2023-03-20Separate HTTP preview code and URL previewer. (#15269)Patrick Cloke4-810/+854
Separates REST layer code from the actual URL previewing.
2023-03-20Add Synapse-Trace-Id to access-control-expose-headers header (#14974)Shay3-0/+9
2023-03-20Mirror images to the GitHub Container Registry ↵reivilibre2-1/+12
(`ghcr.io/matrix-org/synapse`). (#15281)
2023-03-20Add /versions flag for MSC3952. (#15293)Patrick Cloke2-0/+3
2023-03-20Bump pygithub from 1.57 to 1.58.1 (#15290)dependabot[bot]2-7/+8
2023-03-20Bump serde from 1.0.155 to 1.0.157 (#15287)dependabot[bot]2-11/+23
2023-03-20Bump anyhow from 1.0.69 to 1.0.70 (#15288)dependabot[bot]2-2/+3
2023-03-20Bump pydantic from 1.10.4 to 1.10.6 (#15286)dependabot[bot]2-37/+38
2023-03-20Bump txredisapi from 1.4.7 to 1.4.9 (#15289)dependabot[bot]2-3/+4
2023-03-20Bump types-requests from 2.28.11.12 to 2.28.11.15 (#15291)dependabot[bot]2-3/+4
2023-03-17Load `/register/available` endpoint on workers (#15268)Jason Little4-1/+4
2023-03-17Make `configure_workers_and_start` script used in Complement tests ↵reivilibre2-1/+2
compatible with older versions of Python. (#15275)
2023-03-16Remove no-op send_command for Redis replication. (#15274)Patrick Cloke4-89/+3
With Redis commands do not need to be re-issued by the main process (they fan-out to all processes at once) and thus it is no longer necessary to worry about them reflecting recursively forever.
2023-03-16Implement MSC2659: application service ping endpoint (#15249)Tulir Asokan7-0/+141
Signed-off-by: Tulir Asokan <tulir@maunium.net>
2023-03-16Refresh remote profiles that have been marked as stale, in order to fill the ↵reivilibre5-4/+504
user directory. [rei:userdirpriv] (#14756) * Scaffolding for background process to refresh profiles * Add scaffolding for background process to refresh profiles for a given server * Implement the code to select servers to refresh from * Ensure we don't build up multiple looping calls * Make `get_profile` able to respect backoffs * Add logic for refreshing users * When backing off, schedule a refresh when the backoff is over * Wake up the background processes when we receive an interesting state event * Add tests * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> * Add comment about 1<<62 --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-03-16Move Account Validity callbacks to a dedicated file (#15237)Andrew Morgan8-106/+154
2023-03-16Preparatory work to fix the user directory assuming that any remote ↵reivilibre4-34/+127
membership state events represent a profile change. [rei:userdirpriv] (#14755) * Remove special-case method for new memberships only, use more generic method * Only collect profiles from state events in public rooms * Add a table to track stale remote user profiles * Add store methods to set and delete rows in this new table * Mark remote profiles as stale when a member state event comes in to a private room * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> * Simplify by removing Optionality of `event_id` * Replace names and avatars with None if they're set to dodgy things I think this makes more sense anyway. * Move schema delta to 74 (I missed the boat?) * Turns out these can be None after all --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-03-15Remove unused class: DirectTcpReplicationClientFactory. (#15272)Patrick Cloke2-51/+1
2023-03-15Enable running tests & release artifacts on merge queue. (#15244)Patrick Cloke3-1/+5
2023-03-15Add schema comments about the `destinations` and `destination_rooms` tables. ↵reivilibre2-0/+53
(#15247)
2023-03-14Remove unused store method `_set_destination_retry_timings_emulated`. (#15266)reivilibre2-54/+3
2023-03-14Additional functionality for declaring worker types in Complement (#14921)Jason Little3-115/+413
Co-authored-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-03-141.79.0 v1.79.0Mathieu Velten3-1/+13
2023-03-14Avoid unneeded work if auto-join rooms aren't configured. (#15262)Patrick Cloke2-2/+9
It is not necessary to reach out to the database to check some parameters if the auto-join rooms are not configured, or (in some cases) if auto-create rooms is not configured.
2023-03-13Bump cryptography from 39.0.1 to 39.0.2 (#15257)dependabot[bot]2-24/+25
* Bump cryptography from 39.0.1 to 39.0.2 Bumps [cryptography](https://github.com/pyca/cryptography) from 39.0.1 to 39.0.2. - [Release notes](https://github.com/pyca/cryptography/releases) - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pyca/cryptography/compare/39.0.1...39.0.2) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-03-131.79.0rc2 v1.79.0rc2David Robertson6-4/+23
2023-03-13Ensure fed-sender catchup does not block for full state (#15248)David Robertson4-3/+125
* Reproduce bad scenario in test * Avoid catchup optimisation for partial state rooms
2023-03-13Install rust during Stage 0 of docker build (#15239)David Robertson2-1/+17
* Install rust during Stage 0 of docker build Thanks to @atomdmac for spotting the fix. Fixes #15179. * Changelog
2023-03-13Bump hiredis from 2.2.1 to 2.2.2 (#15252)dependabot[bot]2-90/+91
* Bump hiredis from 2.2.1 to 2.2.2 Bumps [hiredis](https://github.com/redis/hiredis-py) from 2.2.1 to 2.2.2. - [Release notes](https://github.com/redis/hiredis-py/releases) - [Changelog](https://github.com/redis/hiredis-py/blob/master/CHANGELOG.md) - [Commits](https://github.com/redis/hiredis-py/compare/v2.2.1...v2.2.2) --- updated-dependencies: - dependency-name: hiredis dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-03-13Bump serde from 1.0.152 to 1.0.155 (#15253)dependabot[bot]2-4/+5
* Bump serde from 1.0.152 to 1.0.155 Bumps [serde](https://github.com/serde-rs/serde) from 1.0.152 to 1.0.155. - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](https://github.com/serde-rs/serde/compare/v1.0.152...v1.0.155) --- updated-dependencies: - dependency-name: serde dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-03-13Bump pysaml2 from 7.2.1 to 7.3.1 (#15254)dependabot[bot]2-8/+8
* Bump pysaml2 from 7.2.1 to 7.3.1 Bumps [pysaml2](https://github.com/IdentityPython/pysaml2) from 7.2.1 to 7.3.1. - [Release notes](https://github.com/IdentityPython/pysaml2/releases) - [Changelog](https://github.com/IdentityPython/pysaml2/blob/v7.3.1/CHANGELOG.md) - [Commits](https://github.com/IdentityPython/pysaml2/compare/v7.2.1...v7.3.1) --- updated-dependencies: - dependency-name: pysaml2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-03-13Bump msgpack from 1.0.4 to 1.0.5 (#15255)dependabot[bot]2-53/+65
* Bump msgpack from 1.0.4 to 1.0.5 Bumps [msgpack](https://github.com/msgpack/msgpack-python) from 1.0.4 to 1.0.5. - [Release notes](https://github.com/msgpack/msgpack-python/releases) - [Changelog](https://github.com/msgpack/msgpack-python/blob/main/ChangeLog.rst) - [Commits](https://github.com/msgpack/msgpack-python/compare/v1.0.4...v1.0.5) --- updated-dependencies: - dependency-name: msgpack dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-03-13Bump gitpython from 3.1.30 to 3.1.31 (#15256)dependabot[bot]2-5/+6
* Bump gitpython from 3.1.30 to 3.1.31 Bumps [gitpython](https://github.com/gitpython-developers/GitPython) from 3.1.30 to 3.1.31. - [Release notes](https://github.com/gitpython-developers/GitPython/releases) - [Changelog](https://github.com/gitpython-developers/GitPython/blob/main/CHANGES) - [Commits](https://github.com/gitpython-developers/GitPython/compare/3.1.30...3.1.31) --- updated-dependencies: - dependency-name: gitpython dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-03-10Refactor `filter_events_for_server` (#15240)David Robertson5-30/+109
* Tweak docstring and type hint * Flip logic and provide better name * Separate decision from action * Track a set of strings, not EventBases * Require explicit boolean options from callers * Add explicit option for partial state rooms * Changelog * Rename param
2023-03-10Fix missing conditional for registering ↵Andrew Morgan3-9/+16
`on_remove_user_third_party_identifier` module api callbacks (#15227
2023-03-09Give PyCharm some help with `@cache_in_self` (#15238)David Robertson2-3/+27
* Give PyCharm some help with `@cache_in_self` * Changelog * Fix import for old python versions
2023-03-09Faster joins: Fix spurious errors on incremental sync (#15232)Sean Quah2-2/+8
When pushing events in partial state rooms down incremental /sync, we try to find the `m.room.member` state event for their senders by digging through their auth events, so that we can present the membership to the client. Events usually have a membership event in their auth events, with the exception of the `m.room.create` event and a user's first join into the room. When implementing #13477, we took the case of a user's first join into account, but forgot to handle the `m.room.create` case. This change fixes that. Signed-off-by: Sean Quah <seanq@matrix.org>
2023-03-09Add missing type hints to `synapse.storage.database`. (#15230)Patrick Cloke3-8/+17
2023-03-09Pull in netaddr type hints. (#15231)Patrick Cloke7-12/+23
And fix any issues from having those type hints.
2023-03-08Add topic and name events to group of events that are batch persisted when ↵Shay2-56/+53
creating a room. (#15229)
2023-03-08Include the room ID in more purge room log lines. (#15222)Patrick Cloke5-15/+23
2023-03-08Add a missing endpoint to the workers documentation. (#15223)Patrick Cloke2-0/+2
2023-03-07More speedups/fixes to creating batched events (#15195)Shay5-9/+33
2023-03-07Fix typo in changelogDavid Robertson1-1/+1
2023-03-07Stabilize support for MSC3873: disambuguated event push keys. (#15190)Patrick Cloke5-45/+15
This removes the experimental configuration option and always escapes the push rule condition keys. Also escapes any (experimental) push rule condition keys in the base rules which contain dot in a field name.
2023-03-07Pass the Requester down to the HttpTransactionCache. (#15200)Quentin Gliech6-129/+215
2023-03-07Stabilize support for MSC3966: event_property_contains push condition. (#15187)Patrick Cloke9-55/+13
This removes the configuration flag & updates the identifiers to use the stable version.
2023-03-07Remove duplicate entry from changelog v1.79.0rc1David Robertson1-1/+0
2023-03-07Update changelogDavid Robertson1-21/+24
2023-03-071.79.0rc1David Robertson63-61/+102
2023-03-07Hack to rebuild the complement editable image (#15184)David Robertson2-1/+12
* Hack to rebuild the complement editable image * Changelog
2023-03-07Bump types-pyopenssl from 22.1.0.2 to 23.0.0.4 (#15213)dependabot[bot]2-44/+5
2023-03-07Bump types-pillow from 9.4.0.13 to 9.4.0.17 (#15211)dependabot[bot]2-3/+4
2023-03-07Bump types-setuptools from 67.4.0.3 to 67.5.0.0 (#15212)dependabot[bot]2-3/+4
2023-03-07Bump types-psycopg2 from 2.9.21.4 to 2.9.21.8 (#15210)dependabot[bot]2-3/+4
2023-03-07Bump types-commonmark from 0.9.2.1 to 0.9.2.2 (#15209)dependabot[bot]2-3/+4
2023-03-07Split up txn for fetching device keys (#15215)Erik Johnston3-9/+26
We look up keys in batches, but we should do that outside of the transaction to avoid starving the database pool.
2023-03-06Pass the requester during event serialization. (#15174)Quentin Gliech12-75/+151
This allows Synapse to properly include the transaction ID in the unsigned data of events.
2023-03-06Stop applying edits to event contents (MSC3925). (#15193)Patrick Cloke6-109/+15
Enables MSC3925 support by default, which: * Includes the full edit event in the bundled aggregations of an edited event. * Stops modifying the original event's content to return the new content from the edit event. This is a backwards-incompatible change that is considered to be "correct" by the spec.
2023-03-06Stabilize support for MSC3758: event_property_is push condition (#15185)Patrick Cloke10-81/+39
This removes the configuration flag & updates the identifiers to use the stable version.
2023-03-06Bump serde_json from 1.0.93 to 1.0.94 (#15214)Co-authored-by: ↵dependabot[bot]2-2/+3
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com> * Bump serde_json from 1.0.93 to 1.0.94 Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.93 to 1.0.94. - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](https://github.com/serde-rs/json/compare/v1.0.93...v1.0.94) --- updated-dependencies: - dependency-name: serde_json dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-03-03Use nightly rustfmt in CI (#15188)Erik Johnston4-2/+5
As we use some nightly only options, e.g. to group and sort imports consistently.
2023-03-03Fix ICU tests on alpine / macOS. (#15177)65432-0/+3
The word boundary behaviour is slightly different, consider it acceptable for the tests.
2023-03-03Combine AbstractStreamIdTracker and AbstractStreamIdGenerator. (#15192)Patrick Cloke7-27/+15
AbstractStreamIdTracker (now) has only a single sub-class: AbstractStreamIdGenerator, combine them to simplify some code and remove any direct references to AbstractStreamIdTracker.
2023-03-03Remove unspecced and buggy `PUT` method on the unstable ↵Quentin Gliech2-15/+2
`/rooms/<room_id>/batch_send` endpoint. (#15199)
2023-03-03Configure ruff to automatically fix issues. (#15194)Patrick Cloke2-1/+2
2023-03-03Experimental MSC3890 Implementation: Fix deleting account data when using an ↵Andrew Morgan3-26/+16
account data writer worker (#14869)
2023-03-02Add a `get_next_txn` method to `StreamIdGenerator` to match ↵Andrew Morgan4-11/+48
`MultiWriterIdGenerator` (#15191
2023-03-02Add support for knocking to workers. (#15133)Dirk Klimpel9-16/+15
2023-03-02Remove the unspecced and bugged PUT /knock/{roomIdOrAlias} endpoint (#15189)Quentin Gliech2-15/+2
2023-03-02Dockerfile-workers: spell out when config isn't generated (#15186)David Robertson2-1/+6
* Complement: Spell out when config isn't generated * Changelog
2023-03-02Update intentional mentions (MSC3952) to depend on ↵Patrick Cloke11-94/+73
`exact_event_property_contains` (MSC3966). (#15051) This replaces the specific `is_user_mention` push rule condition used in MSC3952 with the generic `exact_event_property_contains` push rule condition from MSC3966.
2023-03-02Fix conflicting URLs for dehydrated devices. (#15180)Patrick Cloke2-1/+2
2023-03-02Add Sytest jobs with the asyncio reactor enabled (#14101)Quentin Gliech3-0/+17
2023-03-02Move event_reports to `RoomWorkerStore` (#15165)Dirk Klimpel2-177/+178
2023-03-02Implementation of MSC3967: Don't require UIA for initial upload of cross ↵Hugh Nimmo-Smith5-9/+182
signing keys (#15077)
2023-02-28Remove support for aggregating reactions (#15172)Richard van der Hoff8-377/+30
It turns out that no clients rely on server-side aggregation of `m.annotation` relationships: it's just not very useful as currently implemented. It's also non-trivial to calculate. I want to remove it from MSC2677, so to keep the implementation in line, let's remove it here.
2023-02-28Update spam checker documentation for moved media modules. (#15175)Patrick Cloke2-2/+3
2023-02-28Fix a long-standing bug where an initial sync would not respond to changes ↵reivilibre4-2/+77
to the list of ignored users if there was an initial sync cached. (#15163)
2023-02-281.78.0 v1.78.0H. Shay4-2/+16
2023-02-28Allow use of the `/filter` Client-Server APIs on workers. (#15134)reivilibre6-8/+27
2023-02-28Add missing type hints to InsecureInterceptableContextFactory. (#15164)Patrick Cloke3-5/+4
2023-02-28Do not accept pattern_type from user input in push rules. (#15088)Patrick Cloke6-186/+244
Internally the push rules module uses a `pattern_type` property for `event_match` conditions (and `related_event_match`) to mark the condition as matching the current user's Matrix ID or localpart. This is leaky to the Client-Server API where a user can successfully set a condition which provides `pattern_type` instead of `pattern` (note that there's no benefit to doing this -- the user can just use their own Matrix ID or localpart instead). When serializing back to the client the `pattern_type` property is converted into a proper `pattern`. The following changes are made to avoid this: * Separate the `KnownCondition::EventMatch` enum value into `EventMatch` and `EventMatchType`, each with their own expected properties. (Note that a similar change is made for `RelatedEventMatch`.) * Make it such that the `pattern_type` variants serialize to the same condition kind, but cannot be deserialized (since they're only provided by base rules). * As a final tweak, convert `user_id` vs. `user_localpart` values into an enum.
2023-02-28Add documentation for caching in a module (#14026)Brendan Abolivier2-0/+57
* Add documentation for caching in a module * Changelog * Formatting * Wrap lines at a length that mdbook is happier with * Typo fix Co-authored-by: Erik Johnston <erik@matrix.org> * Link to recent version of the API In the longer term I'd like to see us generate markdown with Sphinx. * Refer to public `cached` decorator * Mark caching as being added in 1.74 Some of the underlying infrastructure was added in 1.69, but the public-facing `cached` decorator was only added in 1.74. It is the latter that I think we should be advertising. * Update docs/modules/writing_a_module.md Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> --------- Co-authored-by: David Robertson <davidr@element.io> Co-authored-by: Erik Johnston <erik@matrix.org> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
2023-02-28Admin API endpoint to delete a reported event (#15116)Dirk Klimpel5-11/+224
* Admin api to delete event report * lint + tests * newsfile * Apply suggestions from code review Co-authored-by: David Robertson <david.m.robertson1@gmail.com> * revert changes - move to WorkerStore * update unit test * Note that timestamp is in millseconds --------- Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
2023-02-28Correct documentation about registration_shared_secret_path (#15168)Evan Krall2-2/+3
* Correct documentation about registration_shared_secret_path * Create 15168.doc * Update changelog.d/15168.doc --------- Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
2023-02-27Remove dangling reference to being a reference implementation (#15167)Travis Ralston2-2/+4
* Remove dangling reference to being a reference implementation * Create 15167.misc
2023-02-27Add module API callbacks for adding and deleting local 3PID associations (#15044Andrew Morgan12-48/+324
2023-02-27Refactor media modules. (#15146)Patrick Cloke31-1123/+1190
* Removes the `v1` directory from `test.rest.media.v1`. * Moves the non-REST code from `synapse.rest.media.v1` to `synapse.media`. * Flatten the `v1` directory from `synapse.rest.media`, but leave compatiblity with 3rd party media repositories and spam checkers.
2023-02-27Small fixes to `MatrixFederationHttpClient` docstrings (#15148)Andrew Morgan2-7/+10
2023-02-27Bump ruff from 0.0.237 to 0.0.252 (#15159)dependabot[bot]3-19/+21
* Bump ruff from 0.0.237 to 0.0.252 Bumps [ruff](https://github.com/charliermarsh/ruff) from 0.0.237 to 0.0.252. - [Release notes](https://github.com/charliermarsh/ruff/releases) - [Changelog](https://github.com/charliermarsh/ruff/blob/main/BREAKING_CHANGES.md) - [Commits](https://github.com/charliermarsh/ruff/compare/v0.0.237...v0.0.252) --- updated-dependencies: - dependency-name: ruff dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-02-27Bump types-setuptools from 67.3.0.1 to 67.4.0.3 (#15160)dependabot[bot]2-18/+4
* Bump types-setuptools from 67.3.0.1 to 67.4.0.3 Bumps [types-setuptools](https://github.com/python/typeshed) from 67.3.0.1 to 67.4.0.3. - [Release notes](https://github.com/python/typeshed/releases) - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-setuptools dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-02-27Bump types-opentracing from 2.4.10.1 to 2.4.10.3 (#15158)dependabot[bot]2-3/+4
* Bump types-opentracing from 2.4.10.1 to 2.4.10.3 Bumps [types-opentracing](https://github.com/python/typeshed) from 2.4.10.1 to 2.4.10.3. - [Release notes](https://github.com/python/typeshed/releases) - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-opentracing dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-02-27Bump typing-extensions from 4.4.0 to 4.5.0 (#15157)dependabot[bot]2-3/+4
* Bump typing-extensions from 4.4.0 to 4.5.0 Bumps [typing-extensions](https://github.com/python/typing_extensions) from 4.4.0 to 4.5.0. - [Release notes](https://github.com/python/typing_extensions/releases) - [Changelog](https://github.com/python/typing_extensions/blob/main/CHANGELOG.md) - [Commits](https://github.com/python/typing_extensions/compare/4.4.0...4.5.0) --- updated-dependencies: - dependency-name: typing-extensions dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-02-27Bump matrix-org/backend-meta from 1 to 2 (#15156)dependabot[bot]2-1/+2
* Bump matrix-org/backend-meta from 1 to 2 Bumps [matrix-org/backend-meta](https://github.com/matrix-org/backend-meta) from 1 to 2. - [Release notes](https://github.com/matrix-org/backend-meta/releases) - [Commits](https://github.com/matrix-org/backend-meta/compare/v1...v2) --- updated-dependencies: - dependency-name: matrix-org/backend-meta dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-02-27Bump actions/checkout from 2 to 3 (#15155)dependabot[bot]2-2/+3
* Bump actions/checkout from 2 to 3 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-02-27Bump docker/login-action from 1 to 2 (#15154)dependabot[bot]2-1/+2
* Bump docker/login-action from 1 to 2 Bumps [docker/login-action](https://github.com/docker/login-action) from 1 to 2. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](https://github.com/docker/login-action/compare/v1...v2) --- updated-dependencies: - dependency-name: docker/login-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-02-27Bump dawidd6/action-download-artifact from 2.25.0 to 2.26.0 (#15152)dependabot[bot]2-1/+2
* Bump dawidd6/action-download-artifact from 2.25.0 to 2.26.0 Bumps [dawidd6/action-download-artifact](https://github.com/dawidd6/action-download-artifact) from 2.25.0 to 2.26.0. - [Release notes](https://github.com/dawidd6/action-download-artifact/releases) - [Commits](https://github.com/dawidd6/action-download-artifact/compare/b59d8c6a6c5c6c6437954f470d963c0b20ea7415...5e780fc7bbd0cac69fc73271ed86edf5dcb72d67) --- updated-dependencies: - dependency-name: dawidd6/action-download-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-02-24Batch up storing state groups when creating new room (#14918)Shay14-49/+371
2023-02-24Fix bug where 5s delays would occasionally happen. (#15150)Erik Johnston3-0/+80
This only affects deployments using workers.
2023-02-24Improve handling of non-ASCII characters in user directory search (#15143)Sean Quah3-2/+184
* Fix a long-standing bug where non-ASCII characters in search terms, including accented letters, would not match characters in a different case. * Fix a long-standing bug where search terms using combining accents would not match display names using precomposed accents and vice versa. To fully take effect, the user directory must be rebuilt after this change. Fixes #14630. Signed-off-by: Sean Quah <seanq@matrix.org>
2023-02-23Do not fail completely if oEmbed autodiscovery fails. (#15092)Patrick Cloke3-13/+65
Previously if an autodiscovered oEmbed request failed (e.g. the oEmbed endpoint is down or does not exist) then the entire URL preview would fail. Instead we now return everything we can, even if this additional request fails.
2023-02-23Stop parsing the unspecced type parameter on thumbnail requests. (#15137)Patrick Cloke2-1/+3
Ideally we would replace this with parsing of the Accept header or something else, but for now just make Synapse spec compliant by ignoring the unspecced parameter. It does not seem that this is ever sent by a client, and even if it is there's a reasonable fallback.
2023-02-23Fix a typo in MSC3873 config option. (#15138)Patrick Cloke4-9/+10
Previously the experimental configuration option referred to the wrong MSC number.
2023-02-23Fix typo in federation_verify_certificates in config documentation. (#15139)Centzilius2-1/+2
2023-02-23Add information on uploaded media to user export command. (#15107)Dirk Klimpel5-16/+136
2023-02-23Documentation using Shibboleth with OIDC Plugin for SSO. (#15112)Fly2-0/+42
2023-02-22Update .git-blame-ignore-revs for #15103.Patrick Cloke1-1/+5
2023-02-22Bump black from 22.12.0 to 23.1.0 (#15103)dependabot[bot]117-218/+108
2023-02-22Tighten the default rate limit of creating new devices. (#15135)Patrick Cloke3-5/+15
2023-02-22Use `json.dump` in `FileExfiltrationWriter` (#15095)Dirk Klimpel2-8/+9
To directly write to the open file, instead of writing to an in-memory string first.
2023-02-22Clarify the workers that the ThirdPartyRules' `on_new_event` callback will ↵Andrew Morgan2-0/+4
run on (#15071)
2023-02-22Remove unused `room_alias` field from `/createRoom` response (#15093)David Robertson10-39/+40
* Change `create_room` return type * Don't return room alias from /createRoom * Update other callsites * Fix up mypy complaints It looks like new_room_user_id is None iff new_room_id is None. It's a shame we haven't expressed this in a way that mypy can understand. * Changelog
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-12-22 09:28:07 +0000